From patchwork Tue Jan 11 13:32:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 49867 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 266CD38A9433 for ; Tue, 11 Jan 2022 14:08:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 266CD38A9433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1641910090; bh=wCoTSxXXvwdj5A9Mbpz3IPjAX1g/DNoh8L2+cZyw4aQ=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=wLk+O7KAnrH69qn7d2aWbljZBcMImsCkry7Wi2n6C5fkfzvqlC7oKGmTsTjOnqhUb QKQnQV+WFtg/52TLC+UnKEpai4VU7WrjpyggKMVCZeU9K8wHN5qPWf6WR7vm1Vh7yo u8zhktpD+OZtO1X5Wg8Zd4EkwD7OvrOZvclQ4s3k= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 2D65938A940F for ; Tue, 11 Jan 2022 13:32:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D65938A940F Received: by mail-wr1-x429.google.com with SMTP id e9so31499946wra.2 for ; Tue, 11 Jan 2022 05:32:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=wCoTSxXXvwdj5A9Mbpz3IPjAX1g/DNoh8L2+cZyw4aQ=; b=n2IzZl/DhRM7+zn6DDgXHNRP8Pl6rp9xvhLH/qV0vtN40pSeQaOCwPWEjJZpQdhZFk ggcTV+ZFsa5E1Ib6Su1Z5f/jS1LkE2P3SCJsTnvXbWzudmaqMazsIjz2X/u3uF4AhlFQ vNOBrvKP7XIK7CVHGfQoDrxeADjCj7Y/leI1C3sAUQmks4w+TtoZyFSweicQur/Z98js WpO+IcFEkb53nojJFzAha2IiONdGAztOUVtsQPh8XCUjhL+upShC+I8dKh8ntt0dV+2v bLuk5kBt/dMnE6cXiRlWCntKI01lUjfwb33rq4JjuXXkZMRA6wjFjhDRVBv/q4Ofsb/E nyWA== X-Gm-Message-State: AOAM530lEdZ5BCPX5XbHeVo0jNvp8EgXk5B3FBQcuKq4scXov1ATHEB2 dsk41t+HtMtnpjqUnoKKRbHa0MdJ/AkDoQ== X-Google-Smtp-Source: ABdhPJwsVnbqWzUjMrJ0aVSWAgregbv3uHwXyQTMAbD4cA+vL7Jy9b/ojFCyIM3YVf+Q7gOBquAaVw== X-Received: by 2002:a5d:6d45:: with SMTP id k5mr3708826wri.397.1641907962175; Tue, 11 Jan 2022 05:32:42 -0800 (PST) Received: from adacore.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id 5sm10690539wrb.77.2022.01.11.05.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 05:32:41 -0800 (PST) Date: Tue, 11 Jan 2022 13:32:40 +0000 To: gcc-patches@gcc.gnu.org Subject: [Ada] Task arrays trigger spurious unreferenced warnings Message-ID: <20220111133240.GA749002@adacore.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Pierre-Marie de Rodat via Gcc-patches From: Pierre-Marie de Rodat Reply-To: Pierre-Marie de Rodat Cc: Justin Squirek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Incremental patch to handle multi-dimensional arrays of tasks and records with task components. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_warn.adb (Check_References): Add call to Has_Task instead of checking component type. diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb --- a/gcc/ada/sem_warn.adb +++ b/gcc/ada/sem_warn.adb @@ -1701,13 +1701,10 @@ package body Sem_Warn is and then Ekind (E1) /= E_Constant and then Ekind (E1) /= E_Component) - -- Check that E1T is not a task or an array of them + -- Check that E1T is not a task or a composite type + -- with a task component. - or else not - (Is_Task_Type (E1T) - or else (Ekind (E1T) in Array_Kind - and then Is_Task_Type - (Component_Type (E1T))))) + or else not Has_Task (E1T)) -- For subunits, only place warnings on the main unit itself, -- since parent units are not completely compiled.