From patchwork Tue Jan 11 13:21:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Zhukov X-Patchwork-Id: 49835 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6AB86385802C for ; Tue, 11 Jan 2022 13:22:07 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from forward104j.mail.yandex.net (forward104j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::107]) by sourceware.org (Postfix) with ESMTPS id DF30C3858D39 for ; Tue, 11 Jan 2022 13:22:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF30C3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=zhukoff.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zhukoff.net Received: from forward103q.mail.yandex.net (forward103q.mail.yandex.net [IPv6:2a02:6b8:c0e:50:0:640:b21c:d009]) by forward104j.mail.yandex.net (Yandex) with ESMTP id E783E2F99193; Tue, 11 Jan 2022 16:22:01 +0300 (MSK) Received: from vla1-68d3ce55e22b.qloud-c.yandex.net (vla1-68d3ce55e22b.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3385:0:640:68d3:ce55]) by forward103q.mail.yandex.net (Yandex) with ESMTP id E535E56A0013; Tue, 11 Jan 2022 16:22:01 +0300 (MSK) Received: from vla5-047c0c0d12a6.qloud-c.yandex.net (vla5-047c0c0d12a6.qloud-c.yandex.net [2a02:6b8:c18:3484:0:640:47c:c0d]) by vla1-68d3ce55e22b.qloud-c.yandex.net (mxback/Yandex) with ESMTP id 1SIMBnpCZr-M1eS0Eh3; Tue, 11 Jan 2022 16:22:01 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zhukoff.net; s=mail; t=1641907321; bh=QodTYhJuIxVQ4ImaojmrkgpYs8H45eSSTRhz9PzMKaM=; h=Date:Subject:To:From:Message-Id:Cc; b=u7MNdpDI6PNOlDWovkIuqmznK8WNoyg/ZO8X0EcHhj8S7amqDYoudZPYqZ7cACsx9 F76EEQaEikqLQnDWYH8kLu/8KzLOfvmH6zoRPp1QMX+MRwps2Xi5K+OG3vclHstSuo 9iSZMNL4F5ciarn5tTjs2VorfKi18Vpzq5RDs9JU= Authentication-Results: vla1-68d3ce55e22b.qloud-c.yandex.net; dkim=pass header.i=@zhukoff.net Received: by vla5-047c0c0d12a6.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id ji0Ksy38es-M0PCfBV0; Tue, 11 Jan 2022 16:22:01 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-Yandex-Fwd: 2 From: Pavel Zhukov To: libabigail@sourceware.org Subject: [PATCH] Escape the value of the symbols name attribute Date: Tue, 11 Jan 2022 14:21:57 +0100 Message-Id: <20220111132156.2883-1-pavel@zhukoff.net> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , Cc: pavel@zhukoff.net, Pavel Zhukov Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Symbols name may include < and > characters (go-runtime is an example) which causes xml parsers to fail. Signed-off-by: Pavel Zhukov --- src/abg-writer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/abg-writer.cc b/src/abg-writer.cc index 76ce809b..e2239e01 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -3111,7 +3111,7 @@ write_elf_symbol(const elf_symbol_sptr& sym, annotate(sym, ctxt, indent); do_indent(o, indent); - o << "is_variable() && sym->get_size()) o << " size='" << sym->get_size() << "'";