From patchwork Tue Jan 11 13:10:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Zhukov X-Patchwork-Id: 49833 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C1BD38A941D for ; Tue, 11 Jan 2022 13:10:29 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from forward102p.mail.yandex.net (forward102p.mail.yandex.net [77.88.28.102]) by sourceware.org (Postfix) with ESMTPS id D9F71385801F for ; Tue, 11 Jan 2022 13:10:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9F71385801F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=zhukoff.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zhukoff.net Received: from iva7-b0912e7c43b6.qloud-c.yandex.net (iva7-b0912e7c43b6.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:2e8e:0:640:b091:2e7c]) by forward102p.mail.yandex.net (Yandex) with ESMTP id C309A393E704; Tue, 11 Jan 2022 16:10:22 +0300 (MSK) Received: from iva8-a4a480c9f089.qloud-c.yandex.net (iva8-a4a480c9f089.qloud-c.yandex.net [2a02:6b8:c0c:da5:0:640:a4a4:80c9]) by iva7-b0912e7c43b6.qloud-c.yandex.net (mxback/Yandex) with ESMTP id zLvbypUKdh-AMe0coLL; Tue, 11 Jan 2022 16:10:22 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zhukoff.net; s=mail; t=1641906622; bh=ohSffpSljFJmN6hwqLG3ZEU10Kv4oomrjl5mk16FKPE=; h=Date:Subject:To:From:Message-Id:Cc; b=jbGEm+t+HXUSmWN1ktMrXlINl2yJkSc3EV5ncgMZmHdvuJBppZtKdmIrMcIBXF2q4 scXAMiWVeVroNajBAtkIdURB27cp47KDGrUrciQeYCzeCwEFTLf8onivDYVrgFgO3o e8hnCY9VXV49VGm0hlnOwBBR4mt8/e+5bWZGe1Lc= Authentication-Results: iva7-b0912e7c43b6.qloud-c.yandex.net; dkim=pass header.i=@zhukoff.net Received: by iva8-a4a480c9f089.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id hAaFiZjl1k-ALQiDR2d; Tue, 11 Jan 2022 16:10:21 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-Yandex-Fwd: 2 From: Pavel Zhukov To: libabigail@sourceware.org Subject: [PATCH] Escape the value of the symbols name attribute Date: Tue, 11 Jan 2022 14:10:14 +0100 Message-Id: <20220111131014.25278-1-pavel@zhukoff.net> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , Cc: pavel@zhukoff.net, Pavel Zhukov Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" From: Pavel Zhukov Symbols name may include < and > characters (go-runtime is an example) which causes xml parsers to fail. Signed-off-by: Pavel Zhukov --- src/abg-writer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/abg-writer.cc b/src/abg-writer.cc index 76ce809b..e2239e01 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -3111,7 +3111,7 @@ write_elf_symbol(const elf_symbol_sptr& sym, annotate(sym, ctxt, indent); do_indent(o, indent); - o << "is_variable() && sym->get_size()) o << " size='" << sym->get_size() << "'";