From patchwork Wed Jan 5 14:17:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 49596 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA28B3858016 for ; Wed, 5 Jan 2022 14:17:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA28B3858016 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1641392277; bh=qSnCq2tIRAVDKEAs6G9U7pp5ZfzFqc7nliDrlhLkMA8=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Cxnt8FE6AqvxkdWEStNt+r2AlI2XLDuVhW5ZLdAwSTaOdzkTmvQQbEWuiUt5GRV+x +zrDD3uwJBVXbuJprjTjXQACQsSUDnKbMsTwlKcbRxF+vfo/TpP0TvP6hjuqUortwl PZMmZ3jOifE8u1nKzQmNreUUhsz3t2DeOAlTrjoo= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 7571A385840A for ; Wed, 5 Jan 2022 14:17:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7571A385840A Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 647281F37C; Wed, 5 Jan 2022 14:17:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4CEC913BE3; Wed, 5 Jan 2022 14:17:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Y5OCEXio1WELTAAAMHmgww (envelope-from ); Wed, 05 Jan 2022 14:17:28 +0000 Date: Wed, 5 Jan 2022 15:17:27 +0100 (CET) To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/101530 - fix shufflevector lowering Message-ID: <70538ps9-3o3o-26r5-9op-r9n1q318s52@fhfr.qr> MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Cc: jakub@redhat.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" This makes __builtin_shufflevector lowering force the result of the BIT_FIELD_REF lowpart operation to a temporary as to fulfil the IL verifier constraint that BIT_FIELD_REFs should be always in outermost handled component position. Trying to enforce this during gimplification isn't as straight-forward as here where we know we're dealing with an rvalue. Bootstrap & regtest running on x86_64-unknown-linux-gnu - OK for trunk? Thanks, Richard. 2022-01-05 Richard Biener PR middle-end/101530 gcc/c-family/ * c-common.c (c_build_shufflevector): Wrap the BIT_FIELD_REF in a TARGET_EXPR to force a temporary. gcc/testsuite/ * c-c++-common/builtin-shufflevector-3.c: New testcase. --- gcc/c-family/c-common.c | 5 +++++ .../c-c++-common/builtin-shufflevector-3.c | 15 +++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 gcc/testsuite/c-c++-common/builtin-shufflevector-3.c diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index 13341fa315e..64209303d54 100644 --- a/gcc/c-family/c-common.c +++ b/gcc/c-family/c-common.c @@ -1243,6 +1243,11 @@ c_build_shufflevector (location_t loc, tree v0, tree v1, tree lpartt = build_vector_type (TREE_TYPE (ret_type), mask.length ()); ret = build3_loc (loc, BIT_FIELD_REF, lpartt, ret, TYPE_SIZE (lpartt), bitsize_zero_node); + /* Wrap the lowpart operation in a TARGET_EXPR so it gets a separate + temporary during gimplification. See PR101530 for cases where + we'd otherwise end up with non-toplevel BIT_FIELD_REFs. */ + tree tem = create_tmp_var_raw (lpartt); + ret = build4 (TARGET_EXPR, lpartt, tem, ret, NULL_TREE, NULL_TREE); } if (!c_dialect_cxx () && !wrap) diff --git a/gcc/testsuite/c-c++-common/builtin-shufflevector-3.c b/gcc/testsuite/c-c++-common/builtin-shufflevector-3.c new file mode 100644 index 00000000000..0c9bda689ef --- /dev/null +++ b/gcc/testsuite/c-c++-common/builtin-shufflevector-3.c @@ -0,0 +1,15 @@ +/* { dg-do compile } */ + +typedef int __attribute__((__vector_size__ (sizeof(int)*4))) V; + +int +foo(V v, int i) +{ + return __builtin_shufflevector (v, v, 2, 3)[i]; +} + +int +bar(V v, int i) +{ + return __builtin_shufflevector(v, v, 4)[0] & i; +}