From patchwork Wed Jun 3 12:18:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 136380 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE2BC4BA2E20 for ; Wed, 3 Jun 2026 12:19:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE2BC4BA2E20 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2LNOm+j9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=542KcpHQ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2LNOm+j9; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=542KcpHQ X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 955BF4BA2E15 for ; Wed, 3 Jun 2026 12:18:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 955BF4BA2E15 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 955BF4BA2E15 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780489137; cv=none; b=U5NQmmfRzlwGNSm4G/bvlPSAcIqlIeZda5kg3VLu83bJtKWuZ7NSSRxVVTdGobtiHWg/cF0HVZ0IukJGaXLJEjFT9C0aSPW8O/s3RozlxF8ORg6WWQNE1MK1M8LY+smrTTdkf6YRwYF2JWIwWrUQBjRiblnyJCESQlLUYgw7qE0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780489137; c=relaxed/simple; bh=YTtYTdTzI6POcbsqnYjI9S1RZ5/aCyqOOF9OBdZJBUA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=unyV3aN/2q49Uy6z+a03+8TTa662R3e0kzhfO7cLOvsHbjdETpWszWVwNuLe7K0+OEZHFWrX9ccdcnf58u/7YW3XITP2j9jVri4/CMmLM2qSTYYRpKT4C+XlQ3RZxEihFyyXwGFzUbgtUS/6Y+rm2EGIhvI9rsRf9/3rWYxiSeM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2LNOm+j9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=542KcpHQ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2LNOm+j9; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=542KcpHQ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 955BF4BA2E15 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 863D76A990 for ; Wed, 3 Jun 2026 12:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780489136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4HVX0LuAgI+N0hrHfaubYdTTBBbHcd+bmJUBZwGu5fY=; b=2LNOm+j9NBEQfL1MPUhFRxu4UVgT0Fa2GmI6i/vs9rq2DI6rWzpBwwyeic6VQWXPnF65am mN+9LHQzXolJyE/JNCd9/e8HN5482bbt4BrhEfFHrKrIEBAlpij/W3M8HogKWU2vWmpZz4 yscxnfE6UsTBqxDBU09c1zZ8h4P4c2k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780489136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4HVX0LuAgI+N0hrHfaubYdTTBBbHcd+bmJUBZwGu5fY=; b=542KcpHQtLa6VF6/H2N31oCAO6E7zdoCsu5BFzVca8ulj3KnpOnalbCPGLBddUqwJoEr4O MDQFsrVD2Nb7gmDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780489136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4HVX0LuAgI+N0hrHfaubYdTTBBbHcd+bmJUBZwGu5fY=; b=2LNOm+j9NBEQfL1MPUhFRxu4UVgT0Fa2GmI6i/vs9rq2DI6rWzpBwwyeic6VQWXPnF65am mN+9LHQzXolJyE/JNCd9/e8HN5482bbt4BrhEfFHrKrIEBAlpij/W3M8HogKWU2vWmpZz4 yscxnfE6UsTBqxDBU09c1zZ8h4P4c2k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780489136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4HVX0LuAgI+N0hrHfaubYdTTBBbHcd+bmJUBZwGu5fY=; b=542KcpHQtLa6VF6/H2N31oCAO6E7zdoCsu5BFzVca8ulj3KnpOnalbCPGLBddUqwJoEr4O MDQFsrVD2Nb7gmDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 702F7779A7 for ; Wed, 3 Jun 2026 12:18:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qhcMGrAbIGrNfgAAD6G6ig (envelope-from ) for ; Wed, 03 Jun 2026 12:18:56 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [pre-commit] Add file mode check Date: Wed, 3 Jun 2026 14:18:56 +0200 Message-ID: <20260603121856.212613-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Spamd-Result: default: False [-2.79 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.19)[-0.948]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,imap1.dmz-prg2.suse.org:helo,suse.de:mid,gnu.org:url]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-Spam-Score: -2.79 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Claude Code mentioned in a review that a source file was marked executable. I've submitted a patch to fix this [1]. Detect this problem using pre-commit to prevent it from re-occurring. The current unfixed state gives us (abbreviated output using "..."): ... $ pre-commit run check-file-mode --all-files check-file-mode.........................................................Failed - hook id: check-file-mode - exit code: 1 100755 ... gdb/testsuite/gdb.base/jump_multiple_objfiles.h 100755 ... gdb/testsuite/gdb.fortran/nested-funcs.f90 100755 ... gdb/testsuite/gdb.fortran/oop_extend_type.f90 100755 ... gdb/amd64-tdep.c 100755 ... gdb/testsuite/lib/compiler.cc 100755 ... gdb/testsuite/gdb.fortran/nested-funcs.exp 100755 ... gdb/testsuite/gdb.fortran/vla-type.f90 100755 ... gdb/testsuite/gdb.arch/amd64-lam.c 100755 ... gdb/testsuite/gdb.base/jump_multiple_objfiles.exp 100755 ... gdb/testsuite/gdb.testsuite/gdb_test_multiple-lbl.gdb 100755 ... gdb/testsuite/gdb.btrace/exception.exp 100755 ... gdb/testsuite/gdb.fortran/vla-type.exp 100755 ... gdb/testsuite/gdb.base/jump_multiple_objfiles.c 100755 ... gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c 100755 ... gdb/testsuite/gdb.fortran/oop_extend_type.exp 100755 ... gdb/testsuite/gdb.fortran/print_type.exp ... Shell-checked new script gdb/contrib/check-file-mode.sh. [1] https://sourceware.org/pipermail/gdb-patches/2026-June/227780.html --- .pre-commit-config.yaml | 5 ++++ gdb/contrib/check-file-mode.sh | 42 ++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) create mode 100755 gdb/contrib/check-file-mode.sh base-commit: 663cb9c0428068165fc98675599442163d302d41 diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index fe8466433ac..d75468d0b48 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -112,6 +112,11 @@ repos: additional_dependencies: ["pyyaml"] always_run: true require_serial: true + - id: check-file-mode + name: check-file-mode + language: script + entry: gdb/contrib/check-file-mode.sh + files: '^(gdb|gdbserver|gdbsupport)/.*$' - repo: https://github.com/nmoroze/tclint rev: v0.8.0 hooks: diff --git a/gdb/contrib/check-file-mode.sh b/gdb/contrib/check-file-mode.sh new file mode 100755 index 00000000000..a558731c425 --- /dev/null +++ b/gdb/contrib/check-file-mode.sh @@ -0,0 +1,42 @@ +#!/bin/bash + +# Copyright (C) 2026 Free Software Foundation, Inc. +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +set -e + +no_exec_files=() +for f in "$@"; do + case $f in + */*.py|*/*.sh|*/configure) + continue + ;; + gdb/gstack-1.in|gdb/gcore-1.in|gdb/po/gdbtext|gdb/make-init-c|gdb/testsuite/lib/notty-wrap|gdb/testsuite/lib/pdtrace.in) + continue + ;; + *) + no_exec_files=("${no_exec_files[@]}" "$f") + ;; + esac +done + +if [ ${#no_exec_files[@]} -eq 0 ]; then + exit 0 +fi + +# Flag files that are executable, but not meant to be executable. + +if git ls-files --stage -- "${no_exec_files[@]}" | grep '^100755 '; then + exit 1 +fi