From patchwork Thu May 28 02:21:35 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Allen X-Patchwork-Id: 135852 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 798CC4BAE7D8 for ; Thu, 28 May 2026 02:26:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 798CC4BAE7D8 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=h0PUCvdO X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id B79184BAD15C for ; Thu, 28 May 2026 02:25:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B79184BAD15C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B79184BAD15C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779935149; cv=none; b=cHU7gOQRQvHCOZYgKVMlSS78xost/s6EqEr4CihVRHYGu2JynY8oXq2fYjToTnx6kb7F5p8RfjspwrpNqI++loHSL9gZzuvlcIOc12FNvWHitfMfWCogMCE8zT3C0SJYxUVZIgPBLKyph++Xr9bK3TqyTdZDyFF3Ceyynai/bcM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779935149; c=relaxed/simple; bh=6txCR3I2JeCyRpGdqIhfUuw5IrHGTu659eMfe4sY4Kc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Q5toNhzvGm69TuQwR1F9alq0gr+a1c5S91LjmEyZQv2wos45IFPcbufaAY5fpa2bFYTrD6hreEW8egmKIxPfHMxjZ/Gx0uhLDendVBVQr6pxNe4OCR4u9aPRfEuHtzETx7hEy7rnDINSVutcOtf8PZG3BTQJw2ubC8a1OVLlWJQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=h0PUCvdO DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B79184BAD15C Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-43acf1694daso7034752fac.3 for ; Wed, 27 May 2026 19:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779935149; x=1780539949; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5wUQWEcXmholqy9sxKE5oMmJJy4PYdh9daZR42qAeRA=; b=h0PUCvdOehnlBjVCfEvWpaCQiLAllg7HZzulFPrDXQ74NcUXmi1KLnfkM8syMsclnW D3AB6shiJFW10HCUPj8VrEWPfo6qonlYvNiQP2RQlm7METbdg+d/fFdifhSPnO+H+YQK benYvV8h+ty9PhzclaPeVC/nvL2aqlb+sc+ZEhA5j6Hakzcps+QgDZSY+kHGWA946/kL 2Z2TJHA+hks+fnj04TZuVgr6ZEL354G874UlaL7r3xMlP5TQySnxMgpHLimJ8rimRaN2 3JqKkgxJU1D0EUoxNnLLQnHg1F0QMd6OW7z/FwI/ecA9VTGew1DvXTl2wwGYvwenTKMa oCvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779935149; x=1780539949; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5wUQWEcXmholqy9sxKE5oMmJJy4PYdh9daZR42qAeRA=; b=asMY2X2/G2Atc0Nxa+Z3WJZY4lOZNBdw191RkjKTkiVDoVZ2NfOPWY7CafDV6A8y5v ZfljQWI2oxCDkLpDBDQNy1UvVWJyo+mh0z29yIRbIqzp1Xt8cJ6XS+g+Azm4dOlenSnt UAb4TtcRQ4L/zLKvLsgv6Jp1OhshcKa8oc5hgKXzIUiXWfLecneB10ZEpMNL7IKZe/Kb Qoxqjy2j3pm4F10DN9jbfW+8DkjzQmNl/25LN5SnQ7y8PA8gShQpYQLKHIwQQEau/IAx lRxLnsKff7u2yh2dGcavtKwj5b5oz9UfhzhDaAABk6mEy19N6TVvz4bDZKYxj1cOouEU ivLA== X-Gm-Message-State: AOJu0YyrtT9B19byFSPyRyBCuNpkZmeXAQcf5eHGM9TTePV0jCbWeliC ohka07+zUwfBYHVdxcKsdx37aoyl1lht6ORtGnbPDeBTeLiB9IZHQ3AewW2Epmr/ X-Gm-Gg: Acq92OEXpEwGBYmUX4hz7Vmp0e229rn8JOUhO9Vi8kPMjBCbvykmYXbb4zsMnieK+fu Q8JsNhqAegcdj+PBzOFxQFsfLAxDbrnz3BCNBkIKKrsX/3Q4Fq3vYTfgVlxGDZ7IUT2eeY0BB2d FBJ/umsLV0qNkpOtPstDmjYyfpWQiLJDzFJcSy2TSMS+n2HYWeDoZgWrH2HVjNon//ji40u6eit luez9BcurmDbry5UIcpZGnr9FKPH376cPJYcXLZRvHNVR5yxly5JKzuTdxcp7IeevxHM6PhIgWy IGKi238Lkbo2zmjTLtYnX2cuBmZI1YEI+awNLAOjXmM0JAKrBy/NvIhtLUJS0qTKtQda/UWxUBF PaKMhCYb6OzsWuKj7PPy9cHwLD55Qr6Nc0viiU+K48wS/8AVl1q4HnbV86LRFkrPtsH/3V/hwPU sTAAH5Gl3tJTR7bbVjRPpfqROvzeE42KVMBEguKA== X-Received: by 2002:a05:6870:35cc:b0:43b:471d:2921 with SMTP id 586e51a60fabf-43b5adca7e6mr15746160fac.22.1779935148954; Wed, 27 May 2026 19:25:48 -0700 (PDT) Received: from rsaxvc-x220.lan ([2605:a601:adbb:2600:c0d1:e2d0:b4be:913d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43b6350ad6bsm18969210fac.4.2026.05.27.19.25.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 19:25:48 -0700 (PDT) From: Richard Allen To: binutils@sourceware.org Cc: rsaxvc@gmail.com Subject: [PATCH] gprof: fix disappearing inlined functions Date: Wed, 27 May 2026 21:21:35 -0500 Message-ID: <20260528022134.133959-2-rsaxvc@gmail.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_PBL, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Load the function names from line/debug-symbols if available. The following test spends most of its CPU cycles mathing the long way around in xorshift_reverse(), but prior to this patch gprof would show 100% CPU spent in main(). #include #include #include static uint32_t xorshift_forward(uint32_t x) { x ^= x << 13; x ^= x >> 17; x ^= x << 5; return x; } static uint32_t xorshift_reverse(uint32_t x){ for(uint32_t i = 1; i < 4294967295; ++i){ x ^= x << 13; x ^= x >> 17; x ^= x << 5; } return x; } int main(){ uint32_t x = 1; uint32_t x_minus = xorshift_reverse(x); uint32_t x_minus_plus = xorshift_forward(x_minus); printf("x:%" PRIu32 " x-:%" PRIu32 " x-+:%" PRIu32 "\n", x, x_minus, x_minus_plus); return 0; } --- gprof/corefile.c | 2 +- gprof/gprof.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/gprof/corefile.c b/gprof/corefile.c index 712dd243e90..b79da05e7b2 100644 --- a/gprof/corefile.c +++ b/gprof/corefile.c @@ -881,7 +881,7 @@ core_create_line_syms (void) if (!get_src_info (vma, &filename, <ab.limit->name, <ab.limit->line_num) - || (prev.name && prev.line_num == ltab.limit->line_num + || (prev.name && (!line_granularity || prev.line_num == ltab.limit->line_num) && strcmp (prev.name, ltab.limit->name) == 0 && filename_cmp (prev.file->name, filename) == 0)) continue; diff --git a/gprof/gprof.c b/gprof/gprof.c index cea269bc80f..926581fe17e 100644 --- a/gprof/gprof.c +++ b/gprof/gprof.c @@ -641,10 +641,8 @@ symtab_init (void) /* Create symbols from core image. */ if (external_symbol_table) core_create_syms_from (external_symbol_table); - else if (line_granularity) - core_create_line_syms (); else - core_create_function_syms (); + core_create_line_syms (); /* Translate sym specs into syms. */ sym_id_parse ();