From patchwork Fri May 22 13:03:13 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kito Cheng X-Patchwork-Id: 135454 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F4DF4900302 for ; Fri, 22 May 2026 13:03:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F4DF4900302 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1779455033; bh=T0Zf//HtNFqCbJGmztuBe791Xh2BUX9UYEv4cmRuBG0=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=ZVOF7nz/C+F/aR7do8A/AKwV6GGxggyBshUrW/e6AbOb4QzD/99zSy9Mqo0k2Crac xJwNH3sTi9e4eRRSIRrOZDVLTI6iNJSvWMVijUZx0Bfp+s4fNO1kCAgSY1f+cyZLof T3irfazMmqYeIWqmsqa0SNvv590LfEi2kxxm7oFE= X-Original-To: newlib@sourceware.org Delivered-To: newlib@sourceware.org Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id CA7714BB3BAA for ; Fri, 22 May 2026 13:03:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA7714BB3BAA ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA7714BB3BAA ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779455001; cv=none; b=xWdmNAT58mQhWb88ZMvGVcn5iZbiXoJJ6iLJ5+RuimRogrvKvOOftwu9ipUtt02sg30+QBwZZhzr34JS2/odsVbZsoW1hTOE2pe2dOriLfJyH1vROVjUalr7RtKxj8qwt6JqWYrzEpZEOkbJ6VpLU7eGH9VrRIryJqduqFP08hw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779455001; c=relaxed/simple; bh=v/xSPjf2hMdk4Ia0NoZzLdyTHb5a/S7o1KMllYX0cqk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sFqS8DPW/UVNsgtpwzFjpw5DsNFdEm8okWI8TXHDowjqRivPBc51ZkWJETgAoUzayii4hgi5ZZi8Qmgsx7V5Yx+3nkpq3qEmQDedbfMKfxwS1Rf58EzyG5GKEGlSRZVV3syuMoUR0c7kyHBUHJvcsxEImYrldFUfVSVRDBLivKU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=AfrGgCKe DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA7714BB3BAA Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-367cbac9c37so4067044a91.2 for ; Fri, 22 May 2026 06:03:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779455000; x=1780059800; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T0Zf//HtNFqCbJGmztuBe791Xh2BUX9UYEv4cmRuBG0=; b=kphj9S8CMsQhrtKaaNaC5Zj+ABIaVxbViUbZL+F9Ymf4f4DMUC0De/4gYwv/DG4xtE mTd3IKgFmtOeACUjpb2SFGuSITyV1minnzow4+p4cj9+ojqXUCMWq3ygk6TYdfnrj2GM AU6BQz42KhWPQ2YHow8ijLh7wl9Yd5CmrKIFQcX6Abc1NUe0KthXzo9jGysoFor5tYI+ UAXQt6AkD7Gpv8h43TFxSxCHZcwx/vNqDFCJkRkV1wM7/Mo2fLg1WUghVGqsXdnHIE32 IewNNxs2HBVnDXXOZcDchjJ/SkOUHqfRG1hD03RmHLe3/LdIykuFipVzewK5xOT5p/bR puTw== X-Gm-Message-State: AOJu0Yw1VpxcJcPpI5US+EC1gzQTqBwcVf/n6i4orc8pt13rYW4AUBJs rWr8ttB/Ksm3cUx9j/iY0rtWOWslTuema9sWiv92m6P2h4NIuwhRc1ENDkDnZ7tbVDSfodBX0AR /8XLCSU/sWqqHJK+mCPHMIhEJNnLTaxKmnpI4LQJVDWGbNKwvGCOFfVLeVGs+0IkneBIZsUYGDD PaADwIpFgJIzoC0StzZCu/cOQ0lpNNJrtlz++w4Ptr8eKl X-Gm-Gg: Acq92OFS+4QuZLJvaZHxKpFKYIL0fYqJr29VWuOUv12sG2wkcJ+0p2cLlD4cwCFPEaM oLrRY8mbokiZxk/ppbwcA4b37CyO9qKJIGWnD091WW7FULLXFxjjP6VJnkZBKCz6t0Ocrot0ko5 nat5Gwr4Z+fmLVwfNImyF4HDhu5DJvEaSmKf+M8rTHWZ3c4CNBzmh99UH3tr/u0GGW5OC4CzxxT 1OA/+5W6jz8StIDZUsEd829cZGUp2H57u9nLXnSlPAYQpnt1vQhHJxQt/Lajm7r31Ye/h6vtZQB fe0hvxqiFPplxge6+lVRInoNDXJA0qcPkcjzqNvV203EiPKjboh0BoRdEnTe5repCfGGj0789kT Lr5r7Ow8IPywxGWSxrGTr5xIFH74yihhSJu/MggGZToTYM0eHXGeBONq7Xx+3tLaQKXawOX/Fv+ DOt+VBj7zxvUw3t7vxRyr7lQPfdkwxdoKtQhXiOU3fnpwuFmb+ X-Received: by 2002:a17:903:1b68:b0:2bd:9da9:a29b with SMTP id d9443c01a7336-2beb031a83fmr39468055ad.5.1779454999556; Fri, 22 May 2026 06:03:19 -0700 (PDT) Received: from hsinchu18.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56ba00csm17955685ad.22.2026.05.22.06.03.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 06:03:18 -0700 (PDT) To: newlib@sourceware.org, kito.cheng@gmail.com Cc: Kito Cheng Subject: [PUSHED] riscv: don't do misaligned access with !_HAVE_HW_MISALIGNED_ACCESS Date: Fri, 22 May 2026 21:03:13 +0800 Message-ID: <20260522130313.930052-1-kito.cheng@sifive.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kito Cheng via Newlib From: Kito Cheng Reply-To: Kito Cheng Errors-To: newlib-bounces~patchwork=sourceware.org@sourceware.org Respsect _HAVE_HW_MISALIGNED_ACCESS for riscv string functions --- newlib/libc/machine/riscv/rv_string.h | 3 ++- newlib/libc/machine/riscv/strcmp.S | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/newlib/libc/machine/riscv/rv_string.h b/newlib/libc/machine/riscv/rv_string.h index dc2a26daf..754e2b577 100644 --- a/newlib/libc/machine/riscv/rv_string.h +++ b/newlib/libc/machine/riscv/rv_string.h @@ -13,6 +13,7 @@ #define _RV_STRING_H #include +#include "newlib.h" #include "xlenint.h" #if __riscv_zbb @@ -67,7 +68,7 @@ static __inline char *__libc_strcpy(char *dst, const char *src, bool ret_start) char *dst0 = dst; #if !defined(PREFER_SIZE_OVER_SPEED) && !defined(__OPTIMIZE_SIZE__) -#if !(__riscv_misaligned_slow || __riscv_misaligned_fast) +#if !_HAVE_HW_MISALIGNED_ACCESS int misaligned = ((uintxlen_t)dst | (uintxlen_t)src) & (sizeof (uintxlen_t) - 1); if (__builtin_expect(!misaligned, 1)) #endif diff --git a/newlib/libc/machine/riscv/strcmp.S b/newlib/libc/machine/riscv/strcmp.S index 18ac9a981..49b999c0f 100644 --- a/newlib/libc/machine/riscv/strcmp.S +++ b/newlib/libc/machine/riscv/strcmp.S @@ -10,6 +10,7 @@ */ #include +#include "newlib.h" .text .globl strcmp @@ -36,7 +37,7 @@ strcmp: #else li t2, -1 -#if !(__riscv_misaligned_slow || __riscv_misaligned_fast) +#if !_HAVE_HW_MISALIGNED_ACCESS or a4, a0, a1 and a4, a4, SZREG-1 bnez a4, .Lmisaligned