From patchwork Mon May 11 05:11:34 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 134756 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D5874BA7981 for ; Mon, 11 May 2026 05:16:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D5874BA7981 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=X+PESoDJ X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 1D29C4BA23D6 for ; Mon, 11 May 2026 05:11:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D29C4BA23D6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D29C4BA23D6 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778476316; cv=none; b=dVHIdeijJpmePC5twAcOevKZ1ZxUHGpdgeIb5R+h3Tbz3SJiAfPutc9IqqX5OykuCZT9UQZy+IvBjcjE7bP9uf345MYBK1l8vzc1vb/QQONR8/7zR+CXkBLwAaj7rePDWTKOkeh4ozJPAwqThW50RBHEill6leAELA+pA8pU9ZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778476316; c=relaxed/simple; bh=oEXimqKz4YkqB/m1W8wXkRY7g7LHFDWLM7cA3pYFvlc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qzzuX3jEQDNlHYlycijLlY1sinTKVcaAmjQmF+IdwgE6WNEJiA3Dd07btPnBX8MuZLdFNZ6MMf0wP390wD0XC+YzuzeGpeAHRAbeo0MshevdKc83docAp1sQIBJur/DAg9OhjMQLjPGDdTP+3EADmtP2LPiDOl4hyhW9/+YjvhQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=X+PESoDJ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D29C4BA23D6 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2ba0714574fso20988205ad.2 for ; Sun, 10 May 2026 22:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778476310; x=1779081110; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4pxCK1i/W/U7WIl9vKJyGdKbTvx4j7Yl8hrKQVqXGgM=; b=X+PESoDJ/cBW8SLkVgMm+irLi42bzTfuNY27G48/CgUBcbd26pUnwUBQfpgvm2lsVt vLBA79B3W/7o8Qkq9pOE3uvpCSWaMmKtngzdKFcj0BykVAKgYCaKjeP+hRU0hk8QvJPu v/OEgM/wa+BahpRzbpU3XPSTgSGweSMs1g/wob0DQfl1+7yrNt8Drvj4Ww+KPRLWvTlj t/KekfQgxH5XhYH+qTRy7RFZ25YxglR5rvFK8J6zFsxD2IO/0ySUA3JfwGTlydef2iGE 4ke3PdL0hEEUqsrDmhk2gku01OC766hF0dMxdmSdyO1OxPfT7htlmXMLC/yxBJzVeIjl OH6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778476310; x=1779081110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4pxCK1i/W/U7WIl9vKJyGdKbTvx4j7Yl8hrKQVqXGgM=; b=HAsxh12JNC5rsSYAh8LmslStAWZqxS6fIZd8jtRqtYrRQ2yulMH3/mPqB3B6d+AVTb fpOXTGobJ/aHP1gFqOd2kh8+0tobs+QpxZOlf42GHS4BobsLP9srPw8rYRHKgpg3oWfb fpEDV9a1iY+Har+jGSX/lXeRSxKWsToR2+ckEpCKU5bnO0K3sPTvZxJSufqfxwNgU7i4 feQVQqbtjA1s41Xk/OtgFB/2kSInSRp+wx+qEs8rqhra9mswrtC3xznnKY360e7CzWO+ QgV5VwOhLw2D9fYe9+bT3ZcUdknluJfUbvREi6Mom0ss3+WgK69i863ud+8SgUl9nNDN 6l2g== X-Gm-Message-State: AOJu0YwMPertc0fYDOvw/Dd0dhoI3o9KkKqeZdFcemgKx3vVQMnlqRtG ZmeQNFwLebedt/DTn0EmOTXidAs/eWm2no6Rvv+bTryXAKK9ouIawitMSPhLlA== X-Gm-Gg: Acq92OH/eatq7VWcU9uX8+MidEBcvqVZds6VA/V1C3DZO9Z5Yi9aj+qQ4cNJyPlDwrO +6eQPaChj74vKtWElUCy6CCO/9xvWm7uMy/5iLgCNFQX682hPzdAfT1oN0b0HHFxk+mtcwjLFa1 sODtQnHgONu3DKMxdn0auHpP82RbOxX9d2o290lFp10jUlLrP11Ea23SxvMo9wtABlIDHxnGXRd ApEXY+vg8Z5uPG7KvC7boO3jR1oF4MpV3rWOb6IezeCYZIYM8v7sBIAz9PEHt6rYmnN8NGPdRx7 z5KsDX6lsqCqPvqaJ2skYAdpQ9TIr5sNKAES90F0rBK9ZLo7UxsIa+Q/Asv3ixzbPgmolCl50K4 RLC3A3bqQ1jatBk19sU1XccHiIM5041QWOIX5kGgEDrVPPzUzyd9x7D2joMZlDGtbLKIPDgBy2J 9VErXYr5FJKNteSr8rTJmhv2u3fyxhmVsDP0Lh X-Received: by 2002:a17:903:191:b0:2bc:78ec:54c0 with SMTP id d9443c01a7336-2bc78ec7562mr93441935ad.31.1778476309701; Sun, 10 May 2026 22:11:49 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:1195:f39d:dcd2:8fed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d2709bsm93193495ad.5.2026.05.10.22.11.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 22:11:49 -0700 (PDT) From: Alan Modra To: binutils@sourceware.org Subject: hppa64: get_opd in elf64_hppa_mark_exported_functions Date: Mon, 11 May 2026 14:41:34 +0930 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-3029.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org late_size_sections is too late to be creating a dynamic section, as it won't be mapped to an output section. So don't pretend that this will do anything useful, and instead omit the traversal if opd_sec is NULL. This bug showed up when using a linker-created dynobj. * elf64-hppa.c (elf64_hppa_mark_exported_functions): Don't attempt to create .opd here. (elf64_hppa_late_size_sections): Only mark exported functions for space in .opd if .opd exists. (elf64_hppa_finalize_dynreloc): Make the test for a discared other_rel_sec robust. diff --git a/bfd/elf64-hppa.c b/bfd/elf64-hppa.c index 8de91622465..f4b24b294f3 100644 --- a/bfd/elf64-hppa.c +++ b/bfd/elf64-hppa.c @@ -1017,10 +1017,6 @@ elf64_hppa_mark_exported_functions (struct elf_link_hash_entry *eh, void *data) && eh->root.u.def.section->output_section != NULL && eh->type == STT_FUNC) { - if (! hppa_info->opd_sec - && ! get_opd (hppa_info->root.dynobj, info, hppa_info)) - return false; - hh->want_opd = 1; /* Put a flag here for output_symbol_hook. */ @@ -1646,11 +1642,12 @@ elf64_hppa_late_size_sections (bfd *output_bfd, struct bfd_link_info *info) We have to traverse the main linker hash table since we have to find functions which may not have been mentioned in any relocs. */ - elf_link_hash_traverse (&hppa_info->root, - (hppa_info->root.dynamic_sections_created - ? elf64_hppa_mark_milli_and_exported_functions - : elf64_hppa_mark_exported_functions), - info); + if (hppa_info->opd_sec) + elf_link_hash_traverse (&hppa_info->root, + (hppa_info->root.dynamic_sections_created + ? elf64_hppa_mark_milli_and_exported_functions + : elf64_hppa_mark_exported_functions), + info); if (hppa_info->root.dynamic_sections_created) { @@ -2479,7 +2476,8 @@ elf64_hppa_finalize_dynreloc (struct elf_link_hash_entry *eh, if (hppa_info == NULL) return false; - if (discarded_section (hppa_info->other_rel_sec)) + if (hppa_info->other_rel_sec == NULL + || discarded_section (hppa_info->other_rel_sec)) return true; if (hh->reloc_entries)