From patchwork Wed Apr 8 15:01:23 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 132817 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 27BE04BA2E20 for ; Wed, 8 Apr 2026 15:01:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 27BE04BA2E20 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=ROS88X8o X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id A38A54BA5439 for ; Wed, 8 Apr 2026 15:01:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A38A54BA5439 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A38A54BA5439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775660486; cv=none; b=FwYY+AcVNoSwdvtg7wIDE59rMqffNljxUjAax/JzNpwsvbvj2VzfgWc6wsCKmZvDoLvbNwny9WJTDMQ5FGExf/bB5vNf8XGxhzBIG0O58xDeQ5i0Bmk9hOWfgfGdIenmtN+MXYIt2lw+2owv2IATxsdf8HGYuim4i0qnBa4N71c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775660486; c=relaxed/simple; bh=dcwN0uhcU3sffeZxI+ubParWcw/BSOuweYHAvacfTdQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=A3pDFEC8ztiEUawlMwPAf2CGcK6lcieCkMEQlnXbAR3jtDV1MXhsy2I9mGo9JMJUtHg+7STM6Fv0k5idGVnz4SwaxCXOauU9r4S3os1HwE1w7fhtcRRWBYbySWSrWq1fnS/JRY4Ihi85P336U9vhT58B1HrZYElsnLOhYxSgT/o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A38A54BA5439 Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-7dbf23885dfso1460962a34.3 for ; Wed, 08 Apr 2026 08:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1775660486; x=1776265286; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xYUsD5SU1hsmQRFa9ALdOR0E3p3GvkAMx80F4xFDDYQ=; b=ROS88X8oMKn7ayS72e4w9S9u5KsLf1Cg3msBOgHVF0PqZuAVwuSkMc2OsEqrjqwnlf 5TTOikUYOdCrQiw+VlEfREFG13KL4GWbeU7jABJ9Kwx4LjQowCubUS6p7lXhX0ddb64D y1/ve6j07qPRE3HskZoTyjSFVW2X1YYSSVzGbFHYtR4ae5gYmRfstKK/+33y9mXCjyTc tGSuGVCVYsO6Z5wE1A+30xaT9ejkPEzG5NfIUkM2zkLDLIevcb9mR0u/zeJdEcur9aJS L1qEuFp/L08ZAsDVQNUg+Yfj13JsDh8Yin4NIydqMtrGYafZ3wQDGHgGb6yZsTFBRTTZ VKGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775660486; x=1776265286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xYUsD5SU1hsmQRFa9ALdOR0E3p3GvkAMx80F4xFDDYQ=; b=SnxyzUMP0y0IAo+QXUXgifGpRkhUPYMm806pjfgbaaqH3DJ0/fqXbjhCQYVZb+k9Hi Jk9nTkF/3EM/aWa449y4bFjIRlVyV2GxX19m544TAjEXr4pvqmev5j19J49LCN4GZ5gC +OYVyF+ufRE6CNI8tnsfkuE9MrM/cGBgYABYWjFM0NLqKcSkH/+ZfqlgofCbzuIyhSAX GsnxIqzLCXCs+lE3jbZplVgF66SRVqlrKjjl0n0fSaIIa324A32wrSg4d7DAzumXpw7T tUTmgCQWeaQvcUIrC8GfF2rx5TNDYSy5PRCf7AwRnNsnsXveC22QIFCgMGmGJx8rB8yi WeVQ== X-Gm-Message-State: AOJu0YxoNXazskYsyqTDBryXOKUkw+zFmO/yF92ffUHbHZ+woFGePlkY tu7mFUBAbMWkKoUn56iBKZvxaIkvrJkR96jy21gA1eF53GEVb5JGpr881cIpswV0yfqw1Z8oEmv 2MGc= X-Gm-Gg: AeBDiespkv8wwJ7SN1AcUq+k2Vl8jvvAR0O/9Mrk/E64cuNHgzri+SKSCE2PAo+zg5R hNC2fmQ8IzjOL46AE6S0J8P9bNKApKQybaDkQL2aopt7m3syJcluNhWv4bnSkbXIYX8zVinQez+ n2n1TxTJ7WrCdxNrmyASPXfrCZgUHopSYzlyoR0vdFXxZFangc+rTqtUNVC07G87r/r8yg6Dlvl ni3hR+71/Ho5QAHu8g7Gf2znxJVTu1cOyPnlu1G8IE8TMb8wfXpAH+bx3cJ09gCwtPNjCGUWv1d T5SlqbHZi5fRVYd4vhgU0e57t70pYkaVgzTv0bUN6sHJ6ds4trjrINU9MaLBC+Jn7eCvj8oRgXZ oPFNqaDgGxZHv6RncXko9HcrRXaF+YLa099uWVkd9cNaOTQ+IbjPalZvf8GMxmgxoJJxVH+3fHg NpHjZU9t8Fqm1dwuc6Xrc4Dic47BrW/4FSo78qN5CBXhCS+BS0FR47fg== X-Received: by 2002:a05:6830:6af8:b0:7d7:eaa0:5e3f with SMTP id 46e09a7af769-7dbb7576b60mr12837849a34.24.1775660485555; Wed, 08 Apr 2026 08:01:25 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dbf2ddd6c8sm4256821a34.23.2026.04.08.08.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 08:01:25 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Clean up comment in language.h Date: Wed, 8 Apr 2026 09:01:23 -0600 Message-ID: <20260408150123.3095252-1-tromey@adacore.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org I noticed a comment in language.h that was partially obsolete. This patch removes the obsolete bits and makes a small change to the rest. --- gdb/language.h | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) base-commit: e3998113f9b66cbd0806424ac4700d2aaf8d0f77 diff --git a/gdb/language.h b/gdb/language.h index 67e6ac438b6..da903eb702d 100644 --- a/gdb/language.h +++ b/gdb/language.h @@ -661,17 +661,11 @@ extern const struct language_defn *get_current_language (); always points to *some* valid struct; it can be used without checking it for validity. - The current language affects expression parsing and evaluation - (FIXME: it might be cleaner to make the evaluation-related stuff - separate exp_opcodes for each different set of semantics. We - should at least think this through more clearly with respect to - what happens if the language is changed between parsing and - evaluation) and printing of things like types and arrays. It does - *not* affect symbol-reading-- each source file in a symbol-file has - its own language and we should keep track of that regardless of the - language when symbols are read. If we want some manual setting for - the language of symbol files (e.g. detecting when ".c" files are - C++), it should be a separate setting from the current_language. */ + The current language affects expression parsing and evaluation and + printing of things like types and values. It does *not* affect + symbol-reading -- each source file in a symbol-file has its own + language and we should keep track of that regardless of the + language when symbols are read. */ #define current_language (get_current_language ())