From patchwork Tue Apr 7 13:48:02 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 132765 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 9D94D4BA2E0D for ; Tue, 7 Apr 2026 13:48:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D94D4BA2E0D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=hngpaFFp; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+K/Iv+AM; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YONNLLqK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n0kWsjoy X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id D84CA4BA2E06 for ; Tue, 7 Apr 2026 13:48:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D84CA4BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D84CA4BA2E06 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775569684; cv=none; b=FDWLOAPRGRPk8eJJ4XPI8PGs8rOY+c5Bk/LRSsNobudG/E63iTW9RneKL30eMFE3l8WrHV/IbVFgrgyUDnB7tVTu74PwoWplnieSLFIrAXMOsBFCtA2xpW5U9PcxA8zWIGjBByWkx9UvkLBWvhl2YAfPRn0UL47GZqdFYr5eYH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775569684; c=relaxed/simple; bh=Tx/GmOotj2E1nafpCIGtdE5IS28HHOHunmOGwoA9v8Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=Ja6CjCYa2cX4LLTY+oSBYI5eBfB8rVja4yFjWPhXtlEaPJuw2yxNs2JB803WTtRfsFZMHSGP4skaLNxExamg/XsX8vcWnVLLRoUK+24T7omFuqv3stxMfUS1a/RCDm5EYI+96U1re2rbb0TKJedghWknzQRyP1C5jtGrusklwrA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D84CA4BA2E06 Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ADC6F5BD6C for ; Tue, 7 Apr 2026 13:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775569683; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=5TDD5Wf1F9UHrSwN/WyOH0jDFBa7sYq41KOdfwtNxvY=; b=hngpaFFpbKTfFQg9MLZHcKZVIjDRCGnxlrcsZpYeAZ7DHFKmW0GMxqVREsUZuvmxY+O/QO 0uO4qo5xzQwKB7ABsEahiQRaWd1OTdYLJVus46R+BEEo+esGjK12JuZRLiCFrCF4aFzhJ5 4SR2EF7YrpdfDk8ogiYnYoT2Po5NFRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775569683; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=5TDD5Wf1F9UHrSwN/WyOH0jDFBa7sYq41KOdfwtNxvY=; b=+K/Iv+AMhD1Y12npwe/Rwp01341NT/BrmNn0wb1+CnPBRnSk2Xkm7ZhWh3XZohrKskd1D1 danqr2kWPDa0bOAg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775569682; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=5TDD5Wf1F9UHrSwN/WyOH0jDFBa7sYq41KOdfwtNxvY=; b=YONNLLqKMuCf35E3eKu4SWyPZmFQnWayjkVU03fePsij/edq2g0AMDDYXQym+wWcX+T5gE d6xamnUBW5HubvrI1Tjz+59EySHJDzF1KDrFokQ9W607dFewfe2KArhj/tAIcW770bTyDB j+We0pVuERvl9ZjrIeRs8XybpWwQysk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775569682; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=5TDD5Wf1F9UHrSwN/WyOH0jDFBa7sYq41KOdfwtNxvY=; b=n0kWsjoyzT5g122abeGaet2u3ejXaB9VBaFW+rkegpJbJwUvIUesAVi5mIYXVDJD9ThLZR aLNpvaP4i+VXLsDw== Date: Tue, 7 Apr 2026 15:48:02 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH 1/2] tree-optimization/124802 - wrong SLP pattern detection MIME-Version: 1.0 X-Spam-Score: -1.80 X-Spam-Level: X-Spamd-Result: default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[murzim.nue2.suse.org:helo, tree-vect-slp-patterns.cc:url] X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Message-Id: <20260407134842.9D94D4BA2E0D@sourceware.org> We have some permute SLP nodes which still have a SLP_TREE_REPRESENTATIVE, so make sure we're not facing a permute note when trying to perform SLP pattern matching. Bootstrap & regtest running on x86_64-unknown-linux-gnu, this is the conservative fix suitable at this stage and for backporting. PR tree-optimization/124802 * tree-vect-slp-patterns.cc (vect_match_expression_p): Fail for SLP_TREE_PERMUTE_P. * gcc.dg/vect/vect-pr124802.c: New testcase. --- gcc/testsuite/gcc.dg/vect/vect-pr124802.c | 118 ++++++++++++++++++++++ gcc/tree-vect-slp-patterns.cc | 1 + 2 files changed, 119 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/vect/vect-pr124802.c diff --git a/gcc/testsuite/gcc.dg/vect/vect-pr124802.c b/gcc/testsuite/gcc.dg/vect/vect-pr124802.c new file mode 100644 index 00000000000..f67e07bc73a --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/vect-pr124802.c @@ -0,0 +1,118 @@ +/* { dg-skip-if "requires x86 intrinsic header" { ! { x86_64-*-* i?86-*-* } } } */ +/* { dg-require-effective-target avx2_runtime } */ +/* { dg-require-effective-target fma } */ +/* { dg-additional-options "-mavx2 -mfma" } */ + +/* PR tree-optimization/NNNNN + Wrong code with AVX2 complex double multiply at -O2. + Reduced from a sparse matrix kernel. */ + +#include + +#include "tree-vect.h" + +static inline __m256d +cmul (__m256d a, __m256d b) +{ + __m256d t = _mm256_mul_pd (_mm256_movedup_pd (_mm256_permute_pd (a, 0x5)), b); + return _mm256_fmaddsub_pd (_mm256_movedup_pd (a), b, + _mm256_permute_pd (t, 0x5)); +} + +__attribute__((noipa)) void +kern (long n, long nnz, const double *alpha, const double *val, + const long *col, const double *B, long ldb, double *C) +{ + for (long p = 0; p < nnz; p += 4) + { + long blkr, p0, p1, p2, p3; + long left = nnz - p; + if (left == 1) { blkr=1; p0=p; p1=p; p2=p; p3=p; } + else if (left == 2) { blkr=2; p0=p; p1=p+1; p2=p; p3=p; } + else if (left == 3) { blkr=3; p0=p; p1=p+1; p2=p+2; p3=p; } + else { blkr=4; p0=p; p1=p+1; p2=p+2; p3=p+3; } + + double ar0 = alpha[0]*val[p0*2] - alpha[1]*val[p0*2+1]; + double ai0 = alpha[0]*val[p0*2+1] + alpha[1]*val[p0*2]; + double ar1 = alpha[0]*val[p1*2] - alpha[1]*val[p1*2+1]; + double ai1 = alpha[0]*val[p1*2+1] + alpha[1]*val[p1*2]; + double ar2 = alpha[0]*val[p2*2] - alpha[1]*val[p2*2+1]; + double ai2 = alpha[0]*val[p2*2+1] + alpha[1]*val[p2*2]; + double ar3 = alpha[0]*val[p3*2] - alpha[1]*val[p3*2+1]; + double ai3 = alpha[0]*val[p3*2+1] + alpha[1]*val[p3*2]; + + long b0 = col[p0]*ldb*2, b1 = col[p1]*ldb*2; + long b2 = col[p2]*ldb*2, b3 = col[p3]*ldb*2; + + for (long j = 0; j < n * 2; j += 4) +{ + __m256d cv = _mm256_loadu_pd (&C[j]); + __m256d bv0 = _mm256_loadu_pd (&B[j + b0]); + __m256d bv1 = _mm256_loadu_pd (&B[j + b1]); + __m256d bv2 = _mm256_loadu_pd (&B[j + b2]); + __m256d bv3 = _mm256_loadu_pd (&B[j + b3]); + __m256d av0 = _mm256_set_pd (ai0, ar0, ai0, ar0); + __m256d av1 = _mm256_set_pd (ai1, ar1, ai1, ar1); + __m256d av2 = _mm256_set_pd (ai2, ar2, ai2, ar2); + __m256d av3 = _mm256_set_pd (ai3, ar3, ai3, ar3); + + switch (blkr) + { + case 4: cv = _mm256_add_pd (cmul (av0, bv0), cv); + cv = _mm256_add_pd (cmul (av1, bv1), cv); + cv = _mm256_add_pd (cmul (av2, bv2), cv); + cv = _mm256_add_pd (cmul (av3, bv3), cv); + break; + case 3: cv = _mm256_add_pd (cmul (av0, bv0), cv); + cv = _mm256_add_pd (cmul (av1, bv1), cv); + cv = _mm256_add_pd (cmul (av2, bv2), cv); + break; + case 2: cv = _mm256_add_pd (cmul (av0, bv0), cv); + cv = _mm256_add_pd (cmul (av1, bv1), cv); + break; + case 1: cv = _mm256_add_pd (cmul (av0, bv0), cv); + break; + } + _mm256_storeu_pd (&C[j], cv); +} + } +} + +int +main (void) +{ + check_vect (); + + double alpha[2] = { 1.0, -2.0 }; + double val[] = { 5, 12, 5, 40, -1, 5 }; + long col[] = { 0, 1, 2 }; + double B[] = { + 10, 240, 24, 523, + -23, 233, 55, 28, + 1, 2, 2, 52 + }; + double ref[4] = { 0 }, res[4] = { 0 }; + int i, j, k; + + for (k = 0; k < 3; k++) + { + double ar = alpha[0]*val[k*2] - alpha[1]*val[k*2+1]; + double ai = alpha[0]*val[k*2+1] + alpha[1]*val[k*2]; + for (j = 0; j < 2; j++) + { + ref[j*2] += ar*B[(col[k]*2+j)*2] - ai*B[(col[k]*2+j)*2+1]; + ref[j*2+1] += ar*B[(col[k]*2+j)*2+1] + ai*B[(col[k]*2+j)*2]; + } + } + + kern (2, 3, alpha, val, col, B, 2, res); + + for (i = 0; i < 4; i++) + { + double d = res[i] - ref[i]; + if (d * d > 1e-10) + __builtin_abort (); + } + + return 0; +} diff --git a/gcc/tree-vect-slp-patterns.cc b/gcc/tree-vect-slp-patterns.cc index f30b1eb91a3..0976258a36d 100644 --- a/gcc/tree-vect-slp-patterns.cc +++ b/gcc/tree-vect-slp-patterns.cc @@ -302,6 +302,7 @@ static inline bool vect_match_expression_p (slp_tree node, code_helper code) { if (!node + || SLP_TREE_PERMUTE_P (node) || !SLP_TREE_REPRESENTATIVE (node)) return false; From patchwork Tue Apr 7 13:48:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 132766 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E93ED4BA2E26 for ; Tue, 7 Apr 2026 13:50:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E93ED4BA2E26 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WAEt+9zQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1FzgPNs/; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JLTICPNH; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rVfZdcGJ X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id D6F4A4BA2E1D for ; Tue, 7 Apr 2026 13:48:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6F4A4BA2E1D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6F4A4BA2E1D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775569706; cv=none; b=rF1j+aMppXTRsR3EI+DhIi2dXp1nDkUQg5sH3pkyavzjovdDA5/Vgd3t/8qYWYJeW+5ZsyEZsToD1A1o1hdvf+FJNaTTtW0IaEfL/r3jHNOnpnBj210HGbTa0aP6k9//ojrNDDtuf5XdEfL4W/vubhjb29+bnjZWEMXwAuc/LeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775569706; c=relaxed/simple; bh=+fJ45xuDbYudraL8nJ1MJn4z6nz1y7k6xf95+n8hVlU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=MapYR0ajelDgHyLCsKzshefO46WthVOW6pwjMlXDCVfn72ohKxlosG81ymwhpyop1xRVWCOSqsQv6cHaPU01YOsqAEL5UPTbHxA8sXpMPh84RYp0v6ijJg0K9HKc8nwTLINnlWsw/EeZ5QjJzxiZ1eBRIv41TMcz+9IfsBDccY0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6F4A4BA2E1D Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D81025BD6C for ; Tue, 7 Apr 2026 13:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775569705; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=cpgBz58cMaVAB/bE0dRtcVB022pXkGqeJLrQEnBuKRQ=; b=WAEt+9zQDn9/1c0oU0w2BTue575kYOqxFhJ8TNMnH+VbEIgQ4P4co8TUsz1OBtLumYdQhO Z1HwBC45y8PBiwRWNQ1PRRdXYCyWLIhOdx9jPiVneZwDmO0TuKN7DeYXCU7uh+iVoKe9hF /G+UB515Ax4M46ubqYgwPfUEEFTkZvA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775569705; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=cpgBz58cMaVAB/bE0dRtcVB022pXkGqeJLrQEnBuKRQ=; b=1FzgPNs/L7eH6SL7f+5AssyVBhIo2sfrayYcW56aqJphN0ZGqGumpZRDhawMOLHhn4I1TB ZRX/jPcZ7cPPAyAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775569704; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=cpgBz58cMaVAB/bE0dRtcVB022pXkGqeJLrQEnBuKRQ=; b=JLTICPNH83l6QjPbWfRQftfhwhcAJK3OiHa+zFRbL0fpuV/sRNWiZA9LEXejVrhzOcqrf7 0ZzUa3clJfTjPyqkrCymv1pim+PK0hnZBXwrT0s3Vpvpz5UNN+0XVjbSl6pR9V+mdElH9k 93zEkGW7vE0rhJmTPODS5OYhe4ZWkJE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775569704; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=cpgBz58cMaVAB/bE0dRtcVB022pXkGqeJLrQEnBuKRQ=; b=rVfZdcGJ/r0X7DXuSkXVaXu8hB0i7KlfbeO/SkvzbqoQah8B1Gd7IbwdaZrRheMtBqK/ty zSn3Mu6BiPWK8VBg== Date: Tue, 7 Apr 2026 15:48:24 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH 2/2] tree-optimization/124802 - avoid SLP_TREE_REPRESENTATIVE for permutes MIME-Version: 1.0 X-Spam-Score: -1.80 X-Spam-Level: X-Spamd-Result: default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.20)[-0.995]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[murzim.nue2.suse.org:helo] X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Message-Id: <20260407135001.E93ED4BA2E26@sourceware.org> The following avoids having a SLP_TREE_REPRESENTATIVE for permute nodes from two operator SLP matching. Bootstrap and regtest running on x86_64-unknown-linux-gnu. And this I plan to push for stage1. PR tree-optimization/124802 * tree-vect-slp.cc (vect_build_slp_tree_2): Reset SLP_TREE_REPRESENTATIVE for permute nodes built from a known set of scalar stmts. --- gcc/tree-vect-slp.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 9d2d0f98ea8..aa442d53999 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -3137,6 +3137,7 @@ fail: SLP_TREE_VECTYPE (pnode) = vectype; SLP_TREE_CHILDREN (pnode).quick_push (child); SLP_TREE_CHILDREN (pnode).quick_push (child); + SLP_TREE_REPRESENTATIVE (pnode) = NULL; lane_permutation_t& perm = SLP_TREE_LANE_PERMUTATION (pnode); children.safe_push (pnode); @@ -3166,6 +3167,7 @@ fail: SLP_TREE_CODE (node) = VEC_PERM_EXPR; SLP_TREE_CHILDREN (node).quick_push (one); SLP_TREE_CHILDREN (node).quick_push (two); + SLP_TREE_REPRESENTATIVE (node) = NULL; enum tree_code code0 = ERROR_MARK; enum tree_code ocode = ERROR_MARK; if (gassign *stmt = dyn_cast (stmts[0]->stmt))