From patchwork Tue Apr 7 10:15:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 132749 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id BA38E4BA2E11 for ; Tue, 7 Apr 2026 10:19:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA38E4BA2E11 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=FB/vyivf X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by sourceware.org (Postfix) with ESMTPS id 0489F4BA2E24 for ; Tue, 7 Apr 2026 10:15:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0489F4BA2E24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0489F4BA2E24 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=209.85.215.171 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1775556956; cv=pass; b=wzOfMD0hfjgqe4V17EC9SvrsfjWsjfa009amA1vjEFf+fscnqtbQrMPDNlLG9P2j0EaxevAxc18KUqhpWO4SkDyl11yLRBm88sTQ9UKAwUV7AsP6zJWEI2UWxznfEBLyj4JXICj+G7IKSDhWLaPnqQ+o1AYNefbwnt6DnWTlx7Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1775556956; c=relaxed/simple; bh=xrvTjwS625s1iy7hDyWYZaMUiR0j/kiOV/Tmqc6raIQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=maYgkTWr7vkjRyKyZld9y6yqKzgBeaMvlfmk7h0yEDnm71IQZBLg9uLGGjeo7QOvFRA30552oJTIPcTO3IkNvAHqidK5C9TJeL47m9Bp4y0WbfsUdrWDWOJEsLcXFmfZ0+Tf1y04EzRcLlvsYB0VmF6YF6igjdzGQ1o/O35Nefk= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0489F4BA2E24 Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c757a9251faso1647787a12.1 for ; Tue, 07 Apr 2026 03:15:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775556955; cv=none; d=google.com; s=arc-20240605; b=bSTZ2FZvuF2WHSAwiHslxDeHXWcz+vRdzMWELT7REr28ACe6358k/4v47m1K2Lqj5U IXESiEBdHJl/QXvD3Hl070MOJ3BdLrYX/3LwSd5l6W+DIU/CdgbU/8+D14jEwL9517u0 VnvOtd1gom8RRNi2kMpL2x6TYb8ZATU0jkZL/HbKK64xZtzTYjDRsaBOdtVf4qgp2V8i mjtnxN0jmxd1PCZEWPKObnLBvXnmPlHXnDYYt8GBT4ipbektluLcKybrpO6hKr8EL1Ay DFker9yHv8dx3tzCRX6Iv8YEP5aZteHozzUrJRmL+tlmq/mxIabZPUr8qLfrMNPukx53 LZIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=to:subject:message-id:date:from:mime-version:dkim-signature; bh=W5DkqWlLGlEQLxEsDr4tBDs2WNMB6fWo1glCwiiuzGs=; fh=okR1CaX4KpVgB6hlfiPM+t24kv6J9DbMhqBwAOjM2v0=; b=TzDvJKzx7Cv9nygWeo0cdeVQGjBCQFeldQRQ4PMymzWDw2+d9t+G3/9taYpqsJeI2W s6n82JAIcJZu0HTCcvTKdVf00pB3q3mZ+HzTTcRfEsBNgcCfYiz8F349jnRoCCSbSZUs zbrHxj2yBuOpStWeYD1ZGzSNnswbJz+fpOob2CFrezYZlScKhZVGPZsJo4W6JXnC9d5c RyL8I1QSp29ZlmCiZq2vU8YMsBe3sMCYCoxwGvgJoWNPjh51weMQfRa9Cc20w2OgFkIx TNLGgR1+nIsNOmAFqekivKOaTRPSdJqTPOJN+VMLzV7VmMtQrHz5WmhHxtpPV5XqNX4q R6Xg==; darn=gcc.gnu.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775556955; x=1776161755; darn=gcc.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=W5DkqWlLGlEQLxEsDr4tBDs2WNMB6fWo1glCwiiuzGs=; b=FB/vyivf6FbohhQ86Of8UmfcuBCHCL8JbumQA7PFUEYCk02E76IJHuThERFKGyB/cn Z4MSBMGk8zxmEXdFat1/gT0KcdM3ju72p8Uo8lYA9rhDRayVJVmJMlaaykXevAPx9VXJ qHmo6iENWsgPvb6cUHJSZkJn01D9AMbK+I8L74cDZ7ZrAFMje/rYX+gGgRHLImSVrPdp rmNyiR3dyX4hhPnTkmg+cQvlbYMx2VP8m0rHNn4ToMV8cpwz0jGXD6s/7RKzCV5VOnWP XNpsD/pjvxp5GCuncwDTtwr5c7kTwBX5H6ltwNjedt+Plso7+AXToIUwGt9vDPtEZpnU Dd5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775556955; x=1776161755; h=to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W5DkqWlLGlEQLxEsDr4tBDs2WNMB6fWo1glCwiiuzGs=; b=BMQ8LmZ7KETrTQnQrgl9/TnWU5yeZZAIz7EOiy1VsKrpMzgKGk+MaNc0l0ALaXeA33 cHsPHZu+3EAVqZEJZyKNlu75pClJVo2JuvjP+nWW17IQkesh1UpqbHA7+Jxu2RAgaBff 0UTGLzRsO1V+pFE8RjLQKapmWdN7FIAwsPunqK52qCmcQP3jdZctvvHTqq7LOrxv7iRZ 5/839dbg2P/yL0JhSlQiOAx0JZAG0Fflyua1ORtZAbhPphPhECTzoDbt3UrwiU4dNkyx iV6Rrwv0F7scm65cQtHlK9V2EB+NPdO5aOuvrL0m/I4mnmM3ptVrbdeoR33GD2ZG/Pb0 pcRg== X-Gm-Message-State: AOJu0YzmwdEwK3OJNzSWfKJtTDI0LL7/nV60FrfNoAD0EyHOiyxPtjIZ ZSYEjg/1BKHb1Fs+YTMQALxGAwFfZAEa2IqGqvSIA6vRXLqJ5qxnIr+S+PepHZEyY4u5kyTZIUV rMsMKAj5nDkpq4gcc6IVnOtoq+Rzc2DuYbe2U7S+L0w== X-Gm-Gg: AeBDieuB5WaT1VOoZpaOqac2UBY/xUlU1KwA+t4z9fbsPJ0eImb+QBSOFT45oJgjIZb 2pY3AOcyglJGcwSCUePNXE6MPW0Eh+r8Dqoe6it5qH0rKNREPc4TQiHvWx2smtxxpxNX/qFB7gI dIfV57dmI64e3u9nKqvHWRUgDUf++90aFl/Jr9k12yXe+SRYlYaYMiSMbsqdbRoAy4zpEyiK+t8 QM3CxgzzpPvAbceS60cto9tmFofJcDsxrSVtyVuIkNaiNWYOTVCXVAs2/kDveZWmg04dJ3vwtJ+ HZ3l8w== X-Received: by 2002:a05:6a20:430a:b0:39b:c9ff:e3eb with SMTP id adf61e73a8af0-39f2f045a80mr17874909637.4.1775556954526; Tue, 07 Apr 2026 03:15:54 -0700 (PDT) MIME-Version: 1.0 From: "H.J. Lu" Date: Tue, 7 Apr 2026 18:15:17 +0800 X-Gm-Features: AQROBzD2Pxd8a2kcLzttLLZmSxyHUOxOCO-MAi9TkYEphwMHgyYesR6qFrYD7aw Message-ID: Subject: [PATCH] Update x86: Call ix86_access_stack_p only for larger alignment To: GCC Patches , Richard Biener , Uros Bizjak , Hongtao Liu X-Spam-Status: No, score=-3011.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org commit f511bf93f947199a9f9099fee87b7052e5515fb9 Author: H.J. Lu Date: Sun Mar 29 14:30:28 2026 -0700 x86: Call ix86_access_stack_p only for larger alignment incorrectly uses GET_MODE_ALIGNMENT as memory alignment since memory alignment can be different from mode alignment as in (set (reg:OI 20 xmm0 [orig:112 s ] [112]) (mem/c:OI (plus:DI (reg/f:DI 7 sp) (const_int -32 [0xffffffffffffffe0])) [3 s+0 S32 A128])) MEM_ALIGN should be used instead. * config/i386/i386.cc (ix86_need_alignment_p_1): Replace GET_MODE_ALIGNMENT with MEM_ALIGN. From ab0ab385d5feffc62e9b25fda22279f5f1b71748 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Tue, 7 Apr 2026 18:12:27 +0800 Subject: [PATCH] Update x86: Call ix86_access_stack_p only for larger alignment commit f511bf93f947199a9f9099fee87b7052e5515fb9 Author: H.J. Lu Date: Sun Mar 29 14:30:28 2026 -0700 x86: Call ix86_access_stack_p only for larger alignment incorrectly uses GET_MODE_ALIGNMENT as memory alignment since memory alignment can be different from mode alignment as in (set (reg:OI 20 xmm0 [orig:112 s ] [112]) (mem/c:OI (plus:DI (reg/f:DI 7 sp) (const_int -32 [0xffffffffffffffe0])) [3 s+0 S32 A128])) MEM_ALIGN should be used instead. * config/i386/i386.cc (ix86_need_alignment_p_1): Replace GET_MODE_ALIGNMENT with MEM_ALIGN. Signed-off-by: H.J. Lu --- gcc/config/i386/i386.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index 39136ce5042..f4d0f623943 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -8789,7 +8789,7 @@ ix86_need_alignment_p_1 (rtx set, unsigned int alignment) rtx dest = SET_DEST (set); if (MEM_P (dest)) - return GET_MODE_ALIGNMENT (GET_MODE (dest)) > alignment; + return MEM_ALIGN (dest) > alignment; const_rtx src = SET_SRC (set); @@ -8799,7 +8799,7 @@ ix86_need_alignment_p_1 (rtx set, unsigned int alignment) auto op = *iter; if (MEM_P (op)) - return GET_MODE_ALIGNMENT (GET_MODE (op)) > alignment; + return MEM_ALIGN (op) > alignment; } return false; -- 2.53.0