From patchwork Thu Mar 19 09:13:21 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 131948 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 46C3E4B1A2F4 for ; Thu, 19 Mar 2026 09:14:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46C3E4B1A2F4 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=L7zsqNJX X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 9DCE54BBCDA0 for ; Thu, 19 Mar 2026 09:13:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DCE54BBCDA0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DCE54BBCDA0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773911605; cv=none; b=w+pzM05oOXoKZqpFGMRJ/0V5axUowtRjdxpApUkVUB7s20UARqe2np5RHvvVAgiF31fkH5Faq+jgAeUG6lW5+zeQEvS07ItSQS7Q8l5tO0IO0LK43QlSReW+7IQTfBEvrB7D8RlIM3fx4gVwUaLckZTbNkpdd0J3rCJQ0QhffPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773911605; c=relaxed/simple; bh=wtgqczJXFpy6adia+lDa/8cOMbTQxe/UHP1IRUr5ews=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=I2TLI3NBPScNAhNWmSC14hOLOLD1O4VNNITTh8unqeCUSOKz0WM7pCHuDU96xNDjT76DkKGGa6+5Xnqs8LhYJq6ErxywHo/eXw7q3ltFpGtIV4jDcEW5+GkVDgGbG0HO58YHJ1KR8wnbM6/yzvNBJbtcInF8llPWvbjCU/r6lmQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9DCE54BBCDA0 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2b05761bec1so8001225ad.1 for ; Thu, 19 Mar 2026 02:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773911604; x=1774516404; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=TKdn7gYgbbdl+/k5ZWn7+NuV2MRVABmauAjtE0urUPE=; b=L7zsqNJXd13uz3zFJr02h4Ch50sNrMjJd/Qn1SdT7tYz+AYOU8iKvzfsY8LC+vR09R DFWlUVMpBquFzbFUVyzLqLjWUmd0QjgepY/JIElF6tGr7A9A99HISF5XVQod/0o5mzJO MPgxEUJ5KYCe01dTNe3rEuSsMa+8T8BPHFuE/3Y629rIUOxHEnA1cYxMycECUTy5erJx /Mzcv6LvjdAbdgSaplK+DGDA/DD1lGXScVj3lv0IWMyJdI0YtT+k6AmnTJtgurQOCzvg ZwgKV/nTX5+sDja9ItGiIWpdVggisS18cSVoyN3ODdQIAqfCP03SvffGlhnC0Vb/X5oB yKlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773911604; x=1774516404; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TKdn7gYgbbdl+/k5ZWn7+NuV2MRVABmauAjtE0urUPE=; b=VkewjBHZDWNjgQz+sw+ihVC9DNSXs0X/afrydL2nTb6CawW6CkuZbnPnQoM72VS4jL mHzaM384zgq1XxsWhv0AGS5bYJ26BVtsk9GsVGKZs3+dG6dlTCKqtKnY2ceyVsRufiz0 MLN2L0vCIp3q8fS1xHY9g6PoxsWphmuhLmHs9RJJJr+J+vJUHCERUJBbdh1qCcXgBTUF tUnThzJwEz3411sB+kSQSLclyhxqlFV9juh90ymHBwpV2ilnGuC650dR0xfAJUqwtHSo +G4cjyIQbgza+gmgms/xFnWyiTtuQxWKw9WxoBVEDyw7SKoRYykyfTPhGKlzQye0V7Vp jD5Q== X-Gm-Message-State: AOJu0Yz9urS3qwCw/Q7BSaK+D+nWEbk33PHdYsptfE7woiNSmGmak9xL E7hktvgETQXwt3mUi+5ovbKorOPq649DQNpHSHOJ0hvLLmwJwy3AWdVvIGW6Dg== X-Gm-Gg: ATEYQzzGGbXer7/RjjjAkUAmza8Z+7JST/ynMnpRC7+Ebh8pIUmvN96cuc9Iw9l9bqD ONmaA70IB7Nq+vA05Xz7soFFM+eDkI/Sw4o7XUhTrujIq5KSZ7wz47e9BfVdr6ufzEECgMfV7Pr Au+FCO649gdXtGJd409XW0MEBdBRImXqpNvo0f1B4LHzHzt/I/ONMwp0yR6nXMYKlyH45pjU988 BFOBJ/p5Vj/FEN4uuAWeK60PkbvR3PervNOemqUYPBxz9ZwDA7ZIv4RFwv4mjmFvdSQ6q4axdik 5fAxwrtYxaueHoiF21nePUiKsjNtzDPufyfKqvSuXWN+AOse3PeMf79dTmliSTTU5XMbUQLfoe0 IpCN44r/QV41gtMPEKwMtJpSpY3yWDQpJC9wHp7/aabyq2pr/gMIxYRxXsOK1I8wkbNsnDfr8EN otb5av8LIGW2OFq2MrO/yE821R0Ks7IUJYVQI6oNpj9VxXCaIJ6mKOMbZp1+TZOa5efM3SCbyT1 0KNJLku X-Received: by 2002:a17:903:234d:b0:2b0:6068:4c5f with SMTP id d9443c01a7336-2b077149c90mr22204565ad.8.1773911604340; Thu, 19 Mar 2026 02:13:24 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e604e7bsm70493795ad.63.2026.03.19.02.13.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 02:13:23 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 27AFE1141A9F; Thu, 19 Mar 2026 19:43:21 +1030 (ACDT) Date: Thu, 19 Mar 2026 19:43:21 +1030 From: Alan Modra To: binutils@sourceware.org Subject: xtensa: properly check reloc address Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org The existing check didn't take the reloc size into account. * elf32-xtensa.c (bfd_elf_xtensa_reloc): Use bfd_reloc_offset_in_range. diff --git a/bfd/elf32-xtensa.c b/bfd/elf32-xtensa.c index 1faa884f1d8..8a1e2e064ea 100644 --- a/bfd/elf32-xtensa.c +++ b/bfd/elf32-xtensa.c @@ -2178,7 +2178,7 @@ bfd_elf_xtensa_reloc (bfd *abfd, } /* Is the address of the relocation really within the section? */ - if (reloc_entry->address > bfd_get_section_limit (abfd, input_section)) + if (!bfd_reloc_offset_in_range (howto, abfd, input_section, octets)) return bfd_reloc_outofrange; /* Work out which section the relocation is targeted at and the