From patchwork Tue Dec 14 11:53:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 48894 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E397385842B for ; Tue, 14 Dec 2021 11:54:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E397385842B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639482850; bh=Qi7N0+gjwdr13AQ3xPzpKifxfrVI6cqgjxHFX0lV4MA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=QjavqEKWH/vbR1t6kpTzoh16yrBx7nUAmy2qgLk5nwtTdU3YkdVQWlnpvlfnS2IWr 646OdUzhej8PR3sDgidL8ctmkE+mq0UovATVGztr6USSUgf63uJrRgcP/gmwSK39EF ABAmbrVUHaBws3JIpGioNLAV+ZhdLrQ2uAjroK1A= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C68C43858D28 for ; Tue, 14 Dec 2021 11:53:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C68C43858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-330-FJSwiNUsNkeLzAG0I03fkw-1; Tue, 14 Dec 2021 06:53:47 -0500 X-MC-Unique: FJSwiNUsNkeLzAG0I03fkw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 551AA100C609; Tue, 14 Dec 2021 11:53:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.17.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1044196F8; Tue, 14 Dec 2021 11:53:44 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH] elf: Use new dependency sorting algorithm by default Date: Tue, 14 Dec 2021 12:53:41 +0100 Message-ID: <87fsqvqu62.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The default has to change eventually, and there are no known failures that require a delay. Tested on i686-linux-gnu and x86_64-linux-gnu. Reviewed-by: Adhemerval Zanella --- NEWS | 7 ++++--- elf/dl-tunables.list | 2 +- elf/tst-rtld-list-tunables.exp | 2 +- manual/tunables.texi | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index b53f230cca..2aaece42f5 100644 --- a/NEWS +++ b/NEWS @@ -60,9 +60,10 @@ Major new features: of the existing sorting algorithm when encountering particular circular object dependency cases. -* A new tunable, glibc.rtld.dynamic_sort, can be used to select between the two - DSO sorting algorithms. The default setting of '1' uses the current existing - algorithm, while a value of '2' selects the new DFS-based algorithm. +* A new tunable, glibc.rtld.dynamic_sort, can be used to select between + the two DSO sorting algorithms. The default setting of '2' uses the + new DFS-based algorithm. The setting '1' switches to the old + algorithm used in glibc 2.33 and earlier. * ABI support for a new function '__memcmpeq'. '__memcmpeq' is meant to be used by compilers for optimizing usage of 'memcmp' when its diff --git a/elf/dl-tunables.list b/elf/dl-tunables.list index 46ffb23784..ffcd7f18d4 100644 --- a/elf/dl-tunables.list +++ b/elf/dl-tunables.list @@ -162,7 +162,7 @@ glibc { type: INT_32 minval: 1 maxval: 2 - default: 1 + default: 2 } } } diff --git a/elf/tst-rtld-list-tunables.exp b/elf/tst-rtld-list-tunables.exp index 9bf572715f..44e4834cfb 100644 --- a/elf/tst-rtld-list-tunables.exp +++ b/elf/tst-rtld-list-tunables.exp @@ -10,6 +10,6 @@ glibc.malloc.tcache_max: 0x0 (min: 0x0, max: 0x[f]+) glibc.malloc.tcache_unsorted_limit: 0x0 (min: 0x0, max: 0x[f]+) glibc.malloc.top_pad: 0x0 (min: 0x0, max: 0x[f]+) glibc.malloc.trim_threshold: 0x0 (min: 0x0, max: 0x[f]+) -glibc.rtld.dynamic_sort: 1 (min: 1, max: 2) +glibc.rtld.dynamic_sort: 2 (min: 1, max: 2) glibc.rtld.nns: 0x4 (min: 0x1, max: 0x10) glibc.rtld.optional_static_tls: 0x200 (min: 0x0, max: 0x[f]+) diff --git a/manual/tunables.texi b/manual/tunables.texi index 5d50b90f64..28ff502990 100644 --- a/manual/tunables.texi +++ b/manual/tunables.texi @@ -318,7 +318,7 @@ value of @samp{2}, a different algorithm is used, which implements a topological sort through depth-first search, and does not exhibit the performance issues of @samp{1}. -The default value of this tunable is @samp{1}. +The default value of this tunable is @samp{2}. @end deftp @node Elision Tunables