From patchwork Wed Dec 3 09:20:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "claudiu.zissulescu-ianculescu--- via Binutils" X-Patchwork-Id: 125821 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AB55F48F5360 for ; Wed, 3 Dec 2025 09:21:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB55F48F5360 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1764753706; bh=lEZeI+3BxHgXOEj89zw+f7X1Z6ciUXzREDU37MvSZkU=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=NlZh0KBAw0XQlqb3OpEaeHqLYl1VOf1Zpf4gAtz6/jOs5JWa2qyryhC8SexuTGY6f cvDVHHlJ5dfXkn5vnWonWIzhA+qhlGwGyuLw2HtQnzu6WZw39vI/FQ5jrCn+y8xPL9 dg1OjhJL3ccCjoNipsvqdoKyWopzIMYw7nhhX2iw= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 8E4AE48F8E39 for ; Wed, 3 Dec 2025 09:21:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E4AE48F8E39 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E4AE48F8E39 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1764753663; cv=pass; b=qThNkKMAEd+brXbPZ8XUHC01WgxmTB/y3k0kFA2vItoomtYfd5hutpyCWr+DLDichK18elbsrowrzYvK85KZx0lYyhSWgYyJiq3UVbCAAHYFjLuZBD5t/F3KCfjlE5Zu6kYjt865YFZJKFCrvR924wTwYoEsY5rCmjIn2FnwE/I= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1764753663; c=relaxed/simple; bh=HTeC2gvIuQ1N1KmHBKFS1Iyh8C0QEaXEqL/kokCkCk8=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=OCMypL+TkLQkDWB4M3BIVbDwugx/JFO0jP6LbZ03QwQo8IhMaAFeo2fdhSf26rJSE5ynIqeAut6iWkSg/t4ppXVJmir3XxXCHnj9tljuxZ/3NzaY8BSgEqHO0KzkWoMmuE3Q0v9KtcY5ja1llas5Cg5FexV68Ck/VgAQaQ/cDG0= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E4AE48F8E39 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B391r7j2309273 for ; Wed, 3 Dec 2025 09:21:02 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4as7cp4wjg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 03 Dec 2025 09:21:02 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5B38X9Mj016716 for ; Wed, 3 Dec 2025 09:21:01 GMT Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012019.outbound.protection.outlook.com [40.107.209.19]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4aqq9a7bk6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 03 Dec 2025 09:21:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kzlmBCYOmlYZuhbW+vr4xmY5vwP92VEkcK4Lrf47BGbiOj1WSxb42xs01LAy4UKTZLeaJ8Di4mug7PzBzk+h/NAvphSkweJoLVDbnbwIz+dvQjNehod22ng41pC0N/oj6S1NelyXa0kID8XdYBS5FvmNUldywfy61wi5KH/ZfCj5+W3Bw/Y34qTxvyaN6N3qaxH22wqKj1XboWwZDKsoeSlWy3b63pzwH+LkFpI6OfueViNVNjesPjV5wUbjteQtvHk46L2xKaeOCVkoeNOU4FFJZc5iyyLTDraAIT5eWLpHmcf5J9zSPsTdBa2XYF34fTbENY0TqJ6O64rLrPUa3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lEZeI+3BxHgXOEj89zw+f7X1Z6ciUXzREDU37MvSZkU=; b=Civl0LmLqF97/7BHjh7CIITRmnHWGSE+3pv/l5XSrFtSrFj82QdDkAEpqR1ojMY/f839cowyPNVCqP6VSVPU1yjfEfkpzJCianbVpAfbsWxlk39jzHcY/QCYVYBbaGKHUWfQ0nftNsV+wQP7O+MlfDg6/9cK5AijDIXwSZnMXkvNkLzPAq5nDZniEO75oKN5KMj5jtiqBlAj9wULM3YQIwka914eAw5bP5Gjd/dEWKcv1KA/LJYlXqoXoi2bNs6akeUwEdDFN4evLv4ScXkx4Hffsq4dpJaFOFLu9krHpS/xjQbmYNTnQkMHQRWcfe3mwwAXFkWQZHAncN5tvVjKSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from CY5PR10MB6011.namprd10.prod.outlook.com (2603:10b6:930:28::16) by BLAPR10MB5105.namprd10.prod.outlook.com (2603:10b6:208:325::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Wed, 3 Dec 2025 09:20:59 +0000 Received: from CY5PR10MB6011.namprd10.prod.outlook.com ([fe80::3aca:a3f6:e92f:782e]) by CY5PR10MB6011.namprd10.prod.outlook.com ([fe80::3aca:a3f6:e92f:782e%3]) with mapi id 15.20.9388.003; Wed, 3 Dec 2025 09:20:58 +0000 To: binutils@sourceware.org Cc: jose.marchesi@oracle.com, elena.zannoni@oracle.com, indu.bhagat@oracle.com Subject: [PATCH 1/2] bfd: ld: sframe: skip R_*_NONE relocations from input bfds Date: Wed, 3 Dec 2025 11:20:49 +0200 Message-ID: <20251203092050.6795-2-claudiu.zissulescu-ianculescu@oracle.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203092050.6795-1-claudiu.zissulescu-ianculescu@oracle.com> References: <20251203092050.6795-1-claudiu.zissulescu-ianculescu@oracle.com> X-ClientProxiedBy: VIXP296CA0009.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:2a9::14) To CY5PR10MB6011.namprd10.prod.outlook.com (2603:10b6:930:28::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR10MB6011:EE_|BLAPR10MB5105:EE_ X-MS-Office365-Filtering-Correlation-Id: a03a34bd-2751-4928-795d-08de324d4504 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: 3ekk4SEkUClw8DPU3qk1SLNTTJHEvKNKKP/C6ZCghAlYTTybyWDFC9sK7FzQMlmdnL9uomcsC9z+fgd6LZ0knN3lsgoWDjyXSY3kZGom8UO5tKdsmpXP+MhYvkVpShFqQpzw+ys9QH4IR3pDATxstgcqpjsjJs5z8v3eOXazYxE89ZzDXhxh42WvPjBYCtL9Wh+QQ4MO9/muAsbTAKTZzcxXf8LpEblb3XSzmRPOnbg7lVet+IXxV6NyvMqC7VX26WitybRMYpdJ0BLET/uJF7p+4n5k4QKUlzZLnL8VoObZT15ZSL7UxrXEWuKwlPXPVadDZd/OFPu/hALoKCeMKLm1l5BFtdZp6ZEd+kcchsr0z1oJTMQgYeAQNWbMFD9w2pwFbdCjfrU4ykCxiWRKBL4KzArv0zLc2WwHIJwJYqoS+IqbsR0AbCAo1DiNRgYu8c06jZYd8s9s1Rr1IPunkyUdGECYGTkRFC+9grfaplHbopo9G6ACRD+tfoOyM+XyaJM0d40oWqAUtlDoWm1wDGIXjhx/NftRDtsjT+AuJM6oXWh5bXx89ZrJ6PmAkDaCOc+CJ0fczj5cIfX3IDPMFIdBmK9zTvh/WlNbiiEV7Z3VW7qwNjJ0MFmu/kJCV6dBacV2Xc37zYrWTP3hCLzOIvvV89BU7HJUwx9WwWNaZkcZeNhJYMtRwUtZbyMggFaLESDVIkaQ4tgKx2JylThvgPMboC5RrSNC+K3f/RnPysv56qvw7fB6cdyGABSJjdHAWvN6+HAN3RyQtwErpF2LDa2Zl4JSKW41BFo1N/sT19Jp0D7mQkByYanDgHb0IomCVZ+30t8fXavR+7JR3VFKIjOf0YRb+n2WgVV9rgw+y4FMK7wRs5NQ1Y07jbWllRNb6MADBlKcxLACHLJpeoqt9ttxOY+AT9bOQz4L+wIaV6jKmt8dMZqVyE/YVm0pXDI5R6D7WWb50l/sCXUBX8oRpK8VXRgfXQYbJp0d7IZo+AIp39qhx3jyVttgJAJlCY82Rc3J/Bdt8PNy9rJxRd9DPUkBQ/XI56yw62fohifD4EGmaQXQ8H/IQZFd8OmLyCGdBrMzLnsddCD5i+1wnEYwcqBOc/XQvYTWaNU0SccIDFnC/3yAn8ymwjf7sMmhRAJUPY4YFNbd7ZfcU3zEf0adXvMQWZOa1e/hF2fH8225GteJdjbGaMvVxVuM7U3zzoir5CDpC4XTlcEWmugOYjpIC8c43fmB6SSyqvr0MeIRi8QrRNJbzhGCyq82p03o7Eim1hsxJvMAn5gs+7RQluS06SZmAEtufZfhncq2rp98TeN0MuPNC0enYpMEVf8Dghgp5B/kL4FtR5NBp6u1/UczbevrPoH2DOKPp3SuhI0EkXRSkIb9fV/uaRA8xxXZ8Y1YoDgd8LDAc2jps9lMocAQO+ucS0rPcO4C2KzpkIzCChLbu0VczRj4Vq9+YKatM6RG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR10MB6011.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UtDccZpwIbA5uY4JlCc4Ybc4FZEVwawZ25fVJ6IwNTWUz1bh/D+Ww0pwEjIXZbl7E2iHn9DlBynIowam9/ba8WZWpt6V6T7IFLrPai64CFtgjZWfm4Z7Q8aaSSA+LqHYXqgAs7tJA/igWTQhlBSSdqo9WBDWPcnzsTjDrDJvD3/O0DufF40SrAHGUemMZvJ5FaQzvT5z6MGB566NjwimHvM/eHPXhASKhNy31WVBizlNC3jDBYh/RhQqeoJa9HpRWy6Nia5hdAfiQcbe8ZagAedV5qSKZyFvnm2NIemwM7uOPyJQNpc79cSveyleCPI6zTAuZ7/0u7kutHU57xFEdWwxkZs+oFY5GnGWn0M3BRR+erM5a/9dA323fAdq2udUqejXJUGtHiP080EwmiKzRT+WBSsZdFEM3b1ax64gMlD8xwG1E0vdpU5sg88F046IypoFqg0nnVKIQ66llpbR6smcRBjoK35HOfJikC09oLhIJbNFeFqdS6Py3duqW2epZbYdeIF0tbpDEuFzsySPm2SZMnPNSdCGKWC6HxeYzvpCic+5yy8jwLX1OpuNruoeAVtKXg18SWWq5yqM0dWrI0cg/AdGdWHolJKbzI+Ua+yReZrXICrrfK76TICLvfIH88NgdnwWLDj1jBKdD9zSbaterW7M5hSUVGnkyOblknbbUzp6tM6pLsZ0e+KQHne/NRazvKob8dTYNEHBIE3Zsl4U3LFj40VCkO7i6YkfuRqFJ12Cm9wFTzGH0tRFKIwHO3n4Ai0ERY6Yg8FVOFH7bvuwISIV38S+npphm+cEnQbjSD0qieL3orb5lC13PMfg8LPKXZcpZlgk0a/mXPcRIQdE/AgQmkPNRFcf0MlRV5QdJHdQGCLX2EhEJwdHBj7sh2PvPJEHiTUQhlvV9wtNfm5bN8vHZR6fr8hJb/4qI7Lf1riYHOz7QfuFhgHOdyAJKoDpS7ynpfsXwAb7UJEKqCooMXiAMUak0V6rnVqtLzBxiiIAUviVujYJhNuIsWkcx+8tJFT7uizwCQf8vMGTYqgzLs5k/aX3GuqIo0/J3jmk4w4pq/Vo5bbYebmHBYWMNBtmr5bW1of1hJhnnyi2BwUbqMWMxPVHrpWnnLU5iVKcpAjs1WCzdWIRiOQu+qPgZX+CUOBKiJfyeMDY+uAdZHJfFQ4obJBEzrdojB5H+QSzHMCaQ4earEyRsISyKX2wNB9620cWrVeuRQummy/NksjoDXr6/r5HYrThYaphSBNLN3HxczQ7IEc051x3n5yqGhQi6yBagJJZE7q4xg7hYyWXk/aniPCRA7O5cFWcNvUr93/gjFx+Ec1Dv/q1bVWFqwlRtCAXoVDHJcpZhXiRvuftLH8EH4OB2IgJnHcJXa75kTAS1oWRWpQCGJC3zxR62XFGoteQppEANiBYI0ktd41hirEBXHML1lUCPU+AMw5ugRb7xUWQ+bkp0vVqpSUurYGEbg2sqX61gGtvnmXBBSrnqH6s1LGMxCPb0pp7SA5Kv4hrAiR8LEJxCHfbYMBSxbAoO0jx1beYI3WAgcNRWdTX9p7d2WHv7t5dP1wcVnNvb/UIHaoFP/gbmCdie8I0J9KGBGTiFwYcSI1rCcc8eEHJjqWq++j9g8yeS19eu7dDFjUsS1eRmVzRyukeSD+S X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fwIQqLHsHHKQTN6lXsy+BzKhurGU6gmPUxW+1cJ8dN+0lZAPTS8hwbINwFf5llyu+D2yveFLj/sAd2k9lelXpnyR2/6kM9VYWVcRqlPQMFIbzO+GGYEX8PLfw5v8zpLvHpPweYR7FWjgvf2j94EQKsvDdmQ8+Hohx93VcY9WZj94TkO0lzXV9x+HPXtbrTicPOrEXSwuuOeDQdybsnUjHTZk9RcilHt64Rn8492BuUtpEOsZq3sBhh0QlOUy7ss8RYfZE2pSsnivaAX9UlFpb0MuR5mw1fzimqtoGzJOR4rrAMwZsaSAMEuqYpNqQMOYRCn2tfeX0alDDYEqSrM6YIf8BaX1NWaxioF3F+TIVYPT62KsRhHym7HPX85nuK1eiTCahvt2Q5nU54+SbAYEqzcvv6IbgfL32AL4eEA+fnk1/0Z7MhPpqsfk8e/IawyOzGtOYrCX2TfvwjbsmVWYh3v2kbHb7+QUlxwJmXNnV94sn9nWk+j0wG/ynnUmV67r8jBDPzmHnyZWQm9w8IWsFN12e7xo6cDxEnAsE0uws5J2UQa4AWsWbAATrhDPZv74w/rhqXkqMSBYE+EcmAMIFP2gdJ/zb1YbM8j6j8dMBQU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a03a34bd-2751-4928-795d-08de324d4504 X-MS-Exchange-CrossTenant-AuthSource: CY5PR10MB6011.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2025 09:20:58.6161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QYqwRAPnf9duZSpuKR8ScFiuF8B5oNNbSpOKw2FbUG/Zv5fK5i7o3tYSgEBnfGe/keiOOuoJ7cBzHboIf2JR5Wzn653YhtE0B74do+Sfm1qF5+yBUliGzXlSv+1bK/uKPHz0JXzWmJOEIjmIK4GZdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5105 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2512030073 X-Authority-Analysis: v=2.4 cv=ZfgQ98VA c=1 sm=1 tr=0 ts=693000fe cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=wP3pNCr1ah4A:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=DHE891H7Gske2VlohvUA:9 X-Proofpoint-ORIG-GUID: l6eBMq2JGAhnTa8G_BItKPv7uinVSBLT X-Proofpoint-GUID: l6eBMq2JGAhnTa8G_BItKPv7uinVSBLT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA3MyBTYWx0ZWRfX/dZoGokf48oL J7kNUKTSlQXeUKsWKjdkiQjBKnezNTnkIKYWyg34nGF/i9qaBoNVil4UpsmV3RUrNib/KlrQ+5Z JSmMpwHevcIuS2+9wDDYfH0cVDjBqCLLVU7wfFHRymTXmgrZoSnNyGGk0YpZhPuPArJqXQy0eHq i81LCjzjSoiZanmofz+2YOC41PEBhIpV6bT6U1g1nHdktzen+adg00ZEtpSaCGm+RIZwHUEqwqt ZQm5nWLNK0WbR+YPfyoZDjRD4n8tznpudOzzqGV0RcR6nYhWzr+Qu6+3gga1/bfUuDiiRIQpDkF cpfMa7qPeR6BnLlk5GUdlrpBW8cj0MmCnW9qsKOFLfxFEl9bWC6tkTckvxESuZJOp6+l5WcqLEH E9MUlNgin2KgI3wDF5kpen6+/tSn2Q== X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "claudiu.zissulescu-ianculescu--- via Binutils" From: "claudiu.zissulescu-ianculescu--- via Binutils" Reply-To: claudiu.zissulescu-ianculescu@oracle.com Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org From: Indu Bhagat Fix PR ld/33401 - SFrame assertion when linking gav-0.9.1 As the issue demonstrates, R_*_NONE relocations are not necessarily at the end of .sframe section (previously thought so with PR ld/33127). Skip over R_*_NONE relocs when they are strewn intermittently inside the .rela.sframe section. bfd/ PR ld/33401 * elf-sframe.c (sframe_decoder_init_func_bfdinfo): Skip over R_*_NONE relocations. --- bfd/elf-sframe.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/bfd/elf-sframe.c b/bfd/elf-sframe.c index 8e4cfdd73d3..80043550777 100644 --- a/bfd/elf-sframe.c +++ b/bfd/elf-sframe.c @@ -121,13 +121,24 @@ sframe_decoder_init_func_bfdinfo (bfd *abfd, return true; rel = cookie->rels; + unsigned int reloc_index = 0; for (i = 0; i < fde_count; i++) { /* Bookkeep the relocation offset and relocation index of each function - for later use. */ + for later use. There may be some R_*_NONE relocations intermingled + (see PR ld/33401). Skip over those. */ + while (rel->r_info == 0) + { + reloc_index++; + rel++; + } + + BFD_ASSERT (reloc_index < sec->reloc_count); + sframe_decoder_set_func_r_offset (sfd_info, i, rel->r_offset); - sframe_decoder_set_func_reloc_index (sfd_info, i, i); + sframe_decoder_set_func_reloc_index (sfd_info, i, reloc_index); + reloc_index++; rel++; } From patchwork Wed Dec 3 09:20:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "claudiu.zissulescu-ianculescu--- via Binutils" X-Patchwork-Id: 125822 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 21D9A48F60C7 for ; Wed, 3 Dec 2025 09:21:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21D9A48F60C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1764753715; bh=D6Q3p9FVAjnGmV1d0SLO20O/7QtYSY0gwwq2OZWL4yw=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=c0QVqxju81jKcBFZenXlfeHwrSpq1Bov8hssVmUaB8bBjmSJ7Zx+udyu9JzI+FncK QFeTj1t2w51w2P0mx/vQCW77WHYHNGIvgxG4BkzTiozgqIw6+qPGGWj6NMfFDpEHAx yhCI0kQUqDGvtATESUsgq2kHGmJC08YiEwGGEEFA= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id EFC3648F66B3 for ; Wed, 3 Dec 2025 09:21:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EFC3648F66B3 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EFC3648F66B3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1764753668; cv=pass; b=WWHxEb9FxI/xknvPc+KlgW0u9v3z0zmExnkMaD5vqCNmTovR/TpnRsqwIM3nmNn/+iD59EBP/P1Z6tC2f+mzJnddfBYf+N2rvvD7HlQZ0hzkTlA6kHhuE6HOaEsbnt9SyRRyQXGjMIW5NVkDkAuHSnZYiLKyxH7d4jQT807LiPY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1764753668; c=relaxed/simple; bh=npHOgANHRnPG8BYroD3Q46pXqZ3g0HNa+NvBEosdbZ8=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=Eu8ovJsu9MSOW+RYcLpukhC4UyLdiPtOMHCOf1sEQVDCAOwfBHtzI4PiGJAkxykA16k1Pjx8OTid8pbnEijw7SRcAcFw2w2Yi8SJqbNEPU7W8aXlrLU3SGrAptnXfb6cISx14C4jZznI8QeQekfrAaJqJ+dm1IxOVoXSGdW5h9k= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFC3648F66B3 Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B391sbi2388312 for ; Wed, 3 Dec 2025 09:21:06 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4as6v3cxw2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 03 Dec 2025 09:21:06 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5B389eGZ035401 for ; Wed, 3 Dec 2025 09:21:05 GMT Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11010053.outbound.protection.outlook.com [52.101.193.53]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4aqq9mfsvy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 03 Dec 2025 09:21:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NUP4EYk6OnnEzByzNqwX0BLLwvlHATKoIysOjAB68nzzkwq+M/8TfqSxpGK2N/v1YH/HdlVyVjp3XvqvsQIF/+rGJH9ncSJgN2utu6utvayptXo+AdnkmrTIQYG9vIijNhDq7u0Kzm/UjDwqPPH90iqegEJXb0Kr2IrWU+ou98OLrlveNNexTroERgywfCN54dZhwxJvGWfE2dOCb6a1TiCxvRURDhnwQQX8rxbOG2N0t5HeW5TCjxAkgEL7qIk1LNYnqU1fg7of1dv48EDYmkqUBtIpV8DKkppHAV/llnZQJzeBxCGP02sRl15QTsJb3S8cXwMz1TSyo7TkAT92gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D6Q3p9FVAjnGmV1d0SLO20O/7QtYSY0gwwq2OZWL4yw=; b=vTmsIDosuQv1u8mifVIM8jp4i+oLZdBA+v4YScdn/ug6JCT3x1XLbwwKlw4f85ys+TBjS0Whzy5inxRx7pfg0tDyk20wvO5e3uIwqIx8usAgFPSRG112vnXZZT1g/9gND3eYjthJN5LUppwXlgenPul9v4OpZ/X6wxldY4TTm+EkI6uMGSYVJpvLTcy7WWOM5r2MaYDzMTWw/QdT9mb91t2zGQ0O7dD/4JWU19KJJodNeTX66H2QCO2/9cfGRoWWasPQeQLJ+qKhLkuKo7swywuLcoA9DHxCRMN4gGeQzYyN7NtATBqTpWGuP2sOUKKTX4AAo8ZCx3QU9yGujE8H5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from CY5PR10MB6011.namprd10.prod.outlook.com (2603:10b6:930:28::16) by BLAPR10MB5105.namprd10.prod.outlook.com (2603:10b6:208:325::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Wed, 3 Dec 2025 09:21:03 +0000 Received: from CY5PR10MB6011.namprd10.prod.outlook.com ([fe80::3aca:a3f6:e92f:782e]) by CY5PR10MB6011.namprd10.prod.outlook.com ([fe80::3aca:a3f6:e92f:782e%3]) with mapi id 15.20.9388.003; Wed, 3 Dec 2025 09:21:03 +0000 To: binutils@sourceware.org Cc: jose.marchesi@oracle.com, elena.zannoni@oracle.com, indu.bhagat@oracle.com Subject: [PATCH 2/2] ld: testsuite: Add sframe test for PR 33401 Date: Wed, 3 Dec 2025 11:20:50 +0200 Message-ID: <20251203092050.6795-3-claudiu.zissulescu-ianculescu@oracle.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203092050.6795-1-claudiu.zissulescu-ianculescu@oracle.com> References: <20251203092050.6795-1-claudiu.zissulescu-ianculescu@oracle.com> X-ClientProxiedBy: VIXP296CA0005.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:2a9::9) To CY5PR10MB6011.namprd10.prod.outlook.com (2603:10b6:930:28::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR10MB6011:EE_|BLAPR10MB5105:EE_ X-MS-Office365-Filtering-Correlation-Id: 27093572-53d7-4690-129e-08de324d47a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: tpZ+Dvr+tV7IFkfDmTKShWN/BbWc9bUtufsDsAAIdYl/4lY7MvhlTmWld7H/vaJVUA9OehMylr212WNnIYANHQ79KENX1pWlynOp3XQPq+mxqZVieTKGR6BgjyW8AGNtaT1gIS95HB7rhowdzOl6X7S9kbH6x4Z5oQZBRcz4r9btG05NSH8Se6imaCq6HUznaMRF28f4AP8rPehqh0h3IuZ63LFX1i1KDHapIcrvJNY/CwkJ/JF3vLY6q7orYG1PWYOUZgrWxyZbdjcg4XNL2jHFY/2+hcJicnvflX0Wc2YGQWDmqGFG7L/8yC3MuWohqQnZbpbA2gygbLBNLhNnYMCETRC++StJ7pvvG0eNn7YiZHeTJ8KzyTNviFiIf4tqfq/gOOopxSAuHWoomFhE9vX7FwDR1YNtWUQoOxLxE3JWBkYIaZfjMXk1GspYTLYEU/Ea43Dt6qLdawxvaCOmphncwVVHyCo4p9N+ScfdXMIPAP95GFy3rkNiDGxQP0O7hASoxHCpdvaHgF3o83OYYMVWh4nHeUlzZz7jWPMOSRiJXcYawJ6SYKUDoBWq0RUYyzbKrvimeYHBtH6E8o7cm/Owq3HlKnO6Ps816AB+lW9RtYIEsrDX4hTY98NrQYVX+ew+78CQjjF6ellyFyGzemdDejnpon0kCSgttNtXcisAYSqzbBHs5ggJMUBcPhDXu+3F6ehdUTlCvrDiz2gTj4bUqarQQM54JDUKjBqVpM83ZfRZiy3S1af6+m+9VjuGG+R+VuKzIqr6I6wn4SlOd9tPLmwXSj8mXUBQHi/m0w58Zrnzc+mv+aCJNsBzgr/oq0aw75s+D/x9KLrzsrdWxbcZujLjMGwvfgGCexG9bdcysALoiQKFfXr0iI7a9pXmb2W/08ckML/IRxQwk+SXHBQDwzmCN9VG3gizxJnTeLjP0zSycs2nurRCnrkQtdHkHrOeO2/fFq/Z9k30PHoEvWZ1hus/sxCBReM2vF5ripYTkd5XCuNISmkhzvz9+H8ZChWZ8FZkrJsQiBOIWAwzu8VHe8y/PjoBZ3307X1rdD4b0pxtPDax5sf3hD5pP7bO2gKEpo2Ag9JGu1s3WiMjv5sxnBFSn79Dj00tFhdQy1QEKUEwOWTOO7EYye4FhdZvHrhEj1GhDjdVdiga7P9YHzbZK8XTAJoixPQxJB60Zr1YLEM3GmfbWpO3FDbZa/T1UBR3U8J1rd1jwm8Hf4R0S/1HENnXLgtFYTEbXQ0H4IeZb2hSLIeCcq9E/Zkc5BD9s9DFc2jCe8eXDr0ev5tRqEVUMqHdJLpWBYhCOOHBw1Z/IdNCf0mRUwUtpc4m2WECcV40Rs7grtKy94fmFeJwElL2+qnDtJcsbu03GtpBSF8ydXJPdnCP5uWlG5LU5QkEC0nl9umy6KtEIsVB7rG8nWElJ078iNfw2/RyXWYQvoSKvhGFyZl9UdtLf3aNQJPQPbdXg4v2HYlYab4r1G5NJw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR10MB6011.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0pbb2Bg/+3BoHV6nV5tMphga5AYoBxnguvM0piZrrAk6zypT/B23AJLfbHcKCLnKAPfPefLLvNJ4OjKF3U1aN528Ot/TWMPr013EDPRW5O50n8jPC/Evr3ArUKdX+R4OrE9HQ6b8+YlL8TPEo1b+PEAhoC7Z7WmvWPpsj5aGMEzKhSkE0Mo6L8F6FKXI3z5fjTel95utMJX0QBLGp2UfqTECA5SswHNn2EI9UEtscMfV3wNwVkAFvzpl60NVOrfxBnZYsnsHpqMCrKF/I6WVvDaK99eXT03400dOkmJorl3FI5ddBV3T71HXiB6C702KXos9Yuxyu9OR8Ktf29wVOPBMOfI4Htsq2eLAKeKDXSvTn1qQkLIF4LUsleiiQ5XXLsrOd5wyyk+pCUb8IdEm0KNrZk2fyrRL5pPMj3nNSLaNBYIqbTCbl7rRrgexZWtxEhRzPR7g3G8McLvieHS5ElGXNq4wWQbYp8o2B+qZxmFrALxc+2MAGZY1eHp/GfwrMgjc0Z+lnIj00Qo5iOjTJJ+4846q2uBeU2q1BMPMkLZza5uYIFBml9DhVGi9B5ZBclfJ33ACWAPVQkySxIHhC843Um6upw8z+Ta2bA4GCKokC12EZLfTD2LaODigUjy/VIBkJ09PjUVYtlPyIVYybRgtKPKwzco70sxnMkNhQ5YHtdoIKs1DN5VXG9Z5WIWmaVR1xBfJe4vhTjKH3BQyf/I3hjbuucAX0q2bqI7q39n4sjcrwYNgpNhye8AGX5z36B22G7ZHdicFRsVhjwh8SumPvMwjoWdDSIsvhEoNzpk/9v8SDwP55+PZBnXOZ+Q19RrNEigFHFhwr82jdV8hbqcAetN3jkJKJHQk7wl5U6GM6yiTMMjrRDnzuMt8Hv/8sTCMoYPEoxG+LcH49v906OaeKz8Fa1xvTprBEq5NYkacMuSCmbh+clvZ0PkxLskJdSAKM82C3DpNpmNmmHQAUMEGXma7zSNuL4MGbzn/bzs+0c6cITFNaxVS82L/1Bx4bo56eowNFMd447nh7/v4PM0BdP032U5Eh5TeeeWowMCX7aPjNFeVkBwJQ9c34i9yLP0KGBX27uVbNSi6mPHc+lkNqnhk9OL+wLHiPEQVBfAzXk9R051dh90u5AozqTcADeBmtN93NPzAUWwNLcT8014rgkSs3ldUFi+SuQqpTQCCXLaf+Q7l8sCFys3LIA5yeVOHsATA8OEeLNK0k4qGageCNRJEO+c+zaqZ+artLJ1exZAo4eAiIUeb9f+37ZnTYEgH6T54HMqo9ptqa9MLsK9n/uaVVgo23jjAbmj8KJgpThJZ5r3DMpz7539uPAA4OVMQwjqBwfd9GvkPYaaMAP13TLfd7OZMRlMx/yKkDDZPweqNRexaX0chyiThsKi+daomSJCpl0oMxNwpe//CHrLsjXmJqPbkR88IvndE2ePtaoNLHOj+pRFBMruYOkQoXWvSFN0KpYsqqY0OD0zEk68Gi88SKoVgbtINxXuO5hJu4jouTBKlitExRJ9XbnAE7qRBbrfT17iHhfFo9v+NEAFd0MKCrOWyb7mw8dQ6Smk70MxLceBbc34Nl05+u8Y3oQFcgMO78zMJ6SBgqlAREQqdD8cf2E8DImUL7NTKuLAgpgiv0bZQwvx8enb2Xlb8 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: RBoCnwiWALPWyIgQx/cDxuTfpV3JbjLrzaex+4+7aLfnzP4UuI5OgFTBiAgPCvzwps4e/hzv+ufXi2P5jBxRXhXM3hNH6kq6I5Kem6oteQhdbkS58adKhxxn+I9AeBRGcow7jRBNZS+PRqmutE04RAAQXbn4lH9/WEqtWPWFcQaSjvQCwap/n47JpPfJmhVUVf8sKFstpKI3QenItIpgWZ0d9ImZJDCJwN37ksleyA1lTJ+hgooyIUMW0bDcTlTeDpEB9CvPUyqSa4dPuR6t8OqZXyk7fwcg/6oO1CiHNoy2LU7BxQXf3mop9NyAmte5hbj+zvHzpwMWMlEgkI3Ev9UbG8DSf2x1aIlQkZeyrjLGqfgyjsH9oMlF8TGOaM05wfEs+cM0n27skthVL56jNPQEd7P/q64dQeZ3u5SM9LDBnakRRTgwqMiwn6ECjaeAs4zewsTmrFVp6cw2186Ypg41EwE/Rf8Q4nPqE8IYYajzXwb1mNuTpsRLwv5/hkwoLv3lam5oBptbq6VPyZvnplHfjTszbdgjVPvcs/U085WwUYRbHxtRyW9CTJ1fMlGVy7JkEAWS0EWvuluY4sqE49Ni2J83CI6LrJoGJvNMtW8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27093572-53d7-4690-129e-08de324d47a3 X-MS-Exchange-CrossTenant-AuthSource: CY5PR10MB6011.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2025 09:21:03.0988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0ykUK36FVsNXrgx/bPjkOMdx/OPgfDqw2uvOWxD4BxTocVFg60+UJEF5LDVDC7ymyz4AE5VxqchT8biXypZwnowslkTSVwogrujWjk7hS3VMP3Bl04ZjAgn1XXTkIVgcF21FyywX57sPlwfQXAAc0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5105 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2512030073 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA3MyBTYWx0ZWRfXwVTP4nqFrimK NU8/YsRMU4OqllNWizkXl8EN5dnkSuPBjF2JdtgDqIp0WpPA3QAR3OUJ6Y+YR5vXRdOxsW/IJoF 4r/DA2zTlJst3sZ+TQ5rGSEll6qanp39PvZBjU3be/MHlfkb+h4CX4JkZY/1Djc3PtWJgi136k5 PonFtkcEsP6uwiqZymQVH0PQyxKAo7S2Z/pnBtma/uRaO8xYm+bALK8OBf/GVxcEzrG8AQkb4+u WbW/rH7dKsX1rJOAi60YIrHqB88h5riDM+napRTGhCg31JV0om+dQv+dni29Aw/0SpyRfU45CW9 A0leBkgoYx7Jupx28/o0SP8SHfnrShgbS7nb7v7Fci+2ZfkgllO1qsPE6CdJ/Ym0+aTN1Cl9Djv MUzR7yhJRE25taQi8o1d1lCGEsgbx4S9Jxcaryz/IdgsPEZvFCQ= X-Authority-Analysis: v=2.4 cv=fqjRpV4f c=1 sm=1 tr=0 ts=69300102 b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=wP3pNCr1ah4A:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22 a=CCpqsmhAAAAA:8 a=yPCof4ZbAAAA:8 a=RlDa5q1iiidd5xcwwFIA:9 a=ul9cdbp4aOFLsgKbc677:22 cc=ntf awl=host:13642 X-Proofpoint-GUID: szHkzi_AWy4ICsmig1_uRquIhavV3wdx X-Proofpoint-ORIG-GUID: szHkzi_AWy4ICsmig1_uRquIhavV3wdx X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_NONE, TXREP, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "claudiu.zissulescu-ianculescu--- via Binutils" From: "claudiu.zissulescu-ianculescu--- via Binutils" Reply-To: claudiu.zissulescu-ianculescu@oracle.com Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org From: Claudiu Zissulescu When linking for a relocable output file (-r), one or more R_*_NONE relocations may be generated for .sframe section. Two new tcl procedures are added to sframe.exp file. 'check-dump' is checking if an input bin file has the same relocation as specified in the second input argument. 'check_pr33401' is the main checking function for PR33401 which calls twice the ld tool to produce an relocable output file. ld: PR ld/33401 * testsuite/ld-sframe/StateClient.cpp: New file. * testsuite/ld-sframe/StatePlaying.cpp: Likewise. * testsuite/ld-sframe/pr33401.rd: Likewise. * testsuite/ld-sframe/sframe.exp (check_dump): New procedure. (check_pr33401): Likewise. --- ld/testsuite/ld-sframe/StateClient.cpp | 26 ++++++ ld/testsuite/ld-sframe/StatePlaying.cpp | 41 +++++++++ ld/testsuite/ld-sframe/pr33401.rd | 3 + ld/testsuite/ld-sframe/sframe.exp | 114 ++++++++++++++++++++++++ 4 files changed, 184 insertions(+) create mode 100644 ld/testsuite/ld-sframe/StateClient.cpp create mode 100644 ld/testsuite/ld-sframe/StatePlaying.cpp create mode 100644 ld/testsuite/ld-sframe/pr33401.rd diff --git a/ld/testsuite/ld-sframe/StateClient.cpp b/ld/testsuite/ld-sframe/StateClient.cpp new file mode 100644 index 00000000000..0154469ce6c --- /dev/null +++ b/ld/testsuite/ld-sframe/StateClient.cpp @@ -0,0 +1,26 @@ +void a(void *); +class b { + long ag; + bool c(); + void m_fn2() { + if (c()) + d(ag); + } + void d(long); + +public: + ~b() { m_fn2(); } +}; +class Player { + int *an; + b ao; + char be; + +public: + virtual ~Player() { + a(&be); + a(&be); + a(&be); + delete an; + } +} e; diff --git a/ld/testsuite/ld-sframe/StatePlaying.cpp b/ld/testsuite/ld-sframe/StatePlaying.cpp new file mode 100644 index 00000000000..f61c32d54c1 --- /dev/null +++ b/ld/testsuite/ld-sframe/StatePlaying.cpp @@ -0,0 +1,41 @@ +void b(void *); +class c { +public: + long am; + bool d(); + void e() { + if (d()) + f(am); + } + void f(long); + ~c() { e(); } +}; +class g { +public: + virtual ~g(); +}; +class Player { + int *bh; + c bi; + char bj; + +public: + virtual ~Player() { + b(&bj); + b(&bj); + b(&bj); + delete bh; + } +}; +class h { +public: + ~h() { + Player *a[0]; + delete a[0]; + } +}; +class i : g { + h bo; + virtual int j(); +}; +int i::j() {} diff --git a/ld/testsuite/ld-sframe/pr33401.rd b/ld/testsuite/ld-sframe/pr33401.rd new file mode 100644 index 00000000000..00142818b34 --- /dev/null +++ b/ld/testsuite/ld-sframe/pr33401.rd @@ -0,0 +1,3 @@ +#... +[0-9a-f]+ +0+ +R_.*_NONE +.* +#pass \ No newline at end of file diff --git a/ld/testsuite/ld-sframe/sframe.exp b/ld/testsuite/ld-sframe/sframe.exp index 61dc4dafa2e..42faeafca5f 100644 --- a/ld/testsuite/ld-sframe/sframe.exp +++ b/ld/testsuite/ld-sframe/sframe.exp @@ -18,6 +18,118 @@ # MA 02110-1301, USA. # +proc check_dump { binfile dumpfile } { + global srcdir + global READELF + global subdir + global env + global runtests + + set binary $READELF + set progopts "-j .rela.sframe" + set failed 0 + + # Ensure consistent sorting of symbols + if {[info exists env(LC_ALL)]} { + set old_lc_all $env(LC_ALL) + } + set env(LC_ALL) "C" + set cmd "$binary $progopts $binfile > dump.out" + send_log "$cmd\n" + catch "exec $cmd" comp_output + if {[info exists old_lc_all]} { + set env(LC_ALL) $old_lc_all + } else { + unset env(LC_ALL) + } + set comp_output [prune_warnings $comp_output] + if ![string match "" $comp_output] then { + send_log "$comp_output\n" + return 1 + } + + if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then { + verbose -log "output is [file_contents "dump.out"]" 2 + return 1 + } + return 0 +} + +# Test infrastructure for bug 33401 +# https://sourceware.org/bugzilla/show_bug.cgi?id=33401 +# Sframe section contains R_*_NONE relocations intermingled with other +# relas in the output relocatable object. +# +# src_files filenames of assembler files +proc check_pr33401 { src_files } { + global ld + global CXX_FOR_TARGET + global as + global LDFLAGS + global srcdir + global subdir + global env + global runtests + + set objfiles {} + set testname "PR33401" + set failed 0 + set linkfile "tmpdir/automa_module.o" + + if ![runtest_file_p $runtests $testname] then { + return 0 + } + + # Assemble each file in the test. + foreach src_file $src_files { + set fileroot "[file rootname [file tail $src_file]]" + set objfile "tmpdir/$fileroot.o" + + if { [file extension $src_file] == ".cpp" } { + set as_file "tmpdir/$fileroot.s" + if ![ld_compile "$CXX_FOR_TARGET -S -O2 -w" $srcdir/$subdir/$src_file $as_file] { + set failed 1 + break + } + } else { + set as_file "$srcdir/$subdir/$src_file" + } + if { ![ld_assemble $as "--gsframe $as_file" $objfile] } { + set failed 1 + break + } + lappend objfiles $objfile + } + + # Catch assembler errors. + if { $failed } { + verbose -log "Error during assembling one if the input files." + unresolved $testname + return 0 + } + + # Do the first linking. If this fails, we cannot resolve the test. + if { ![ld_link $ld $linkfile "-L$srcdir/$subdir -r $objfiles"] } { + verbose -log "Error during linking assembled objects." + unresolved $testname + return 0 + } + + # Check the output of the first ld invocation + if { [check_dump $linkfile pr33401.rd] } { + verbose -log "No R_*_NONE in .rela.sframe" + unresolved $testname + return 0 + } + + # Check if the second ld -r invocation is ok + if { ![ld_link $ld /dev/null "-L$srcdir/$subdir -r $linkfile"] } { + fail $testname + } else { + pass $testname + } +} + if [skip_sframe_tests] { unsupported "no SFrame format support in the assembler, or SFrame disabled" return 0 @@ -40,6 +152,8 @@ foreach sframe_test $sframe_test_list { run_dump_test [file rootname $sframe_test] } +check_pr33401 {StateClient.cpp StatePlaying.cpp} + if {[info exists old_lc_all]} { set env(LC_ALL) $old_lc_all } else {