From patchwork Tue Sep 16 15:19:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 120364 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32C473857348 for ; Tue, 16 Sep 2025 15:28:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32C473857348 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=e3Kd0TSm X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B0E663858D39 for ; Tue, 16 Sep 2025 15:19:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0E663858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B0E663858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758035969; cv=none; b=BHOAX+bbk9doVgINULJzRpx70A/Nm/sDA5CR1lzw2n0bX+uO06bHaj3bIsvYk7ni54JEGQw4/g8iLiL+twGyC0TSco545ZxQNUefcCEztRmHrM8qgnBqM3f6djEugZP0hEdq2M1Il11/DCu6/l8xiOmB0g5nUZRr4SdlBXmoZWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758035969; c=relaxed/simple; bh=t2PMXfdf0dADLtFUXdZEfsWcqOfGLKKsjTnsil4vU0s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cVzvli/1c5AvtWMioNtu6FlEZL/pv6ru0+7Vo/EmzU/z0yySQ90vQXRqHVDEre/c6qs/kxF4z+iXU9ANUlKPd1wGA333a70r8RFFOP2ikIqh5+g3UYWVmBTeYSFZ7WYujCkFMahALPFNkzGzJN9HdE7tmLFVxHES1dDl4tfpR64= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0E663858D39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758035969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6EMZGC7585aSC/7ZSI9CdpD5J9WGoAjzRCju4/UqC74=; b=e3Kd0TSmwc1eidxndCjXjxg/anSs5gEB1MtQXMKeDmrMwmvK5JM0waZIQRCes0dZw1k3+w JvIGSeQSVOWVJsOhGs2YmoZtD3+OCVBIueJmXnogJjuWk/LxDBljZmf/jTq1jbU38Pq5eR 0MHsas/MGE9UHSTk1QaFICX1gVYuy34= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-22p8Kkv0OiGH1q_aRDqxhw-1; Tue, 16 Sep 2025 11:19:27 -0400 X-MC-Unique: 22p8Kkv0OiGH1q_aRDqxhw-1 X-Mimecast-MFC-AGG-ID: 22p8Kkv0OiGH1q_aRDqxhw_1758035966 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 916C0195607A; Tue, 16 Sep 2025 15:19:26 +0000 (UTC) Received: from zen.kayari.org (unknown [10.42.28.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 81F21180035E; Tue, 16 Sep 2025 15:19:25 +0000 (UTC) From: Jonathan Wakely To: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: [PATCH] libstdc++: ranges::rotate should use ranges::iter_move [PR121913] Date: Tue, 16 Sep 2025 16:19:12 +0100 Message-ID: <20250916151923.2680823-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zhMaJoonMPlQC14pmikhVUKapln-5W4_0o0_GWKyhuE_1758035966 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_W, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org The r16-3835-g7801236069a95c change to use ranges::iter_move should also have used iter_value_t<_Iter> to ensure we get an object of the value type, not a proxy reference. libstdc++-v3/ChangeLog: PR libstdc++/121913 * include/bits/ranges_algo.h (__rotate_fn::operator()): Use auto_value_t<_Iter> instead of deduced type. --- Tested powerpc64le-linux. libstdc++-v3/include/bits/ranges_algo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/include/bits/ranges_algo.h b/libstdc++-v3/include/bits/ranges_algo.h index ea933be2f604..4025bba9f204 100644 --- a/libstdc++-v3/include/bits/ranges_algo.h +++ b/libstdc++-v3/include/bits/ranges_algo.h @@ -1685,7 +1685,7 @@ namespace ranges { auto __mid = ranges::next(__p, __n - 1); auto __end = ranges::next(__mid); - auto __t = ranges::iter_move(__p); + iter_value_t<_Iter> __t(ranges::iter_move(__p)); ranges::move(ranges::next(__p), __end, __p); *__mid = std::move(__t); return {std::move(__ret), std::move(__lasti)}; @@ -1713,7 +1713,7 @@ namespace ranges { auto __mid = ranges::next(__p, __n - 1); auto __end = ranges::next(__mid); - auto __t = ranges::iter_move(__mid); + iter_value_t<_Iter> __t(ranges::iter_move(__mid)); ranges::move_backward(__p, __mid, __end); *__p = std::move(__t); return {std::move(__ret), std::move(__lasti)};