From patchwork Thu Aug 21 12:09:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 118703 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6BED13854829 for ; Thu, 21 Aug 2025 12:09:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BED13854829 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A3mw9Pg3 X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B2ADE3856260 for ; Thu, 21 Aug 2025 12:09:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2ADE3856260 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2ADE3856260 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755778151; cv=none; b=nCVDj5oTPGqQ94vy+PC416Zuv4ywZDRGpo6Lgk+x+PzOlcDVCMmtZqxxlgvN2+M7Er90kRY1MfQadTXw6AXyfGr8WONp0mzj6Nz78iRE923VqKEL5Y/paPwJrjnEZ00UMa71oIu9C9UN/QvCRz4jiEEKtwID+AiQJF2RYIZ/1lM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755778151; c=relaxed/simple; bh=R4fENsVJwcDxwra+O+ad/BRt5E0Jg+Jmz8yxDwtNulY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HHHVOQT1ysyTB01Nx24usWNj4+uL3huzYuHZOUbFOxBN5VhWT8piWhGtRd5I2kuZBF6MXMeTdBdjmbWlJv0mo3ULeXqddcvIUjL0iFOI02a17vfpXhd7768dhrBw0BpanukAbbe8nLsbJTKLqM1jppi1ms3TKU2hYxVWW8FvVuI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2ADE3856260 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755778151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=2mE97HXXGKt2WwtSrcM4BP8259poZHl25elTtep8XVs=; b=A3mw9Pg3TvdpVTdXmvT+IDRkSBCdahD69khlA1KY6PqADTrezQNExRbbW0U30MxMDbXvyS YkTSCarDvkXukANZDZkWgl303ihszhrf6HggsROlQ7hwhyyyu2G3r7jGcIMTZXrPSwHX6W XIiY2RZF5AlxZ/aikHk6heCamd4S9AQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-Mp1N7iX6OQWoWqdJZWcC2w-1; Thu, 21 Aug 2025 08:09:10 -0400 X-MC-Unique: Mp1N7iX6OQWoWqdJZWcC2w-1 X-Mimecast-MFC-AGG-ID: Mp1N7iX6OQWoWqdJZWcC2w_1755778149 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 84EAB1800451 for ; Thu, 21 Aug 2025 12:09:09 +0000 (UTC) Received: from localhost (unknown [10.44.22.16]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3A1DE1955F24 for ; Thu, 21 Aug 2025 12:09:09 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id B752BC1B73C8; Thu, 21 Aug 2025 14:09:06 +0200 (CEST) From: Dodji Seketeli To: libabigail@sourceware.org Subject: [PATCH, applied] ir: Avoid crashing canonicalizing anonymous types with member fns Organization: Red Hat / France X-Operating-System: AlmaLinux 9.6 X-URL: http://www.redhat.com Date: Thu, 21 Aug 2025 14:09:06 +0200 Message-ID: <87sehkvpul.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Wk3RiP_50w1sI6LF3HCpcDh9-ThS2xmsR6h3wEoVRHQ_1755778149 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libabigail-bounces~patchwork=sourceware.org@sourceware.org Hello, * src/abg-ir.cc (maybe_adjust_canonical_type): Don't bother detecting discrepancies between member functions of the canonicalized class and member functions of the canonical class for anonymous classes. Signed-off-by: Dodji Seketeli Applied to the mainline. --- src/abg-ir.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/abg-ir.cc b/src/abg-ir.cc index de0703ec..18676e5b 100644 --- a/src/abg-ir.cc +++ b/src/abg-ir.cc @@ -16133,7 +16133,8 @@ maybe_adjust_canonical_type(const type_base_sptr& canonical, m->set_symbol(s1); } else - if (canonical_class->get_corpus() + if (!is_anonymous_type(cl) + && canonical_class->get_corpus() && cl->get_corpus() && (cl->get_corpus() == canonical_class->get_corpus())) // There is a member function defined and publicly