From patchwork Thu Nov 18 15:48:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 47890 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4C5DE385843E for ; Thu, 18 Nov 2021 15:52:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C5DE385843E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1637250755; bh=/doE3TGK7uI90fNNVcdCnSvz32SKZNl8Fc20uQ4chRo=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YwsyAD/vRQwpzPmXuvY+Zc5lx6L3Iq4Z0cyAxF2tfFOFWhhahLXEiwlrTB4tdDKZM S0oJP0+wA5NQK40o6zqEnmzsYOk7+hjye8hyNj/CdgTKGotR5Wog1clCT2JnpQxrpG RZVYYti5YlWTGmfmVwUZSODYQWNJ7M/pExRIuYRc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id 42288385DC00 for ; Thu, 18 Nov 2021 15:49:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42288385DC00 Received: by mail-pj1-x1036.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so6103508pjb.1 for ; Thu, 18 Nov 2021 07:49:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:from:subject; bh=/doE3TGK7uI90fNNVcdCnSvz32SKZNl8Fc20uQ4chRo=; b=iDl2U77XzI+45/3PA6Snfv/gyJyczXzmiNknUcJvPg3keaR6tRI1N1v5kyvq7jWjPK 8Bcr99DIUy0A/LkK/ok7O60mhBagouEWtAXdv+MOAas0X7xhUMMH3Z6mev30/sVfZbIq jwug0Xcf/3Le5bY9mT2GxjuO/WdhaIjsQ161TM2iEELKw79tAMx4UjVs4S3al6DezPOG ZJ4U+Xp81rwFesBSuxGoJ3RSEEgHY4f0XDuPYxwOo1xDsWwjTobf9LuBEZE7iS5EX9lf lNAsYyW1zaiRi6i5DapaoKfC2qkHQGP+AofwRyAaSPjIDBfQ24AfURyIJSvqEykOkn2g 60Tg== X-Gm-Message-State: AOAM532WX7E/Kg8BY6Nbw+UMsIgWudwGpnaKnAtPmTC/2Dd0m5nE8EeA VZ6Pdtk601yMh8Q82aYd0h9acq5N6tU= X-Google-Smtp-Source: ABdhPJxuSfcYfKYdPlv2VxhfV6OBqVrHZw3m86yWSccx4HD9zmkTHSR7hSxoSeF+qc7rO7pSrmfr8g== X-Received: by 2002:a17:90a:e005:: with SMTP id u5mr11374043pjy.17.1637250540907; Thu, 18 Nov 2021 07:49:00 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id u38sm84462pfg.0.2021.11.18.07.49.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Nov 2021 07:49:00 -0800 (PST) Message-ID: <96b978a6-523f-98cd-668f-d28ec1dd0bfa@gmail.com> Date: Thu, 18 Nov 2021 08:48:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Content-Language: en-US To: GCC Patches Subject: [committed] Fix MIPS test after recent match.pd changes X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jeff Law via Gcc-patches From: Jeff Law Reply-To: Jeff Law Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Andrew's recent match.pd improvements resulted in octeon-bbit-1 failing on the MIPS platforms. What's going on is pretty simple.  We've got two functions that collapse into the same code after Andrew's change which causes ICF to kick in.  As a result we don't see as many bbit instructions as we expect, thus the failures. We can restore the test by adding the noipa attribute. Committed to the trunk, Jeff commit 16fab6d691b1410abdf794230246ab9753d183af Author: Jeff Law Date: Thu Nov 18 10:47:21 2021 -0500 Fix MIPS test after recent match.pd changes gcc/testsuite * gcc.target/mips/octeon-bbit-1.c (f3): Add noipa attribute. diff --git a/gcc/testsuite/gcc.target/mips/octeon-bbit-1.c b/gcc/testsuite/gcc.target/mips/octeon-bbit-1.c index f91c68bcdcc..8adbb26e377 100644 --- a/gcc/testsuite/gcc.target/mips/octeon-bbit-1.c +++ b/gcc/testsuite/gcc.target/mips/octeon-bbit-1.c @@ -22,7 +22,9 @@ f2 (int i) foo (); } -NOMIPS16 void +/* f3 and f4 are equivalent and may be subject to ICF. The attribute + is supposed to prevent that. */ +NOMIPS16 void __attribute__ ((noipa)) f3 (int i) { if (i % 2)