From patchwork Wed Nov 17 16:07:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 47836 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06D153858417 for ; Wed, 17 Nov 2021 16:25:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06D153858417 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637166324; bh=PWLcUVdQsq8O5a1mjbtNEX4VH6NMdNJgXcgXtmPjyLw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=GHHL2wcVcChFsM4CGFtOEagkOjSAkz45UuClZp8S6jdplbQ7Re1QDs/8ful8VqYS2 PdpOj0C4+lAth4aRu48mzYpXR4S3AVplvA6u5fsH2AytkW/DsWXvXdsAHnrt1SBBOV 6kgEJ+ZUqnRIlrSi4KtDrVrcaYrq4MgaM8lOa2BM= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id A1E6D3858436 for ; Wed, 17 Nov 2021 16:07:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1E6D3858436 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-571-OSY3U4rmOfiiP_4KpkjIzQ-1; Wed, 17 Nov 2021 11:07:08 -0500 X-MC-Unique: OSY3U4rmOfiiP_4KpkjIzQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A2B71023F67; Wed, 17 Nov 2021 16:07:07 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B193F60CC3; Wed, 17 Nov 2021 16:07:06 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH v2] socket: Do not use AF_NETLINK in __opensock Date: Wed, 17 Nov 2021 17:07:04 +0100 Message-ID: <87v90q4vh3.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" It is not possible to use interface ioctls with netlink sockets in all Linux kernels. Reviewed-by: Adhemerval Zanella --- v2: Comment updated. socket/opensock.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/socket/opensock.c b/socket/opensock.c index ff94d27a61..3e35821f91 100644 --- a/socket/opensock.c +++ b/socket/opensock.c @@ -24,17 +24,10 @@ int __opensock (void) { - /* SOCK_DGRAM is supported by all address families. (Netlink does - not support SOCK_STREAM.) */ + /* SOCK_DGRAM is supported by all address families. */ int type = SOCK_DGRAM | SOCK_CLOEXEC; int fd; -#ifdef AF_NETLINK - fd = __socket (AF_NETLINK, type, 0); - if (fd >= 0) - return fd; -#endif - fd = __socket (AF_UNIX, type, 0); if (fd >= 0) return fd;