From patchwork Sat Jul 19 09:56:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Dubiec X-Patchwork-Id: 116606 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA1E83858C2C for ; Sat, 19 Jul 2025 09:56:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA1E83858C2C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=o2.pl header.i=@o2.pl header.a=rsa-sha256 header.s=20241105 header.b=coeM6O6p X-Original-To: newlib@sourceware.org Delivered-To: newlib@sourceware.org Received: from mx-out.tlen.pl (mx-out.tlen.pl [193.222.135.142]) by sourceware.org (Postfix) with ESMTPS id 8AE253858D35 for ; Sat, 19 Jul 2025 09:56:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AE253858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=o2.pl Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=o2.pl ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8AE253858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=193.222.135.142 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752918981; cv=none; b=dfncqCvuDCmTlm3Eiijvgx8BTTLonS/8/y1623OatsflQwbl+UCgQXegLdX3lBz4oY1KHyk/UEiKHEWh8+1i+9/1POp5lExw3de/sscD5GoB/1+QjhsPsYaWT0JPAIg4bE3UMNSWc08kwveUZpUjfe+JG9kJDuJvCPphP3XCjc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752918981; c=relaxed/simple; bh=C9sffdryCGnGOP7nH/sJFiZAU00qwvC2C5YMsf1guBM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:To:Subject; b=HvjfoAXd7yUOKZ2wUIIASQc8keHkqs1vgu542Xehuce6KEu8e3/mVRhoY/rgmgSjYubdF4h2etPs+f5d2x4GRcQVH5nldAAmXEQ3OgBzyFkv4tooEl+BfiIDmDQtVOAF0a5Ca60qqe9yod6UVpwHKO7ViFvHeFkgwziRFbNLAwY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8AE253858D35 Received: (wp-smtpd smtp.tlen.pl 31466 invoked from network); 19 Jul 2025 11:56:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=o2.pl; s=20241105; t=1752918978; bh=phLqF/MV5CAwtOEtuiizvVQ2fypt7CfF/G4frk3ZCXk=; h=From:To:Subject; b=coeM6O6pHeEKc4NBNdXG4kLeHyiQ3nhZGqMkZ+ZNlVvjDjmKePXu3xTD0KpwQP1i6 wwJ4iEE37anQj3ZWNvfz3tBQ0F6uLqLvnJv4yDftEQi3oHZOnjSm+GKP25qUaBHV3P jQVwZ2EcLrz4V8mJK26kwPp14zq5kIyZr2UL/iQSwzHYrxtLawsIYSVV0O0kNLUW8k EdHRqfOGwSMTkCabs1r2Afve+3MmiFUiepNv7disLitKMokr7UQNKbg1qhn7r+oaSK wqU23XUPtxWk7FINxTJFVxgj7Q9aOBTHT6WNhzA8pVs3G4sB2qQ2VFNQEvHE1Se+mc +/hmI6Vm5S9Gw== Received: from ip-94-42-227-144.multimo.pl (HELO [192.168.0.64]) (jdx@o2.pl@[94.42.227.144]) (envelope-sender ) by smtp.tlen.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 19 Jul 2025 11:56:18 +0200 Message-ID: <38c1b846-2ba6-4208-b452-55f004b09546@o2.pl> Date: Sat, 19 Jul 2025 11:56:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Dubiec Content-Language: pl To: newlib@sourceware.org Subject: [PATCH] H8/300: Start-up code cleanup for H8/300H and newer X-WP-MailID: f32ed889959c34f774f665f62d12110b X-WP-AV: skaner antywirusowy Poczty o2 X-WP-SPAM: NO 0000000 [IUMB] X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: newlib-bounces~patchwork=sourceware.org@sourceware.org This patch has been started as an attempt to fix assembler message about missing stack section attributes: CPPAS libc/sys/h8300hms/crt0.o ../../../combosrc/newlib/libc/sys/h8300hms/crt0.S: Assembler messages: ../../../combosrc/newlib/libc/sys/h8300hms/crt0.S:64: Warning: new section '.stack' defined without attributes - this might cause problems In the process I have noticed that H8/300H, H8/300S and H8SX code does not support normal mode. So the patch does a few things: declares stack section in a proper way, merges H8/300H and H8/300S/SX parts of code into one and adds support for normal mode. 2025-07-19 Jan Dubiec newlib/ChangeLog: * libc/sys/h8300hms/crt0.S: General cleanup: declare stack section in a proper way, merge H8/300H and H8/300S/SX parts of code into one, add support for normal mode. newlib/libc/sys/h8300hms/crt0.S | 80 +++++++++++++++++------------------------ 1 file changed, 32 insertions(+), 48 deletions(-) diff --git a/newlib/libc/sys/h8300hms/crt0.S b/newlib/libc/sys/h8300hms/crt0.S index 05634113c..757fb0477 100644 --- a/newlib/libc/sys/h8300hms/crt0.S +++ b/newlib/libc/sys/h8300hms/crt0.S @@ -1,4 +1,4 @@ -; h8/300 and h8/300h start up file. +; H8/300, H8/300H, H8/300S and H8SX start up file. #include "setarch.h" @@ -10,90 +10,74 @@ _start: mov.w #_stack,sp mov.w #_edata,r0 mov.w #_end,r2 - sub.w r1,r1 + sub.w r1,r1 sub.w r0,r2 jsr @_memset #ifdef __ELF__ - mov.l #__fini,r0 - jsr @_atexit + mov.w #__fini,r0 + jsr @_atexit #ifdef __SIMULATOR__ - jsr @0xcc + jsr @0xcc #endif - jsr @__init + jsr @__init #else #ifdef __SIMULATOR__ - jsr @0xcc + jsr @0xcc #endif jsr @___main #endif jsr @_main jsr @_exit - .section .stack -_stack: .word 1 + .section .stack, "aw", @nobits +_stack: .space 2 #endif -#ifdef __H8300H__ +#if defined (__H8300H__) || defined (__H8300S__) || defined (__H8300SX__) .section .text .global _start _start: +#ifdef __NORMAL_MODE__ + mov.w #_stack,sp + mov.w #_edata,r0 + mov.w #_end,r2 + sub.l er1,er1 + sub.w r0,r2 +#else mov.l #_stack,sp mov.l #_edata,er0 mov.l #_end,er2 - sub.w r1,r1 + sub.l er1,er1 sub.l er0,er2 +#endif jsr @_memset #ifdef __ELF__ - mov.l #__fini,er0 - jsr @_atexit -#ifdef __SIMULATOR__ - jsr @0xcc -#endif - jsr @__init +#ifdef __NORMAL_MODE__ + mov.w #__fini,r0 #else -#ifdef __SIMULATOR__ - jsr @0xcc -#endif - jsr @___main + mov.l #__fini,er0 #endif - jsr @_main - jsr @_exit - - .section .stack -_stack: .long 1 - -#endif - -#if defined (__H8300S__) || defined (__H8300SX__) - - .section .text - .global _start -_start: - mov.l #_stack,sp - mov.l #_edata,er0 - mov.l #_end,er2 - sub.w r1,r1 - sub.l er0,er2 - jsr @_memset -#ifdef __ELF__ - mov.l #__fini,er0 - jsr @_atexit + jsr @_atexit #ifdef __SIMULATOR__ - jsr @0xcc + jsr @0xcc #endif - jsr @__init + jsr @__init #else #ifdef __SIMULATOR__ - jsr @0xcc + jsr @0xcc #endif jsr @___main #endif jsr @_main jsr @_exit - .section .stack -_stack: .long 1 + .section .stack, "aw", @nobits +#ifdef __NORMAL_MODE__ +_stack: .space 2 +#else +_stack: .space 4 +#endif #endif