From patchwork Fri Nov 12 11:39:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 47515 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DBD1385801E for ; Fri, 12 Nov 2021 11:39:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id EA26E3858402 for ; Fri, 12 Nov 2021 11:39:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA26E3858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DEAF91FD57; Fri, 12 Nov 2021 11:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1636717153; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZxTSqZAMO+/ezQV9O3Luexmd+xtarSfLrseNS7lwuUk=; b=ClUZTHlVdqeqAwgU/AoseyF/zZXab/ztx//e1krgYosa58I5HIr1vJXbkg5AQUXeV8OFLL o9DLtaE8jkTO5pplayIvqWSv+SFVMv5Djctbf5OK9VDMYlZmqWYwxG3x5apISza6AuDUrI mk3/S44/vgDMaHfPfE2Mh0g2rAaLpIs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1636717153; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZxTSqZAMO+/ezQV9O3Luexmd+xtarSfLrseNS7lwuUk=; b=0aukYA3C4gqXsVJBRQMpCnu4Z71eXo5L1oxVaAOUF9ZhUEIIffnX+5/aU25e8zJ9QZm4rO beb5XSWpwRadNUAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C79F713BEF; Fri, 12 Nov 2021 11:39:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RRiqL2FSjmGcagAAMHmgww (envelope-from ); Fri, 12 Nov 2021 11:39:13 +0000 Message-ID: <0513856b-6dcb-0a75-eef0-c2c83fac9865@suse.cz> Date: Fri, 12 Nov 2021 12:39:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 From: =?utf-8?q?Martin_Li=C5=A1ka?= Subject: [PATCH][PUSHED] Remove unused function. To: gcc-patches@gcc.gnu.org Content-Language: en-US X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" This one is last unused function we have, I'm going to push this as obvious. Martin, feel free to restore the function once it's used. Thanks, Martin PR tree-optimization/102497 gcc/ChangeLog: * gimple-predicate-analysis.cc (add_pred): Remove unused function: --- gcc/gimple-predicate-analysis.cc | 61 -------------------------------- 1 file changed, 61 deletions(-) diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index 454113d532e..6dde0203841 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -2105,67 +2105,6 @@ predicate::normalize (gimple *use_or_def, bool is_use) } } -/* Add a predicate for the condition or logical assignment STMT to CHAIN. - Expand SSA_NAME into constituent subexpressions. Invert the result - if INVERT is true. Return true if the predicate has been added. */ - -static bool -add_pred (pred_chain *chain, gimple *stmt, bool invert) -{ - if (gimple_code (stmt) == GIMPLE_COND) - { - tree lhs = gimple_cond_lhs (stmt); - if (TREE_CODE (lhs) == SSA_NAME) - { - gimple *def = SSA_NAME_DEF_STMT (lhs); - if (is_gimple_assign (def) - && add_pred (chain, def, invert)) - return true; - } - - pred_info pred; - pred.pred_lhs = lhs; - pred.pred_rhs = gimple_cond_rhs (stmt); - pred.cond_code = gimple_cond_code (stmt); - pred.invert = invert; - chain->safe_push (pred); - return true; - } - - if (!is_gimple_assign (stmt)) - return false; - - if (gimple_assign_single_p (stmt)) - // FIXME: handle this? - return false; - - if (TREE_TYPE (gimple_assign_lhs (stmt)) != boolean_type_node) - return false; - - tree rhs1 = gimple_assign_rhs1 (stmt); - tree rhs2 = gimple_assign_rhs2 (stmt); - tree_code code = gimple_assign_rhs_code (stmt); - if (code == BIT_AND_EXPR) - { - if (TREE_CODE (rhs1) == SSA_NAME - && add_pred (chain, SSA_NAME_DEF_STMT (rhs1), invert) - && TREE_CODE (rhs2) == SSA_NAME - /* FIXME: Need to handle failure below! */ - && add_pred (chain, SSA_NAME_DEF_STMT (rhs2), invert)) - return true; - } - else if (TREE_CODE_CLASS (code) != tcc_comparison) - return false; - - pred_info pred; - pred.pred_lhs = rhs1; - pred.pred_rhs = rhs2; - pred.cond_code = code; - pred.invert = invert; - chain->safe_push (pred); - return true; -} - /* Convert the chains of control dependence edges into a set of predicates. A control dependence chain is represented by a vector edges. DEP_CHAINS points to an array of NUM_CHAINS dependence chains. One edge in