From patchwork Wed Nov 10 08:39:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 47363 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6B3403857C47 for ; Wed, 10 Nov 2021 08:39:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B3403857C47 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1636533593; bh=Fx9/6NQ96rUubeok4OSPRdGg3TiaIJ6wolswEKu2mHc=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=ktyjbkup2uNeWBrZJQfmqdrbtyViSay8ZvBBsGVRo8SpPWW0N3GAbNB2Dy/U8pw2O aO2EnEuGze/N25Pf5JRjIDqxxmIzccTUBOr1FOa1ujoUuj/CNL6xjJwLO7//R6Fe58 VX+LkilbqyBx66nGT64EyE12jrgO0xBCtrJRPhBU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 040173858404 for ; Wed, 10 Nov 2021 08:39:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 040173858404 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-ZdkuX7xSPF2rAWv4geZfkg-1; Wed, 10 Nov 2021 03:39:17 -0500 X-MC-Unique: ZdkuX7xSPF2rAWv4geZfkg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF2571023F59; Wed, 10 Nov 2021 08:39:16 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33A295D9DE; Wed, 10 Nov 2021 08:39:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1AA8dDYg803137 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 10 Nov 2021 09:39:13 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1AA8dCNA803136; Wed, 10 Nov 2021 09:39:12 +0100 Date: Wed, 10 Nov 2021 09:39:12 +0100 To: Segher Boessenkool Subject: [PATCH] rs6000, libgcc: Fix up -Wmissing-prototypes warning on rs6000/linux-unwind.h Message-ID: <20211110083912.GD2710@tucnak> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! Jonathan reported and I've verified a In file included from ../../../libgcc/unwind-dw2.c:412: ./md-unwind-support.h:398:6: warning: no previous prototype for ‘ppc_backchain_fallback’ [-Wmissing-prototypes] 398 | void ppc_backchain_fallback (struct _Unwind_Context *context, void *a) | ^~~~~~~~~~~~~~~~~~~~~~ warning on powerpc*-linux* libgcc build. All the other MD_* macro functions are static, so I think the following is the right thing rather than adding a previous prototype for ppc_backchain_fallback. Bootstrapped/regtested on powerpc64le-linux and powerpc64-linux (the latter with -m32/-m64 testing), ok for trunk? 2021-11-09 Jakub Jelinek * config/rs6000/linux-unwind.h (ppc_back_fallback): Make it static, formatting fix. Jakub --- libgcc/config/rs6000/linux-unwind.h.jj 2021-10-15 11:59:16.227682621 +0200 +++ libgcc/config/rs6000/linux-unwind.h 2021-11-09 11:42:06.840353422 +0100 @@ -395,7 +395,8 @@ struct frame_layout }; -void ppc_backchain_fallback (struct _Unwind_Context *context, void *a) +static void +ppc_backchain_fallback (struct _Unwind_Context *context, void *a) { struct frame_layout *current; struct trace_arg *arg = a;