From patchwork Wed Apr 16 05:14:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 110537 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E61B8385781B for ; Wed, 16 Apr 2025 05:17:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E61B8385781B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=eHaNbqv9 X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 0FAE0385783C for ; Wed, 16 Apr 2025 05:15:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FAE0385783C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0FAE0385783C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744780501; cv=none; b=kmMNhPpo9R2XuHMyGESCpwW81HhRKVKRMGJHqulZ7/6h7dduyCwgMorSeiw331PFwSNKfFYfDgKXIhpKqGCmgoR564Te0Chh5mOaGuXtAzixZUMZBEbWSQBy5xUMczp7Uv9/IvTeYqUouJ8JEZWuspItl85dQf8Gzn8Qo4L+5QY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744780501; c=relaxed/simple; bh=NQQO00EKHb7WMNd0HA9SeFwOpkQwId4yZSnxPFcIqN0=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=OriSpnw/X0KOiou/A1Tu14xt/+KOXADFqgF7KtLT+UTC9SaHGTEsdFH2DoxaROSxu1YPNULZTHnQ4Nnkmh5K5B3VTmye0iXPT6aChjGXGli0WC8Q8fQQP1U+MbPD4hcpQlc4yCnqoaoGuFv3DPdp8GhFmV0/nPaDqBkaRyNJ7nI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0FAE0385783C Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-736a72220edso6496778b3a.3 for ; Tue, 15 Apr 2025 22:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744780500; x=1745385300; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=dpenDXJIrpMipsEiJDrCb44gKbSxFgJBb163mtZKPgk=; b=eHaNbqv9/2DFly5YiOFqdGh2GA1Yl5MswZC4eUrkroycWj1beUCWAmGl2GtMn7ybOq EMoTe1Hq3L/+U8iLEgDqJWOlcyBqd6QP+gg/zWWNjrz+Cigp2E2c8D0CVDEN5rIxRVap /FDATKgyh3GUaTRzoDqUpUttyFED2S2kzOgsM3mvECmiszBpOn4UPNZe+crQeXRCqxfe VwY3JwGpNfD7F+ZCRHgqLx62hTuMAfQklUE989B5X4QJtmMeT98bA89SzQUnyq+iG0zH UFa7Xet94a2LeMcBjjRKEbbvyFynKac0Vokp7DJPaY+SBbdSZ1K+3DzYflCf24fiSiag /YKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744780500; x=1745385300; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dpenDXJIrpMipsEiJDrCb44gKbSxFgJBb163mtZKPgk=; b=Trxi1JItRRTE9MUf03i0n0tefmPKfM1N0ExOGu3IBlxxzCYgniIidwJ9NwW8SO6lQl WCtgg4WwfpsO2gL5a4HSm+LND0JFHgGXlZJZ8fKlGwtKZ0RJ0F1D/PWjNhkVY8LGaCLx ehYTC6zSvLdnmkhEWLm2oSFqiKdHtsgYNXPUoreXjtBzs59syoOvT1NBeTPO7GnKgaIT 3PZvxd4YfqOIJ4Pnu3TDluA4zsR9ssN20MSKjv4Cj4Tm0v2x6ucQOQCH5NX5owgq6c0s wxwrxud19qx93vIxjfGJhff5PNsmsHRAsxSR25OcVLbZZf2pp3u1p2q6PoA017xs1Cff lmnw== X-Gm-Message-State: AOJu0YwLWTtVBs0LLnHFkDcissIvZ1DIBTHqJTJMf/FIVTAyThIYe28S wUWy35TD9GZACE6u4HazneBhgrVb/b6HgWyObsatBS9WOz1Yc0yMr4QQeA== X-Gm-Gg: ASbGncvg2vbSZvo6AmcfSJz88rqgnVSiGoz69K7alk+8KWgFRt+cVC1AZJ96vU/9kqJ eIgWXZF4M81zL4qkwKx2QkbPitefmRrIbqq83PRCwqekKBkK1NmBeJarGgGFTAhg6+VRupF/C8c irApAQrrnzTwilmBf7daS//U0qDwvlJX/1ofHSlB1P/Muht+vG6V4dH+0ewbcYyPdyTh9GBDBbJ FHhafTRKDocKLDBsY5Gk2bCg7z6rnOGCUyky8UWL7QY9B6rBsi1TRKj0JaJQ8P3Xc5N/t8Y4wnQ jlxSU8qj2eDpjcL852NTOzIY9m7yvHdjJzeBtyr9DeZOmoUB0D3TcQ== X-Google-Smtp-Source: AGHT+IHzZXs75tnV2bY0+dVcaL0NUj06zgitr3yPYTakpKiMOoZAMUOmhJh8eAjIkXTJ0eQ1gUHqWg== X-Received: by 2002:a05:6a00:3cc2:b0:730:97a6:f04 with SMTP id d2e1a72fcca58-73c266e73d9mr668663b3a.7.1744780499816; Tue, 15 Apr 2025 22:14:59 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:4d08:cebd:d73f:b794]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd21c20f3sm9450590b3a.39.2025.04.15.22.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 22:14:59 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 192E81140BFC; Wed, 16 Apr 2025 14:44:57 +0930 (ACST) Date: Wed, 16 Apr 2025 14:44:57 +0930 From: Alan Modra To: Chenghua Xu , Zhensong Liu Cc: binutils@sourceware.org Subject: loongarch gas resolving constant expressions Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org The test added in commit 4fe96ddaf614 results in an asan complaint: loongarch-parse.y:225:16: runtime error: left shift of negative value -1 To avoid the complaint, perform left shifts as unsigned (which gives the same result on 2's complement machines). Do the same for addition, subtraction and multiplication. Furthermore, warn on divide/modulus by zero. OK? diff --git a/gas/config/loongarch-parse.y b/gas/config/loongarch-parse.y index 97055fe42c3..b75040c14b1 100644 --- a/gas/config/loongarch-parse.y +++ b/gas/config/loongarch-parse.y @@ -207,29 +207,41 @@ emit_bin (int op) switch (op) { case '*': - opr1 = opr1 * opr2; + opr1 = (valueT) opr1 * (valueT) opr2; break; case '/': - opr1 = opr1 / opr2; + if (opr2 == 0) + { + as_warn (_("Divide by zero!")); + opr1 = 0; + } + else + opr1 = opr1 / opr2; break; case '%': - opr1 = opr1 % opr2; + if (opr2 == 0) + { + as_warn (_("Divide by zero!")); + opr1 = 0; + } + else + opr1 = opr1 % opr2; break; case '+': - opr1 = opr1 + opr2; + opr1 = (valueT) opr1 + (valueT) opr2; break; case '-': - opr1 = opr1 - opr2; + opr1 = (valueT) opr1 - (valueT) opr2; break; case LEFT_OP: - opr1 = opr1 << opr2; + opr1 = (valueT) opr1 << opr2; break; case RIGHT_OP: if (opr1 < 0) - as_warn(_("Right shift of negative numbers may be changed " - "from arithmetic right shift to logical right shift!")); - /* Algorithm right shift. */ - opr1 = (offsetT)opr1 >> (offsetT)opr2; + as_warn (_("Right shift of negative numbers may be changed " + "from arithmetic right shift to logical right shift!")); + /* Arithmetic right shift. */ + opr1 = opr1 >> opr2; break; case '<': opr1 = opr1 < opr2;