From patchwork Mon Apr 14 17:39:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 110416 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 438EF3858429 for ; Mon, 14 Apr 2025 17:40:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 438EF3858429 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FVOFKo+Y X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E5F143858C54 for ; Mon, 14 Apr 2025 17:39:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5F143858C54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E5F143858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744652400; cv=none; b=LNEHDFrZsBYieM7HTgaUzqGeFABwIJ5AdAaILUcuWi0El5YcnKiyg0TEidQQr6y3li64uTenisG87snTJSF3UcVzYXzSbyoeEw4pmW7d5y7stguUPH1NpsJDI1oFmE7r2KE05/oFB75jT6+jOV37ERfM6CWHn/LAlNjIx9x4Mgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744652400; c=relaxed/simple; bh=rS6C1B7Z/zVtHSnSua/a2us6GJli9FeGF+4Li7e4Ar0=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=EfIn0K5caJI92H/ewAJlka6/EzN6hCBUGziJgX+z1X25e3nBRS6tP+ordW9cWRc2JyDVirWU7PeKcRmB1J8eNDm7yARJdEWtvCi4hb9sSYa2nnSpdlGh36jxHkCWKfL7yWwZAyI46Ahfbchro0udkpIENkLl2b/f2rlngaoREko= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E5F143858C54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744652399; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=PzT1BhyKj2WumkH6AmCZKQO0mf1D78rfD6+Ok+aneJ0=; b=FVOFKo+YG2N1QiQfOhGCrFHJWnODJGf0PC8Mxr6HeW/nmsBmaZreJYE1eOgS8yJTyf5z+5 +UVw9GF7Ifp90ttzH4T7ZZf///unIXJFpk3GRGe4ixE2LU5vtSCB2HMOdCL1uUOH+JIKfK kqG+3rPWYcifNdMmNgMQCWsF1TO2580= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-a6DcAu3XPYWTPtKrqcXDdQ-1; Mon, 14 Apr 2025 13:39:55 -0400 X-MC-Unique: a6DcAu3XPYWTPtKrqcXDdQ-1 X-Mimecast-MFC-AGG-ID: a6DcAu3XPYWTPtKrqcXDdQ_1744652394 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 53E261800260; Mon, 14 Apr 2025 17:39:54 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.44.32.53]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 989F9180B486; Mon, 14 Apr 2025 17:39:52 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 53EHdna84159926 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 14 Apr 2025 19:39:49 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 53EHdmY44159925; Mon, 14 Apr 2025 19:39:48 +0200 Date: Mon, 14 Apr 2025 19:39:48 +0200 From: Jakub Jelinek To: Martin Jambor Cc: Jan Hubicka , GCC Patches Subject: [committed] testsuite: Fix up ipa/pr119530.c testcase [PR119318] Message-ID: References: <2304850dbe90aad832fdfc803b1afe191eeded3a.1743458148.git.jamborm@gcc.gnu.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Lerxbkf8Ks3TsVjtNhAKoVOrXNQ-WtXCrj9R2rQRHgk_1744652394 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Hi! On Sat, Apr 12, 2025 at 12:19:28AM +0200, Martin Jambor wrote: > 2025-04-11 Martin Jambor > > PR ipa/119318 > * gcc.dg/ipa/pr119318.c: New test. > * gcc.dg/ipa/pr119530.c: Likwise. I'm seeing +FAIL: gcc.dg/ipa/pr119530.c execution test on i686-linux. The problem is that when long is just 32-bit and so is unsigned, the testcase then behaves differently and should abort. Fixed by making the argument long long instead. While at it, just in case I've changed type of d variable to signed char as well just in case there is -funsigned-char 8-bit int target or something similar. Fixed thusly, tested on x86_64-linux and i686-linux (also with reversion of the PR119318 ipa-cp.cc change where it FAILs on both), committed to trunk as obvious. 2025-04-14 Jakub Jelinek PR ipa/119318 * gcc.dg/ipa/pr119530.c (d): Change type from char to signed char. (e): Change argument type from long to long long. Jakub --- gcc/testsuite/gcc.dg/ipa/pr119530.c.jj 2025-04-14 15:02:23.768540571 +0200 +++ gcc/testsuite/gcc.dg/ipa/pr119530.c 2025-04-14 18:47:15.610079496 +0200 @@ -5,8 +5,8 @@ struct a { int b; }; int c; -char d; -static int e(long f) { return f < 0; } +signed char d; +static int e(long long f) { return f < 0; } static void g(unsigned f) { c = e(~f); } int main() { int h;