From patchwork Thu Apr 10 10:17:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 110166 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 696763839383 for ; Thu, 10 Apr 2025 10:18:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 696763839383 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=kU3L+UrR X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id E792E3839436 for ; Thu, 10 Apr 2025 10:17:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E792E3839436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E792E3839436 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744280258; cv=none; b=L6iMIxYZPgi8zVyTzcMw/aUc+OrYLDxj9njKQ8qOyX7WVFHRFemLgFaIBTskYjIfBbXj60b15UKsUcw8JNq1R3693iYRfyrMM9OMLTiE8/bcLRGHaydk6/Ahr89rbe1e5wKJThjYUgQaTl3jcaevOElEgA+cWecLblNtAguVZ0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744280258; c=relaxed/simple; bh=OfTFgiAUVEdf9Mcl3JOZK3b/rJisEOSHoqCVl4Y2ihw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=YKjq2qWDjtnejnbu05xv/MNO9bZWPBisXCN+iAkOgvYbsFCyPLKq1Zq0GIDOkPDVVqBbk+YMqW0AWZ9NdhGolTCc43ocQBSXQP/WflWz8OMeK4TX80So4sYurU5VMi9cRTakg6FdWm8hoXgIeaEcveKYBvXeXWqia7bI8EIGyh8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E792E3839436 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-22403cbb47fso5931365ad.0 for ; Thu, 10 Apr 2025 03:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744280257; x=1744885057; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=x+dHsmRUIVy3IdDUKBwsfLtWlkEpMp1P872gWzzNHso=; b=kU3L+UrRuV5kfl2rGaZNdKWF0/wEbJ6pHuSuvu/Gl+bgpDVLnqhgeY2w48q2pHFPCz dcFem+PVOEhynlWRATbpxCl9iYNYYxQ7RFavSCBx4zNCqhWL8X1l3rzO02PNfqhXXhUj TkfsrFEUuWWezFMF5u59/RgRKHxxvzQK3/XKvMOOJBgaQVkY2DYp6tNZkuYEwxboRC42 N2+yt3H/CLxRyz0j703BKG6ZTNCCXpD+I6o1+1KUwxi+tde05YOfP8jQe3wNWZyvXJs/ JUbgfTpet8K+Zuk4lhSl+NZP52920T4pnw/FhQarHe+vzDtDQZG0jRFAiGj+YiQaXBNz +mRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744280257; x=1744885057; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x+dHsmRUIVy3IdDUKBwsfLtWlkEpMp1P872gWzzNHso=; b=QMxF7HGH57xqykgLvEhWqkmm/YnUL4E90GWBNQFfaQCYfjGEi+a5qkX5pKrPN3pPDK aJVkYs1d+/6G3qY3PwPLHYcH/k5Bc5XaU9rtdBKKS6s3NAR7ElMoxC5VW2X94296kBNj fsvdzfoSB5Gcm5NK1vePxupRZn5mWk5xkn0tfdFHk4VgHDl+A00RHOczjeb8L2a1I0Rk PYLKCMgD10q7TR+yKuP8JJQ7E4BFeWI+7uYROG+/btpXY+X0IpAjFBtSmBa/MmjOG4Ku AE1B/lXXV37pxqqq7ajvb649fyqXJmcV6Oah+p2B/FJXDMYj9scW240Y5LFGrVzMmozL bE4g== X-Gm-Message-State: AOJu0YzJSUnBC2nFh4BL/NlKS5KAYt8XWw2FVXQ5tQMTqbzdsQksUBmG w0a1WRxNraHOvvIW48hLUbBe/82xD8JkNKmdSDbFTznO3H3fNuoZSCDw8g== X-Gm-Gg: ASbGncv6Ze/5X5UPsH5UamluohqdzO+eHe5TEde0A2xueM283cBeDoA7iIZuJTZtJpp rZ+RdPG4c9/JJuN9KK1u2WRlkwv2O81aD0XDhO1tU/QZytVTSKCShl41UpIcGMIj3E6x5Z2Cfld XF2ppLni4gAhp+fMn23/S+AYQhT1AV8p2UWKzKj+HIu610M8f5l0eOPDemCn8oubRSwcglZ4spT 1IWJXuzPqGUEI4ZMoI2dWmgsvIJq+0POAKuoAJxeDK/1nDj3OSHSwqXB2CKEtNo0K3ignNdJK3B DhTarS/0lI1GSHwRPeJhi5NxygggwtlqofjBui/H18rPfshUe+p239e9iM1nGhpF/T50aGSVQZa nVzv1PJZSTmk= X-Google-Smtp-Source: AGHT+IFzS4mkiNO17DiqGfbWQf4o/Tlw5b9h4rLyrLPhgIgPEUPR5kyCBMZ7vwKwvrNBUzp7GKK0Gw== X-Received: by 2002:a17:902:ccc6:b0:224:2207:5130 with SMTP id d9443c01a7336-22be039bdbdmr28135975ad.45.1744280256658; Thu, 10 Apr 2025 03:17:36 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7b62922sm26672745ad.51.2025.04.10.03.17.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 03:17:36 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id AD09E1141FE1; Thu, 10 Apr 2025 19:47:33 +0930 (ACST) Date: Thu, 10 Apr 2025 19:47:33 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR32858 ld segfault on fuzzed object Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3032.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org We missed one place where it is necessary to check for empty groups. PR 32858 * elflink.c (elf_gc_sweep): Protect against empty group. diff --git a/bfd/elflink.c b/bfd/elflink.c index a76e8e38da7..549b7b7dd92 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -14408,7 +14408,8 @@ elf_gc_sweep (bfd *abfd, struct bfd_link_info *info) if (o->flags & SEC_GROUP) { asection *first = elf_next_in_group (o); - o->gc_mark = first->gc_mark; + if (first != NULL) + o->gc_mark = first->gc_mark; } if (o->gc_mark)