From patchwork Tue Nov 9 09:46:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 47254 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 55A07385842E for ; Tue, 9 Nov 2021 09:58:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55A07385842E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1636451922; bh=zrz5whty7KhZFrySQ+2Z/X0KORYMgAc8C+rahpjvFio=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=QbFkq7R+GEJJE6aNUDEDq2PwxqQJtR7XQJR8u1K4BTtI+iXxFIYSoSAqgC+/YymI5 +lGKhaBj+vO0/bSYrZjWvvAZcTiRYyjgIRa2Dopvu4Us/UYgw00cbwng2DEVZ7tQI0 AW8wsPZgrgVtc5N26FRIdQJsL5Tzao3IV9PYl/Kk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 984013858425 for ; Tue, 9 Nov 2021 09:46:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 984013858425 Received: by mail-lj1-x235.google.com with SMTP id t11so35139080ljh.6 for ; Tue, 09 Nov 2021 01:46:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=zrz5whty7KhZFrySQ+2Z/X0KORYMgAc8C+rahpjvFio=; b=YUapEDOY03BFzRScIlw3yqNsaP0FBRV9FupCB6S7y4pa+lCBiiGky3A5uyCN9cSnd0 jKUZCbo2EPbXfwVt7MNiyX0r4SzQ1xFZ4BE78DEWx/WyyYHkJB7uqDbr4GvQRPMBzrgs bRoY6QVH+RSfzb8oU/IAYH34KmNDfXDXajM8DX9xM2NKhuSTsSbfoqcg9+QtpnsRuOV8 waIlQlkfT8LHN0l3pa+bHEoyFb5gITwy25A4MJ0T6z1AUD3cBtih0HAYUGmlrlnMRC+r +vrHP3GGxgeJJHHz7h7PT990nhcH6mouL5c7bWRBq0gQFYa9H+QCnM8MCo0y0lCVc74F jkmQ== X-Gm-Message-State: AOAM531QMJpiICgh+WZn3PpX5qqbuzzJYNuP9ug99TTM+eb+m6Hbh/lX WZcpuZxxbqsLKL5kUq5t58PMo2pTID43hdlp X-Google-Smtp-Source: ABdhPJx4qEeJ7lQvEZ2KdspYEC9QNMtbIVVw3khUKowWwv+VTHH0rNCMhGzhv31z1NFd7faCE5wJfA== X-Received: by 2002:a05:651c:292:: with SMTP id b18mr6257616ljo.220.1636451162509; Tue, 09 Nov 2021 01:46:02 -0800 (PST) Received: from adacore.com ([2a02:2ab8:224:2ce:72b5:e8ff:feef:ee60]) by smtp.gmail.com with ESMTPSA id c4sm1420138lfb.200.2021.11.09.01.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 01:46:01 -0800 (PST) Date: Tue, 9 Nov 2021 09:46:00 +0000 To: gcc-patches@gcc.gnu.org Subject: [Ada] Simplify building of entity occurrences Message-ID: <20211109094600.GA830343@adacore.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Pierre-Marie de Rodat via Gcc-patches From: Pierre-Marie de Rodat Reply-To: Pierre-Marie de Rodat Cc: Piotr Trojanek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Code cleanup related to expansion of predefined equality for GNATprove; semantics is unaffected. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * tbuild.adb (New_Occurrence_Of): Simplify by reusing Make_Identifier. diff --git a/gcc/ada/tbuild.adb b/gcc/ada/tbuild.adb --- a/gcc/ada/tbuild.adb +++ b/gcc/ada/tbuild.adb @@ -699,11 +699,10 @@ package body Tbuild is Loc : Source_Ptr) return Node_Id is pragma Assert (Present (Def_Id) and then Nkind (Def_Id) in N_Entity); - Occurrence : Node_Id; + Occurrence : constant Node_Id := + Make_Identifier (Loc, Chars (Def_Id)); begin - Occurrence := New_Node (N_Identifier, Loc); - Set_Chars (Occurrence, Chars (Def_Id)); Set_Entity (Occurrence, Def_Id); if Is_Type (Def_Id) then