From patchwork Fri Mar 21 14:42:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 108852 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81C543856950 for ; Fri, 21 Mar 2025 16:02:02 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id E07203857B9B for ; Fri, 21 Mar 2025 14:43:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E07203857B9B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E07203857B9B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568183; cv=none; b=qz0SBwpNdPparOKsDF4tuvsgmyV8hceWy8JcuDehnT1glSm5YAd7Gh02/0p60LAYZN6Iv5T33vDd4IKkVst3G5/n98mHx7t0VDkDKgLQDeVgfsGwo1ID/Q175x01r2P56UpUMFa85eDKke1hHf+yl5bWdpDoJIXkLg/eBlAoVFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568183; c=relaxed/simple; bh=iKn1GaCpVTLvBhr9fyyYo0RtbCXF3n5hITuVbNYespo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=gXJq5tOk+dXHTl+6mW8sk0whI4A5TrV/1UMVK/QjX6qVQWusrt+/CTYI3CY0JNaRO8Bq/yqUYmiSGAexsymOAPpwhxjlI7sjhKH72p2dmY4IAtMV0DYbBgEXGWp39Ub0vF0R+sYSXfMM9+bvEUKpZKi2c0gdUbUyBefgJWmexk0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E608E2126E for ; Fri, 21 Mar 2025 14:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWS+vFtlnayHw1vmq2WKS/ngzJD/JKoxKJcIZ0pfyFg=; b=Hm287W7DGviylyiELGyH808Bm/mzyuifLWNQKVMui8Mc7/bTaBUOQuZyWWekQtYQDfj4qj eRcIeVg7SXZU9JC6LMnOolIozoAb8l9s/7greebcEbBqoACl5gwTSMfVplALtrc/61maL+ 64iPqUSqg423oK1SbZn9+1k612PzX+I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWS+vFtlnayHw1vmq2WKS/ngzJD/JKoxKJcIZ0pfyFg=; b=nKn9XYzAU5+FGeAIvNxY7MYtfPf/eim7B22STByMTd1wPrA/XgOABwCoRXe2+ZpVoxqW+Z 0tD2VP21+LUOG6DA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWS+vFtlnayHw1vmq2WKS/ngzJD/JKoxKJcIZ0pfyFg=; b=Hm287W7DGviylyiELGyH808Bm/mzyuifLWNQKVMui8Mc7/bTaBUOQuZyWWekQtYQDfj4qj eRcIeVg7SXZU9JC6LMnOolIozoAb8l9s/7greebcEbBqoACl5gwTSMfVplALtrc/61maL+ 64iPqUSqg423oK1SbZn9+1k612PzX+I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWS+vFtlnayHw1vmq2WKS/ngzJD/JKoxKJcIZ0pfyFg=; b=nKn9XYzAU5+FGeAIvNxY7MYtfPf/eim7B22STByMTd1wPrA/XgOABwCoRXe2+ZpVoxqW+Z 0tD2VP21+LUOG6DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CED0313A68 for ; Fri, 21 Mar 2025 14:42:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6PoTMdd63WfhBQAAD6G6ig (envelope-from ) for ; Fri, 21 Mar 2025 14:42:31 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/5] [gdbsupport] Fix a typo in common-debug.h Date: Fri, 21 Mar 2025 15:42:47 +0100 Message-ID: <20250321144251.23618-2-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250321144251.23618-1-tdevries@suse.de> References: <20250321144251.23618-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Fix a typo: ... $ codespell --config gdbsupport/setup.cfg gdbsupport/common-debug.h gdbsupport/common-debug.h:109: re-used ==> reused ... --- gdbsupport/common-debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbsupport/common-debug.h b/gdbsupport/common-debug.h index 6c793dc33d4..f7c8d8190af 100644 --- a/gdbsupport/common-debug.h +++ b/gdbsupport/common-debug.h @@ -106,7 +106,7 @@ struct scoped_debug_start_end If the FMT format string is non-nullptr, then a `: ` is appended to the messages, followed by the rendering of that format string with ARGS. - The format string is rendered during construction and is re-used as is + The format string is rendered during construction and is reused as is for the message on exit. */ scoped_debug_start_end (PT &debug_enabled, const char *module, From patchwork Fri Mar 21 14:42:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 108827 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46DB63857729 for ; Fri, 21 Mar 2025 15:29:53 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 672C1385781A for ; Fri, 21 Mar 2025 14:43:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 672C1385781A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 672C1385781A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568214; cv=none; b=G91XCBYwORmuU30QbJe0Lb4BhVUcoLILyTIK1ZIWj2+X2MlH+IGnL87Iyeu0kUxwkfAizmsgr8/UuoY5IOGi7LxNl1mRaKr6+74n2n2ww49QQHCG6MGoLOhofdhzFcUx8Dwd0opnRUj3weSG3qB0k7LEF2W7TbpM4XthE19LmLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568214; c=relaxed/simple; bh=WczAoIptxUugELWxxe7igMM3sU0YkPYIB7dtRqgJKXo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=pCSMcGm7UyMFUft4D7mcND1zOn3G0Hyrb1ouBUgBTsnVdU+Y3TJbByy+Xvn4E1me+6E0fbZu3LzYoiNjPQPvt/tiFDQogZggJSaLpQyPzmMYAKFjcmv/UFb3HI95BbBaklGC2T2fRAR3+LO5UkMeEJwQQCvfdbSmsI4BpUKAoUs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0E6261F7DD for ; Fri, 21 Mar 2025 14:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=caeqAJp/TMhh7Xygz+erXqw7OOzoYBTkmB7caw8fwfU=; b=edSuUhA2KuDso5gYT0PfBwM5LoFohPnpeXpbscbOnlhxKbcuYYdue1+AKJdJVeL5aOzX5I u4mFLTToslHR1m/MYAQkYvoAYLMDsbmP1MRmwYFdLHLfuIsvfnb5uE/p783WzdIBdNC2+g 47jPtB7yc8ynYISSYbrJH4Xx8KWCIRg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=caeqAJp/TMhh7Xygz+erXqw7OOzoYBTkmB7caw8fwfU=; b=L3UhT2hkF6JgE2RRWzX1B2/joQajvyP58MepRu8/YMSwzmenz0OzENJlHeg0l0vcYTZqfI T0E8rxfXsHdZ0aBA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=edSuUhA2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=L3UhT2hk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=caeqAJp/TMhh7Xygz+erXqw7OOzoYBTkmB7caw8fwfU=; b=edSuUhA2KuDso5gYT0PfBwM5LoFohPnpeXpbscbOnlhxKbcuYYdue1+AKJdJVeL5aOzX5I u4mFLTToslHR1m/MYAQkYvoAYLMDsbmP1MRmwYFdLHLfuIsvfnb5uE/p783WzdIBdNC2+g 47jPtB7yc8ynYISSYbrJH4Xx8KWCIRg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=caeqAJp/TMhh7Xygz+erXqw7OOzoYBTkmB7caw8fwfU=; b=L3UhT2hkF6JgE2RRWzX1B2/joQajvyP58MepRu8/YMSwzmenz0OzENJlHeg0l0vcYTZqfI T0E8rxfXsHdZ0aBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EC3B113A70 for ; Fri, 21 Mar 2025 14:42:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YN0+ONd63WfhBQAAD6G6ig (envelope-from ) for ; Fri, 21 Mar 2025 14:42:31 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 2/5] [gdbsupport] Ignore pathc in codespell check in gdb_tilde_expand.cc Date: Fri, 21 Mar 2025 15:42:48 +0100 Message-ID: <20250321144251.23618-3-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250321144251.23618-1-tdevries@suse.de> References: <20250321144251.23618-1-tdevries@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: 0E6261F7DD X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:mid, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -3.01 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Ignore the following codespell detections: ... $ codespell --config gdbsupport/setup.cfg gdbsupport gdbsupport/gdb_tilde_expand.cc:54: pathc ==> patch gdbsupport/gdb_tilde_expand.cc:99: pathc ==> patch ... by adding codespell:ignore comments. --- gdbsupport/gdb_tilde_expand.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbsupport/gdb_tilde_expand.cc b/gdbsupport/gdb_tilde_expand.cc index 4a0a5734ad8..f0099793cde 100644 --- a/gdbsupport/gdb_tilde_expand.cc +++ b/gdbsupport/gdb_tilde_expand.cc @@ -51,7 +51,7 @@ public: } /* Return the GL_PATHC component of M_GLOB. */ - int pathc () const + int pathc () const /* codespell:ignore */ { return m_glob.gl_pathc; } @@ -96,6 +96,6 @@ gdb_tilde_expand (const char *dir) const gdb_glob glob (to_expand.c_str (), GLOB_TILDE_CHECK, nullptr); - gdb_assert (glob.pathc () == 1); + gdb_assert (glob.pathc () == 1); /* codespell:ignore */ return std::string (glob.pathv ()[0]) + remainder; } From patchwork Fri Mar 21 14:42:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 108849 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D93D23857039 for ; Fri, 21 Mar 2025 15:54:05 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 4664F3857B91 for ; Fri, 21 Mar 2025 14:44:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4664F3857B91 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4664F3857B91 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568247; cv=none; b=d40p+jM8ZbHVUjh2scIpZY30yOctoIVUXYE3oeZ0N0MIT5LJhg4N8qlw7LfRjehZlb+91BDgjyyNlTGlyPKWLula5ROZpQKH2iFuG0lsfm8igdqk0EmGaRli+II6oiawg9XbxycA3+1DSfEP+M484Dz9A759F2Im/008M4AR8Y0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568247; c=relaxed/simple; bh=8m5SUpYOHBuNmZTFh4j/uti+fPPQ7S4zq7XRTeWv3ZA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=r70YVfWFwPCVJisEVN8fbVJsnX+5Aq3s/h1HwfmWey6KcM65N7DfeW85ZcY+NxXhVmq6JlAml/5nwAJFDVDRtTjDX99lUpaeyWSxQQbb6iIUuF2uZbJ+RcqcwiYM2c5/fGBt0fT2RVdGnTA8kunRBG6Z7L1XLI3XNwR8KCeb4o8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2C7301FF0C for ; Fri, 21 Mar 2025 14:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ENO7ZnasXgMWx1ZqKAfJFmy5rcZ5QOvafyA/m8x1yOM=; b=oA5hZvoSpMiLS976jtCCw+d1FetTbyfFcnFwt02BPCU+NKns6f3hmjgOyxIYiBJ6/AWg56 jmPzWGUP+94tJBTqENjYThXKqBXiPXxgMv5vkweaRPcpd3rV3tfRYPPTBmMs2dLPKF/C1Z ykzbjD736RiLLdY7amtMQ8ftnX1G+wE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ENO7ZnasXgMWx1ZqKAfJFmy5rcZ5QOvafyA/m8x1yOM=; b=uPjim0s7CwF2f6SCW2RfKK5NOQe2eknUsf8NZS7VCRGOD8zRvh0SHh9CxH8edxp6XLv2g3 TrDh1mGyQ0ZlieBg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oA5hZvoS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=uPjim0s7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ENO7ZnasXgMWx1ZqKAfJFmy5rcZ5QOvafyA/m8x1yOM=; b=oA5hZvoSpMiLS976jtCCw+d1FetTbyfFcnFwt02BPCU+NKns6f3hmjgOyxIYiBJ6/AWg56 jmPzWGUP+94tJBTqENjYThXKqBXiPXxgMv5vkweaRPcpd3rV3tfRYPPTBmMs2dLPKF/C1Z ykzbjD736RiLLdY7amtMQ8ftnX1G+wE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ENO7ZnasXgMWx1ZqKAfJFmy5rcZ5QOvafyA/m8x1yOM=; b=uPjim0s7CwF2f6SCW2RfKK5NOQe2eknUsf8NZS7VCRGOD8zRvh0SHh9CxH8edxp6XLv2g3 TrDh1mGyQ0ZlieBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 158DC13A2C for ; Fri, 21 Mar 2025 14:42:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sPzHA9h63WfhBQAAD6G6ig (envelope-from ) for ; Fri, 21 Mar 2025 14:42:32 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 3/5] [gdbserver] Fix typo in tracepoint.cc Date: Fri, 21 Mar 2025 15:42:49 +0100 Message-ID: <20250321144251.23618-4-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250321144251.23618-1-tdevries@suse.de> References: <20250321144251.23618-1-tdevries@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: 2C7301FF0C X-Spam-Score: -3.01 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Fix a typo: ... $ codespell --config gdbserver/setup.cfg gdbserver/tracepoint.cc gdbserver/tracepoint.cc:951: mistakingly ==> mistakenly ... --- gdbserver/tracepoint.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc index 5e3792e1d2f..97e41c0dd2f 100644 --- a/gdbserver/tracepoint.cc +++ b/gdbserver/tracepoint.cc @@ -948,7 +948,7 @@ struct ipa_trace_buffer_control who wrote last to the buffer control structure. We need to freeze any inferior writing to the buffer while GDBserver touches memory, so that the inferior can correctly detect that GDBserver had been - there, otherwise, it could mistakingly think its commit was + there, otherwise, it could mistakenly think its commit was successful; that's implemented by simply having GDBserver set a breakpoint the inferior hits if it is the critical region. From patchwork Fri Mar 21 14:42:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 108831 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 40D49385701A for ; Fri, 21 Mar 2025 15:30:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40D49385701A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TmmKqW56; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=u2yGJidf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TmmKqW56; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=u2yGJidf X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D06053857C78 for ; Fri, 21 Mar 2025 14:43:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D06053857C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D06053857C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568218; cv=none; b=hAW0ndEQUyAaYi9p1t6VqVzLiiYss7u/juWgvjT/W0SQPEgOidl6kAyu7ERb35fYUsmQv+G6Glu344OtosuM+AlrUJjRna1+sCnhWy19Znch9D5nr6G8CSaIyACGsRAH+KGg7AcEdqO1HbrtKsMOCWDPmCFrndbI+6iB631JFuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568218; c=relaxed/simple; bh=SeRRDfzjXB34DYgY0Dg9Iejvc6osucMgMA83mzVbs2s=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=ENlTLvyYj8hwcOQYAvF8QhE789I6+AJg7rj+K92q+xajcyQuKAncoZO1m2StgCjsI6g6hQAY7Flwc+sbGd5duBqEjKFCO0BElhbTKc9I59InX7lOaRDGuK6mZG3nVql8C0IWthq1RK1j7u7lrc5sh5SLfSrAlBNqCtOmJdMAWUw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 52F2F2128C for ; Fri, 21 Mar 2025 14:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yzO11ZXrgpxK8BDhcVq0j1yyT/4RSgN3Ehta4RwwlIM=; b=TmmKqW56OfRVLanDK62P/hS5QaxV1GM/gVmz87Xr+Q0Je1GLf/kNESbkrNPBfl6/R3DSZ1 lZjrEs2/Z9fqJcF8hMGEQv8fRlhgYp3L5HkKcOuE3NOZEFxMzQo62Wtq8iVDhjsX58IrFH cIpJ7p+uqsWb95akQfZhNhgQ8UEfFHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yzO11ZXrgpxK8BDhcVq0j1yyT/4RSgN3Ehta4RwwlIM=; b=u2yGJidfMjL7OxzqLX6EL7BFJ8TyT0YJwHSMe1zauUddNEApIHA4fZc3IukgyO1/uu75vs 97g9yFYlhY/tSmCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TmmKqW56; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=u2yGJidf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yzO11ZXrgpxK8BDhcVq0j1yyT/4RSgN3Ehta4RwwlIM=; b=TmmKqW56OfRVLanDK62P/hS5QaxV1GM/gVmz87Xr+Q0Je1GLf/kNESbkrNPBfl6/R3DSZ1 lZjrEs2/Z9fqJcF8hMGEQv8fRlhgYp3L5HkKcOuE3NOZEFxMzQo62Wtq8iVDhjsX58IrFH cIpJ7p+uqsWb95akQfZhNhgQ8UEfFHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yzO11ZXrgpxK8BDhcVq0j1yyT/4RSgN3Ehta4RwwlIM=; b=u2yGJidfMjL7OxzqLX6EL7BFJ8TyT0YJwHSMe1zauUddNEApIHA4fZc3IukgyO1/uu75vs 97g9yFYlhY/tSmCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3340B13A68 for ; Fri, 21 Mar 2025 14:42:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oJMlC9h63WfhBQAAD6G6ig (envelope-from ) for ; Fri, 21 Mar 2025 14:42:32 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 4/5] [gdb/contrib] Add SME to codespell-ignore-words.txt Date: Fri, 21 Mar 2025 15:42:50 +0100 Message-ID: <20250321144251.23618-5-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250321144251.23618-1-tdevries@suse.de> References: <20250321144251.23618-1-tdevries@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: 52F2F2128C X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:mid, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -3.01 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Ignore the following codespell detection: ... $ codespell --config gdbserver/setup.cfg gdbserver gdbserver/linux-aarch64-low.cc:827: SME ==> SAME, SEME, SOME, SMS ... by adding SME to codespell-ignore-words.txt. --- gdb/contrib/codespell-ignore-words.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/contrib/codespell-ignore-words.txt b/gdb/contrib/codespell-ignore-words.txt index a8287f71286..2b9d878c853 100644 --- a/gdb/contrib/codespell-ignore-words.txt +++ b/gdb/contrib/codespell-ignore-words.txt @@ -1,3 +1,4 @@ configury invokable useable +SME From patchwork Fri Mar 21 14:42:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 108850 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 800E7385703C for ; Fri, 21 Mar 2025 15:54:21 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 3AFC33857839 for ; Fri, 21 Mar 2025 14:44:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3AFC33857839 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3AFC33857839 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568247; cv=none; b=vwPsEESa9C9IHRXArOY0LcVo0xvNr2tQtY+rcGt6dNIa+Pccq65RQgM7D9CrbF/aIUKHjHjn6dT3xhtz+3yJMbtyxu7JS14gM0ZmMrVy7PDPak2tOPiBkzMpdpet3cKoJ1bSYWspeaLLJRpkE9QkFbA7l/pKKTxKKuZL1Mrq6Xw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742568247; c=relaxed/simple; bh=/oou1XBsgmNBMGT4ZpDwDjnGQNqAQvPKbl/3wQDxLXQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=ZqczNWs/8SdcnSzayX2WaFam96TeOCvBfllpX/MBxOnj5St3Vl/qLvu2MZeDwRbu0/d1WtNvfxLZ/ZdBFRtUyqd3jvrNxiRKgtG4M8oXrksEPGsV1xUMoVt3GdBh2lPNvqdGk3nEIrJnFMwIi2dxYzxc0Nvod/KmtAKTJoopAQk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7DBF421292 for ; Fri, 21 Mar 2025 14:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8pK5VCvdStEPWjdeJuOke3HjSvWzO4QheSDX0bHKOLo=; b=nHfeESp1UfGbe4QPtyfwGo40+KALyaS6t2mrNt+I3nQv2oeUtsacwmwwdlC08z32FPAnAp E2jOipT0iYqXuZztrKoqTa3npSYJRCBTfZe+mkS6RlqNDmUKUQwraxarCImDoTcgLTWGqa 49FDomyRLCmjyttUniBN4HKf7R+drKo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8pK5VCvdStEPWjdeJuOke3HjSvWzO4QheSDX0bHKOLo=; b=cYnT3S3FHW3C5g3jNyvHXRZcQDgGdiC0OAFQMAZ/pypAXFdm+kr2XCvM8HchC46L9r/GRM Lg5OaLFgsxCifECA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nHfeESp1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cYnT3S3F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8pK5VCvdStEPWjdeJuOke3HjSvWzO4QheSDX0bHKOLo=; b=nHfeESp1UfGbe4QPtyfwGo40+KALyaS6t2mrNt+I3nQv2oeUtsacwmwwdlC08z32FPAnAp E2jOipT0iYqXuZztrKoqTa3npSYJRCBTfZe+mkS6RlqNDmUKUQwraxarCImDoTcgLTWGqa 49FDomyRLCmjyttUniBN4HKf7R+drKo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742568152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8pK5VCvdStEPWjdeJuOke3HjSvWzO4QheSDX0bHKOLo=; b=cYnT3S3FHW3C5g3jNyvHXRZcQDgGdiC0OAFQMAZ/pypAXFdm+kr2XCvM8HchC46L9r/GRM Lg5OaLFgsxCifECA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5B09513A2C for ; Fri, 21 Mar 2025 14:42:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gO3NFNh63WfhBQAAD6G6ig (envelope-from ) for ; Fri, 21 Mar 2025 14:42:32 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 5/5] [precommit] Add codespell hook Date: Fri, 21 Mar 2025 15:42:51 +0100 Message-ID: <20250321144251.23618-6-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250321144251.23618-1-tdevries@suse.de> References: <20250321144251.23618-1-tdevries@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: 7DBF421292 X-Spam-Score: -3.01 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Add a pre-commit codespell hook for directories gdbsupport and gdbserver, which are codespell-clean: ... $ pre-commit run codespell --all-files codespell................................................................Passed ... A non-trivial question is where the codespell configuration goes. Currently we have codespell sections in gdbsupport/setup.cfg and gdbserver/setup.cfg, but codespell doesn't automatically use those because the pre-commit hook runs codespell at the root of the repository. A solution would be to replace those 2 setup.cfg files with a setup.cfg in the root of the repository. Not ideal because generally we try to avoid adding files related to subdirectories at the root. Another solution would be to add two codespell hooks, one using --config gdbsupport/setup.cfg and one using --config gdbserver/setup.cfg, and add a third one once we start supporting gdb. Not ideal because it creates duplication, but certainly possible. I went with the following solution: a setup.cfg file in gdb/contrib (alongside codespell-ignore-words.txt) which is used for both gdbserver and gdbsupport. So, what can this new setup do for us? Let's demonstrate by simulating a typo: ... $ echo "/* aways */" >> gdbsupport/agent.cc ... We can check unstaged changes before committing: ... $ pre-commit run codespell --all-files codespell................................................................Failed - hook id: codespell - exit code: 65 gdbsupport/agent.cc:282: aways ==> always, away ... Likewise, staged changes (no need for the --all-files): ... $ git add gdbsupport/agent.cc $ pre-commit run codespell codespell................................................................Failed - hook id: codespell - exit code: 65 gdbsupport/agent.cc:282: aways ==> always, away ... Or we can try to commit, and run into the codespell failure: ... $ git commit -a black................................................(no files to check)Skipped flake8...............................................(no files to check)Skipped isort................................................(no files to check)Skipped codespell................................................................Failed - hook id: codespell - exit code: 65 gdbsupport/agent.cc:282: aways ==> always, away check-include-guards.................................(no files to check)Skipped ... which makes the commit fail. --- .pre-commit-config.yaml | 6 ++++++ {gdbserver => gdb/contrib}/setup.cfg | 4 +++- gdbsupport/agent.cc | 1 + gdbsupport/setup.cfg | 4 ---- 4 files changed, 10 insertions(+), 5 deletions(-) rename {gdbserver => gdb/contrib}/setup.cfg (64%) delete mode 100644 gdbsupport/setup.cfg diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index be3ee825575..88288e044ec 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -65,6 +65,12 @@ repos: - id: isort types_or: [file] files: 'gdb/.*\.py(\.in)?$' + - repo: https://github.com/codespell-project/codespell + rev: v2.4.1 + hooks: + - id: codespell + files: '^(gdbsupport|gdbserver)/' + args: [--config, gdb/contrib/setup.cfg] - repo: local hooks: - id: check-include-guards diff --git a/gdbserver/setup.cfg b/gdb/contrib/setup.cfg similarity index 64% rename from gdbserver/setup.cfg rename to gdb/contrib/setup.cfg index 08646b8ea19..71459fe5471 100644 --- a/gdbserver/setup.cfg +++ b/gdb/contrib/setup.cfg @@ -1,4 +1,6 @@ [codespell] + # Skip ChangeLogs and generated files. -skip = ChangeLog*,configure +skip = */ChangeLog*,*/configure,gdbsupport/Makefile.in + ignore-words = gdb/contrib/codespell-ignore-words.txt diff --git a/gdbsupport/agent.cc b/gdbsupport/agent.cc index c70b59a4c83..be14a57f627 100644 --- a/gdbsupport/agent.cc +++ b/gdbsupport/agent.cc @@ -279,3 +279,4 @@ agent_capability_invalidate (void) { agent_capability = 0; } +/* aways */ diff --git a/gdbsupport/setup.cfg b/gdbsupport/setup.cfg deleted file mode 100644 index e3e92988fd7..00000000000 --- a/gdbsupport/setup.cfg +++ /dev/null @@ -1,4 +0,0 @@ -[codespell] -# Skip ChangeLogs and generated files. -skip = ChangeLog*,Makefile.in,configure -ignore-words = gdb/contrib/codespell-ignore-words.txt