From patchwork Sun Mar 9 20:34:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 107563 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1F333858D37 for ; Sun, 9 Mar 2025 20:35:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1F333858D37 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=NRSdkWsn X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by sourceware.org (Postfix) with ESMTPS id AADB83858D1E for ; Sun, 9 Mar 2025 20:34:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AADB83858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AADB83858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741552488; cv=none; b=IOBUEIvfqqE7+3pwmeMa6plzXdNYUN6bvNG7vbTVLqKjP8qBjhBAIo8Wi05zAyWC2EzFwptVx0nMuPFoHNjPgnAdFalrttRpZwj1tmrySl82FO8vOklp/BScHZBqAgQUuTGGj++5MS/sudS+Dm/TkoeruQo6E0TEhs83Nax9FCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741552488; c=relaxed/simple; bh=TSLcj3dESVv6koEWaTsJkjoHeYQpmq5N6u5z7MeqIRs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cU0TVVnDwIQp5iSeJEdQ5qyPcX0hhZxzYFIgpO71vYlDouN7HDXDkXXywr+SH2ElCH6+p0uLqNyC31ciKhssjhyxGKScahDUSAUL9dUHgjUVb6JCNgjq12xYsyDUYbRd3++mUWOKgP+l88IhwLecfQ0TKHdacRfqEDs8zwI8g94= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AADB83858D1E Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 529DHFvA012347 for ; Sun, 9 Mar 2025 20:34:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=QCfi0foPUvdX+8uzx0GTYW YLpqbqYumi3RbTP4hUr8g=; b=NRSdkWsnzf+K0NjcG7s8Fp82xBRZJndz+RRXn/ iYctXa5cMjghOmBJVoAcWcWDRBGXMqxl+tSBoKjDRdawn8Sc7ppV6vVIu9y7F+S1 X8KJP3GJrFxA8a9iNrlGj1fTQb96hn77K59v8UEVJkQYflz+ROJBkF/pnz2QYH9r 3hU3bDmj2nmcM0iVNyEuO5Uk4AIRk7LvJo6sAtBRgin+3gSqOREGUQBa/afmeb0V PdpdRLg0En3vJlTo9lXmHoi5T5SO5ETsibn4P4EAeLQuWQc3tGY/Ipx7sJQv199e Sy6stxPwGaBoAsuC41SaFBjXbISAjk4NjGBezYhhiRihyFOw== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 458f6aarc1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 09 Mar 2025 20:34:47 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 529KYl5M011112 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 9 Mar 2025 20:34:47 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Sun, 9 Mar 2025 13:34:46 -0700 From: Andrew Pinski To: CC: Andrew Pinski Subject: [PATCH v2] testcase: Add testcase for shrink wrapping of vector::push_back [PR118502] Date: Sun, 9 Mar 2025 13:34:36 -0700 Message-ID: <20250309203436.1826325-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=WsDRMcfv c=1 sm=1 tr=0 ts=67cdfb67 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=3H110R4YSZwA:10 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=E1-Eli9FcE8E6jaBec4A:9 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 1QoTEl7kzgf5mkUnf2PbXspR827PmSYI X-Proofpoint-ORIG-GUID: 1QoTEl7kzgf5mkUnf2PbXspR827PmSYI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-09_08,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503090168 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org LLVM folks noticed that GCC was shrink wrapping the call to vector::push_back. So I thought it was a good idea to commit a testcase to make sure GCC does not regress in this area unknowning. Note the shrink wrapping started with r15-1619-g3b9b8d6cfdf593. Note this enables the testcase for x86_64 (!ia32), powerpc, aarch64 and riscv which I tested via godbolt to see the shrink wrapping occurs. Also tested the testcase for both x86_64-linux-gnu and aarch64-linux-gnu to make sure I got the target selects correct. Changes since v1: * v2: Fix some comments typos that was mentioned in the bug report. PR rtl-optimization/118502 gcc/testsuite/ChangeLog: * g++.dg/opt/shrink-wrapping-vector-1.C: New test. Signed-off-by: Andrew Pinski --- .../g++.dg/opt/shrink-wrapping-vector-1.C | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 gcc/testsuite/g++.dg/opt/shrink-wrapping-vector-1.C diff --git a/gcc/testsuite/g++.dg/opt/shrink-wrapping-vector-1.C b/gcc/testsuite/g++.dg/opt/shrink-wrapping-vector-1.C new file mode 100644 index 00000000000..8b1ad53fa80 --- /dev/null +++ b/gcc/testsuite/g++.dg/opt/shrink-wrapping-vector-1.C @@ -0,0 +1,17 @@ +// { dg-do compile { target { { { i?86-*-* x86_64-*-* } && { ! ia32 } } || { powerpc*-*-* aarch64*-*-* riscv*-*-* } } } } +// { dg-options "-O2 -fdump-rtl-pro_and_epilogue" } +// { dg-skip-if "requires hosted libstdc++ for vector" { ! hostedlib } } + +// PR rtl-optimization/118502 + +// The shrink-wrapping should happen around the slow path of vector::push_back, +// The fast path is just checking if there is enough space and doing a few stores. +// We want to verify that shrink wrapping always happens. + +#include + +void push_back(std::vector& xs, unsigned char x) { + xs.push_back(x); +} + +/* { dg-final { scan-rtl-dump "Performing shrink-wrapping" "pro_and_epilogue" } } */