From patchwork Fri Feb 14 21:35:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 106557 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 75DD83858C33 for ; Fri, 14 Feb 2025 21:37:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75DD83858C33 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=V4traP9/ X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id B589C3858C39 for ; Fri, 14 Feb 2025 21:35:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B589C3858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B589C3858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739568957; cv=none; b=QdAr0bMhKL1S31stAPT4tm3RldxXMByqantyi0D7K7tDla+ELU419jyPZGikH5x9gengQDgbYZejD2X/BM33jF3B7flB5LXlzO+1lpLS9QyXwLXgPKuNDx9/bs4mOUd5EMqSoLW5NBgeJ+booAn2sa5FT4Bae1k8Cz1EApw3Za0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739568957; c=relaxed/simple; bh=gm+nvoDKKC7VOn3PYqDCsPeuOcEhYt3GEwOP5ga/9O0=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=wHBIcCp+GJeyEr+uLXk10frVaO/mcJR4xJbiek/+JsuoIk1/vPb0FG6XWwqWPD3jjYPyacprrMimRqOyDwD1znfVdK7LwKevq7GIvD9UNvCWw7S+wRlSCd3SCTdZnXjJi0SReK7YvWCmUyaWm/6+3b43/VY4p9jTCCZP8prNKsE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B589C3858C39 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-43962f7b0e4so15366795e9.3 for ; Fri, 14 Feb 2025 13:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739568950; x=1740173750; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vEhMKHBv3ldfTXM2EEWtfHpJhKRCLiv++BkYIcZnlxk=; b=V4traP9/96p25RzjuyYp+KXMwSnCaNT3QNJoJxR/BpgZXmMi+OlUKrYo68NGdsQVdS PeWMLO5RwYM1sJyUZPxG/LUnH4T2g2OTAGrN7Zk985EMIyuY7PIPBpbypWAnQt7KCrok tfLJczotZsBBmBaYklouXLNxMg+tZckDBTvnyAjCkqguzkb4aAWdDPQV1DhsFYR5OzRp yrnlfspkBho/pSr/bgyFo19SiMtqJuDPCDiVH9IvqEorxVQ45p3RWGItfniZh72pxEPH yvAzY4a1eNhhnJyqW+bDJgzw6R00kMbKFMwWlvYspGvXkdY1cv/NkgyONCndA6otXp5C 9yGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739568950; x=1740173750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vEhMKHBv3ldfTXM2EEWtfHpJhKRCLiv++BkYIcZnlxk=; b=WS3WLEMfC/tFAnI550EWxFx1shqIsdrMfAvKfLc/yCHxNeONmR0j9fjdUan3qLr6IU DmqWZwf05f01+9QkiRAd4dyAQ9utjneWLAlnlkTSUhgszCgCep6AKZU4dRXSGIPFAmhk NYTGqyD7UaY8xYYdRO9s5iGr8OOXe64l0XJSU6SchedfN3WzccK2ZTfpcKq70lwb2tXr ytqtLVRzcu7BomFbtCddVIIhUJ7cz61rCBc4I2w3vaceVzM+OxVt3A/DO/avG67qOjQ2 aFrr/C4oWD5Lu1QaaNKEGlbNl++Bic2hXm1qC2mkyzn6NAedKFik5aezmUq3bVu43ovh KAkw== X-Gm-Message-State: AOJu0Yw+QVI6dHwL/m+TKPzSFRvJ4y75LQnTwShlOeBOwpzzn0V6tjXb v28ytdrCPzL5S3Fyid+S0n7YOu+DQpIFAXRNQVdcDTyPoNIWGn0+t8lkW5FcOK2AcvD7bMt02qP 9ifg= X-Gm-Gg: ASbGnctBUJ/z/q7RivAHlBqbPNbGlHq6q83/tSU8WUaCtD3/cQ2IVJ4rW0/cJQaJQLV GiLR70xFGitRgF2xwUXZRMZ7F9V4fsAm6St5eaGPRYGfakavlUZ0qqGI5DgzJAzZggjTRdIrjkh Ho7rI7EDV708wzaJxggZrvQKKieGQcjoeTQOr7jnWUIN8wuFmyJNaUMzzpMgUtrud5xoxq8CsFw 2TIUBQ3f8XJIt1sJePy6/l//36DXZUgtFaugt2PcUFk4K4ShjNWujG7Jdv4LO7+hMMP5Ls7Gt9N U/sbLtyIp1OqCoKDwosCO/96jaaX++yn7wSaKS5zL1YGOQ0NEhUSegSYGYsgfLFXwKc7ADVT2Rc 3gSDxsZwvQ70JekOMmhqKZ3bU4b4hc+7N X-Google-Smtp-Source: AGHT+IEVmSyX8HYzf7ozIT+QN7pfek3KpVfEhNl75s9iqu7YorE/y9r8wc0Ir/RSNHOv8jH1gjKVVg== X-Received: by 2002:a05:600c:1c28:b0:439:42c6:f11f with SMTP id 5b1f17b1804b1-4396e6ab033mr11111905e9.4.1739568950143; Fri, 14 Feb 2025 13:35:50 -0800 (PST) Received: from dem-tschwing-1.schwinge.ddns.net (p200300c8b71232008b8a1c4003161d48.dip0.t-ipconnect.de. [2003:c8:b712:3200:8b8a:1c40:316:1d48]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4395a06cf2fsm84670815e9.19.2025.02.14.13.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2025 13:35:49 -0800 (PST) From: Thomas Schwinge To: gcc-patches@gcc.gnu.org Cc: tdevries@suse.de Subject: [PUSHED] nvptx: Clarify 'nvptx_output_skip' case of no or incomplete initializer Date: Fri, 14 Feb 2025 22:35:25 +0100 Message-Id: <20250214213525.1342539-1-tschwinge@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <56674729.2030604@acm.org> References: <56674729.2030604@acm.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org I was getting confused about 'nvptx_output_skip' in certain cases not doing anything at all; write down and 'assert' what I found. gcc/ * config/nvptx/nvptx.cc (nvptx_output_skip): Clarify case of no or incomplete initializer. --- gcc/config/nvptx/nvptx.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gcc/config/nvptx/nvptx.cc b/gcc/config/nvptx/nvptx.cc index 060f45318f4..6f364619205 100644 --- a/gcc/config/nvptx/nvptx.cc +++ b/gcc/config/nvptx/nvptx.cc @@ -2391,6 +2391,12 @@ nvptx_output_skip (FILE *, unsigned HOST_WIDE_INT size) if (size) nvptx_assemble_value (0, size); } + else + /* Otherwise, we don't have to do anything: this skip terminates the + initializer; we skip either the full ('!init_frag.started' case) or the + remainder ('init_frag.started' case) of the initializer (that is, either + no or incomplete initializer). */ + gcc_checking_assert (size == init_frag.remaining * init_frag.size); } /* Output a string STR with length SIZE. As in nvptx_output_skip we