From patchwork Mon Feb 3 22:01:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Polacek X-Patchwork-Id: 105954 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 611A4385840A for ; Mon, 3 Feb 2025 22:04:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 611A4385840A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hl30b4BO X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7A4A4385840E for ; Mon, 3 Feb 2025 22:01:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A4A4385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7A4A4385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738620081; cv=none; b=Y+X2xnXNKw660Nz8UHpAcw6M3L2GlkQTgYm/hXFxmffSzW67X4tnm33rw4Sxw1jqA2115DMsI81prm6xwoLHev34nTSDvwWqNsKzUFK3olzt9/XWXQH14wr8YTC/AMJ0J10On6/bqg1B8g/BxYa1qzVa98mJSh53RQGP/VrBSMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738620081; c=relaxed/simple; bh=ZjoFJcD7pRXkF+ausUXlLRWEd8NsJWbQofUvq/6VexM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qODsT60+udqH0m0Gw29Brv7R/RMHEWS+8a/4x1GP93ChhWiF0pFVDlif4NuAV9j3hyAGMMyoxr4pgxjoH+7K60yNnnN8QWGRnM6Ilb0yiGuOi1NZuF2bx3EVY5wtzwnYhqqnmVacKSHJEOrBtunjCzXEVL/ITaZczuZBoYlHo3Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A4A4385840E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738620080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O2AcQang6Of2VqBEc01mBhunxpkKkI18XUei+JxtQSc=; b=hl30b4BO5Bs2h8Up5OY9KR4HlXRNaH8Pw+YgYNUufvzdLuHyXX+cUmCn+vj9+P1vieqdfu Io++jixmUuD7SMK4moMlv7Ttl9J6+cvmnvaZi1+fNCMAQPj+wvnqGwBVkf2HLDxboAQlsE trqY1u/iyHfzI2skNzIOA7L3KTgJlBE= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-oPUJ1d2oO-m8rvXNuNGiwg-1; Mon, 03 Feb 2025 17:01:16 -0500 X-MC-Unique: oPUJ1d2oO-m8rvXNuNGiwg-1 X-Mimecast-MFC-AGG-ID: oPUJ1d2oO-m8rvXNuNGiwg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 05D5F18009E9 for ; Mon, 3 Feb 2025 22:01:15 +0000 (UTC) Received: from pdp-11.lan (unknown [10.22.64.70]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0FA6430001BE; Mon, 3 Feb 2025 22:01:13 +0000 (UTC) From: Marek Polacek To: Jason Merrill , GCC Patches Subject: [PATCH] c++: ICE on invalid 'tor with =default [PR118304] Date: Mon, 3 Feb 2025 17:01:10 -0500 Message-ID: <20250203220110.58445-1-polacek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _PawOm8BbJ7K7HwKvWE-dOqJbZc8GU7Kafu3kt8AFGk_1738620075 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- In this PR we crash in maybe_delete_defaulted_fn because the switch doesn't expect a cfk_constructor/_destructor. But we can get there: struct A { *A() = default; }; is invalid due to the void/void* mismatch, so we get to m_d_d_fn: if (!same_type_p (TREE_TYPE (TREE_TYPE (fn)), TREE_TYPE (TREE_TYPE (implicit_fn))) maybe_delete_defaulted_fn (fn, implicit_fn); Currently, we give no error (subject to c++/118306), but even if we did, we should probably return early in maybe_delete_defaulted_fn. PR c++/118304 gcc/cp/ChangeLog: * method.cc (maybe_delete_defaulted_fn): Return early for cdtors. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/defaulted70.C: New test. --- gcc/cp/method.cc | 10 +++++++++- gcc/testsuite/g++.dg/cpp0x/defaulted70.C | 9 +++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/defaulted70.C base-commit: 214224c4973bfb76f73a7efff29c5823eef31194 diff --git a/gcc/cp/method.cc b/gcc/cp/method.cc index 3914bbb1ef2..99e247125c3 100644 --- a/gcc/cp/method.cc +++ b/gcc/cp/method.cc @@ -3531,10 +3531,18 @@ maybe_delete_defaulted_fn (tree fn, tree implicit_fn) if (DECL_ARTIFICIAL (fn) || !DECL_DEFAULTED_IN_CLASS_P (fn)) return; + const special_function_kind kind = special_function_p (fn); + if (kind == sfk_constructor || kind == sfk_destructor) + { + /* FIXME: This is ill-formed, and we should have given an error. + But this is only going to be fixed in GCC 16 via c++/118306. */ + gcc_assert (true || seen_error ()); + return; + } + DECL_DELETED_FN (fn) = true; auto_diagnostic_group d; - const special_function_kind kind = special_function_p (fn); tree parmtype = TREE_VALUE (DECL_XOBJ_MEMBER_FUNCTION_P (fn) ? TREE_CHAIN (TYPE_ARG_TYPES (TREE_TYPE (fn))) diff --git a/gcc/testsuite/g++.dg/cpp0x/defaulted70.C b/gcc/testsuite/g++.dg/cpp0x/defaulted70.C new file mode 100644 index 00000000000..e269d9bc6a5 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/defaulted70.C @@ -0,0 +1,9 @@ +// PR c++/118304 +// { dg-do compile { target c++11 } } + +struct A { + *A() = default; // { dg-error "invalid" "PR118306" { xfail *-*-* } } + *~A() = default; // { dg-error "invalid" "PR118306" { xfail *-*-* } } +}; + +A a;