From patchwork Mon Feb 3 14:30:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 105930 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A140B3857C47 for ; Mon, 3 Feb 2025 14:31:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A140B3857C47 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=If4anHpP; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RkcW2JuY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=If4anHpP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RkcW2JuY X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 7D2893858294 for ; Mon, 3 Feb 2025 14:30:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D2893858294 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D2893858294 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738593042; cv=none; b=LcNhuXDyHpy5o1C70hx1VJHHBZufjcLJHumNdYW45w614tqo+mrGwjN+3PY8sSbZQaUKlFig5EpsReTAOOD0Pfeq8A3dXX3lK0vQlx4ism3AKg5BqkiFHkcHeWa9kl1BUVVHbKIsERcei8M1/4CzDkDmnSCzcjCCzWdR61lnNIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738593042; c=relaxed/simple; bh=CBMwEKF0fVLoj219YWeZjFVNJeWwL0v7u29O1IpzuC4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=AVPTazlyNd0yc3zR9O3/qJfS3m4kvsRs0xxOrPQmHYVpNND9G5i0fz2DY3jEtusPS8h5fTSZp2HVUdH0eD/cz9tJZNOPBGwkxqhvmdCPivoXyo5AWAc8fw2VgOMi4mzw/RMrVNwUk/2edk/Xvqj0zAcUQZ4oPl6Stbe72bqU5Gk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D2893858294 Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 76ED82115C; Mon, 3 Feb 2025 14:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738593041; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=02yhwZ4uEQ21PaRpJVDVRPSxsnFxxSX6Djb4o5krXI0=; b=If4anHpPA02nOeRGOPeeX5xnie21JAqvHi4kR1TJa6mN/g/Ne+Z2E582UpIH/zinkKKt5J 4Ga1LF9B5OO84HCDW52rOgaGthGqBCY2y/6zMHPxxLFDBVt7itnuIYhIgl3a6lpCGIFVrF FcQoDSLZCIAwBA9u1IaQ1xsHFaELLYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738593041; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=02yhwZ4uEQ21PaRpJVDVRPSxsnFxxSX6Djb4o5krXI0=; b=RkcW2JuY+2+XQZQIS5BGtaHtG01ibUqeZTtmrmFwFrHdwFiRklFOe6UM51/YByunZj+gNX /wdVD1myT7qOxiCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738593041; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=02yhwZ4uEQ21PaRpJVDVRPSxsnFxxSX6Djb4o5krXI0=; b=If4anHpPA02nOeRGOPeeX5xnie21JAqvHi4kR1TJa6mN/g/Ne+Z2E582UpIH/zinkKKt5J 4Ga1LF9B5OO84HCDW52rOgaGthGqBCY2y/6zMHPxxLFDBVt7itnuIYhIgl3a6lpCGIFVrF FcQoDSLZCIAwBA9u1IaQ1xsHFaELLYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738593041; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=02yhwZ4uEQ21PaRpJVDVRPSxsnFxxSX6Djb4o5krXI0=; b=RkcW2JuY+2+XQZQIS5BGtaHtG01ibUqeZTtmrmFwFrHdwFiRklFOe6UM51/YByunZj+gNX /wdVD1myT7qOxiCw== Date: Mon, 3 Feb 2025 15:30:41 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jakub Jelinek , avr@gjlay.de Subject: [PATCH] rtl-optimization/117611 - ICE in simplify_shift_const_1 MIME-Version: 1.0 X-Spam-Score: -1.25 X-Spamd-Result: default: False [-1.25 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.52)[-0.518]; NEURAL_HAM_SHORT(-0.13)[-0.665]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_THREE(0.00)[3] X-Spam-Level: X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Message-Id: <20250203143145.A140B3857C47@sourceware.org> The following checks we have a scalar int shift mode before enforcing it. As AVR shows the mode can be a signed _Accum mode as well. Bootstrap and regtest pending on x86_64-unknown-linux-gnu. OK if that succeeds? Thanks, Richard. PR rtl-optimization/117611 * combine.cc (simplify_shift_const_1): Bail if not scalar int mode. * gcc.target/avr/pr117611.c: New testcase. --- gcc/combine.cc | 6 ++++-- gcc/testsuite/gcc.target/avr/pr117611.c | 7 +++++++ 2 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/avr/pr117611.c diff --git a/gcc/combine.cc b/gcc/combine.cc index 90828108ba4..3beeb514b81 100644 --- a/gcc/combine.cc +++ b/gcc/combine.cc @@ -10635,8 +10635,10 @@ simplify_shift_const_1 (enum rtx_code code, machine_mode result_mode, outer_op, outer_const); } - scalar_int_mode shift_unit_mode - = as_a (GET_MODE_INNER (shift_mode)); + scalar_int_mode shift_unit_mode; + if (!is_a (GET_MODE_INNER (shift_mode), + &shift_unit_mode)) + return NULL_RTX; /* Handle cases where the count is greater than the size of the mode minus 1. For ASHIFT, use the size minus one as the count (this can diff --git a/gcc/testsuite/gcc.target/avr/pr117611.c b/gcc/testsuite/gcc.target/avr/pr117611.c new file mode 100644 index 00000000000..c76093f12d1 --- /dev/null +++ b/gcc/testsuite/gcc.target/avr/pr117611.c @@ -0,0 +1,7 @@ +/* { dg-do compile } */ +/* { dg-options "-Os" } */ + +_Accum acc1 (_Accum x) +{ + return x << 16; +}