From patchwork Thu Jan 23 12:09:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 105292 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2F861385840F for ; Thu, 23 Jan 2025 12:09:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F861385840F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=x5pvn4N8; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mkZlWLHo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=x5pvn4N8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mkZlWLHo X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 87AC83858D3C for ; Thu, 23 Jan 2025 12:09:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87AC83858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87AC83858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737634158; cv=none; b=Op6gScgm1S3goW0y30/cRTAI+w6Pl5ta1SQ4Nzi5bYHGnhX+QvysLi7TAJckEqRprSHsfUA8aCK4xfQW2iqJbcDs1+oImPqgleXMbJ8PnKxk+R0CiBYjoloEQrDCkCmREiwbZhFT5L1Rc1jmytRIN4fI9RnEq70dDPoTopXr57c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737634158; c=relaxed/simple; bh=UBNNbPoR1wW9vejfLSU70vMY8qMeBheqSoXN1maKeJY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=Vg/o01xPV9HjlsoaJ+h5OKdyMveauUbVTBlru6Y8RsrTjQL7MYt8XdBCfnN0ptXPYAaMSEXn6aX3MbH02qOn+nGo2fxsMwtz35VSqgAqUxucym6WSfY8RhqE58mTt2mEe7YQi9Ezu6FrIWzSYkdVhn3z0/gAtVk135jTHm0kmCE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87AC83858D3C Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5C5C81F37C for ; Thu, 23 Jan 2025 12:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737634157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=T4GZWydd3e3Y1/B0VnOkl+TL0KruROR7Y0TFmUwZDss=; b=x5pvn4N8sFHt5BYLKuszswjUiKsRsi2g3pba7VxoTcoLJ3MoMKIUnvnFMci6LYXLDiovmT YZDbNESRkiYyzEqrxNxFXxOTXSw+HFcfnDNN5O7+gUIn8Im8cm7XLhPuSNyKBSw1N7BEZv UfDkiK1eiDX8diolULmhYWV7f5XS7w4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737634157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=T4GZWydd3e3Y1/B0VnOkl+TL0KruROR7Y0TFmUwZDss=; b=mkZlWLHoeOXeuPqaOzBX5YJcE+F3drtGaqvS1XZXZNgkx9Vx0nXt0hEYokOKvmuQ2AiLtS nSg7OZHaRBIS+MBA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=x5pvn4N8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=mkZlWLHo DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737634157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=T4GZWydd3e3Y1/B0VnOkl+TL0KruROR7Y0TFmUwZDss=; b=x5pvn4N8sFHt5BYLKuszswjUiKsRsi2g3pba7VxoTcoLJ3MoMKIUnvnFMci6LYXLDiovmT YZDbNESRkiYyzEqrxNxFXxOTXSw+HFcfnDNN5O7+gUIn8Im8cm7XLhPuSNyKBSw1N7BEZv UfDkiK1eiDX8diolULmhYWV7f5XS7w4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737634157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=T4GZWydd3e3Y1/B0VnOkl+TL0KruROR7Y0TFmUwZDss=; b=mkZlWLHoeOXeuPqaOzBX5YJcE+F3drtGaqvS1XZXZNgkx9Vx0nXt0hEYokOKvmuQ2AiLtS nSg7OZHaRBIS+MBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4769C1351A for ; Thu, 23 Jan 2025 12:09:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Lg4bEG0xkmcQSAAAD6G6ig (envelope-from ) for ; Thu, 23 Jan 2025 12:09:17 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/testsuite] Fix gdb.ada/big_packed_array.exp on s390x-linux Date: Thu, 23 Jan 2025 13:09:39 +0100 Message-ID: <20250123120939.714-1-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: 5C5C81F37C X-Spam-Score: -3.01 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org When running test-case gdb.ada/big_packed_array.exp on s390x-linux, I run into: ... (gdb) print bad^M $2 = (0 => 0 , 1)^M (gdb) FAIL: gdb.ada/big_packed_array.exp: scenario=minimal: print bad ... This is with gcc 7.5.0, and this xfail should trigger: ... if { $have_xfail && [string is integer $last] \ && [expr ($last & 0xf) == 0] } { # gcc/101643 setup_xfail *-*-* } ... but it doesn't because $last is '1'. Fix this by using 0xf0 as mask for big endian. Tested on s390x-linux. --- gdb/testsuite/gdb.ada/big_packed_array.exp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) base-commit: 0c1b7977c93facc6e198da457e17559c0ba7b10b diff --git a/gdb/testsuite/gdb.ada/big_packed_array.exp b/gdb/testsuite/gdb.ada/big_packed_array.exp index 33b1dfd7634..6f030f368d8 100644 --- a/gdb/testsuite/gdb.ada/big_packed_array.exp +++ b/gdb/testsuite/gdb.ada/big_packed_array.exp @@ -21,6 +21,8 @@ standard_ada_testfile foo_ra24_010 set old_gcc [gnat_version_compare < 9] +set endian [target_endianness] + foreach_gnat_encoding scenario flags {all minimal} { lappend flags debug @@ -54,8 +56,13 @@ foreach_gnat_encoding scenario flags {all minimal} { } -re -wrap $re_xfail2 { set last $expect_out(1,string) + if { $endian == "little" } { + set mask 0x0f + } else { + set mask 0xf0 + } if { $have_xfail && [string is integer $last] \ - && [expr ($last & 0xf) == 0] } { + && [expr ($last & $mask) == 0] } { # gcc/101643 setup_xfail *-*-* }