From patchwork Wed Jan 15 11:48:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 104825 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E55EC385E017 for ; Wed, 15 Jan 2025 11:50:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E55EC385E017 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=jBBAuXem X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 32417385E000 for ; Wed, 15 Jan 2025 11:48:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32417385E000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 32417385E000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736941696; cv=none; b=iYYDZTdsard8vlU1RzlWX/S0HphAQT/LwBT3DvADFldbD5lVBCTJnhQuIazxUgVHkPmlFtbmxpVg7L4FyHG+APhlRGEMS5CyuSai/2YYm/FQpQmbhP4fwGLB37ykqRf1f8AUTw9POEBumSgJnuWXOSfuiS2wNJ+tP+/U9SbRmiA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736941696; c=relaxed/simple; bh=78kX16EE3BRytsZ7AhCNz5TVVpVrv9025BNRtfk1DVI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=qFS587pjsTtVny3hE/lf2JJ8NDy/gcl9rz5w3Ta66mPsfiOSSJjQNk+ukS8H1Zo4jbFRed22IQIIM7Rbsq8JM8ll/4kMTiSd8TbJfHgbVzbuY5M9qNwPOmBrBET/qAX4WuvhyAhfNRI0V2g3lQE7ylft0ZH85QIftgDU8XF/Otw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32417385E000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-21644aca3a0so145091455ad.3 for ; Wed, 15 Jan 2025 03:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736941695; x=1737546495; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=O/cX721rpCCJ8zSrxQsGnvgLi9Lxk+Az+p5CQLalUgY=; b=jBBAuXemPcuXxZOWhYSs+eTFUIcKoPox3MTmLt7cNviuXThOtR58nIZQpoi1zBVJ2L 6ibKr4v/75HCm8awzSrcbItPkohDy7xkc1Hon4aDDBSCGsxnCOQdTYZ6uusWLFBiD4VJ zduuxTFeZY8wdS9sY3fk/BpDimlUlkgeJ05686fmo5DE4kfPvioLucRZ5ECeis69nRsv LySqVJlnXmtOFxtW4aQthFQni1EGEbWpTTlc1CJ2sh9ik5EDYlPp18p1q7dLcg25szSU lpFunN50DRzZxBEKl+jnRCPdwNmmqLe2iLmbgBvjg2jQN19946il7jr+doP8NRF0Wqai GgOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736941695; x=1737546495; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O/cX721rpCCJ8zSrxQsGnvgLi9Lxk+Az+p5CQLalUgY=; b=vplWE3TYbGvqJGvaQU9yC8Fr5k5uvA2cb0SbIwwT8am+sWudtqHq8JVK6AmVnPnvuI LMYtNUSUmto5ndiY8LiE1hEj4lzbW5P9caWYVaMkh+hM6p53F5V57TSTutPTT9i9fp13 bxxnoBctKg3BwYqH0j7kHvh13TgJg6bP6VOvM050o9xN/CUzKEpnZVO7NkPkwv6fZC+K ODqjMmKiyORb/h5PqaJ45mlJqc8z0ECmkxgG8+7WUqWg6wkKPUdmKnSxgi12Oh1XdfHK /36PjHUmlYb1747r9mMXOf3V1sD+8nINtVZpZ3WFLqbugboaW0EWAepnFR6YTJdW2GP4 XLqg== X-Gm-Message-State: AOJu0YxTSkhxGeCxL2WmoVuoGiZfGKi0L4SPeTEkYxOuuRNHu1tB2I9l gp+j1Whuje4naTG0Yu6wzvgPvJ8K+40K7eDsYrEYsbwt4RXpfBIRlu8Ccg== X-Gm-Gg: ASbGncvx0kt3OiRUfs9RU5zGR0hS7ot3qNLSsh0JZ3zeBNGocKM73LCjNcg7spyDMeh UdUgFkuBvvNyqu/Jk8nF1JAxpxSBs8myuIHQsdag5Pa7S9vdbHNW492nx9DQFmvvN+eH5OdqjsH TNIqR6EFUmkWc45BgL5C7V7fXIRu0vhobhQjrwKEVk/pxslDTkZkwFAphTBXfb0ZCcKImLV5xX4 Sb7aw7ZsibXMm40e5e+1hRJu4pAeLTOO/PCgqsFWGQFQ9Ul4AO9UgkMw8OrBTIsuAg6Mw== X-Google-Smtp-Source: AGHT+IFSBNBN+5ngsNifW3m1T6QDt5OQGaRrjfAhI7LlzbI7RXKp5n33IkBfJUHZ41sDrnkqAsn+9g== X-Received: by 2002:a05:6a20:cd8f:b0:1e1:adcd:eae5 with SMTP id adf61e73a8af0-1e88d0fc495mr40760568637.42.1736941694980; Wed, 15 Jan 2025 03:48:14 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:4703:c009:5064:1d87]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-a318eea5b31sm9640121a12.39.2025.01.15.03.48.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 03:48:14 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 1A0D01140713; Wed, 15 Jan 2025 22:18:12 +1030 (ACDT) Date: Wed, 15 Jan 2025 22:18:12 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Fix known minor objdump leak Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org * objdump.c (main): Free disassembler_options. diff --git a/binutils/objdump.c b/binutils/objdump.c index 80044dea580..ebe586e0e3a 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -6001,12 +6001,14 @@ main (int argc, char **argv) { char *options; if (disassembler_options) - /* Ignore potential memory leak for now. */ options = concat (disassembler_options, ",", optarg, (const char *) NULL); else - options = optarg; + options = xstrdup (optarg); + free (disassembler_options); disassembler_options = remove_whitespace_and_extra_commas (options); + if (!disassembler_options) + free (options); } break; case 'j':