From patchwork Fri Oct 29 03:18:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 46774 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E6523857832 for ; Fri, 29 Oct 2021 03:18:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E6523857832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635477530; bh=mkR7O1GZfVK8VbUPRiAZSli3Pl9XV0Yh8zcKiZBPKvg=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=XWGst7zI/hyhJdWXXfcPG8A87EGwwzDKmzqpns4zyCRoCuiGiN8rciImg9jwOlqxp +BKiXnGToPgAXYQZN/dFMAn/EvQ3xTZNTQoMO46aEjnMErq2Z7zASpl7MQnKh2uSMW z/pPDX88sn6NZDQDIHL0BnShqlMQz6Dfg/BB4LrM= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from bat.birch.relay.mailchannels.net (bat.birch.relay.mailchannels.net [23.83.209.13]) by sourceware.org (Postfix) with ESMTPS id 544243858C39 for ; Fri, 29 Oct 2021 03:18:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 544243858C39 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 48ED8E09A4; Fri, 29 Oct 2021 03:18:21 +0000 (UTC) Received: from pdx1-sub0-mail-a53.g.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C21ACE06BE; Fri, 29 Oct 2021 03:18:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a53.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.97.65.133 (trex/6.4.3); Fri, 29 Oct 2021 03:18:21 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Shoe-Dime: 261f9c75594d4dc5_1635477501109_140638134 X-MC-Loop-Signature: 1635477501109:274626184 X-MC-Ingress-Time: 1635477501109 Received: from pdx1-sub0-mail-a53.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a53.g.dreamhost.com (Postfix) with ESMTP id 5599E7F78B; Thu, 28 Oct 2021 20:18:20 -0700 (PDT) Received: from rhbox.redhat.com (unknown [1.186.223.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a53.g.dreamhost.com (Postfix) with ESMTPSA id 067647F6B4; Thu, 28 Oct 2021 20:18:17 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a53 To: libc-alpha@sourceware.org Subject: [PATCH] Handle NULL input to malloc_usable_size [BZ #28506] Date: Fri, 29 Oct 2021 08:48:02 +0530 Message-Id: <20211029031802.254600-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3493.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Siddhesh Poyarekar via Libc-alpha From: Siddhesh Poyarekar Reply-To: Siddhesh Poyarekar Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Hoist the NULL check for malloc_usable_size into its entry points in malloc-debug and malloc and assume non-NULL in all callees. This fixes BZ #28506 Signed-off-by: Siddhesh Poyarekar --- malloc/malloc-debug.c | 12 ++++++------ malloc/malloc.c | 23 ++++++++++------------- malloc/tst-malloc-usable.c | 21 ++++++++------------- 3 files changed, 24 insertions(+), 32 deletions(-) diff --git a/malloc/malloc-debug.c b/malloc/malloc-debug.c index 9922ef5f25..5e954d7dc2 100644 --- a/malloc/malloc-debug.c +++ b/malloc/malloc-debug.c @@ -399,17 +399,17 @@ strong_alias (__debug_calloc, calloc) size_t malloc_usable_size (void *mem) { + if (mem == NULL) + return 0; + if (__is_malloc_debug_enabled (MALLOC_MCHECK_HOOK)) return mcheck_usable_size (mem); if (__is_malloc_debug_enabled (MALLOC_CHECK_HOOK)) return malloc_check_get_size (mem); - if (mem != NULL) - { - mchunkptr p = mem2chunk (mem); - if (DUMPED_MAIN_ARENA_CHUNK (p)) - return chunksize (p) - SIZE_SZ; - } + mchunkptr p = mem2chunk (mem); + if (DUMPED_MAIN_ARENA_CHUNK (p)) + return chunksize (p) - SIZE_SZ; return musable (mem); } diff --git a/malloc/malloc.c b/malloc/malloc.c index 2ba1fee144..9a345572a1 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -5008,29 +5008,26 @@ static size_t musable (void *mem) { mchunkptr p; - if (mem != 0) - { - size_t result = 0; + size_t result = 0; - p = mem2chunk (mem); + p = mem2chunk (mem); - if (chunk_is_mmapped (p)) - result = chunksize (p) - CHUNK_HDR_SZ; - else if (inuse (p)) - result = memsize (p); + if (chunk_is_mmapped (p)) + result = chunksize (p) - CHUNK_HDR_SZ; + else if (inuse (p)) + result = memsize (p); - return result; - } - return 0; + return result; } #if IS_IN (libc) size_t __malloc_usable_size (void *m) { - size_t result; + size_t result = 0; - result = musable (m); + if (m != NULL) + result = musable (m); return result; } #endif diff --git a/malloc/tst-malloc-usable.c b/malloc/tst-malloc-usable.c index a1074b782a..cd5c27cfcd 100644 --- a/malloc/tst-malloc-usable.c +++ b/malloc/tst-malloc-usable.c @@ -21,29 +21,24 @@ #include #include #include +#include +#include static int do_test (void) { size_t usable_size; void *p = malloc (7); - if (!p) - { - printf ("memory allocation failed\n"); - return 1; - } + TEST_VERIFY_EXIT (p != NULL); usable_size = malloc_usable_size (p); - if (usable_size != 7) - { - printf ("malloc_usable_size: expected 7 but got %zu\n", usable_size); - return 1; - } - + TEST_VERIFY_EXIT (usable_size == 7); memset (p, 0, usable_size); free (p); + + TEST_VERIFY_EXIT (malloc_usable_size (NULL) == 0); + return 0; } -#define TEST_FUNCTION do_test () -#include "../test-skeleton.c" +#include "support/test-driver.c"