From patchwork Wed Jan 1 12:39:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 103843 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 60E5E3858C56 for ; Wed, 1 Jan 2025 12:57:17 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 71F663858C60 for ; Wed, 1 Jan 2025 12:39:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 71F663858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 71F663858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735735192; cv=none; b=AfP9bGf90s/+nN3RxySHKvegYTcTglsx3O/PmfLrmHHW5M9UycLLoa5z0CaUOxFfxoucP6f0NsWuOWambL04PE3TJGhQDlxIJwP4IfEvwdoPo9K5RcWaGQcanUKNBhVgzE4eTGC4MOi5ZvN2qcDQvULNStU2hXo09FMJ6kmgRhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735735192; c=relaxed/simple; bh=RHmEZZrUYrb93uY73+MrhPvT5y65SHpgriTJv0XTYL8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=t3d4R8YWrZBEULI2gG4NlxdWkx7QLshGkHP3/U08M7SjyNjNfqkMGk5PJPLqICEK5PEhPmpHRfL5qJlLh3y+K60Q9vRmhR0lCitMKIjIgky7/C/hoMKpCWqzKfmzacu+IbZRY0IXxmBh2AfuC3UWX8YTHvy8pxKCck95npntGaE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71F663858C60 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=bmq8qQED Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2eeb4d643a5so14788927a91.3 for ; Wed, 01 Jan 2025 04:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735735191; x=1736339991; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=3Ou4r55IKcp5m3/FnmDySxK7x4GUR7Rwvj/Wu4GHcu8=; b=bmq8qQED1CPvsAGJ64me5hD0KnD3nmtWimMZuKw8udgLgG51jbnM00RZLPhK2LdQyD gZxS0pSjpqbFohQXqf2v2O3zX+vN0u20uypr6EBrpQQaRUVRKiarn2o1bAbpu0FqO7qu kT2E3LwU0u85Vw6jEHchbIkbxw4dSH2zqeBaVSss6bABU/2MoKe+bTSsKnzCZWtAsS0w k6akSp6LGi81ILFXuBdx3ky3aaa4F3JOuo0lA9o7U162R+2rzhnSCA46rzjDTzYOrOAy Xtr6frbG54EscQfNV/yi0f0fqv9lP/BjEKRHBHUR4dCXA66d7EFfJf+uRbt3n7SCnHn0 7ULQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735735191; x=1736339991; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3Ou4r55IKcp5m3/FnmDySxK7x4GUR7Rwvj/Wu4GHcu8=; b=VFjWEKG0lPaPT1IMz620Ey13IZZwj4lQnL8Ftkwr4R6G3ypopQpnAf+u6G9eU7kbLD 1s9qszEW33Yf6vqDqjr5s1nki1s3xw1OA14goLw5Z8vDNnE4s1akKCX4CamLuyLR3yow 5FtoIEju4SmJh5mX5ISm5Wvc3+gLF/u5C1pXRw4QsWXDrCsru8Y1oBO8hYsr9mccCwfD 51zYG7thU2XHRDbQib7qqgr7EnhICdmyQByDN2507Dq7ZkvEOuv+7qf5cT2/U5JfgrnJ dmLDa4IuuX9EKWSnzjV260zyCuMygZ0WjVrmUA0NERYw6A6uOnGGVoQ+FL/0BfaTlMWy 8D6A== X-Gm-Message-State: AOJu0YwujlTVY+snQj64AOi6sHax+CxL5om4NdEPq1iT2YgwKCKKUZwo yMWDNuordn5pNsHbk2PzlfEdWXNmsJZuY0k2XezKoiLqis6/WyQyx2eAQw== X-Gm-Gg: ASbGncsRRVgiamN1Zy2EyIC62p8ePnyZZvHXjEQgyNzn5mQl6adRnYnz8mTGExjabgA dAXLK9GpCXqcCaKmvaUgNTx1BkRJH7uS4HvA+w+AEF/QFcaMiB8mgKdSKuakH/prZ1CcVDZG3ON V+Vhx5J34F2YARQ24MNAOLr9oRRqvpzozBQ0tff0Qp/l2O3VjcoHYs4Gp6tEQlVZNSiiu0d2qSz 5zQhVDD18vxtuvm6JgG2IGL8icCPdRfS3BRdZQO3N7sEc9L5J3THqV5nA9W/Q4YW4u3ZvfZm/yJ GRI66J3H+5KdphFz/WgpCmYFcKs= X-Google-Smtp-Source: AGHT+IGyyCyrNpffoJe6HZ9cN67c9nqgvgmEaNd2do21GSSFiG9Infii+ySlDQcpxkjm6zlAt58L8g== X-Received: by 2002:a17:90a:e706:b0:2ee:bc7b:924a with SMTP id 98e67ed59e1d1-2f452eb14c7mr56152236a91.28.1735735191211; Wed, 01 Jan 2025 04:39:51 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ee26b131sm28910582a91.44.2025.01.01.04.39.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2025 04:39:50 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id C0F44114260D; Wed, 1 Jan 2025 23:09:48 +1030 (ACDT) Date: Wed, 1 Jan 2025 23:09:48 +1030 From: Alan Modra To: binutils@sourceware.org Subject: bfdtest1 loop check Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Add a check that next_archived_file doesn't return the same element. Seen with the following, which I think shows a bug with "ar r" and thin archives as you get two copies of artest.a in artest2.a. $ rm tmpdir/artest* $ ./ar rc tmpdir/artest.a tmpdir/bintest.o $ ./ar rcT tmpdir/artest2.a tmpdir/artest.a $ ./bfdtest1 tmpdir/artest.a $ ./bfdtest1 tmpdir/artest2.a $ ./ar rcT tmpdir/artest2.a tmpdir/artest.a $ ./bfdtest1 tmpdir/artest2.a oops: next_archived_file diff --git a/binutils/bfdtest1.c b/binutils/bfdtest1.c index 9714998fa6b..ef68732e37f 100644 --- a/binutils/bfdtest1.c +++ b/binutils/bfdtest1.c @@ -53,6 +53,8 @@ main (int argc, char **argv) last = next) { next = bfd_openr_next_archived_file (archive, last); + if (next == last) + die ("next_archived_file"); bfd_close (last); count++; } @@ -62,6 +64,8 @@ main (int argc, char **argv) last = next) { next = bfd_openr_next_archived_file (archive, last); + if (next == last) + die ("next_archived_file"); bfd_close (last); count--; }