From patchwork Fri Dec 27 10:34:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 103718 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5700C3858CDB for ; Fri, 27 Dec 2024 10:34:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5700C3858CDB Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Z9KDj6s9 X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 8CE263858D20 for ; Fri, 27 Dec 2024 10:34:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CE263858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8CE263858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735295645; cv=none; b=SSC1RWm356KUckmXtzATUuBH4Dvd9a6eb1JtR6H9vXhaKzD+6hsQCT9Fc8rxYGz4EuosjBU22HwuWBynIs6KCP3u+k0okkSFImoaXBnYOqhpkKrc9YXTti6dz2UBskvGj137XLsPwg7ao0b+CB5hxddOpjNQrnb2jlFUJTre8nU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735295645; c=relaxed/simple; bh=uSUJ7GV6VbnNc6hKwzkMpfMduLPDhLMp8RNf2Rtf3EY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=ueGp1K8f7wql0wmL/PZ3SfLvES5Nnr8D3JsoBD757UP74Bevnu+Y1rZqCKe4wBQ2msaT7bkwxTCW1leotWiQ13DJWYWRcl4+JsCq6a/9XwIbniQBeMzxaeRnxPA+uWOALQmWLMchtyS5AOetNJeCBWDwd7akpHb4hXSbdca4FbY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CE263858D20 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4361b6f9faeso43045645e9.1 for ; Fri, 27 Dec 2024 02:34:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1735295644; x=1735900444; darn=sourceware.org; h=content-transfer-encoding:autocrypt:subject:from:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=lBYjP1SE0Pg66fTLuNcj0cgTw6RDxVraLs8n5y/Gr0k=; b=Z9KDj6s9EKo3Ia5VeBxYlrReueDvdiOwPw7DJPT+4Oe84hRnqCkZbEL9PuLiXws+rR 2J6P7v/9kYZ9jFCGzR/+hvj1EFEAR/usjUR5R+e9xYIIxxD9xtYwuOtOst8/xGlbo0A5 OP6M3wtZEbx57xSR+DKKV4ZHA8E58Cz6orTCLjqMYGiPzo9kP6eaPUpYkzokva5Rk1Sv 8ganPKp16+LnIftZh2kVrOPJGdFFIXKEooY8DRp1/xFkKlPbWtpw+HpCEDuN9m0rqqs9 YmJklDh2JBK3F5Ypq/rSutUnXuWs/giZVju0l6MOLUkQme7VCvnGlkJC5iL46WBHmqOI hH5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735295644; x=1735900444; h=content-transfer-encoding:autocrypt:subject:from:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lBYjP1SE0Pg66fTLuNcj0cgTw6RDxVraLs8n5y/Gr0k=; b=derVaHGbDPurVM2DeN8qt/ORHEDVTMhP4k9raLFlbT0XmzHPjTixpiBOgzVuJku78U 93MRWAB1vJ1RuYiaC0iRaeXQA8wQrox9oyiGHbzNfpYbgBynRs4RSxyWyUTq50jGakIb BetpWZ/FZyJgAyti9dm21H13mR9fGDmLeYrDLTB1UJgWOW0Q5u7d+sSRVAU77mWamydR djotnnKFSFm0dHeHQ5I6OOXXeONIPVxQy+uChha/VWT85xAzIrR2alZz8jemDUE/n+6+ fD2vxGTBKEpLUDe1IsyB2aeOowNKyqsEJ/ol+4dyBlwXvh1IVz8YlggSn9Q4UZpaJep2 PYNQ== X-Gm-Message-State: AOJu0YzbgUtBlwjhHUwjqZ1Mpm3/uLFSGP/exsvEANEsYLCRvpf/rIWS BebGPpAASU4sCdTkIzlseI4QTzBsM3F0/HG2sfgzSF5Yl7D1LGGyybWxkawNmY6CBaPmchD+Mhk = X-Gm-Gg: ASbGncuaHkzX7MVd8EG3G4HpDMKKBdxR6IOklsCBlsV/3YsjBRVQHD54LVHfd48UPL9 121niMqXRAAoqvNGFPHf8MxuceYJq1rYqb64vEfrz3qS6Dz4hnM/heN/IDM1lCf065CuSXocwkE 4HMekjEKILwRAKcAeFEg47C90TamNT7ZAYcDBWahqfNhL4Rld+vmVwZK++8y0ggAIB/4eVLE498 SAcyWdGHOeF2yl8KxXSniAliXhEUu+i/QWpRUavSRmx5pF9BPx76doSu1EMWlruLx2T6aGxPTvM eKQ6a4yx9wYwC/5bhXFUUMdl+oAsY9J1KVpzZxLZUA== X-Google-Smtp-Source: AGHT+IGsq8c351HCEngTape4LQLGFJCDaAI7p3x1qkRrO67Ubc979GwL6l7+h1jT+VxDnWQF5XTz1w== X-Received: by 2002:a05:600c:4302:b0:435:edb0:5d27 with SMTP id 5b1f17b1804b1-4365c775131mr240434685e9.9.1735295644167; Fri, 27 Dec 2024 02:34:04 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b3b271sm293883215e9.34.2024.12.27.02.34.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Dec 2024 02:34:03 -0800 (PST) Message-ID: <5fbe60da-8684-43c3-9cb0-b107ca3b7c56@suse.com> Date: Fri, 27 Dec 2024 11:34:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Binutils From: Jan Beulich Subject: [PATCH] x86/Intel: don't accept memory operands with J*CXZ and LOOP* Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL X-Spam-Status: No, score=-3022.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org PR gas/31887 Like for, in particular, J such should be rejected. Simplify the respective conditional in i386_intel_operand(), leveraging that JumpAbsolute will never occur in the first template of a mnemonic- specific group (thus making it unnecessary to exclude that one case). At this occasion do the same simplification later in the function as well: The resulting two operands will uniformly be invalid for all mnemonics other than CALL and JMP (and their AT&T counterparts, which we've been wrongly accepting in Intel syntax) anyway. --- a/gas/config/tc-i386-intel.c +++ b/gas/config/tc-i386-intel.c @@ -907,9 +907,7 @@ i386_intel_operand (char *operand_string } /* Operands for jump/call need special consideration. */ - if (current_templates.start->opcode_modifier.jump == JUMP - || current_templates.start->opcode_modifier.jump == JUMP_DWORD - || current_templates.start->opcode_modifier.jump == JUMP_INTERSEGMENT + if (current_templates.start->opcode_modifier.jump || current_templates.start->mnem_off == MN_jmpabs) { bool jumpabsolute = false; @@ -1046,9 +1044,7 @@ i386_intel_operand (char *operand_string ljmp 0x9090,0x90909090 */ - if ((current_templates.start->opcode_modifier.jump == JUMP_INTERSEGMENT - || current_templates.start->opcode_modifier.jump == JUMP_DWORD - || current_templates.start->opcode_modifier.jump == JUMP) + if (current_templates.start->opcode_modifier.jump && this_operand == 1 && intel_state.seg == NULL && i.mem_operands == 1