From patchwork Sun Dec 22 05:34:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Flavio Cruz X-Patchwork-Id: 103610 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 539FF3858D3C for ; Sun, 22 Dec 2024 05:35:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 539FF3858D3C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NmQX6bJK X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id 7C4073858C35 for ; Sun, 22 Dec 2024 05:34:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C4073858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C4073858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::82a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734845677; cv=none; b=lospVeItAEkEFI4GDmIIPyR/6OxlC3h8acB1FPFsuZC0tSl23hT7FlaIGW8bIjJbnncVKUVW8vi66/e1pNr2s5Lu3R6vjzZgbj9YI57qN4CKubyfjRbjJlBQGR9zGEjZFXRpSr9R7d2kVlAsnWNCzC62MqZ02nwSM6SejXb+Nd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734845677; c=relaxed/simple; bh=L2X+2Iep1e9SRvi5vVrkd2mdW1HC1X2FT/S0ByMxXyI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=HY1hz0PnGyhjXxHExZiLp+7IlO4ibMl0PRAjk5xnJjm6IIhApNNqf8iIQEn1HvOSxnx6kagOLuIzECS5Ynv1jUtMy7aoyMC9I9ZPHPB5lemcG1UKQKkuJoTn96GPbOOZHVnbsDi7ULdaNlNKC+rOkX5TJPDVCz21LQl/KnVRbbo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C4073858C35 Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-467a17055e6so34258851cf.3 for ; Sat, 21 Dec 2024 21:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734845676; x=1735450476; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=ia09nM0O0P2AxnHuyo6OILbcdIViodSjmauqq7YBrAk=; b=NmQX6bJKqz08HSSi4JntKEd+6SHZ+VBZ4YI/SOVS5FtwtzUb9VWi1UqVzfxhFlAyHZ prL52iTBkk7MlrQu7Rtx6UQIAwOdcsyHTK8FuE2Ifu935BO5kXaLLmxq3x3Hs+Z3aP2o B3TnWmhuJ2eJiO+Vxp9+Bg7cgCY6vlxAuyTUiM4A9KkALaWFrlZIuVsuTTVS5GLwX1c2 siu78Gtzi0wMFy3aGQor2GMOOGWTu/InApEgk7BHlWU7GamraXRvIdp3J6E6YQ4m1AkI RUEE+M+3RQiOOb9iDwRD7hbhqIX0PooL4twivGlxB3CARtu4yA4/vO31L2jouojUlxlF dq4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734845676; x=1735450476; h=in-reply-to:content-disposition:mime-version:message-id:subject:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ia09nM0O0P2AxnHuyo6OILbcdIViodSjmauqq7YBrAk=; b=DikAF5cFbVZMQEXkq06BvA4u91+RfgE9tIFyRkwrJrVqaGNOYVEV3K4za8HnJaJPtR 8z6RJ+Z6+BN6n0+QSmz8sj1arClandmJQGppFDN50CgrABQ2rY6M4RqoCswfe/pnh7GX Qao6rqcswnPCGNCrTSLVoqJ8i5YXXcaApBle0vmcPzLhhl/6tp5vk6SiV3/4LEn9rFOo iZp+b6fKv0dVO9oHsSXw1HQ4pHkV8Tynv6ZSaCNwzw/DgE04Eo47R+R99ezQSt3HLm8T OQiFn9Vg2ghzwXJEOhOxgcdD6YEaejiAmEblRqz1eU3O3P//xc7kMf/idGKb5hI+i+qx kBNQ== X-Gm-Message-State: AOJu0YweVx1jqoHDvwMnGUlRdiQyINYVW3mz3BCYaseyqdHFHfMly1u6 yMH+47yNAvFOIusKJwWnt73PvdDd0EnfaFyREnsvSCCf0DzyRaa7N1lYdac= X-Gm-Gg: ASbGncuRfktJz9Dsso+WGXx0Czq/H/Vw8tVH35QNd+DSr6GmdKO2mtjqSLC2pVhNSYa QQ0JoxASQn7Lx19i05ZS4+EEmYO2nHBHBuNgVce7c0FWrrL8lvXY7dIQQEhxBhDVBulLXTTnB8S s5RT6uCjOlgqLqqT46xAglSchGfyj8eCkwaSqmg2oeY1eVUE5SuS3w6uAfppBuGrxzKv0Fy4GQo V+jOmdFGVB8iGxUieTz3isP18x2r+DnBtUmsq7pyFAbWx2p0RvIAw/vSWRG2ETSnRcdsWpvWyOH rjr4zRhhPFPCmTc6bO4Q5a/za1M= X-Google-Smtp-Source: AGHT+IHB8t4UlpJ5U+YHnnMTqD16aZnrjCofO4O6Isn/JvqEBnTvjZWxCpTtkpssCFInzyh6e+w0zA== X-Received: by 2002:a05:622a:d2:b0:467:6e45:2177 with SMTP id d75a77b69052e-46a4a8cddbdmr122217781cf.12.1734845676490; Sat, 21 Dec 2024 21:34:36 -0800 (PST) Received: from localhost (dynamic-acs-24-144-188-205.zoominternet.net. [24.144.188.205]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3eb30ef7sm32405211cf.82.2024.12.21.21.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 21:34:36 -0800 (PST) Date: Sun, 22 Dec 2024 00:34:35 -0500 From: Flavio Cruz To: gdb-patches , Simon Marchi Subject: [PATCH v2] Hurd: remove VLA usage. Message-ID: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <009b3d1c-9852-49bc-bcb5-f25d418310ad@simark.ca> X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Compilation will fail with -Werror=vla, which seems to be the default. Note that we don't need to allocate num_threads + 1 since the matching algorithm works only on the num_threads as returned by task_threads. --- gdb/gnu-nat.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index a8a4da1c..ab157094 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -1016,15 +1016,13 @@ gnu_nat_target::inf_validate_procs (struct inf *inf) { /* Make things normally linear. */ mach_msg_type_number_t search_start = 0; - /* Which thread in PROCS corresponds to each task thread, & the task. */ - struct proc *matched[num_threads + 1]; + /* Which thread in PROCS corresponds to each task thread. */ + std::vector matched (num_threads); /* The last thread in INF->threads, so we can add to the end. */ struct proc *last = 0; /* The current thread we're considering. */ struct proc *thread = inf->threads; - memset (matched, 0, sizeof (matched)); - while (thread) { mach_msg_type_number_t left;