From patchwork Mon Dec 16 11:40:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 103172 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 67A4B3858CDB for ; Mon, 16 Dec 2024 11:42:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67A4B3858CDB Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=PzT/lSJE X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 979FF3858404 for ; Mon, 16 Dec 2024 11:40:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 979FF3858404 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 979FF3858404 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734349224; cv=none; b=ewI1CFqKIpPx6+MS+UyzNkpyb/C+qLwzEvhD8dNEtNBstaPRGnu4QfUVl5IWxK/2ql4mfSkYRCcdrHnsE4ykfKYilq/bE12rAmEx6rkOZwR/q6wn3Lk7pbwFhQDfJ0Qz/Z4mv/ebuDMHNdvkb4eYDlgLAExhLNYOEnalm7mMtdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734349224; c=relaxed/simple; bh=yijtmCyjwXGJMiJEsY0oMG0faoEQTvbMXNyQpTOg2GA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=VTSZaSp7Olumx8yjnIZ5kdRSXs22YoiZSI2Ml19+vH/hlXyrrXmeodJqmgRjv7aE6I1UK97U4OFQDf6filGgjHFDeKILSBGoOrxGdnI/j4/zR1JK48SmSOqjbTJomMUdxG+bHTX238fuDDd+ObEBtN1XoF/dzGLCUv+DEmYa+8g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 979FF3858404 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-436281c8a38so25304795e9.3 for ; Mon, 16 Dec 2024 03:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734349223; x=1734954023; darn=sourceware.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=HVX+yStx4GXQ42w7rLEiCh++xNSXc3hNrm8ikVCxfHc=; b=PzT/lSJEy6c1tD++RldTpgUxp/3C/OOscNmUWb9n1Wd5OJbKxd9m0xGnAqmzuFC41N GHbOlDQQGhByQBzY5NJ6X9VcTWOjvL38mlfeJqT3wvVfQyQBTutOpWwUfV+KIgKYeahC FRmxMZrvUYImr/otXkWVIUdTuhWoBGodCXWRmv4taBRqyINGJno/IfrR2eq6CjkQG3Oj Im0c0a1MIBuyCloJVzJpGyb6PSgM6APq0N1923WYmlEETBC15XusrwHv//tW7fjQIqsT NAsjz/baxOSbEfu3M7lSQ1hIgw774+R/KqX4BJtM/RGn2uDd52KB65aFgp8vdmnGQGq2 jJRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734349223; x=1734954023; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HVX+yStx4GXQ42w7rLEiCh++xNSXc3hNrm8ikVCxfHc=; b=K6fpLFfyjwWKsC/F4ymuVsTd6zn81OeX3Qc7shjLkjYlrWsk+99izFO4ll0s5u61qE sfpHOppXLsu21hnQTbL5iX0MArlwJ6rUcLVejV2+6KjsbiZkf5l2izPAP1AemF0JRhSo 78TwRhi0rQFp+LSwRneHXvDwV1X+v+lXu3u2jEkvrpDc9pKD9z+XJs+gTMmO+pi+51Qt LrPt9SlsZqKOI6n19efbTDfj/NdZYu6CeF8culMjUaIQNp6Dr5y+y0VOeaD1wrBEDL9w TUe2C6FjRm1wwblxq15fAQHQpRG6jb4DIXxcISjpXXxtH9B0elwXWj40fjFMjo3y8ndx Lecg== X-Gm-Message-State: AOJu0Yxm6uUwXK855zNFe/zyePBYd31+xEu9yupet5J6k04efAXdhIAd QsaiGcCiK973Cctu6P/IuiHmv+XOzSnKRyZDqNe1cvD6M0WGt4L/jtunpCZvf8hERoQCgQCfqzc = X-Gm-Gg: ASbGncu9PeOVuBwnEGB6BgRwIX3hRCViIqQxRrENmdEX208T9bmoIM1FfeXvoH1azjC fv0xh1sZ0/lNyQjlF9EGw1bMtlZJ2In0zmJ6jOwZ3IlyBc46c/b1I/YJWDqmAVAsSyCCd6uGcbx k6topOap9zyB+oNurh7M4glVnKOREB/npDxopxFro9NjXLjZKjbMW0HV17uxH/FX2elkSe2X8xt 6Wksqrdl3f3BymT9Qm7Pnpt689IWgonU2oEM+Kuzfsvw4ACucld+y9xRqN3VZ8t1L004Xe+18M4 oJuTdYB8ER9WLGM7Pv5mqVKp5SRXO0CQ6egKE7UGCQ== X-Google-Smtp-Source: AGHT+IHs2dkkIiUNVrKt1TlQWzs8xoPerI4jzBGoHiRk0W1TXA3TvGvMIveoAP4tNkMlOVb6ZRZszA== X-Received: by 2002:a05:600c:1da1:b0:431:547e:81d0 with SMTP id 5b1f17b1804b1-4362aa4386dmr104844105e9.11.1734349223310; Mon, 16 Dec 2024 03:40:23 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4362527ecc3sm140891745e9.0.2024.12.16.03.40.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 03:40:23 -0800 (PST) Message-ID: <86859d87-f548-4ba4-9ed1-c386ca774fe0@suse.com> Date: Mon, 16 Dec 2024 12:40:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Binutils Cc: Peter Bergner , Alan Modra From: Jan Beulich Subject: [PATCH] PPC: drop redundant value conversion from md_assemble() Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL X-Spam-Status: No, score=-3022.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Just ahead of the enclosing OBJ_ELF conditional the exact same conversion was already carried out, with "val" not further changed in between. --- Doesn't X_unsigned also need taking into account in the remaining identical piece of code? --- a/gas/config/tc-ppc.c +++ b/gas/config/tc-ppc.c @@ -3516,13 +3516,6 @@ md_assemble (char *str) char *orig_str = str; bfd_reloc_code_real_type reloc = ppc_elf_suffix (&str, &ex); - if (ex.X_op == O_constant) - { - val = ex.X_add_number; - if (sizeof (ex.X_add_number) < sizeof (val) - && (ex.X_add_number < 0) != ex.X_extrabit) - val = val ^ ((addressT) -1 ^ (uint64_t) -1); - } if (reloc != BFD_RELOC_NONE) switch (reloc) {