From patchwork Mon Dec 16 10:58:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 103169 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 59B693858D26 for ; Mon, 16 Dec 2024 11:03:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 59B693858D26 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ksu2KeKU X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 2DDEA3858402 for ; Mon, 16 Dec 2024 10:58:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DDEA3858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2DDEA3858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734346723; cv=none; b=GXHdCmjmTVuVAQwgJQA8DtZlhIv3WrB7BFeP/kSd76qlEsnnMLk6Wi+jY73vxh/sZE2kcIuLWk+BvafXDNzm7F3khy+wYfRTQ/OmewXPj20sunQnKA/nNvlL4lf1obHTeE99WL9wlnkI0mQPuvp/JP6pDiW8gJYQn2YN3iLaYKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734346723; c=relaxed/simple; bh=ZLkTO/drErw/9fLAuYvL7nTVPP2ANUuBPwhA04CeMTE=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=g94Pr52lS+hanZ1Z2N94nJ31yHZQ6bmLn2FvDG45b4HKXGCXBTYQnphJMDkPLbvIyM50xOSQgo22xu3hAAbnsAY0/abQbmmnudPd4P35bZWfjGN1IUCiY7rGK9JEzoum28xVMGG6WeYiZNwdhVDkALE0X28kuO3pJ14IfX8qYZ8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2DDEA3858402 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-21669fd5c7cso32603055ad.3 for ; Mon, 16 Dec 2024 02:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734346722; x=1734951522; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=lUPDUZhG8B4cens4NTE5JSZoNplKskIoY1MvovkqKc0=; b=ksu2KeKUIKLS0RTVdAcW8ttdVWOzuHGIr7HK4yg7Bn3GXiYZKNgnX1A0yzowu+NbU/ 3ysFv7230eBk8+1HnVacoRtt9LontXZcXD6pbcKCVsNT48wPtP68almG1Y7gzBtGP9Jz MgO9kY3NVEbOn76pvC+TEO//LjC4PYr6KDde8VpHtJtVjrx0f/7BT/c9muUnUUomg3I6 T2ACp+3Cw38rx6TK33iwnmONjWqycI4ue/vBq3cezDqBjPacL/OWgllER6kcWXnNEBoy L6rfj6vRTpjmQUQ9vR62eFZONPU6fYvrF2wH4FEnpJRMFDZU5/PQdS4QaYvVYbOokRnj bhgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734346722; x=1734951522; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lUPDUZhG8B4cens4NTE5JSZoNplKskIoY1MvovkqKc0=; b=OmRlH4v8dqKLsx+ITGmz7EsGx4gml/3LV1ATE0t6Us0mdxgzaZqDHdEPjlCDspp5vb Z9QQpQkvVm9YrNS7V3pfOPoh7womQkw/GQh/kVLCBXUaeetcdjgNbvNy3PchDIlADoZx ddFVuLyx9LbDMn6vLVTxbDwNbOBqvcXou+/WeOW6ySxJ0fFfU1BEAPVfVoxV4m8q5zW0 4MU00eTrZMm2twUsTK7GOOX3rp9MNOwM4lXX7+lwg0/BL3UJ7O1qr740mtXLxlMwyLOk hwbAvS3YMYhtMoAwrHJ0kYZgeohJvctinh0b3uJgsNfz7Hf89gYN2nb4qUsrhJUpIdAG fEeg== X-Gm-Message-State: AOJu0YxQzEio0mg3DVIubnSo9u0sH7htLfCRktiWarjNihWwr8iDP78N KycOz6+drZEvz5dp3UB7z0y5kvC5ivYd6Tlb6KCAX24nnviStn+sL4Be3A== X-Gm-Gg: ASbGncsFMJutLvk+XUWgTQHz0T50wt84xWF7OvCj/ph9E7+f78JELZhetsNnzBAFUPq tCnPUoGWTojDfRe9Bb7oLAWSffRFKbl0UP8D6RmxoTosl+bTVMkgqDUkWwxgV3M77TT7jKY0RR9 9lmETqnnX5koPy9Unkt9B8AUCixWqT8U9iAkmZxuyXGV6+nWIueMcuDTDU4DRLKwaoq+DuOzW62 r7QeYiWrp5HYP+JqoNY70Ty53YwBLYXEMYHjiHRxFvRwFVTf35C0kJDkrvqqy4i+nkRzdK3kCpt I5F0CVgGlR+tK4MTJrOay1/U4Jc= X-Google-Smtp-Source: AGHT+IGAtlQa3uzp6o4eWkoWUAcV2vA8oTvB5jsawf4HNp14aUkENbqkYtdcFCjdib7dVodVcCW9yw== X-Received: by 2002:a17:902:e881:b0:215:aae1:40f0 with SMTP id d9443c01a7336-218928de67dmr209098765ad.0.1734346722000; Mon, 16 Dec 2024 02:58:42 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f12cd0c308sm3376444a91.2.2024.12.16.02.58.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 02:58:41 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 89FFB1140C8F; Mon, 16 Dec 2024 21:28:38 +1030 (ACDT) Date: Mon, 16 Dec 2024 21:28:38 +1030 From: Alan Modra To: binutils@sourceware.org Subject: mach-o segment section count assertion Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Add an assertion that verifies we have filled the mdata->sections array in bfd_mach_o_flatten_sections. diff --git a/bfd/mach-o.c b/bfd/mach-o.c index 9ec5cabc021..8d5ca9b09a6 100644 --- a/bfd/mach-o.c +++ b/bfd/mach-o.c @@ -5076,7 +5076,7 @@ bfd_mach_o_flatten_sections (bfd *abfd) { bfd_mach_o_data_struct *mdata = bfd_mach_o_get_data (abfd); bfd_mach_o_load_command *cmd; - long csect = 0; + unsigned long csect; size_t amt; /* Count total number of sections. */ @@ -5120,6 +5120,7 @@ bfd_mach_o_flatten_sections (bfd *abfd) mdata->sections[csect++] = sec; } } + BFD_ASSERT (mdata->nsects == csect); return true; }