From patchwork Fri Dec 13 04:27:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 102948 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3B3E3858410 for ; Fri, 13 Dec 2024 04:30:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3B3E3858410 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=YV3MfFD6 X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 2AC063858429 for ; Fri, 13 Dec 2024 04:27:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2AC063858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2AC063858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734064077; cv=none; b=TBXZFiHQkmj6XJfyyJ/JfUpsVvqne79VdqFPxj6kZzPQjDYfWRmD6v4fj+aItSSfISkAx9b8jtc+wvEE0zby2VoZhOrusMrMhaZE5qGXdi74XmBiREXRc64YYIjj8hCgUvU9kLeKfaBsNgLOO1V7zOOaaVs2/+lIIPLXyzAStJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734064077; c=relaxed/simple; bh=YvPNwMlPZDH/Bn/QKZvxAd3r6E4KMP5ja038bRBp338=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Y3yCKuDEGhBeZjPLdd2OzNvnI9IPVkZkkE9eR7h4WQFXW47aDSfv42l1/6zW6WdClFvxFlu7DPUhNgi5YZxF1Z1A2fbNSSyl757FDwWn1tB7ZA5t1wkrWyqn9WFcTRV3Q25b9aOiqda4/OeJFOmB1hpfywkEUC1aQmD8dcgJTfc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2AC063858429 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-725abf74334so1120977b3a.3 for ; Thu, 12 Dec 2024 20:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734064076; x=1734668876; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=eDDq1QYfA6iNGl0V39vS9dv8OOiIC/oZcas20I9mQdw=; b=YV3MfFD6f8IlCMzwe+1by7SddnvTteLw9JTfKGSRSHaIy/KZQHXaTkFxyqcJI9aQAF cqxhlHQcTjCSo1AyhySmNzG/LEQxnrODU8x+HC7j+CxmKYDa4rbHrgrKIDvI8+z5mzmj uSYkmQKDEnC0OJYJBMWKRKH9gBTcN/1d3z5xX83Cj4gIE0YMUkyfenmssRM5a/FJCP/S m2WYPkvlzpS02F8ifuSVVB4RIk9FddT3qOOvmZDi4m1jI0ibqnfzwsnRPAOs2ZeO+Q9n tVYlmx5xgtBRvT8ZvfucyORnuwkjbkyLstfbFMnunqiDkj4D3Ha5ZdHfaQmmpNZa0QJK eYXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734064076; x=1734668876; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eDDq1QYfA6iNGl0V39vS9dv8OOiIC/oZcas20I9mQdw=; b=NLyDE/kQ+xGlYMMfz4huuodg/XyFvnSNa67Eo/J2As4/0CZS1Lz7/saB33XehGdFYD 9FluFl3lLImA4+rr7xkJ3E/ZNRRvMYXhapC6irhmK5XNXfZoQsO2UjQCmOxfXFawo/mZ nz4h2v+E85b7h9O4gfH/0FS1ea36PGUxcEpCRHmv91SMjeoXrUQSJC+0kRq6I4/mqr3e AkbnHj4wdTZZmbIeOSL21hEz4qBRlBEpx9GY0GoVRGhbbWV1oW9BG/jpQ7ewsmAG3tHh sF2xiqsssQ26dJywlWqzXSBwHs6L5YqyNc2KnsaogeRmDFJZg6hL8ZTMkOGiNNLFBZre q31A== X-Gm-Message-State: AOJu0YwRyJTT43K6hTV55ev7fr55J+ZG5IZJOfVRlqmeqborX7TNJV/z 6uiZNeVYnCV7ck9HM80ZTzW9bYi6fDtrNhtK4x/vUMEmG+fJcstloWlhhQ== X-Gm-Gg: ASbGncu/veP5VIQ8p/3OoR3wfuD07U1oK2ABdIInszRhdV5wsn21IZVg6E8d9mW/GnD Dd4UNxAdzbPxDrbsq4kovXQGqY37VxwFGkHfXslcTya3Wt7KLB0MPVVVHmXW04iMT1RKGn947iy VH0KIVaWZHi+/YKA4KfKpQ3NhDhiXjXN/i4H0Z+xwZFT5UDN7Ou6NVInVTeGowmrOiEIjFMncBy UlRxMLAsm1zcIgTZOK57nbFg06E6fZnXuiwR5wj7UHvDq0RXXaHovYDN3MWh+VN23aL6lzWADvB yXeUqjZ2bKew6uTM5S8Uqfz5ndc= X-Google-Smtp-Source: AGHT+IFDzSRiTza3p837Du4FwoB0d6fa0MutJ+f1gslYiDJrGaivS3bxW5YcHrEHfiXuMUmcEjSU9g== X-Received: by 2002:a05:6a00:420c:b0:725:df1a:281 with SMTP id d2e1a72fcca58-7290c155379mr1852435b3a.10.1734064075897; Thu, 12 Dec 2024 20:27:55 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fd3b48171csm8270873a12.13.2024.12.12.20.27.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2024 20:27:55 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 612521140BF3; Fri, 13 Dec 2024 14:57:53 +1030 (ACDT) Date: Fri, 13 Dec 2024 14:57:53 +1030 From: Alan Modra To: binutils@sourceware.org Subject: small coffgen.c tidy Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org _bfd_coff_free_cached_info should always call _bfd_generic_bfd_free_cached_info, even if _bfd_coff_free_symbols returns an error. (It won't return an error here, but let's not leave anyone wondering about _bfd_coff_free_cached_info.) * coffgen.c (_bfd_coff_free_cached_info): Ignore return status of _bfd_coff_free_symbols. diff --git a/bfd/coffgen.c b/bfd/coffgen.c index dc5b0f40020..27bd54dcdd0 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -3295,8 +3295,7 @@ _bfd_coff_free_cached_info (bfd *abfd) Do not clear the keep_syms and keep_strings flags. These may have been set by pe_ILF_build_a_bfd() indicating that the syms and strings pointers are not to be freed. */ - if (!_bfd_coff_free_symbols (abfd)) - return false; + _bfd_coff_free_symbols (abfd); } return _bfd_generic_bfd_free_cached_info (abfd);