From patchwork Mon Dec 9 09:10:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 102648 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 878CF3858416 for ; Mon, 9 Dec 2024 09:11:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 878CF3858416 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=YP/9ZKJV X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 2132C385842A for ; Mon, 9 Dec 2024 09:10:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2132C385842A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2132C385842A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733735434; cv=none; b=jrpQZOZy4bcqFTrI6L+f6J0LEyPnP2i6pOtPk1Bx3GbmyVUhq+lz2LNTH+q4DB9SnwIW6ljVHKUY2u/EOdlYl0/C5m9C7TeIlbmQ6Qy0/wvlN8RuHT7i+3beHNgbjXcJZULonrfCh8r8LL7dS9ePvQkT+QR/r+7B1B4VCiREEqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733735434; c=relaxed/simple; bh=29sdARJEcIJT9cNlNXs0kk5hs1O7YUNFJwTIJNU0gu0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=dLh68zF7R9PxN0aWNWmthI7Z5DXJngtzHypyjfzl8fIxvDOYNdx2KDKnGCngxtnkDRbAc/+rJJ1ZKOk+ncjD4m2njxi5lroejkdwwJv9iXz9uAL5jX4Tyecjap3RbX2ItS6WntzbKAS8blR+D7ATh5t/MB2DXt/b2za3Icu18fY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2132C385842A Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-385f06d0c8eso1875885f8f.0 for ; Mon, 09 Dec 2024 01:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1733735432; x=1734340232; darn=sourceware.org; h=content-transfer-encoding:autocrypt:subject:from:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=OBa2qNZeHG2104pGZ6YcsrfhmOjR8F41pzzUctoZyyE=; b=YP/9ZKJVwEgdV0S8WlK6j3y+iQle6tajVOnsYwb4BJ99pVQ4zOOaN77OIYe/cnwxXK T9pgZQRY0lNTuZe5qx1NHmxVD3ooFMaHb87yncuZqjAZ1XyM3UDv9W91c1VbKOTFQRvQ QSEqgKWTXopgCnkzCcS3W3IrZqEamiMvMNb123EShpW4EjtTbs6TMvQRgOSxONTuFQ0A QX9KjpFss/fz7Be8ius7kBYVaAdHOXhsTflpZcpMFXJDzsAcfFtyGcJ/HhbH4drIbOz4 a9/iehWrCJOAQ25a6GBL5TWbOLUODfdIQxIMlSOHuVG1bir8avIGVbfOBFF5FV7utv7l 3HCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733735432; x=1734340232; h=content-transfer-encoding:autocrypt:subject:from:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OBa2qNZeHG2104pGZ6YcsrfhmOjR8F41pzzUctoZyyE=; b=i7BSxk/BSLLQgiX2VPiFteQYKt9upWdi2G19tdI9LRQxgzePL49Q3SZg/UOzNGTs1o QZpBacjcab54YVqJCYpCWVzGKNDBfqCBnJ768oQKrAjjRrridr1o5WCxMXkmXXYWduYD uEqYR46/lCvh+F2pYB8WIgk8GEWsbNLXNu3GQ/sAL49dhrzsz05YLnW7PNvpwttuJU0G RSMBDFwymRw1D5CVpu6xSII/CHQW5QegQx8YbEAct1tWi1NZ/TIdv90kK1ynYVKIJ905 /XdoDAGTiYvaUkX6TuCo0ONNP7xKVaTD/kLmoLL23Pwrec1VO4kkgy/cZZ1uPr8m7a/w XSCg== X-Gm-Message-State: AOJu0Yw4gF3aNEAn11fd5PHdQkt5PU3zbEltVk1hjhcHyLbwPKAo8762 9CDKZ+iQJN65BzKs8ZeO4L7UZR+CJsihX4ZVUMKOBO2UeE0JtHXC0iVApfF3l/486SMea0s5UEw = X-Gm-Gg: ASbGncs794qULNxr2e3sgT5GJdN2yHmzdDCz+SwtMWahvqbozE7urm3OiMSqxvuq85L cQs3sjVFqIYgXJLqNFhgLk4kFSRmedNVcIjgzFzPHMuz222mXH8lIPyhV7YMa8jxXcGVxZ9klMx oLP48jGUGKUdWxD3SVn9H5EqACp4BXqoerF/JoJjUBUJast+/LKLqCDtHg/gWJbBapjAfZ+BbMz D2PbfEfEFE5tqI0Fy6D6rsrmAEzXDAbCqpL2mpChCXHf/SMovL7EXbDsdnQolv7hn7ZBf750T52 C4dflgLj2Q3l/irtMRllec9vW9v2SysCqh8= X-Google-Smtp-Source: AGHT+IFJ9Fz7L6J31yXQSIoG+rT4tR/ZhwPezpufzqmYFWE6dn44HdTsHqDRp+FDuvfW46QNgxNP3w== X-Received: by 2002:a05:6000:178a:b0:385:ee59:44f1 with SMTP id ffacd0b85a97d-3862b35538dmr8483882f8f.20.1733735432384; Mon, 09 Dec 2024 01:10:32 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-216460ee31bsm18960855ad.63.2024.12.09.01.10.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 01:10:31 -0800 (PST) Message-ID: <59c46287-cfce-444e-a16a-9d01d54026af@suse.com> Date: Mon, 9 Dec 2024 10:10:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Binutils From: Jan Beulich Subject: [PATCH] gas: avoid UB on signed multiplication in resolve_symbol_value() Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org Commit 487b0ff02dda ("ubsan: signed integer multiply overflow") touched only one of the two affected places (the 3rd, resolve_expression(), is already using valueT type local variables). --- Of course it's quite bad that we have three places evaluating expressions, all doing things a little differently. Question is whether unifying things is (a) practical and (b) not going to cause regressions. --- a/gas/symbols.c +++ b/gas/symbols.c @@ -1721,7 +1721,8 @@ resolve_symbol_value (symbolS *symp) switch (symp->x->value.X_op) { - case O_multiply: left *= right; break; + /* See expr() for reasons of the use of valueT casts here. */ + case O_multiply: left *= (valueT) right; break; case O_divide: left /= right; break; case O_modulus: left %= right; break; case O_left_shift: