From patchwork Fri Nov 29 16:15:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Uecker X-Patchwork-Id: 102135 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2FF2F3858D26 for ; Fri, 29 Nov 2024 16:18:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2FF2F3858D26 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=tugraz.at header.i=@tugraz.at header.a=rsa-sha256 header.s=mailrelay header.b=m9HeBXR1 X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mailrelay.tugraz.at (mailrelay.tugraz.at [129.27.2.202]) by sourceware.org (Postfix) with ESMTPS id 8903E3858D29 for ; Fri, 29 Nov 2024 16:15:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8903E3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=tugraz.at Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tugraz.at ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8903E3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=129.27.2.202 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732896918; cv=none; b=MYLth3LRckkKGK5FTXLadNFnjEA8PdzOSQKUPlNE0VYjjs04TGfJBxBjUfMEASo0ZTalg7wBLY9DBKPA+EOc+ZviJSxcamopt5I63rSRHYh9mvKDo61v6+YsZ+GlxjJKR6+ttq04a92T1mA0L4TYIsO0tGNtrh1YqSnroL9bYj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732896918; c=relaxed/simple; bh=icsZiWWbSkKBYn3Es7L7oXWrbUxx7jiDI7N1eFprhVs=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=lALUrndnAt7/Qw+LFBRNc5kJY3Rkw9OOyjcNNnZPJGdx885fXyeI4NDgcbbSOYreZ5MN5m7gphZSrgbBvF8OKIMNRI4USDn7m+ZaE5d/xz0TNOXtQRQTylsZ1FwgjYbQQK4MjmtA051XLdP6Xfev3JsAbRQKVwvFOK3iJWa0xGc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8903E3858D29 Received: from vra-171-243.tugraz.at (vra-171-243.tugraz.at [129.27.171.243]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Y0JDX5yslz3wV6; Fri, 29 Nov 2024 17:15:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1732896909; bh=of1HcOvD/F8djJ7JhQmx3tGZ3zfqn2szuTkFYKcMKa8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=m9HeBXR1PhhJu2Xhhapb/hhhKU12W+YSCRoeyBwnnNAxywh18nyJgLCsrmhXhzxDy CVxSgrRE3FTlsEtDD14BZ0PHds3YTheW/Wy0AblzPR31CJ0ef193NRmrE3CBhI99Ol EoWOZ1pnCYS2Yl9aKDDQzyK9JqvZZjsUNq4XD36s= Message-ID: Subject: [C PATCH] c: Set attributes for fields when forming a composite type [PR117806] From: Martin Uecker To: gcc-patches@gcc.gnu.org Cc: Joseph Myers Date: Fri, 29 Nov 2024 17:15:08 +0100 In-Reply-To: <49a04b095f6e80f286daee5b36d28bf076bee839.camel@tugraz.at> References: <93bdc0f1e3d8b08d52db6dd79b7565df35564cdb.camel@tugraz.at> <49a04b095f6e80f286daee5b36d28bf076bee839.camel@tugraz.at> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-TUG-Backscatter-control: G/VXY7/6zeyuAY/PU2/0qw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org It seems we also miss a decl_attributes call for the fields when building the composite type. Bootstrapped and regression tested on x86_64. c: Set attributes for fields when forming a composite type [PR117806] We need to call decl_attributes when creating the fields for a composite type. PR c/117806 gcc/c/ChangeLog: * c-typeck.cc (composite_type_internal): Call decl_attributes. gcc/testsuite/ChangeLog: * gcc.dg/pr117806.c: New test. diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc index 611daccb926..e60f89a21d9 100644 --- a/gcc/c/c-typeck.cc +++ b/gcc/c/c-typeck.cc @@ -791,6 +791,8 @@ composite_type_internal (tree t1, tree t2, struct composite_cache* cache) DECL_ATTRIBUTES (f) = DECL_ATTRIBUTES (a); C_DECL_VARIABLE_SIZE (f) = C_TYPE_VARIABLE_SIZE (t); + decl_attributes (&f, DECL_ATTRIBUTES (f), 0); + finish_decl (f, input_location, NULL, NULL, NULL); if (DECL_C_BIT_FIELD (a)) diff --git a/gcc/testsuite/gcc.dg/pr117806.c b/gcc/testsuite/gcc.dg/pr117806.c new file mode 100644 index 00000000000..bc2c8c665e7 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr117806.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-std=c23" } */ + +struct Test { + double D __attribute__((packed,aligned(4))); +} x; +struct Test { + double D __attribute__((packed,aligned(4))); +} x; +struct Test { + double D __attribute__((packed,aligned(4))); +} x; +