From patchwork Wed Nov 27 03:53:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Mezentsev X-Patchwork-Id: 101942 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 99D2C3857C47 for ; Wed, 27 Nov 2024 03:57:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 99D2C3857C47 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256 header.s=corp-2023-11-20 header.b=guSwEg/A; dkim=pass (1024-bit key, unprotected) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-oracle-onmicrosoft-com header.b=bhPPmHEo X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 6A7C03858D37 for ; Wed, 27 Nov 2024 03:53:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A7C03858D37 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A7C03858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1732679605; cv=pass; b=AF1sIojMGbdjfN19isxUBR2KuFnwgQL8WwZmv8yzyG607Ip+s/cbqCq3bzW7aKez1OUCtHNLMdZwLYyNPFleNZRch3gOFX+nnObQAUrxVM9mefsY8ihoZqngtGABA567/WHGFJhD2yrVHLWPk6u6vPIRweJRyopgRcVuLwgLkHM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1732679605; c=relaxed/simple; bh=y3ZOJcVHVmEb4TtD+XPGx2UYIeJOa4EAnokp4wZyuH4=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=qKhj51R4p8AbvFUrAM3zu+ReF81kq+1FaDKRHK6img0rMJFI/bM1VgrgB1VavcKGAi3nu4aw+AvzqStletWhhsLd6LV37/8vNHySaUsYHUdgLC3iibsYZQdAiycBEpaOf7e6F/Y1OsuFda0CluDZmb59i19aOhIHUkd7CXEsYYE= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A7C03858D37 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AR0gEPp007641 for ; Wed, 27 Nov 2024 03:53:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=corp-2023-11-20; bh=a+W1mzw1y8GhNAvF dDoCEEOOFW50hrbmZ9n3xfrGtTY=; b=guSwEg/AhiXgr99P3Zp4NQETRF+JA4z/ WKz9e433XfD3b7FUFx/UkWRaJwopxPTQ7BdF3Us8J1csjI8bD+SNsF52ZZROy2gU /unhrNVB7agRy0AlrUj3Vif/I/iw/fANrBtf64gla4pexd0AnJnRdTN0UKJQUEV5 b42wDS9eA8vgOUlJszyr501rFGNtP/kcFhMU3aSnWRR/M7FNGQQfF812JrZPOcOq IsV+MXvHPJUr7ttVeEmu+MNuHhRIyF5c4kD1gGGjAPzxAgDDjZSfuE3ZY99AgFhl PTweDblIPzpU1W/Jp5FsCm3UNJXz6Vzmkk5ooWGCR6p/WDd+lqs3kw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 433869y1wg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Nov 2024 03:53:23 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4AR2C6OG019326 for ; Wed, 27 Nov 2024 03:53:22 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2047.outbound.protection.outlook.com [104.47.70.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4335ggfq2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Nov 2024 03:53:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qr9t9bsyAqk43+XRtYIuAQH1/HvphdKs+k2jzSZlkY6NJAZ0IJQpFArZTjWbQoCdDa5u7bGpNswqRl6z520UrQ9K6U9UnJVex7z+iv4Kb03kDI6MRS3R6bj28TD2fLAi62paVtetQYQmfXMhkatX3F6wJRuxM3lzEuhANrGqU0GV5G3TZbdy19mWyVUC7ApwlZnV9Zt+z0JY3Q4yf9P5YmHWjbOwTsoGc4hZWIJCWaXWVhjIwSBzhab/plOdST7WaWLOXbk+p9LI+D0l6lc31AWggl0hnXlyxzWod52YPUvA3yNz+oJncr070yUwyaly1qcf/l4mh4wG5xT2CsgqxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a+W1mzw1y8GhNAvFdDoCEEOOFW50hrbmZ9n3xfrGtTY=; b=gj2J7zhO3Awbu3WAkAuIkROyYgSp8y5GSp1g9Hp0R1QuDhwP0xytwb4yeito5fe7uZXkZZq2IL6L0lchvrebZV3YEp5NHEpquYB0lhN8lDpeohOH5Z6PFetlTj9p5yvKnV4MXZBIieYzmTsWypC3Y4u5kE9YuYAI3tv2lOnYXTe7gNMUQy0AG8+FgRgG5vWkhlxLu7ykTUzxo8rlserjWrmnm+cc9SK7boMulSnWVuRQTCMx/zgl3rFN/u/V8bkqlgzHvoWnBjLCgjaFQ3nfSRcWnRtjBygnv1FnGoXFwjtsZbUNwCPDUcj5bu2d8BiY6O/q7Q6AJVEUQwluDcUjsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a+W1mzw1y8GhNAvFdDoCEEOOFW50hrbmZ9n3xfrGtTY=; b=bhPPmHEoOkvTjJVZKWPbAb3s6vlTDOhNRmb3HCLnLrlMdQn0KYEffdZLz266/NI7eUCZtX6mbLZPi8/sQPh48Q+ss2KqemMyu6YwHmgLA8fDUCgJJEUUPewPNCYAxqyqxJ5QaVqFIdI13uoFIwC/7JMPz+xBbE2+XzLSo3c/JpM= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by DS0PR10MB6101.namprd10.prod.outlook.com (2603:10b6:8:ca::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.20; Wed, 27 Nov 2024 03:53:14 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::1b3d:bd64:9100:c3fb]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::1b3d:bd64:9100:c3fb%7]) with mapi id 15.20.8207.010; Wed, 27 Nov 2024 03:53:14 +0000 From: vladimir.mezentsev@oracle.com To: binutils@sourceware.org Cc: Vladimir Mezentsev Subject: [PATCH 1/2] gprofng: skip unrecognized input command Date: Tue, 26 Nov 2024 19:53:08 -0800 Message-ID: <20241127035308.3738491-1-vladimir.mezentsev@oracle.com> X-Mailer: git-send-email 2.43.5 X-ClientProxiedBy: BYAPR03CA0024.namprd03.prod.outlook.com (2603:10b6:a02:a8::37) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|DS0PR10MB6101:EE_ X-MS-Office365-Filtering-Correlation-Id: 933e48e0-9e3d-4573-e545-08dd0e9704c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: gAAcwONHK+IIVZfkynyADX+8FTwyXVrCvJ5gSm7T3gZwMVm4bcrN0izBDoA/pGhs5uZQUBkvshbvypG2lIpGBjOIQDcRATSXNMV44G49Y+BgqXapQxtLODI5Gc1JsBL/kuGPBvSnlh85JKra/Z+xWmc2Uni9VWIFdkizxBU6YaDS4VHNPlBfXBhSY6a9nX9nXOmDrNMv1dFZzXVsviMsRObhOgzwslffCUsactOJIoTz+CX/AUoyC56dUh8HEKkT9uMN/L+sA4mMN18rzL69tD91z1x14toMQZODies1Y+5dU6AOJAuFvjYmLDqj15vfgnoZ14e2KGExuu/VFwaMWoXo+Wr/VGP5O8grZdqmRFIK7MBTd140vQOWRZYgMGLb6ZcqR4htFpBYaia/sQ1J5q3KXcGaQLI4KvpZTbDR6jDnzdL2/bsC3pdw32wNbprCCkjzgW0nWa63HE8j0iZJaR/Q3rG/IFc7yBnemE3mhkUEIiKHumcRRshQg553rFySMFmT+RCfH1sVOr46vZZOmmKM58VJm1Sffq5Wb/DFvTv044IEfNVxvqycHFFhnd1eUyPs3afEGvlWxhgKbtq9ywfjjo4KeSOJ4LHE3uJ+4ydj+RDjWpN5OwidYmP1g3U3wXzIRN9c4WRiwjGYoCmXJJhkJsu/tJA/xNyJ6Ar0pKre6S3jZOtPHluQY9cpHDDWfoEvg5cQGXeIEVPJK4Ty74tVGR0WiRYYoZobH0iq/SnsV0rMCORa/D4WZO6hUN3Kr+L0Pk2roVA4PMuY/VaLmYN2PqgUO25YmgH4cMYPr6pygUsv3wNCoHhCcm2UMnjFB1QT7MJm7mE+juoKe0y6mpL/1Igi6DIrnu3/lkluu4zzrHlBY9mfb1iVfxbcoE5YZ4kDCuJW3ewHKrFrXEVO2VKCwiSNA5yxp5DPIIKcTyIOHE79mdj3rIDoCUCgAlgJ3cdNApG755jOdKDdWQEA3ZxoDYIe5kkbZwdCngIOFAc3xhZpaZiZamU2TSL0l3kxg4gpX6bFJ3qcV6DwhnY6/g1FAXIZRcGPgWrA0Bdg8fMn3ASNQdhDIN7AHM/3o0UzxTgvff45Wh0gJ9kSf/xc2RHbPCVwSRQqbJJ0Lvng37n22FV0/4GDVAqX7CI5JRsKlVN7Bn/8/e9pu3+mNtZqDVdHtSr0G+FsgN46fbc44IOSFckReYyqv71knxdfcXyZwhe2PerrYnaYhNTtFEkcz8hZ/AkuGs9Q+YAEJMIuQ/0bbWr4oQypUg7wt8CkVKjlbnAbwVRFdLTWSavbeEAApM2cIcB0TatFZudi+A2Y7RdV7wdpqCm161mTDYQjM4f8Xr+wSgDlHVAweFgDY7u5hQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(10070799003)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ObVr58oMuy2yEQKt/4bpSiiAMWAoHRgVadHN98LHntCR4lDELDHiu1ZCfga68CmoL93c9HmdL5YodWt1uuQfzfsPHgWNssFHDoI3QCQAixrpP/zLC7CQWFopQPTPriEVG11N5I8wHRJ9AlqELfGB9r9k1qjy5ZN4vnJ3VLAEvTBwSBVSXeyGaVELCrfWGRmed/a49Eoo5CvE0lq3aAk4i8aYqn+93K213nmD2HXUfDu+J+pQrPC5WaMdRy/SDMXi4m3/ZNzEwyJ2UlwF59SYMems6bU5FefYLOGjGYptXbM1X92muBXtJcr5Unjg9ZyeJ50uwadCnUJQudC7LInZ3uvbhGGYtuyn9+oKE8iiLld9l/QLNoZnEgUagh6bzf4Nau76k2sDAJgtRmXh3gfwMreIUrS2z493KoEpwr0oWjmJZd7mTdIjY+M4vJt5VOmrBGtys1e5YBi0T7x+U0YeDMgNt4hhyKXkTdfmF9zh1fNleY5Ndxx6ue4CbV7s5A9VSv2QsceKfta66WFOzr6eXT9+ck5Zt4++euUKoBEaeilyUQFEMWaKPrdSFW9gZnwtbQCD4fPadG2k1QgmAwwgn+jclYdHGbwVHhr2am9uZ/lM7DO5cp5SwBLIWE66EClHzLSRWd9ugQta0HNHUQQ1MZ1YVgWHN6nbKPROhSpuvw45VOtkxwt6i2+jqNir+KoTaij83Jz0rvSMYx2AmpHTEIuZ2wLi+9ATVYAWOa0rt/Wu2Evl92j4/O3vSgcBahc9gtr3UD8Am0146u4TS7iJRazn2MWNsqYAKvIz+L/JftLcem0PWr4pD8eNDU9jDrz0RcGAcdXRigF/CnGzZ0mN5UZI17cwRsRh1M/18C3CIv5thCIkh111ffv0B+7hPw7Gq6Vhcq/ei0WOQdYKVd50SBFUuyCMJR1NtzkD5c5jHdKwGZKOTPezYnUFeR2dhsJXKXLdGLA3HH1JUZwqWs84/SzqOKxkRbJmTRvT986UnkohCamfh1bt7/ruyzIUDepr09Cz+xFKrSoKxz3kufLGwnQrfsk5uNsLKD4nYjjr4/VFpNw3gJS/PAjCTiqvorHA3ANAmlAWz+i+Y+CeA0A6izcU/VAotYDVl4GL1DNBCfpTLtr1v/NtUJlhx7/BhmuoAnF1eHY5IwA4t5LJqVjx8Lckzx+vZVH431m4VXEKETjfK7Re/5bAFEMuSR5ZxdXKDbZaTcEB0J8/mjb6CLh9nHWHXdM9eSp4pXI9ja1VkFm/Cr976SQLzso0SENyOJg3pnkshBfaWxbIAdYKCKM96iDcpiD/YDHsqvJOK0JOVP3bfHpjgtwFDThXFk73jfziiJmQbcucZtTUDdW5erj+Jkq0cmDUMRM6OJE5iGri+faZ7FHtFkVgYdWuvMRw5NWsaixb8AI3mwAHw+QUZi4p+qFfWTg1fcu50P/2D/LLzQuRLiGlEOiUfBRrwErQXkpyZx5pswZ3/C3NEm9on35erw+xZlSnWlje0io0o+p6ixe0gR04Kn0EdGw8W0iA1rzhQqG3jXqnjdomOUV/3yc0TSRv8y4o800x5MqVOvlSIyHoutkzypXaed54egO+JGTmzPG+4I8gpihehGVaWR/zkkyRI6CRgs/tRRQ/HJT16pnAzL0BLOphdZTAIKIPJL0c X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LHCRvt9iqKim5TGkH1UI6Nc5dBICg0TnQ/MqsNmBwC2W7zjPxaPSBhBFlmUAs156U7gbzMKUeC8APPorLZeDSJ2Trxd+4HbG4abYUCP4xKppW2yMBhyx07saYLVjvtwzwPDx91lXXUIji0W4oFvFORuD047HpqK3c+yj5Lj0dItNSRR/wK0aZtKocscqEGKXlA9Bv00jUApgizUxYdcHkM4wnd19VuEaIxZF2UgEtzrhQP+lkJz3yTT5hClYQA5siYbzzBYxbY0u06KTDPQzMAbMLhK2Lw28oUOapA2t9pA/IB+LKW3nA3niNhgQXArw2DD6sT0K0PhWzoEmPylvlHbkZrmsjcMQm1Fkg2Kx82DN0g64it727RLZfDSkSdaw0yGQmd4ukgwiVwVgBUrWDb+cauWiuZfWR4X/vNoI0ry+YFXTdWnvNZ/1/UJlJNuDowCjOWVvP82QlDXE+vRSue5yDgQpomo66dd8gv2IVVCDddzfvJAuj3HYcUtvcvkfDv0rpXAojtYikIcM58tAMwvnf5OcoTEDbeJOJ/F7OwxNXdTeCryB+Ew8nx0tP1W0+pXCMRa63NDZ9WQXsHkK/J3qJTWudJYI3bvtu/IjUUM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 933e48e0-9e3d-4573-e545-08dd0e9704c6 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2024 03:53:14.1921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: umUJOPfrr5GvxPvNPYgeJYuEa8x1ORaz152XV72GoAvCwRfelQsPIwqYyJD8bmVuJDItQchM69MaDeKh45AuL1NjO1x/CabOtrHLGTJscns= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6101 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-11-26_16,2024-11-26_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411270030 X-Proofpoint-ORIG-GUID: j9Hr5KxYOs-hVqgAFnQPM47lqLSru_pz X-Proofpoint-GUID: j9Hr5KxYOs-hVqgAFnQPM47lqLSru_pz X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org From: Vladimir Mezentsev gprofng crashes when the GUI sends an invalid command. Skip unrecognized commands and return an error status to the GUI. gprofng/ChangeLog 2024-11-26 Vladimir Mezentsev * src/ipc.cc (ipc_doWork): Skip unrecognized commands. * src/ipcio.cc (writeError): New function. * src/ipcio.h: Add RESPONSE_STATUS_ERROR. --- gprofng/src/ipc.cc | 6 ++++-- gprofng/src/ipcio.cc | 10 ++++++++++ gprofng/src/ipcio.h | 5 ++++- 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/gprofng/src/ipc.cc b/gprofng/src/ipc.cc index 3e706dbc9d0..feda1f8eb08 100644 --- a/gprofng/src/ipc.cc +++ b/gprofng/src/ipc.cc @@ -2534,8 +2534,10 @@ ipc_doWork (void *arg) } else { - ipc_log ("Unrecognized input cmd \"%s\"; Aborting.\n", inp); - return 1; + char *s = dbe_sprintf ("Unrecognized request: \"%s\"", inp); + ipc_log ("%s\n", s); + writeError (s, req); + free (s); } ipc_log (" processing IPC command %s complete\n", inp); free (inp); diff --git a/gprofng/src/ipcio.cc b/gprofng/src/ipcio.cc index 8ff16d5a8e2..c20a22f9b60 100644 --- a/gprofng/src/ipcio.cc +++ b/gprofng/src/ipcio.cc @@ -776,6 +776,16 @@ writeString (const char *s, IPCrequest* req) RESPONSE_TYPE_COMPLETE, RESPONSE_STATUS_SUCCESS, OUTS); } +void +writeError (const char *s, IPCrequest* req) +{ + IPCresponse *OUTS = responseBufferPool->getNewResponse (BUFFER_SIZE_LARGE); + OUTS->sendByte (L_STRING); + OUTS->sendSVal (s); + writeResponseWithHeader (req->getRequestID (), req->getChannelID (), + RESPONSE_TYPE_COMPLETE, RESPONSE_STATUS_ERROR, OUTS); +} + void writeObject (DbeObj obj, IPCrequest* req) { diff --git a/gprofng/src/ipcio.h b/gprofng/src/ipcio.h index 23c35fc33dd..7cef74311b8 100644 --- a/gprofng/src/ipcio.h +++ b/gprofng/src/ipcio.h @@ -40,6 +40,7 @@ typedef char *String; #define RESPONSE_STATUS_SUCCESS 1 #define RESPONSE_STATUS_FAILURE 2 #define RESPONSE_STATUS_CANCELLED 3 +#define RESPONSE_STATUS_ERROR 4 #define RESPONSE_TYPE_ACK 0 #define RESPONSE_TYPE_PROGRESS 1 @@ -60,7 +61,8 @@ enum IPCrequestStatus IN_PROGRESS, COMPLETED, CANCELLED_DEFAULT, - CANCELLED_IMMEDIATE + CANCELLED_IMMEDIATE, + UNDEFINED_REGUEST }; enum IPCTraceLevel @@ -151,6 +153,7 @@ String readString (IPCrequest*); void readRequestHeader (); // write to the wire +void writeError (const char *, IPCrequest*); void writeString (const char *, IPCrequest*); void writeBoolean (bool, IPCrequest*); void writeInt (int, IPCrequest*); From patchwork Wed Nov 27 03:53:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Mezentsev X-Patchwork-Id: 101941 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6FF813858031 for ; Wed, 27 Nov 2024 03:54:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6FF813858031 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256 header.s=corp-2023-11-20 header.b=LiEFihhm; dkim=pass (1024-bit key, unprotected) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-oracle-onmicrosoft-com header.b=LHupkhv2 X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 0160A3857C78 for ; Wed, 27 Nov 2024 03:53:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0160A3857C78 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0160A3857C78 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1732679620; cv=pass; b=STd7oMpXJLHK2jVOXS7S/Wg2AXu1TyNN37yqPVmTUHMqqOloXY1C07EpBTz0pzDLsnAzF256FkHXUmnJGRy0UYC3DTQ6T83aCw/DYqZagVjJ51LfgDIIptqVhTOPtw21vR9hm/lxp37M4Gtl4r3W/6wy07lbBvvZ9E/iee2ZmpU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1732679620; c=relaxed/simple; bh=b+IJ1gSzYfv6EMmeggKsZigM+v73f8EFak9ROjgggOY=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=sPpEvkVZBSIp8Wo1fgZLqKyEO4Wqb68FBQTKEyOtBsJiOWWZTUIyE5uf0sbrEt6cTp2nhMR7Q+mStgnBH3hlhL2EMRQsQMHONZMgxy3i7DiBucsKymKwGqJz7Nxrc0j2EK67VQCLOeasdsY108jnMe14AkV1i+P6mEWpRsNrgnA= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0160A3857C78 Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AR0fpWb017610 for ; Wed, 27 Nov 2024 03:53:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=corp-2023-11-20; bh=DU+2ZXxVSxtN6nSn xNVjDpcI1RHdEJUl4A6llwFtJSc=; b=LiEFihhm72CscsDjWn5bxqjKTBlJx8xL 7NUsXOX8/gMjwCQ4PHm6ROP3nBXgvCDVZtAtxvNDmJeN7qsYbZh7UA6lykpXdhaT YGeVm8vIv+AbR0h9y62QJ5/mOaxLMPAxvOjBldVlRwUJY5JRILJMmCzcF7GAcZsb JO7b3D7N/Iy7LiGx6nSqS4Qx0bNqEXdne96HaHlWbMX2783P0tAz/lnlFF61mDjC 2Bunaf/Lo5NaI0DPv8hCfwQ7/9lAZklUbLUxkNrYeYf3FfGrhasqmHQa9egK/rnf k8F8dFlkjOETah0eBfZ9IODXRRoqQ706qkpfWLUHzKdNtytsl41BLA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43384gy3fq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Nov 2024 03:53:38 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4AR16Y7j003895 for ; Wed, 27 Nov 2024 03:53:37 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2049.outbound.protection.outlook.com [104.47.51.49]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4335g9w8f5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Nov 2024 03:53:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xQ1Lc9oZorqPLzecP1IHK1hNbp7qHOagVZ7qKVwzxhGCn7cK/RipgsG5eUHF/qKxjXdkLbl+sDs9CbStop8F6ofA3ZjgxosKlmVxprNCAQJVvFpDjwqOzblIdM/eGwiT+MNFiloGmFFjmKS1FmJdIAqOJQLGZct2w4cwiySYFnxcvzEHpr5wEkwq01arBqTEJaY9fLQ+F0cEJaxjgp3JbV3iSxcvHf2bvq9oMAu/czJYbyojxa7af319u9z7jzwmB8WZpJfArq97RVB7v1WSaWBwtTDac6pzsAMUyDdjTOeerN4bpJJqrqdsR1zo2BODo2CCkx4tppvag4NCPOJYqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DU+2ZXxVSxtN6nSnxNVjDpcI1RHdEJUl4A6llwFtJSc=; b=jK3kJUmnwEfD5NgpalrFU54Y2xeM1CKB/dtvsdHARQ9/rU4cIPMxjTUROB0qKnOUnro3u0eVuaGLGKIsKdYw+CtJpqWnygTPGw8/GbAG9+4+EpSbhbpclb7ZfTq6ToUvl8rkeqT/uhMs+lFZOp09YtEishzHLoNi3uWLWNl7YWTONy3CBJtLhKr8umi26WtChYcOfJUW+Se+Bw5rdazTWXH/0+KwciBsmClqdyWNTevJm0jfwJMLjbAtBaVxkL+Baqrd8tXm7vR/YsYNTLOvdomBRjC3qlnbavmbsgKHliUo9evFpJHOuc5mbGaSUSuvF+7Pfy5vfTCihsNiNMhDcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DU+2ZXxVSxtN6nSnxNVjDpcI1RHdEJUl4A6llwFtJSc=; b=LHupkhv28Tf6nIKsIJPr72w4WRZEpdDwz2/mBMgilbq8DbnDy6zwFtMgIVMnAzFox8J6vMG63dxJi7G765vB6qf/RiDW/RTi6wRyR8vyqgdVWPSeoRoTM39RKa0xuwqpIQg2krUsFfREdBmQ47LqeZG6ZUJZgcZxx8u738Yl4lU= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by DS0PR10MB6101.namprd10.prod.outlook.com (2603:10b6:8:ca::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.20; Wed, 27 Nov 2024 03:53:35 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::1b3d:bd64:9100:c3fb]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::1b3d:bd64:9100:c3fb%7]) with mapi id 15.20.8207.010; Wed, 27 Nov 2024 03:53:35 +0000 From: vladimir.mezentsev@oracle.com To: binutils@sourceware.org Cc: Vladimir Mezentsev Subject: [PATCH 2/2] Fix 32392 [2.44 Regression] gprofng fails to build on i686-linux-gnu Date: Tue, 26 Nov 2024 19:53:27 -0800 Message-ID: <20241127035327.3738529-1-vladimir.mezentsev@oracle.com> X-Mailer: git-send-email 2.43.5 X-ClientProxiedBy: BY5PR16CA0029.namprd16.prod.outlook.com (2603:10b6:a03:1a0::42) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|DS0PR10MB6101:EE_ X-MS-Office365-Filtering-Correlation-Id: 03c987b0-0e93-4566-5fba-08dd0e971155 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: ujCyJvPXH92L8eEMAqoW/KpVgxgZ0XlakaV+0jjtkxTBfFSlhC/QbZkCvC3UomMtIxQG957jBJMmPL5cPOfVqydSsQGwFBmJCxUdWIEzhkCb9V/18gS42iVrt2EHZst4uF0AhEZiorLw453R+TRh3zkA/9HM8ELm4G7M4LBVuhmAFai0FH+Hwuvc2Zuk1HitBUN/izU+2E7inc9P2N2p+JtWIVH/6ZKAqCtotx1aPijwdAqUvqPHZvHlZGUqwSIKV92ZvzSBSpA9B8Ko2bI6VMxlSsvgg9RcjLw3KLl8AkcolPygsqOR1oG9498ysgesqRst+bHz5TmgpQXC9TGVDLmuz82GjOuh0uzeuXLJpxQ/uwc60qh3adsCwwkbB3FrdCCP2482qKnXgt95iUpFgfky61uzV0NGze7kE+3HSXb9ELzBaBWRPWZV8e5Yym2Apy89raed1rq8BDMr51JkdBO7FIGDXgyzo4RYJE0EBYCKfOrBlZzXKFdsFVJMIOwrLeUVtShYVDqYZYDkJX/K/U/6OdV2zTmRglAiLjwDC8UHgE0o95qAXKfwLUVYzF5/q+BE/SJrGB+Cq6FvTI0QrsqbNUJjmAjYPQC7RkYXyLYs07p8jRZ00d7GGK0IfxtYWWgQTAtQATDsVrpw1r8Jxg8rl0Sg1AZdZaU6pmT5XG4q3ypgtO2hqFEegD5KhCYFmtygU/DCK/0OMhgqpLYuoiitpcxWWXZus8yKeTAp7Vo0DUB4XnyrcoiBs9jWXTRtZDUhhPazgu3rAb3OTsBgtuvULmngeRFgZo3zqn1NoqCpaX9DbucR3RqMQCZ04it2HxcaCwyBCR2tb9+RHpZT6BCLuEiPezEoezlEtBAXSo3HvHh0kkVI3PSBB5uG+ESAe86j40SVXY/zjm0bQsKvtmlndS3M+4EtHxuCjr6geJm+U1SRYFCd7s1WC2KT2wCEmTCIB47K+6Ku3qe7IaiRV0jqv8oGgksAftj1Y7+/W+U1jqMl0Pgwa86XZ1YvAxhmHXP2Kg61ZXQx67yEdyuamc7vNHw0Lxd2PaCQbIcmmexev2EmJGbbhQ98BPXHjlZqBgbWTBjALwQkfb6/irvltYwN20F5emsfXD7NlqqRICwr/iMDamStfq9A3mIN+ZK4YIshfZiBCSKtzmeOM+V0b4/ahX7VWnbBvG3GFD2FeOKSvvf1u9ndGvMh/KkpcZBaTPTYqthyqEG5u1sjZocY1Z/kv7j46ulgyZOMIsyyCMvo7hgQiOa1Rf2Wx+AgvFZtEQAAIkyB7JPkZgXMw/1umwrba12QM7ywc9GWyVX2WUnpQE7t+/9p8+NTs4gg93sk3MKMQ4WZmlQGr/OiDit4nA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(10070799003)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VVIMiIVOy3QdtyyZ1Zr37OMhMxq7jYtmdszO1Znt5d+UoLtZwv4g/aMp/Ef5HrRtXoOUDgVyyqLevL7iM+z7tzDuTNJMZdwia6r/DPdUHS2s/KWDbolZ5jE5wWTq/fM84OkvWM8MwUVDpgIie18qoH1kda9e2I/10rU7+9hJXmv0K96HCpX7+DPdGtd1vJ6ffPbvooWJTUlorDekehXnEIXhQfiCIORPOfOVzIAyFV/6DTOdo82jLMcFItFS2QEqnUhD9Q/+kZU5T1WJ6CY5Ivry9WIdpwBUt8ogi5dV+S7KvwY9kBYPa4hKdI4DazojHrWSLOK7yhNebdC1mgBpaEKg+TdKya0NUZjD6szc3R7Bk4QoN1V3ARVonBBt4YM0yjUwa9kmN3wCwhgfWQqXHBcrW5sMotgxnuXiSmOSv8Ls/qMesp1azey+7/o1SZffXDD5VC8JS5jsHMG+Hj8SRZ3MHWw7o7zHgf7UfTxNStdq/vOoX3ur/WiqPkWrdVVzDr56WPpWLZertbzEh9cSMyRl+heO11MXahmPTtVY+KqAgr+8qhLKxoTIds70CgPU6YnSeRIX6ltW7dS81lL20pgV8B/3IFNaBgcKqnJamIFBeulgRGt1kQgpUI9Y+7g5MQTJgknSraPV+fx7/EKzmPCJMfLqd+MR5/sG3urqIJzhk1sMIUa2f+R0XhbX7CG+mEJD27XCWi01jmwpu7mK8DUeCxGA6fj5I1o9oyv9mUZKUTjwOseGg+APyBxEkX2kbI2DSbdp8Zx1WYWhPugVy8Lh0sR4t/cqihVtHsxPSxHzjYRsj2vJ4fPXclBhSws2ZCNtz+jCjrktQW6pL0sr9zsK2z/BxtpXdqc5czETX2O/hkuJKZis/72p7hjgPGIm9Qb0Iaqo93SMFKNptNHasz3SgR68jOPyqMd+fSkNQnY2iRcmhaygxs13rf+qojYU9xeQx3NOLRTzBmndQMzNMLVhpXeoEaaNRRDnzVvGW5wOt3+kH7HAwd3ABe32AYkS6/LmhLSyPqcxhXuSHZsgKm82nFNc0jkikRr9LCLuGeqqkl0DhevFBAhm28erKy0pBZCwLBYeGfSELzDDckxbG+VlFmrHtUpzlW/o++0cbpL30xbGK+ltn611Tl8N7k5UzyiF8jx3gZwp/6ypOidfPMX0WtxgNE1RNn26o1Nev0WwFSyr8acO8yK0oytXNycReybs50HO0zC2yqyMpKnKiJ9dX5hDdYaU6aBJObbpqJqI8DSuGf7mZ/qC8SnBUcZVz7MLaCYp/KdGcK7vlo42LEM9kQrRgYak5FOfuvJFfJdrp5nRjUjgcAiffjpgftUiyGqW/BTi2lDWsKXf7waF+dDbJShua3qffHB9zaTAvK6nmXHOI3KTDR1I9bz2Y+W/L6zPsuUomZXWGXB2pYnLCi7raeXoGSVh2EX8+xC7s/DWxKRl/dJLm8dyy45wHH6BKMgS5x7vYQvzscVieG4dHIPOKdoVL4QQw7QXexdebyd73YIO6DZEwyfkrrjstCqGEA/gCpq7nqiKrEBwVfDnUWrvojo6WFUzYzskJbwIuUFOJI5u2npRmRmDXF7cQDymUGRtLAZLBYS9NsITVamoSbH0rGTaSAsoAIAv6cusKg/4ZkJQYhnDNoLUGbzyM21m X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9mLia8OSuNeYUnUr0WhCG67a/VfUGH1eGxlEKoo8nwrPmq829DM1aGAfSV2zU4ITcKNFAhbLIrg5yf0pU2oqxgiOWKZBUTc6HnDMPFe0i1cY8AzMRbPwOFrLK8pSuMhyauxBzjoJC/9j3Suthzk4o0+eBxCjz+8jRnepepV+Q4PnJZxxjifv+Fu7WjsLoZjiaGRFJdW+xr5jhcarG/jf8CKUL+dZWI6YimAk5mkqEU7ClfZiz4DoXBw1/AtDkW+nG+tiak1bFx41/IsV4e/T8kTSQQhggcQtsfc2k21brt2UHswlzOeuL4Dr+j/AhUPVUoxG0tZEGriMmTPmotNH22O3+9EDo0lFzXXqq/dQhre1aUcG1urfZ9tHedHG/QBoFy2BEE/3xRo+ka2bwbEJmOjlmeDS0yEtTKEgl50m9C6JFssDJVZ4IldTmyvtiyMh/zRWKuARyP+vpriHl43Bf7mV9FQwEnz8/+0bqeppaP6MgUhMMqZRm28nFGMS82WbylXNjWNMBfai5FXpJADi6X75uY977U8osSKEb9wLQqnYUop2lzl47p3mM3a25TY5CoqUcb5pGt/CfmCZU25Ya5YR3WhFCQcHswlrZvbMVaw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03c987b0-0e93-4566-5fba-08dd0e971155 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2024 03:53:35.2021 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d5O7qVQeCtPf3310uI4AEVxeR0iSMJVmeIxQeQ6pwUQ2La0pUh7L8YACJvhMvGDgiZ6CKNwDa5hgmjQJVg0tUPtn7Ysi1HiljA/gv8dgN+Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6101 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-11-26_16,2024-11-26_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411270030 X-Proofpoint-GUID: 3oNCAmI2H5fneFYo5sQaMit1PsCFwNaX X-Proofpoint-ORIG-GUID: 3oNCAmI2H5fneFYo5sQaMit1PsCFwNaX X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org From: Vladimir Mezentsev gprofng/ChangeLog 2024-11-26 Vladimir Mezentsev PR gprofng/32392 * libcollector/libcol_util.c (__collector_util_init): Fix warning. --- gprofng/libcollector/libcol_util.c | 51 ++++++------------------------ 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/gprofng/libcollector/libcol_util.c b/gprofng/libcollector/libcol_util.c index 77dc886be22..6be8b823cfe 100644 --- a/gprofng/libcollector/libcol_util.c +++ b/gprofng/libcollector/libcol_util.c @@ -1139,22 +1139,11 @@ __collector_util_init () err = COL_ERROR_UTIL_INIT; } -#if ARCH(Intel) && WSIZE(32) - ptr = dlvsym (libc, "open64", "GLIBC_2.2"); // it is in /lib/libpthread.so.0 + ptr = dlsym (libc, "open64"); if (ptr) __collector_util_funcs.open_bare = (int(*)(const char *path, int oflag, ...))ptr; else - { - Tprintf (DBG_LT0, "libcol_util: WARNING: dlvsym for %s@%s failed. Using dlsym() instead.", "open64", "GLIBC_2.2"); -#endif /* ARCH(Intel) && WSIZE(32) */ - ptr = dlsym (libc, "open64"); - if (ptr) - __collector_util_funcs.open_bare = (int(*)(const char *path, int oflag, ...))ptr; - else - __collector_util_funcs.open_bare = __collector_util_funcs.open; -#if ARCH(Intel) && WSIZE(32) - } -#endif /* ARCH(Intel) && WSIZE(32) */ + __collector_util_funcs.open_bare = __collector_util_funcs.open; ptr = dlsym (libc, "close"); if (ptr) @@ -1183,42 +1172,20 @@ __collector_util_init () err = COL_ERROR_UTIL_INIT; } -#if ARCH(Intel) && WSIZE(32) - ptr = dlvsym (libc, "pwrite", "GLIBC_2.2"); // it is in /lib/libpthread.so.0 + ptr = dlsym (libc, "pwrite"); if (ptr) - __collector_util_funcs.pwrite = (ssize_t (*)(int, void*, size_t, off_t))ptr; + __collector_util_funcs.pwrite = (ssize_t (*)(int, const void*, size_t, off_t))ptr; else { - Tprintf (DBG_LT0, "libcol_util: WARNING: dlvsym for %s@%s failed. Using dlsym() instead.", "pwrite", "GLIBC_2.2"); -#endif /* ARCH(Intel) && WSIZE(32) */ - ptr = dlsym (libc, "pwrite"); - if (ptr) - __collector_util_funcs.pwrite = (ssize_t (*)(int, const void*, size_t, off_t))ptr; - else - { - CALL_UTIL (fprintf)(stderr, "collector_util_init COL_ERROR_UTIL_INIT pwrite: %s\n", dlerror ()); - err = COL_ERROR_UTIL_INIT; - } -#if ARCH(Intel) && WSIZE(32) + CALL_UTIL (fprintf)(stderr, "collector_util_init COL_ERROR_UTIL_INIT pwrite: %s\n", dlerror ()); + err = COL_ERROR_UTIL_INIT; } -#endif -#if ARCH(Intel) && WSIZE(32) - ptr = dlvsym (libc, "pwrite64", "GLIBC_2.2"); // it is in /lib/libpthread.so.0 + ptr = dlsym (libc, "pwrite64"); if (ptr) - __collector_util_funcs.pwrite64_ = (ssize_t (*)())ptr; + __collector_util_funcs.pwrite64_ = (ssize_t (*)(int, const void*, size_t, off_t))ptr; else - { - Tprintf (DBG_LT0, "libcol_util: WARNING: dlvsym for %s@%s failed. Using dlsym() instead.", "pwrite64", "GLIBC_2.2"); -#endif /* ARCH(Intel) && WSIZE(32) */ - ptr = dlsym (libc, "pwrite64"); - if (ptr) - __collector_util_funcs.pwrite64_ = (ssize_t (*)(int, const void*, size_t, off_t))ptr; - else - __collector_util_funcs.pwrite64_ = __collector_util_funcs.pwrite; -#if ARCH(Intel) && WSIZE(32) - } -#endif /* ARCH(Intel) && WSIZE(32) */ + __collector_util_funcs.pwrite64_ = __collector_util_funcs.pwrite; ptr = dlsym (libc, "lseek"); if (ptr)