From patchwork Mon Nov 25 17:57:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinevere Larsen X-Patchwork-Id: 101842 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12B693858424 for ; Mon, 25 Nov 2024 17:58:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12B693858424 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GK6XFMgr X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 318683858D29 for ; Mon, 25 Nov 2024 17:57:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 318683858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 318683858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732557455; cv=none; b=H4JWV0GV8GWCY57hCoa6X8BXtZJgKWocBKf/HrvbfiXzqyZ2hN1sN7d2VRBIFxXk8rqDmCpHeQmdVf51UfKkjm3IhHKO/mrAn9LDBvcwg483H+Aqb925BTY8NsOJ0gMuHsUVGOtbz6R3GtCDz7p/hmRXlHIlSKBOGAcZ+jJEYxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732557455; c=relaxed/simple; bh=vfQPCY1i/p1v34TDJTn1JrsRZy9rLsdCcI9wf/okgJg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=w/bKFCj0Ulry80dPWIn28m5BNPNrBKFHbs975RVs/Xfkrwvt0M8vKZayesLh1a+qVDJJ1fyJb4kYwItdy9ynQYOwDpABRFmHj4NM+pKLC6ZzxWQh4S9LAN/L4clY2NUuZ8BjSyWR1j2XeM4BPUnVBucjY6iOcu9frouECkjjm0I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 318683858D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732557454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1+9NAEkotRh4v9OWzHvhdx6ZqDIxA1u2Pl/FRtCfyng=; b=GK6XFMgrJWQVevz9VAGPBG1D2dDedtoC1tRN7U/1eJ7Umv4PZaskN1SsVPuzQSutaRhrrH l0xM7j0ZXRBWg2Y6mj6F97pfEB4K35T9L/v0dWBcRVaAiML5Vm/xHq4NgA6m95tFY6BNaQ uRUkezZDYF/Bas4rhl4iuRH1R/K3kVk= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577--Cu26cnwOd-a-A4Zuw7J-g-1; Mon, 25 Nov 2024 12:57:33 -0500 X-MC-Unique: -Cu26cnwOd-a-A4Zuw7J-g-1 X-Mimecast-MFC-AGG-ID: -Cu26cnwOd-a-A4Zuw7J-g Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D15EF19560B0 for ; Mon, 25 Nov 2024 17:57:32 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.173]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5ED691956052; Mon, 25 Nov 2024 17:57:31 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: [PATCH] gdb/testsuite: make gdb.reverse/i386-avx-reverse.exp require avx Date: Mon, 25 Nov 2024 14:57:26 -0300 Message-ID: <20241125175726.1012519-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3w2CFjZLQsZTVUQSXny-VRKlZcyNROiBhvtDIN_Uovc_1732557452 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org The test gdb.reverse/i386-avx-reverse.exp was assuming that if the CPU was like x86, it would have AVX instructions because I didn't know how to check for AVX instruction support explicitly. This commit updates that to use the pre-existing TCL proc have_avx. Also update the commet at the top of the test, since it was a copy of a different test. --- gdb/testsuite/gdb.reverse/i386-avx-reverse.exp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp index 6d8990067f2..cc920d3a2f3 100644 --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp @@ -16,15 +16,12 @@ # This file is part of the gdb testsuite. # -# This test tests some i386 general instructions for reverse execution. +# This test tests i386 AVX instructions for reverse execution. This +# is supposed to test all supported instructions eventually. # require supports_reverse - -if {![istarget "*86*-*linux*"]} { - verbose "Skipping i386 reverse tests." - return -} +require have_avx # TODO: this is the case because I used xmm15 all over the test. # Some parts of the test require xmm15 to validate some code paths, but