From patchwork Wed Oct 20 10:24:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 46430 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A67C3858005 for ; Wed, 20 Oct 2021 10:24:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A67C3858005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1634725480; bh=584WGfFsMQ4HE0xanKisH5GLLDOoFlgebYbMhf/wZCE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=UY4R6uAk8rlnZL+WkJGwrdL4xmZ33pOAAnP1xI37RVHk3QbUkZ/SMWBOEAhy+gOmJ GcKjzLUIMeEPEz59Y7tnxUAf+Js5FQL5LZ4cZ+cnuk52r5SIL/C57kZl2x/tVbkn35 9BQJQC04XvAHU9j7cM4rFaNfvqC30wqjflhpSwPs= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id 8401F3858419 for ; Wed, 20 Oct 2021 10:24:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8401F3858419 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-a6ZGxV_XPsWu2p5wgClO0g-1; Wed, 20 Oct 2021 06:24:09 -0400 X-MC-Unique: a6ZGxV_XPsWu2p5wgClO0g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D387C1006AA7 for ; Wed, 20 Oct 2021 10:24:08 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78535100164A; Wed, 20 Oct 2021 10:24:08 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.16.1/8.15.2) with ESMTPS id 19KAO5qj655960 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 20 Oct 2021 12:24:06 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.16.1/8.16.1/Submit) id 19KAO5pU655959; Wed, 20 Oct 2021 12:24:05 +0200 To: GCC patches Subject: [COMMITTED] Remove superflous debugging messages from the threading registry. Date: Wed, 20 Oct 2021 12:24:03 +0200 Message-Id: <20211020102404.655908-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" These are some random obvious cleanups to the threading dumps, since it seems I'm not the only one looking at dumps these days. The "just threaded" debugging message is redundant since there's already an equivalent "Registering jump thread" message. The "about to thread" message is actually confusing, because the source block doesn't match the IL, since the CFG update is mid-flight. Tested on x86-64 Linux. gcc/ChangeLog: * tree-ssa-threadupdate.c (back_jt_path_registry::adjust_paths_after_duplication): Remove superflous debugging message. (back_jt_path_registry::duplicate_thread_path): Same. --- gcc/tree-ssa-threadupdate.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/gcc/tree-ssa-threadupdate.c b/gcc/tree-ssa-threadupdate.c index 293836cdc53..8e6f043bb44 100644 --- a/gcc/tree-ssa-threadupdate.c +++ b/gcc/tree-ssa-threadupdate.c @@ -2295,12 +2295,6 @@ back_jt_path_registry::adjust_paths_after_duplication (unsigned curr_path_num) { vec *curr_path = m_paths[curr_path_num]; - if (dump_file && (dump_flags & TDF_DETAILS)) - { - fprintf (dump_file, "just threaded: "); - debug_path (dump_file, curr_path_num); - } - /* Iterate through all the other paths and adjust them. */ for (unsigned cand_path_num = 0; cand_path_num < m_paths.length (); ) { @@ -2409,12 +2403,6 @@ back_jt_path_registry::duplicate_thread_path (edge entry, if (!can_copy_bbs_p (region, n_region)) return false; - if (dump_file && (dump_flags & TDF_DETAILS)) - { - fprintf (dump_file, "\nabout to thread: "); - debug_path (dump_file, current_path_no); - } - /* Some sanity checking. Note that we do not check for all possible missuses of the functions. I.e. if you ask to copy something weird, it will work, but the state of structures probably will not be