From patchwork Sun Oct 27 20:07:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 99684 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DECC83858415 for ; Sun, 27 Oct 2024 20:08:32 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 525223858C41 for ; Sun, 27 Oct 2024 20:07:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 525223858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 525223858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730059675; cv=none; b=UOl0Xr0e2PFiuFfwIkQIdpheuV34VFcWnd9KGTxqecRLYYke4vqLGCotKkN1XpwyNTWDk4pR28WftwwKfuGJPbi7e0XG3kIUZt3CJv7oE8e77+0b6eKcJRBoeMtmhINJQIGqunsCnVyvPKompfDgZ5wXfrXwzZGr9tGlVmnWWBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730059675; c=relaxed/simple; bh=vP/8K5BHuQHnR3PPPhiVpZuMKYJ5O5vNCDw5mEnNK/A=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Y98YnFs4PGesVA7vsBrMtN31L+F490SbCeX+U6/WUIYAyj6qZRJIyfiEQC9J4ZQhSp8FPpN9VHXtPVaAJs2YZLhAIJrilNqysrbzKhm8IBrxoJ4WXlxfC6sDG1AO2O5GbZuwToT9rY0LU0OXAxDuqsb9rVikoeXvHpoZi/dFah0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730059672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q/q21s9/al7yiO5t3jNNY/NKO+wlxtT75jlQ/S4+J24=; b=AxMiWqsoZT2d0dLI2As/4m5D6w3bg+pI82sIPhAWe2nSafuBa/dAAp0d28y3XgJVqCyJCY oZoAT4Vj4bumGeVqklRFX4YKEctK9uOobUc2qHR9GnpWm7/khdIYvkzzIUHWEJ1dcPUqn/ I7K7i0vAhMc98Q/RrIOzkfoCfTLiHM4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-ERiDdxRQMWWtTUk4l3ygMA-1; Sun, 27 Oct 2024 16:07:50 -0400 X-MC-Unique: ERiDdxRQMWWtTUk4l3ygMA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43151a9ea95so23575715e9.1 for ; Sun, 27 Oct 2024 13:07:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730059668; x=1730664468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q/q21s9/al7yiO5t3jNNY/NKO+wlxtT75jlQ/S4+J24=; b=ChIqj2vEmXmh4ceIIUxWa6cQ1Vkx95aqXg4ZRs+6viyAze8+EHkkksJl0vtTJDgVdb VmgDKQkbTssxYHDgJwg/MloCq31R3Ix4bsdDxWR/OUes8vEX+Je2K6kEY4OdGB/l3r3i B9eRbA4VCo50A4xJB2dV67nS1NL00UMsQ8YGg+2t4vaxlyp9d5YSJnbgwkJZyjpzioeU cyQw0QEgjd8WBQOq3i8zvxSlrvXIJkagsch7xQfhohugWaMfN3ZzRE8gTc4V7kEQo15/ 72bFpxngYLYzU066zgG9nLSuivvr3eaUawSL/CgwiDcwMJm6T+p4Vttwko4cLkpuo6um CI0A== X-Gm-Message-State: AOJu0YxHiiZbFZmo78YtZt7NiS8QdiplvxwBr1gaqmh9lPhfGcv1CqX5 BEAF+FlciCUwTqhUzJqmzg5ioQMKWiyfSE1zpqmj7th3csIHWfJvpMKLYDeeGtIljCppwmJDHU+ wJWQeusbacrMk+TR/go0xi99O/mDY/OCR1xjlSWEmlYEXyU/q+FdK9XBl4nsYbxkLsONt8OeuHg Mbd26zD74JVwjsGzX45NNGRL2QzuK/Fa5x4A6uFl9K1QQ= X-Received: by 2002:a05:600c:35cd:b0:431:52da:9d89 with SMTP id 5b1f17b1804b1-4319a55f003mr45970615e9.1.1730059668107; Sun, 27 Oct 2024 13:07:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8pG3Bl6N5gB8T0fdk2ovHaOjS2UJoCU5x3l4BnZfnxVVgRKq5KLFGVz3VPiynm47DAe403A== X-Received: by 2002:a05:600c:35cd:b0:431:52da:9d89 with SMTP id 5b1f17b1804b1-4319a55f003mr45970455e9.1.1730059667409; Sun, 27 Oct 2024 13:07:47 -0700 (PDT) Received: from localhost (197.209.200.146.dyn.plus.net. [146.200.209.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4318b57a1a4sm115374735e9.41.2024.10.27.13.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 13:07:45 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv5 1/3] gdb/features: set osabi in all Linux related features/*.xml files Date: Sun, 27 Oct 2024 20:07:40 +0000 Message-Id: <5ae0586f15def7f48516494b3529824cc552b839.1730059609.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Some of the top level (i.e. those that contain the element) xml files in gdb/features/ are clearly Linux only. I conclude this based on the files names containing the string "linux". I think that all of these files should have the element included with the value "GNU/Linux". This commits adds the element where I believe it is appropriate and regenerates the associated .c files. The benefit of this change is that gdbserver, which makes use of these files, will now send the osabi back in more cases. Sending back more descriptive target descriptions is a good thing as this makes it easier for GDB to select the correct gdbarch. --- gdb/features/mips64-dsp-linux.c | 2 ++ gdb/features/mips64-dsp-linux.xml | 1 + gdb/features/mips64-linux.c | 2 ++ gdb/features/mips64-linux.xml | 1 + gdb/features/s390-gs-linux64.c | 2 ++ gdb/features/s390-gs-linux64.xml | 1 + gdb/features/s390-linux32.c | 2 ++ gdb/features/s390-linux32.xml | 1 + gdb/features/s390-linux32v1.c | 2 ++ gdb/features/s390-linux32v1.xml | 1 + gdb/features/s390-linux32v2.c | 2 ++ gdb/features/s390-linux32v2.xml | 1 + gdb/features/s390-linux64.c | 2 ++ gdb/features/s390-linux64.xml | 1 + gdb/features/s390-linux64v1.c | 2 ++ gdb/features/s390-linux64v1.xml | 1 + gdb/features/s390-linux64v2.c | 2 ++ gdb/features/s390-linux64v2.xml | 1 + gdb/features/s390-te-linux64.c | 2 ++ gdb/features/s390-te-linux64.xml | 1 + gdb/features/s390-tevx-linux64.c | 2 ++ gdb/features/s390-tevx-linux64.xml | 1 + gdb/features/s390-vx-linux64.c | 2 ++ gdb/features/s390-vx-linux64.xml | 1 + gdb/features/s390x-gs-linux64.c | 2 ++ gdb/features/s390x-gs-linux64.xml | 1 + gdb/features/s390x-linux64.c | 2 ++ gdb/features/s390x-linux64.xml | 1 + gdb/features/s390x-linux64v1.c | 2 ++ gdb/features/s390x-linux64v1.xml | 1 + gdb/features/s390x-linux64v2.c | 2 ++ gdb/features/s390x-linux64v2.xml | 1 + gdb/features/s390x-te-linux64.c | 2 ++ gdb/features/s390x-te-linux64.xml | 1 + gdb/features/s390x-tevx-linux64.c | 2 ++ gdb/features/s390x-tevx-linux64.xml | 1 + gdb/features/s390x-vx-linux64.c | 2 ++ gdb/features/s390x-vx-linux64.xml | 1 + 38 files changed, 57 insertions(+) diff --git a/gdb/features/mips64-dsp-linux.c b/gdb/features/mips64-dsp-linux.c index 7ea0bb704f4..646f5487f49 100644 --- a/gdb/features/mips64-dsp-linux.c +++ b/gdb/features/mips64-dsp-linux.c @@ -11,6 +11,8 @@ initialize_tdesc_mips64_dsp_linux (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("mips")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.mips.cpu"); diff --git a/gdb/features/mips64-dsp-linux.xml b/gdb/features/mips64-dsp-linux.xml index 69518e496c4..6c108555490 100644 --- a/gdb/features/mips64-dsp-linux.xml +++ b/gdb/features/mips64-dsp-linux.xml @@ -8,6 +8,7 @@ mips + GNU/Linux diff --git a/gdb/features/mips64-linux.c b/gdb/features/mips64-linux.c index f4dcf8bc109..98b3d34448d 100644 --- a/gdb/features/mips64-linux.c +++ b/gdb/features/mips64-linux.c @@ -11,6 +11,8 @@ initialize_tdesc_mips64_linux (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("mips")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.mips.cpu"); diff --git a/gdb/features/mips64-linux.xml b/gdb/features/mips64-linux.xml index 4c99206b5bd..f861982a8e9 100644 --- a/gdb/features/mips64-linux.xml +++ b/gdb/features/mips64-linux.xml @@ -8,6 +8,7 @@ mips + GNU/Linux diff --git a/gdb/features/s390-gs-linux64.c b/gdb/features/s390-gs-linux64.c index 49ea08b2c39..ab6ad6f21e3 100644 --- a/gdb/features/s390-gs-linux64.c +++ b/gdb/features/s390-gs-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_gs_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-gs-linux64.xml b/gdb/features/s390-gs-linux64.xml index 035e794643d..e33e8a42f6b 100644 --- a/gdb/features/s390-gs-linux64.xml +++ b/gdb/features/s390-gs-linux64.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-linux32.c b/gdb/features/s390-linux32.c index 43ceb9c008e..e45321a2099 100644 --- a/gdb/features/s390-linux32.c +++ b/gdb/features/s390-linux32.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_linux32 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-linux32.xml b/gdb/features/s390-linux32.xml index 4225e5cb120..6a51c21d07c 100644 --- a/gdb/features/s390-linux32.xml +++ b/gdb/features/s390-linux32.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-linux32v1.c b/gdb/features/s390-linux32v1.c index 291784fdac7..cea14c16969 100644 --- a/gdb/features/s390-linux32v1.c +++ b/gdb/features/s390-linux32v1.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_linux32v1 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-linux32v1.xml b/gdb/features/s390-linux32v1.xml index 60f8ab650ea..63780765f98 100644 --- a/gdb/features/s390-linux32v1.xml +++ b/gdb/features/s390-linux32v1.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-linux32v2.c b/gdb/features/s390-linux32v2.c index 6fa26daa537..182ab2f0b60 100644 --- a/gdb/features/s390-linux32v2.c +++ b/gdb/features/s390-linux32v2.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_linux32v2 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-linux32v2.xml b/gdb/features/s390-linux32v2.xml index 58b1478ee4f..0646ce3f2e0 100644 --- a/gdb/features/s390-linux32v2.xml +++ b/gdb/features/s390-linux32v2.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-linux64.c b/gdb/features/s390-linux64.c index 74c338c1fa6..8bcec095174 100644 --- a/gdb/features/s390-linux64.c +++ b/gdb/features/s390-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-linux64.xml b/gdb/features/s390-linux64.xml index dcd50296983..e8d8f03eae7 100644 --- a/gdb/features/s390-linux64.xml +++ b/gdb/features/s390-linux64.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-linux64v1.c b/gdb/features/s390-linux64v1.c index 0aebbdb6b7a..3a6394b513d 100644 --- a/gdb/features/s390-linux64v1.c +++ b/gdb/features/s390-linux64v1.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_linux64v1 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-linux64v1.xml b/gdb/features/s390-linux64v1.xml index a849e793acd..fc63a165236 100644 --- a/gdb/features/s390-linux64v1.xml +++ b/gdb/features/s390-linux64v1.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-linux64v2.c b/gdb/features/s390-linux64v2.c index 3b3b4916ac3..5ff9a5709ef 100644 --- a/gdb/features/s390-linux64v2.c +++ b/gdb/features/s390-linux64v2.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_linux64v2 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-linux64v2.xml b/gdb/features/s390-linux64v2.xml index 4bbfb09b2fb..3d0c9f9b210 100644 --- a/gdb/features/s390-linux64v2.xml +++ b/gdb/features/s390-linux64v2.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-te-linux64.c b/gdb/features/s390-te-linux64.c index d49e7441313..2abddd53bfa 100644 --- a/gdb/features/s390-te-linux64.c +++ b/gdb/features/s390-te-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_te_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-te-linux64.xml b/gdb/features/s390-te-linux64.xml index e141e0b789c..399053a0319 100644 --- a/gdb/features/s390-te-linux64.xml +++ b/gdb/features/s390-te-linux64.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-tevx-linux64.c b/gdb/features/s390-tevx-linux64.c index ffe1ddf4ee1..8e38a5cf81f 100644 --- a/gdb/features/s390-tevx-linux64.c +++ b/gdb/features/s390-tevx-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_tevx_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-tevx-linux64.xml b/gdb/features/s390-tevx-linux64.xml index f9dc796e66d..2dbb0399b9c 100644 --- a/gdb/features/s390-tevx-linux64.xml +++ b/gdb/features/s390-tevx-linux64.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390-vx-linux64.c b/gdb/features/s390-vx-linux64.c index 30262a63fce..1ce5ad3671a 100644 --- a/gdb/features/s390-vx-linux64.c +++ b/gdb/features/s390-vx-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390_vx_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:31-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390-vx-linux64.xml b/gdb/features/s390-vx-linux64.xml index fe55fb22565..6b32bf8130b 100644 --- a/gdb/features/s390-vx-linux64.xml +++ b/gdb/features/s390-vx-linux64.xml @@ -11,6 +11,7 @@ s390:31-bit + GNU/Linux diff --git a/gdb/features/s390x-gs-linux64.c b/gdb/features/s390x-gs-linux64.c index 501b3b24061..76b8124863a 100644 --- a/gdb/features/s390x-gs-linux64.c +++ b/gdb/features/s390x-gs-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390x_gs_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:64-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390x-gs-linux64.xml b/gdb/features/s390x-gs-linux64.xml index 6131aaa9e38..c41e460d91c 100644 --- a/gdb/features/s390x-gs-linux64.xml +++ b/gdb/features/s390x-gs-linux64.xml @@ -10,6 +10,7 @@ s390:64-bit + GNU/Linux diff --git a/gdb/features/s390x-linux64.c b/gdb/features/s390x-linux64.c index 8655d5a6116..eb6b181f599 100644 --- a/gdb/features/s390x-linux64.c +++ b/gdb/features/s390x-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390x_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:64-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390x-linux64.xml b/gdb/features/s390x-linux64.xml index a70f6372c25..31afe82dadc 100644 --- a/gdb/features/s390x-linux64.xml +++ b/gdb/features/s390x-linux64.xml @@ -10,6 +10,7 @@ s390:64-bit + GNU/Linux diff --git a/gdb/features/s390x-linux64v1.c b/gdb/features/s390x-linux64v1.c index 11bfd85c995..6b43f88ac84 100644 --- a/gdb/features/s390x-linux64v1.c +++ b/gdb/features/s390x-linux64v1.c @@ -11,6 +11,8 @@ initialize_tdesc_s390x_linux64v1 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:64-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390x-linux64v1.xml b/gdb/features/s390x-linux64v1.xml index ffc0505202e..8aa26b4f587 100644 --- a/gdb/features/s390x-linux64v1.xml +++ b/gdb/features/s390x-linux64v1.xml @@ -10,6 +10,7 @@ s390:64-bit + GNU/Linux diff --git a/gdb/features/s390x-linux64v2.c b/gdb/features/s390x-linux64v2.c index 400b1af4485..eeba787ec7b 100644 --- a/gdb/features/s390x-linux64v2.c +++ b/gdb/features/s390x-linux64v2.c @@ -11,6 +11,8 @@ initialize_tdesc_s390x_linux64v2 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:64-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390x-linux64v2.xml b/gdb/features/s390x-linux64v2.xml index 4b2abc60dad..3769a75db40 100644 --- a/gdb/features/s390x-linux64v2.xml +++ b/gdb/features/s390x-linux64v2.xml @@ -10,6 +10,7 @@ s390:64-bit + GNU/Linux diff --git a/gdb/features/s390x-te-linux64.c b/gdb/features/s390x-te-linux64.c index 74883e30fe8..0fec2b0bd02 100644 --- a/gdb/features/s390x-te-linux64.c +++ b/gdb/features/s390x-te-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390x_te_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:64-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390x-te-linux64.xml b/gdb/features/s390x-te-linux64.xml index b38c7c0ac12..c48831d54e5 100644 --- a/gdb/features/s390x-te-linux64.xml +++ b/gdb/features/s390x-te-linux64.xml @@ -10,6 +10,7 @@ s390:64-bit + GNU/Linux diff --git a/gdb/features/s390x-tevx-linux64.c b/gdb/features/s390x-tevx-linux64.c index 1d45d6044c1..c1b890045d3 100644 --- a/gdb/features/s390x-tevx-linux64.c +++ b/gdb/features/s390x-tevx-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390x_tevx_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:64-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390x-tevx-linux64.xml b/gdb/features/s390x-tevx-linux64.xml index 2d7672e1dca..a53bfff5ac7 100644 --- a/gdb/features/s390x-tevx-linux64.xml +++ b/gdb/features/s390x-tevx-linux64.xml @@ -10,6 +10,7 @@ s390:64-bit + GNU/Linux diff --git a/gdb/features/s390x-vx-linux64.c b/gdb/features/s390x-vx-linux64.c index 4de6585a227..af57e052eab 100644 --- a/gdb/features/s390x-vx-linux64.c +++ b/gdb/features/s390x-vx-linux64.c @@ -11,6 +11,8 @@ initialize_tdesc_s390x_vx_linux64 (void) target_desc_up result = allocate_target_description (); set_tdesc_architecture (result.get (), bfd_scan_arch ("s390:64-bit")); + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); + struct tdesc_feature *feature; feature = tdesc_create_feature (result.get (), "org.gnu.gdb.s390.core"); diff --git a/gdb/features/s390x-vx-linux64.xml b/gdb/features/s390x-vx-linux64.xml index 8903f1871e2..fcf75deb588 100644 --- a/gdb/features/s390x-vx-linux64.xml +++ b/gdb/features/s390x-vx-linux64.xml @@ -10,6 +10,7 @@ s390:64-bit + GNU/Linux From patchwork Sun Oct 27 20:07:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 99686 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AAAEC3858C42 for ; Sun, 27 Oct 2024 20:08:58 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 149803858408 for ; Sun, 27 Oct 2024 20:07:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 149803858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 149803858408 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730059683; cv=none; b=rPPVODFfSynYVF7wt2RQwopwvRDe306Jb8FiCggy6NXwNE0C94UqQIRc8+1MdiLxE60X3dy5o7M3qYTZin8wGTu+grQxFr6kqF72yGo0J69u6ANuBuPitPuo3S9SmaHgsr6fZ/zYq01jMhK1BrR3juSlqnQGTXjDLnqNU4F43YI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730059683; c=relaxed/simple; bh=MzC3/nEyOdcCRGs24bx+AoBmZtXuMkmFfMXzujA4/xU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=KQhPT0YKYtf9MEHHwp88MCX/eZRyXtz2+U2Depy1Yjeu7GB87bjYDig9WTtT5FZoeCxn6irbIx6sl/GCJOrIgwyjQ7Y3EU0q8iMyMyzHzj4sVmsT5NzAdhFhlCJsa707ZxM7x/vK+iX6a+A+QG6XkhCjNP4L3BmVad/wbxyIccM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730059674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K5ylSbr8UVgp0YLYHze54szlUeKt/QsVJpJmEQHXB1s=; b=NHTuZp3MN6YWMv29U3iOxABRVlSbP4eDoxHISDiPe2dCRUaW7plAhO9XqgZyjBVMwnZFFB nEx7BsaSrCemRkfzS9egGnS8dFpTreNxba85uYVuN9ro1tXAs+pGswFyDVEvU4HuqqJxNk u1/Gkled/FyRbUWeXS7kuF699eRCHss= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-LBZ7HXqnPDWbkFPiIaKZpA-1; Sun, 27 Oct 2024 16:07:52 -0400 X-MC-Unique: LBZ7HXqnPDWbkFPiIaKZpA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-431518e6d8fso26923085e9.0 for ; Sun, 27 Oct 2024 13:07:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730059670; x=1730664470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K5ylSbr8UVgp0YLYHze54szlUeKt/QsVJpJmEQHXB1s=; b=ots6qM/8pMITqH9Wq0Xaoo2nDei9FHKrjfkKyiIU4mGX/dEfgiiMLjMG7QNajs3T8b 6EJklp67qN0M6H2eO7Gg+rTwT9GVqHWgis9oMZi2+sml57uIjblpcygZDdh7oAzjC61O zTSobTz55ETysUc4T8GQ8iyI9eziEX37RI/BulFyb9Rosu69dEYn1nPJJ0Bst9gIaT+M O+hwfbr66QnysJYZBLVI884XdOAniXq+XqLnYdlpoY48p7/D9WfOZCum8irQ3IfiGMKB dNqvKUJaF9NonBEjtDnumOScwGp9B27x0DxemyzTBE6kwBIx+k77vcVEosKX95m9Ul1s E/mA== X-Gm-Message-State: AOJu0Yx3S0nhIki2aNAgpsCuayStgteFt3DdvKkWyaEaDZpk8HVmL4Tm atmchfxrNWdbBRf3LJDYvPy2UFQi97W8Sdv2hYwY8x090CL5KtPkxRcL3P2PUGyWjg3N52oFz4h YKTK/nUMF3hXwc9teJHGHVbHhH1P8rvRAW5GU1wANw9B9ZVPFvszpwnnoPoOcAF5D+kRbbDVDS8 H7GKXcGaAWIlCdojvplaVh5MMc50OIgnRAydRQdg6Zc8s= X-Received: by 2002:a05:600c:4d8a:b0:431:5bb1:f088 with SMTP id 5b1f17b1804b1-431aa284b53mr11064245e9.29.1730059669423; Sun, 27 Oct 2024 13:07:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2iy0j7Vi7fHYmiTIgPpMEQco9DGJApkJKGA2iW3J1Ld+VH2SHyRnk5/MDuuB+b9P4DrTC8Q== X-Received: by 2002:a05:600c:4d8a:b0:431:5bb1:f088 with SMTP id 5b1f17b1804b1-431aa284b53mr11063975e9.29.1730059668644; Sun, 27 Oct 2024 13:07:48 -0700 (PDT) Received: from localhost (197.209.200.146.dyn.plus.net. [146.200.209.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43193573551sm85332155e9.6.2024.10.27.13.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 13:07:48 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv5 2/3] gdb/regformats: add osabi information to generated .dat files Date: Sun, 27 Oct 2024 20:07:41 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Some gdbserver targets generate their target description based on the gdb/regformats/*.dat files. These .dat files are generated from a matching xml file in gdb/features/. Lets consider a concrete example: Take gdb/features/or1k-linux.xml, this file is processed by gdb/features/Makefile to create gdb/regformats/or1k-linux.dat. When gdbserver is built for the or1k target the file or1k-linux-generated.cc is generated using the gdb/regformats/regdat.sh script. This .cc file is then compiled and linked into gdbserver. The or1k-linux-generated.cc file contains the function init_registers_or1k_linux which is called from within gdbserver, this function creates a target_desc object and sets its xmltarget field to a fixed string. This fixed string is the xml filename that was originally used to generate the xml file, in this case or1k-linux.xml. Additionally, as part of the gdbserver build the file or1k-linux.xml is converted to a string and placed in the file xml-builtin-generated.cc which is then built into gdbserver. Now when GDB asks gdbserver for the target description, gdbserver returns the fixed xmltarget string, which is the name of an xml file. GDB will then ask gdbserver for that file and gdbserver will return the contents of that file thanks to the xml-builtin-generated.cc file's contents. This is all rather complicated, but it does work. So what's the problem that I'm fixing? Well or1k-linux.xml does contain the osabi information, so this will be returned from gdbserver to GDB. That's good. However, the target_desc object created in init_registers_or1k_linux will not have its osabi set correctly. Now this doesn't really matter too much except init_registers_or1k_linux includes a call to init_target_desc. In the next commit I want to extend init_target_desc to require an osabi to be passed in. The motivation for this will be explained in the next commit, but if we accept for a moment that this is something that should be done, then the question is what osabi should we use in init_registers_or1k_linux? Ideally we'd use the osabi which is set in or1k-linux.xml. If we do that then everything will remain consistent, which is a good thing. And so, to get the osabi from or1k-linux.xml into init_registers_or1k_linux, we first need to get the osabi information into or1k-linux.dat file, and this is what this commit does. I've added a new xsl script print-osabi.xsl and updated gdb/features/Makefile to make use of this script. Then I regenerated all of the .dat files. Now every .dat file contains either: osabi:GNU/Linux osabi:unknown The first is for xml files containing GNU/Linux and the second is for xml files that don't contain an osabi element. This commit doesn't attempt to make use of the osabi information in the .dat files, that will come in the next commit. There should be no user visible changes after this commit. --- gdb/features/Makefile | 2 + gdb/features/print-osabi.xsl | 39 +++++++++++++++++++ gdb/regformats/mips-dsp-linux.dat | 1 + gdb/regformats/mips-linux.dat | 1 + gdb/regformats/mips64-dsp-linux.dat | 1 + gdb/regformats/mips64-linux.dat | 1 + gdb/regformats/nios2-linux.dat | 1 + gdb/regformats/or1k-linux.dat | 1 + gdb/regformats/rs6000/powerpc-32.dat | 1 + gdb/regformats/rs6000/powerpc-32l.dat | 1 + gdb/regformats/rs6000/powerpc-64l.dat | 1 + gdb/regformats/rs6000/powerpc-altivec32l.dat | 1 + gdb/regformats/rs6000/powerpc-altivec64l.dat | 1 + gdb/regformats/rs6000/powerpc-e500l.dat | 1 + gdb/regformats/rs6000/powerpc-isa205-32l.dat | 1 + gdb/regformats/rs6000/powerpc-isa205-64l.dat | 1 + .../rs6000/powerpc-isa205-altivec32l.dat | 1 + .../rs6000/powerpc-isa205-altivec64l.dat | 1 + .../rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat | 1 + .../rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat | 1 + .../rs6000/powerpc-isa205-vsx32l.dat | 1 + .../rs6000/powerpc-isa205-vsx64l.dat | 1 + .../rs6000/powerpc-isa207-htm-vsx32l.dat | 1 + .../rs6000/powerpc-isa207-htm-vsx64l.dat | 1 + .../rs6000/powerpc-isa207-vsx32l.dat | 1 + .../rs6000/powerpc-isa207-vsx64l.dat | 1 + gdb/regformats/rs6000/powerpc-vsx32l.dat | 1 + gdb/regformats/rs6000/powerpc-vsx64l.dat | 1 + gdb/regformats/s390-gs-linux64.dat | 1 + gdb/regformats/s390-linux32.dat | 1 + gdb/regformats/s390-linux32v1.dat | 1 + gdb/regformats/s390-linux32v2.dat | 1 + gdb/regformats/s390-linux64.dat | 1 + gdb/regformats/s390-linux64v1.dat | 1 + gdb/regformats/s390-linux64v2.dat | 1 + gdb/regformats/s390-te-linux64.dat | 1 + gdb/regformats/s390-tevx-linux64.dat | 1 + gdb/regformats/s390-vx-linux64.dat | 1 + gdb/regformats/s390x-gs-linux64.dat | 1 + gdb/regformats/s390x-linux64.dat | 1 + gdb/regformats/s390x-linux64v1.dat | 1 + gdb/regformats/s390x-linux64v2.dat | 1 + gdb/regformats/s390x-te-linux64.dat | 1 + gdb/regformats/s390x-tevx-linux64.dat | 1 + gdb/regformats/s390x-vx-linux64.dat | 1 + gdb/regformats/tic6x-c62x-linux.dat | 1 + gdb/regformats/tic6x-c64x-linux.dat | 1 + gdb/regformats/tic6x-c64xp-linux.dat | 1 + 48 files changed, 87 insertions(+) create mode 100644 gdb/features/print-osabi.xsl diff --git a/gdb/features/Makefile b/gdb/features/Makefile index 01b327cbce1..4f42d00cf9b 100644 --- a/gdb/features/Makefile +++ b/gdb/features/Makefile @@ -191,6 +191,8 @@ $(outdir)/%.dat: %.xml number-regs.xsl sort-regs.xsl gdbserver-regs.xsl echo "xmltarget:$(> $(outdir)/$*.tmp echo "expedite:$(if $($*-expedite),$($*-expedite),$($(firstword $(subst -, ,$(notdir $*)))-expedite))" \ >> $(outdir)/$*.tmp + $(XSLTPROC) --path "$(PWD)" --xinclude print-osabi.xsl $< \ + >> $(outdir)/$*.tmp $(XSLTPROC) --path "$(PWD)" --xinclude number-regs.xsl $< | \ $(XSLTPROC) sort-regs.xsl - | \ $(XSLTPROC) gdbserver-regs.xsl - >> $(outdir)/$*.tmp diff --git a/gdb/features/print-osabi.xsl b/gdb/features/print-osabi.xsl new file mode 100644 index 00000000000..77f9931de52 --- /dev/null +++ b/gdb/features/print-osabi.xsl @@ -0,0 +1,39 @@ + + + + + + + osabi: + + + + + + unknown + + + + + + diff --git a/gdb/regformats/mips-dsp-linux.dat b/gdb/regformats/mips-dsp-linux.dat index ce37bf38bdb..dd222857887 100644 --- a/gdb/regformats/mips-dsp-linux.dat +++ b/gdb/regformats/mips-dsp-linux.dat @@ -3,6 +3,7 @@ name:mips_dsp_linux xmltarget:mips-dsp-linux.xml expedite:r29,pc +osabi:GNU/Linux 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/mips-linux.dat b/gdb/regformats/mips-linux.dat index d95e2c9ed45..d333602dad1 100644 --- a/gdb/regformats/mips-linux.dat +++ b/gdb/regformats/mips-linux.dat @@ -3,6 +3,7 @@ name:mips_linux xmltarget:mips-linux.xml expedite:r29,pc +osabi:GNU/Linux 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/mips64-dsp-linux.dat b/gdb/regformats/mips64-dsp-linux.dat index e73df93d69b..5712424c0b6 100644 --- a/gdb/regformats/mips64-dsp-linux.dat +++ b/gdb/regformats/mips64-dsp-linux.dat @@ -3,6 +3,7 @@ name:mips64_dsp_linux xmltarget:mips64-dsp-linux.xml expedite:r29,pc +osabi:GNU/Linux 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/mips64-linux.dat b/gdb/regformats/mips64-linux.dat index 6770c8f6545..843320d46be 100644 --- a/gdb/regformats/mips64-linux.dat +++ b/gdb/regformats/mips64-linux.dat @@ -3,6 +3,7 @@ name:mips64_linux xmltarget:mips64-linux.xml expedite:r29,pc +osabi:GNU/Linux 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/nios2-linux.dat b/gdb/regformats/nios2-linux.dat index fe4af2f4f36..ecfca72ec6d 100644 --- a/gdb/regformats/nios2-linux.dat +++ b/gdb/regformats/nios2-linux.dat @@ -3,6 +3,7 @@ name:nios2_linux xmltarget:nios2-linux.xml expedite:sp,pc +osabi:GNU/Linux 32:zero 32:at 32:r2 diff --git a/gdb/regformats/or1k-linux.dat b/gdb/regformats/or1k-linux.dat index 7b64646fc65..d2d94c65c95 100644 --- a/gdb/regformats/or1k-linux.dat +++ b/gdb/regformats/or1k-linux.dat @@ -3,6 +3,7 @@ name:or1k_linux xmltarget:or1k-linux.xml expedite:r1,npc +osabi:GNU/Linux 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-32.dat b/gdb/regformats/rs6000/powerpc-32.dat index 266636b11f9..f85f95df06f 100644 --- a/gdb/regformats/rs6000/powerpc-32.dat +++ b/gdb/regformats/rs6000/powerpc-32.dat @@ -3,6 +3,7 @@ name:powerpc_32 xmltarget:powerpc-32.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-32l.dat b/gdb/regformats/rs6000/powerpc-32l.dat index 2c8ccbe49b9..286f1a5d88f 100644 --- a/gdb/regformats/rs6000/powerpc-32l.dat +++ b/gdb/regformats/rs6000/powerpc-32l.dat @@ -3,6 +3,7 @@ name:powerpc_32l xmltarget:powerpc-32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-64l.dat b/gdb/regformats/rs6000/powerpc-64l.dat index 10f43b16241..b304c614e4d 100644 --- a/gdb/regformats/rs6000/powerpc-64l.dat +++ b/gdb/regformats/rs6000/powerpc-64l.dat @@ -3,6 +3,7 @@ name:powerpc_64l xmltarget:powerpc-64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/rs6000/powerpc-altivec32l.dat b/gdb/regformats/rs6000/powerpc-altivec32l.dat index c792a2f9616..3b1740bf041 100644 --- a/gdb/regformats/rs6000/powerpc-altivec32l.dat +++ b/gdb/regformats/rs6000/powerpc-altivec32l.dat @@ -3,6 +3,7 @@ name:powerpc_altivec32l xmltarget:powerpc-altivec32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-altivec64l.dat b/gdb/regformats/rs6000/powerpc-altivec64l.dat index a806141b6ee..6cd79eaf37a 100644 --- a/gdb/regformats/rs6000/powerpc-altivec64l.dat +++ b/gdb/regformats/rs6000/powerpc-altivec64l.dat @@ -3,6 +3,7 @@ name:powerpc_altivec64l xmltarget:powerpc-altivec64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/rs6000/powerpc-e500l.dat b/gdb/regformats/rs6000/powerpc-e500l.dat index 750eafed7ca..44d96d1478e 100644 --- a/gdb/regformats/rs6000/powerpc-e500l.dat +++ b/gdb/regformats/rs6000/powerpc-e500l.dat @@ -3,6 +3,7 @@ name:powerpc_e500l xmltarget:powerpc-e500l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa205-32l.dat b/gdb/regformats/rs6000/powerpc-isa205-32l.dat index 7227d06c977..61f06e0f142 100644 --- a/gdb/regformats/rs6000/powerpc-isa205-32l.dat +++ b/gdb/regformats/rs6000/powerpc-isa205-32l.dat @@ -3,6 +3,7 @@ name:powerpc_isa205_32l xmltarget:powerpc-isa205-32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa205-64l.dat b/gdb/regformats/rs6000/powerpc-isa205-64l.dat index 13a72c7eb8f..bd62eb9fdfa 100644 --- a/gdb/regformats/rs6000/powerpc-isa205-64l.dat +++ b/gdb/regformats/rs6000/powerpc-isa205-64l.dat @@ -3,6 +3,7 @@ name:powerpc_isa205_64l xmltarget:powerpc-isa205-64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa205-altivec32l.dat b/gdb/regformats/rs6000/powerpc-isa205-altivec32l.dat index 051724c6132..1e9da0f9443 100644 --- a/gdb/regformats/rs6000/powerpc-isa205-altivec32l.dat +++ b/gdb/regformats/rs6000/powerpc-isa205-altivec32l.dat @@ -3,6 +3,7 @@ name:powerpc_isa205_altivec32l xmltarget:powerpc-isa205-altivec32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa205-altivec64l.dat b/gdb/regformats/rs6000/powerpc-isa205-altivec64l.dat index 867e8213516..7944d39e053 100644 --- a/gdb/regformats/rs6000/powerpc-isa205-altivec64l.dat +++ b/gdb/regformats/rs6000/powerpc-isa205-altivec64l.dat @@ -3,6 +3,7 @@ name:powerpc_isa205_altivec64l xmltarget:powerpc-isa205-altivec64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat b/gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat index 31a7d02e95c..c0337380781 100644 --- a/gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat +++ b/gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat @@ -3,6 +3,7 @@ name:powerpc_isa205_ppr_dscr_vsx32l xmltarget:powerpc-isa205-ppr-dscr-vsx32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat b/gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat index 74c8feb3eea..91cd86f06e0 100644 --- a/gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat +++ b/gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat @@ -3,6 +3,7 @@ name:powerpc_isa205_ppr_dscr_vsx64l xmltarget:powerpc-isa205-ppr-dscr-vsx64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa205-vsx32l.dat b/gdb/regformats/rs6000/powerpc-isa205-vsx32l.dat index fa05cae8594..72e7f6863ae 100644 --- a/gdb/regformats/rs6000/powerpc-isa205-vsx32l.dat +++ b/gdb/regformats/rs6000/powerpc-isa205-vsx32l.dat @@ -3,6 +3,7 @@ name:powerpc_isa205_vsx32l xmltarget:powerpc-isa205-vsx32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa205-vsx64l.dat b/gdb/regformats/rs6000/powerpc-isa205-vsx64l.dat index 75bd4539ad0..ff5e8bd62a4 100644 --- a/gdb/regformats/rs6000/powerpc-isa205-vsx64l.dat +++ b/gdb/regformats/rs6000/powerpc-isa205-vsx64l.dat @@ -3,6 +3,7 @@ name:powerpc_isa205_vsx64l xmltarget:powerpc-isa205-vsx64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa207-htm-vsx32l.dat b/gdb/regformats/rs6000/powerpc-isa207-htm-vsx32l.dat index c19416db868..8c38c537d63 100644 --- a/gdb/regformats/rs6000/powerpc-isa207-htm-vsx32l.dat +++ b/gdb/regformats/rs6000/powerpc-isa207-htm-vsx32l.dat @@ -3,6 +3,7 @@ name:powerpc_isa207_htm_vsx32l xmltarget:powerpc-isa207-htm-vsx32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa207-htm-vsx64l.dat b/gdb/regformats/rs6000/powerpc-isa207-htm-vsx64l.dat index 38359959fd7..4a4acebffe4 100644 --- a/gdb/regformats/rs6000/powerpc-isa207-htm-vsx64l.dat +++ b/gdb/regformats/rs6000/powerpc-isa207-htm-vsx64l.dat @@ -3,6 +3,7 @@ name:powerpc_isa207_htm_vsx64l xmltarget:powerpc-isa207-htm-vsx64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa207-vsx32l.dat b/gdb/regformats/rs6000/powerpc-isa207-vsx32l.dat index 0718d72d930..36891b3615d 100644 --- a/gdb/regformats/rs6000/powerpc-isa207-vsx32l.dat +++ b/gdb/regformats/rs6000/powerpc-isa207-vsx32l.dat @@ -3,6 +3,7 @@ name:powerpc_isa207_vsx32l xmltarget:powerpc-isa207-vsx32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-isa207-vsx64l.dat b/gdb/regformats/rs6000/powerpc-isa207-vsx64l.dat index 510c6c87dad..28515f7cde8 100644 --- a/gdb/regformats/rs6000/powerpc-isa207-vsx64l.dat +++ b/gdb/regformats/rs6000/powerpc-isa207-vsx64l.dat @@ -3,6 +3,7 @@ name:powerpc_isa207_vsx64l xmltarget:powerpc-isa207-vsx64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/rs6000/powerpc-vsx32l.dat b/gdb/regformats/rs6000/powerpc-vsx32l.dat index 6db3e38d5f2..2ff89796331 100644 --- a/gdb/regformats/rs6000/powerpc-vsx32l.dat +++ b/gdb/regformats/rs6000/powerpc-vsx32l.dat @@ -3,6 +3,7 @@ name:powerpc_vsx32l xmltarget:powerpc-vsx32l.xml expedite:r1,pc +osabi:unknown 32:r0 32:r1 32:r2 diff --git a/gdb/regformats/rs6000/powerpc-vsx64l.dat b/gdb/regformats/rs6000/powerpc-vsx64l.dat index bc0a45512c8..4b780382bcf 100644 --- a/gdb/regformats/rs6000/powerpc-vsx64l.dat +++ b/gdb/regformats/rs6000/powerpc-vsx64l.dat @@ -3,6 +3,7 @@ name:powerpc_vsx64l xmltarget:powerpc-vsx64l.xml expedite:r1,pc +osabi:unknown 64:r0 64:r1 64:r2 diff --git a/gdb/regformats/s390-gs-linux64.dat b/gdb/regformats/s390-gs-linux64.dat index 130c8ecc026..ced8c8c66bc 100644 --- a/gdb/regformats/s390-gs-linux64.dat +++ b/gdb/regformats/s390-gs-linux64.dat @@ -3,6 +3,7 @@ name:s390_gs_linux64 xmltarget:s390-gs-linux64.xml expedite:r14,r15,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0h diff --git a/gdb/regformats/s390-linux32.dat b/gdb/regformats/s390-linux32.dat index 545dd0fb915..1a494bc532e 100644 --- a/gdb/regformats/s390-linux32.dat +++ b/gdb/regformats/s390-linux32.dat @@ -3,6 +3,7 @@ name:s390_linux32 xmltarget:s390-linux32.xml expedite:r14,r15,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0 diff --git a/gdb/regformats/s390-linux32v1.dat b/gdb/regformats/s390-linux32v1.dat index b9e7fc89730..9d26f2e8762 100644 --- a/gdb/regformats/s390-linux32v1.dat +++ b/gdb/regformats/s390-linux32v1.dat @@ -3,6 +3,7 @@ name:s390_linux32v1 xmltarget:s390-linux32v1.xml expedite:r14,r15,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0 diff --git a/gdb/regformats/s390-linux32v2.dat b/gdb/regformats/s390-linux32v2.dat index 220af5e3dfb..33bd546404d 100644 --- a/gdb/regformats/s390-linux32v2.dat +++ b/gdb/regformats/s390-linux32v2.dat @@ -3,6 +3,7 @@ name:s390_linux32v2 xmltarget:s390-linux32v2.xml expedite:r14,r15,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0 diff --git a/gdb/regformats/s390-linux64.dat b/gdb/regformats/s390-linux64.dat index b347b6bf33a..b63a932a558 100644 --- a/gdb/regformats/s390-linux64.dat +++ b/gdb/regformats/s390-linux64.dat @@ -3,6 +3,7 @@ name:s390_linux64 xmltarget:s390-linux64.xml expedite:r14l,r15l,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0h diff --git a/gdb/regformats/s390-linux64v1.dat b/gdb/regformats/s390-linux64v1.dat index 8abd92d3a2e..71737fa58da 100644 --- a/gdb/regformats/s390-linux64v1.dat +++ b/gdb/regformats/s390-linux64v1.dat @@ -3,6 +3,7 @@ name:s390_linux64v1 xmltarget:s390-linux64v1.xml expedite:r14l,r15l,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0h diff --git a/gdb/regformats/s390-linux64v2.dat b/gdb/regformats/s390-linux64v2.dat index b282025e238..b25fa04c457 100644 --- a/gdb/regformats/s390-linux64v2.dat +++ b/gdb/regformats/s390-linux64v2.dat @@ -3,6 +3,7 @@ name:s390_linux64v2 xmltarget:s390-linux64v2.xml expedite:r14l,r15l,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0h diff --git a/gdb/regformats/s390-te-linux64.dat b/gdb/regformats/s390-te-linux64.dat index 28e1b8733eb..2c7bdb08d49 100644 --- a/gdb/regformats/s390-te-linux64.dat +++ b/gdb/regformats/s390-te-linux64.dat @@ -3,6 +3,7 @@ name:s390_te_linux64 xmltarget:s390-te-linux64.xml expedite:r14l,r15l,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0h diff --git a/gdb/regformats/s390-tevx-linux64.dat b/gdb/regformats/s390-tevx-linux64.dat index 3db7a91546b..20d0b92acef 100644 --- a/gdb/regformats/s390-tevx-linux64.dat +++ b/gdb/regformats/s390-tevx-linux64.dat @@ -3,6 +3,7 @@ name:s390_tevx_linux64 xmltarget:s390-tevx-linux64.xml expedite:r14l,r15l,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0h diff --git a/gdb/regformats/s390-vx-linux64.dat b/gdb/regformats/s390-vx-linux64.dat index 6a821fd5ac4..4ebb36bcedc 100644 --- a/gdb/regformats/s390-vx-linux64.dat +++ b/gdb/regformats/s390-vx-linux64.dat @@ -3,6 +3,7 @@ name:s390_vx_linux64 xmltarget:s390-vx-linux64.xml expedite:r14l,r15l,pswa +osabi:GNU/Linux 32:pswm 32:pswa 32:r0h diff --git a/gdb/regformats/s390x-gs-linux64.dat b/gdb/regformats/s390x-gs-linux64.dat index 8cd57515e51..9d44d89a9b8 100644 --- a/gdb/regformats/s390x-gs-linux64.dat +++ b/gdb/regformats/s390x-gs-linux64.dat @@ -3,6 +3,7 @@ name:s390x_gs_linux64 xmltarget:s390x-gs-linux64.xml expedite:r14,r15,pswa +osabi:GNU/Linux 64:pswm 64:pswa 64:r0 diff --git a/gdb/regformats/s390x-linux64.dat b/gdb/regformats/s390x-linux64.dat index 5832c438f59..a393b584b2c 100644 --- a/gdb/regformats/s390x-linux64.dat +++ b/gdb/regformats/s390x-linux64.dat @@ -3,6 +3,7 @@ name:s390x_linux64 xmltarget:s390x-linux64.xml expedite:r14,r15,pswa +osabi:GNU/Linux 64:pswm 64:pswa 64:r0 diff --git a/gdb/regformats/s390x-linux64v1.dat b/gdb/regformats/s390x-linux64v1.dat index 4d4de0a14cf..e5092d02131 100644 --- a/gdb/regformats/s390x-linux64v1.dat +++ b/gdb/regformats/s390x-linux64v1.dat @@ -3,6 +3,7 @@ name:s390x_linux64v1 xmltarget:s390x-linux64v1.xml expedite:r14,r15,pswa +osabi:GNU/Linux 64:pswm 64:pswa 64:r0 diff --git a/gdb/regformats/s390x-linux64v2.dat b/gdb/regformats/s390x-linux64v2.dat index b1c5f830231..7f097d5e1a3 100644 --- a/gdb/regformats/s390x-linux64v2.dat +++ b/gdb/regformats/s390x-linux64v2.dat @@ -3,6 +3,7 @@ name:s390x_linux64v2 xmltarget:s390x-linux64v2.xml expedite:r14,r15,pswa +osabi:GNU/Linux 64:pswm 64:pswa 64:r0 diff --git a/gdb/regformats/s390x-te-linux64.dat b/gdb/regformats/s390x-te-linux64.dat index 80f5ab127ee..2f8a7529ef7 100644 --- a/gdb/regformats/s390x-te-linux64.dat +++ b/gdb/regformats/s390x-te-linux64.dat @@ -3,6 +3,7 @@ name:s390x_te_linux64 xmltarget:s390x-te-linux64.xml expedite:r14,r15,pswa +osabi:GNU/Linux 64:pswm 64:pswa 64:r0 diff --git a/gdb/regformats/s390x-tevx-linux64.dat b/gdb/regformats/s390x-tevx-linux64.dat index 2df31e68632..2624b6406f9 100644 --- a/gdb/regformats/s390x-tevx-linux64.dat +++ b/gdb/regformats/s390x-tevx-linux64.dat @@ -3,6 +3,7 @@ name:s390x_tevx_linux64 xmltarget:s390x-tevx-linux64.xml expedite:r14,r15,pswa +osabi:GNU/Linux 64:pswm 64:pswa 64:r0 diff --git a/gdb/regformats/s390x-vx-linux64.dat b/gdb/regformats/s390x-vx-linux64.dat index 1d8f2b6f043..7548e022880 100644 --- a/gdb/regformats/s390x-vx-linux64.dat +++ b/gdb/regformats/s390x-vx-linux64.dat @@ -3,6 +3,7 @@ name:s390x_vx_linux64 xmltarget:s390x-vx-linux64.xml expedite:r14,r15,pswa +osabi:GNU/Linux 64:pswm 64:pswa 64:r0 diff --git a/gdb/regformats/tic6x-c62x-linux.dat b/gdb/regformats/tic6x-c62x-linux.dat index 98ca39e1103..0818ace3cbb 100644 --- a/gdb/regformats/tic6x-c62x-linux.dat +++ b/gdb/regformats/tic6x-c62x-linux.dat @@ -4,6 +4,7 @@ name:tic6x_c62x_linux feature:1 xmltarget:tic6x-c62x-linux.xml expedite:A15,PC +osabi:GNU/Linux 32:A0 32:A1 32:A2 diff --git a/gdb/regformats/tic6x-c64x-linux.dat b/gdb/regformats/tic6x-c64x-linux.dat index 91e84baebc1..fafa53a4004 100644 --- a/gdb/regformats/tic6x-c64x-linux.dat +++ b/gdb/regformats/tic6x-c64x-linux.dat @@ -4,6 +4,7 @@ name:tic6x_c64x_linux feature:1 xmltarget:tic6x-c64x-linux.xml expedite:A15,PC +osabi:GNU/Linux 32:A0 32:A1 32:A2 diff --git a/gdb/regformats/tic6x-c64xp-linux.dat b/gdb/regformats/tic6x-c64xp-linux.dat index a3fa3b7cd40..56fc3d78c20 100644 --- a/gdb/regformats/tic6x-c64xp-linux.dat +++ b/gdb/regformats/tic6x-c64xp-linux.dat @@ -4,6 +4,7 @@ name:tic6x_c64xp_linux feature:1 xmltarget:tic6x-c64xp-linux.xml expedite:A15,PC +osabi:GNU/Linux 32:A0 32:A1 32:A2 From patchwork Sun Oct 27 20:07:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 99685 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D9153858417 for ; Sun, 27 Oct 2024 20:08:35 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id AACAC3858C78 for ; Sun, 27 Oct 2024 20:07:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AACAC3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AACAC3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730059678; cv=none; b=eFU/7FRGm5jVY/mUrFzThyGiZ9larPqNPbsAYx78vWvOToexDGWmB9ubX1P2Hfc0+kv5y5B+SaesMZqxLSNQW/fQ1ioPeRrzVjZofPppcH1K2YywdVltmvlOIPbkiXNId3IVjC0aT049shLtMyJWS0IeEZcObZzYiOq+4YB2P9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730059678; c=relaxed/simple; bh=rhmEYCSy+BFrWTGR9fuCpeqEDhDLFnKPEaHGbjKmNYQ=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=vGlWTUBDfT2uTVOY5qavxe+FXea/Snn37uN8BdB5+1WW0NGGDIaWi6ly7HOEFHmpJdBoiMJJHSpiYTOL0QycLwB0bigXv4YxwriOole028UzqNPI+AU23v9fnNxMogjDLFqPnYSfvs9CLvT2etKWbhFRdefoQikP1spTitASNsA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730059674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=azufmXxHIwW0fSsJjiZ6UEYJ1kakd8SpZgDqta5EyvY=; b=KQU4Dqbebu06RmpnTlmXHP1HjTb/vY40KrEcFX8/no/TLXAD4L38pC481gr1lqzYLhcOfV wjvyX2OGyloAbczPOSFhyDF59YaT6IdKje5lEwB+F8wLpjqt5DZvY/PLfEEdPjwskj5EZY IIGuNPZR35SX4Ya03Wju9ATMKw8GN5I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-K8ub8OBsPaa16VINam4wdg-1; Sun, 27 Oct 2024 16:07:53 -0400 X-MC-Unique: K8ub8OBsPaa16VINam4wdg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-431673032e6so25627635e9.0 for ; Sun, 27 Oct 2024 13:07:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730059671; x=1730664471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azufmXxHIwW0fSsJjiZ6UEYJ1kakd8SpZgDqta5EyvY=; b=opJtS/mwvTw1dTOyDHd4kuEtXimv+w8Mz/dkVCkwX4RwFqsEmk+WrLl1afWXrdphUQ QqdQQy2Wv/gq0u1lZJdcR3bw9ibRrK94ILuVr+ZZKKYAoZDbSzrVL0VQZuLrO+svFoHG 2a0c7/3Ov3+R5LYO+osXQKv/Y0nuSnqeaQMzjZLPt12HLiDHK6dLjbEddv3DqfWzEXNY kPb/5tgQBvzh6FknCnNwMlQEPZIZ9Q4xA5TpTFJJpppQJos5RGCXME56LQ1/xB8bSyGA D0MaLdIgwYGDbIRbfcgXoL0GgylpBO0l8toUD586Kq+jBu0nuDMgg/+EVLgg2Q9sr6bZ Y+BQ== X-Gm-Message-State: AOJu0YwmQF6uCs512AYvqUowxk2dWcrPW48x+/BS5UeJsOigxnDz7cGl XJjgX4Rr34/a0KBe7nkWjDpoKdpID2UZnp334QcXYsB7shxmi625+CXohhqzvdDsxdA6CScrZVC CyNb6Jfg+ngRm82kDfBy3BSL6PAQgv/L4M21FxIVLaHNOG71q4TfY9tOYipuEyFRT0iviSRvnSP TXvRBpibtSnpWTUGplPsxUhDvjHI2FX+jheHKM1uKUQxI= X-Received: by 2002:a05:600c:1c11:b0:431:680e:95ff with SMTP id 5b1f17b1804b1-4319ac9757cmr49214575e9.9.1730059670676; Sun, 27 Oct 2024 13:07:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IER4tqmPiPqR90Eq4GuBnydARV+yGfv0NRtOal9G66/ka/THR5ooLSEHSbkmhK0eqV3oSoEAQ== X-Received: by 2002:a05:600c:1c11:b0:431:680e:95ff with SMTP id 5b1f17b1804b1-4319ac9757cmr49214425e9.9.1730059670097; Sun, 27 Oct 2024 13:07:50 -0700 (PDT) Received: from localhost (197.209.200.146.dyn.plus.net. [146.200.209.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4319360c21fsm84877995e9.40.2024.10.27.13.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 13:07:49 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv5 3/3] gdbserver: pass osabi to GDB in more target descriptions Date: Sun, 27 Oct 2024 20:07:42 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Problem Description ------------------- On a Windows machine I built gdbserver, configured for the target 'x86_64-w64-mingw32', then on a GNU/Linux machine I built GDB with support for all target (--enable-targets=all). On the Windows machine I start gdbserver with a small test binary: $ gdbserver 192.168.129.25:54321 C:\some\directory\executable.exe On the GNU/Linux machine I start GDB without the test binary, and connect to gdbserver. As I have not given GDB the test binary, my expectation is that GDB would connect to gdbserver and then download the file over the remote protocol, but instead I was presented with this message: (gdb) target remote 192.168.129.25:54321 Remote debugging using 192.168.129.25:54321 warning: C:\some\directory\executable.exe: No such file or directory. 0x00007ffa3e1e1741 in ?? () (gdb) What I found is that if I told GDB where to find the binary, like this: (gdb) file target:C:/some/directory/executable.exe A program is being debugged already. Are you sure you want to change the file? (y or n) y Reading C:/some/directory/executable.exe from remote target... warning: File transfers from remote targets can be slow. Use "set sysroot" to access files locally instead. Reading C:/some/directory/executable.exe from remote target... Reading symbols from target:C:/some/directory/executable.exe... (gdb) then GDB would download the executable. The Actual Issue ---------------- I tracked the problem down to exec_file_find (solib.c). The remote target was passing an absolute Windows filename (beginning with "C:/" in this case), but in exec_file_find GDB was failing the IS_TARGET_ABSOLUTE_PATH call, and so was treating the filename as relative. The IS_TARGET_ABSOLUTE_PATH call was failing because GDB thought that the file system kind was "unix", and as the filename didn't start with a "/" it assumed the filename was not absolute. But I'm connecting to a Windows target and 'target-file-system-kind' was set to "auto", so GDB should be figuring out that the target file-system is "dos-based". Looking in effective_target_file_system_kind (filesystem.c), we find that the logic of "auto" is delegated to the current gdbarch. However in windows-tdep.c we see: set_gdbarch_has_dos_based_file_system (gdbarch, 1); So if we are using a Windows gdbarch we should have "dos-based" filesystems. What this means is that after connecting to the remote target GDB has selected the wrong gdbarch. What's happening is that the target description sent back by the remote target only includes the x86-64 registers. There's no information about which OS we're on. As a consequence, GDB picks the first x86-64 gdbarch which can handle the provided register set, which happens to be a GNU/Linux gdbarch. And indeed, there doesn't appear to be anywhere in gdbserver that sets the osabi on the target descriptions. Some target descriptions do have their osabi set when the description is created, e.g. in: gdb/arch/amd64.c - Sets GNU/Linux osabi when appropriate. gdb/arch/i386.c - Likewise. gdb/arch/tic6x.c - Always set GNU/Linux osabi. There are also some cases in gdb/features/*.c where the tdesc is set, but these locations are only called from GDB, not from gdbserver. This means that many target descriptions are created without an osabi, gdbserver does nothing to fix this, and the description is returned to GDB without an osabi included. This leaves GDB having to guess what the target osabi is, and in some cases, GDB can get this wrong. Proposed Solution ----------------- I propose to change init_target_desc so that it requires an gdb_osabi to be passed in, this will then be used to set the target_desc osabi field. I believe that within gdbserver init_target_desc is called for every target_desc, so this should mean that every target_desc has an opportunity to set the osabi to something sane. I did consider passing the osabi into the code which creates the target_desc objects, but that would require updating far more code, as each target has its own code for creating target descriptions. The approach taken here requires minimal changes and forces every user of init_target_desc to think about what the correct osabi is. In some cases, e.g. amd64, where the osabi is already set when the target_desc is created, the init_target_desc call will override the current value, however, we should always be replacing it with the same actual value. i.e. if the target_desc is created with the osabi set to GNU/Linux, then this should only happen when gdbserver is built for GNU/Linux, in which case the init_target_desc should also be setting the osabi to GNU/Linux. The Tricky Bits --------------- Some targets, like amd64, use a features based approach for creating target_desc objects, there's a function in arch/amd64.c which creates a target_desc, adds features too it, and returns the new target_desc. This target_desc is then passed to an init_target_desc call within gdbserver. This is the easy case to handle. Then there are other targets which instead have a fixed set of xml files, each of which is converted into a .dat file, which is then used to generate a .cc file, which is compiled into gdbserver. The generated .cc file creates the target_desc object and calls init_target_desc on it. In this case though the target description that is sent to GDB isn't generated from the target_desc object, but is instead the contents of the fixed xml file. For this case the osabi which we pass to init_target_desc should match the osabi that exists in the fixed xml file. Luckily, in the previous commit I copied the osabi information from the fixed xml files into the .dat files. So in this commit I have extended regdat.sh to read the osabi from the .dat file and use it in the generated init_target_desc call. The problem with some of these .dat base targets is that their fixed xml files don't currently contain any osabi information, and the file names don't indicate that they are Linux only (despite them currently only being used from gdbserver for Linux targets), so I don't currently feel confident adding any osabi information to these files. An example would be features/rs6000/powerpc-64.xml. For now I've just ignored these cases. The init_target_desc will use GDB_OSABI_UNKNOWN which is the default. This means that for these targets nothing changes from the current behaviour. But many other targets do now pass the osabi back. Targets that do pass the osabi back are improved with this commit. Conclusion ---------- Now when I connect to the Windows remote the target description returned includes the osabi name. With this extra information GDB selects the correct gdbarch object, which means that GDB understands the target has a "dos-based" file-system. With that correct GDB understands that the filename it was given is absolute, and so fetches the file from the remote as we'd like. Reviewed-by: Kevin Buettner --- gdb/regformats/regdat.sh | 14 ++++++++++---- gdbserver/Makefile.in | 9 +++++---- gdbserver/linux-aarch32-tdesc.cc | 2 +- gdbserver/linux-aarch64-tdesc.cc | 3 ++- gdbserver/linux-arc-low.cc | 2 +- gdbserver/linux-arm-tdesc.cc | 2 +- gdbserver/linux-csky-low.cc | 2 +- gdbserver/linux-loongarch-low.cc | 2 +- gdbserver/linux-riscv-low.cc | 2 +- gdbserver/linux-x86-tdesc.cc | 15 +++++++++++++-- gdbserver/netbsd-aarch64-low.cc | 2 +- gdbserver/netbsd-amd64-low.cc | 2 +- gdbserver/netbsd-i386-low.cc | 2 +- gdbserver/tdesc.cc | 5 ++++- gdbserver/tdesc.h | 6 ++++-- gdbserver/win32-i386-low.cc | 4 ++-- gdbserver/win32-low.h | 7 +++++++ 17 files changed, 56 insertions(+), 25 deletions(-) diff --git a/gdb/regformats/regdat.sh b/gdb/regformats/regdat.sh index 38464c65b06..49aa02a466d 100755 --- a/gdb/regformats/regdat.sh +++ b/gdb/regformats/regdat.sh @@ -105,7 +105,7 @@ EOF } -exec > new-$2 +exec > new-$3 copyright $1 echo '#include "regdef.h"' echo '#include "tdesc.h"' @@ -118,6 +118,7 @@ xmlarch=x xmlosabi=x expedite=x feature=x +osabi=unknown exec < $1 while do_read do @@ -143,7 +144,7 @@ do elif test "${type}" = "xmlarch"; then xmlarch="${entry}" continue - elif test "${type}" = "osabi"; then + elif test "${type}" = "xmlosabi"; then xmlosabi="${entry}" continue elif test "${type}" = "expedite"; then @@ -152,6 +153,9 @@ do elif test "${type}" = "feature"; then feature="${entry}" continue + elif test "${type}" = "osabi"; then + osabi="${entry}" + continue elif test "${name}" = x; then echo "$0: $1 does not specify \`\`name''." 1>&2 exit 1 @@ -188,11 +192,13 @@ else fi echo +osabi_enum=$(grep "${osabi}" "$2" | sed 's/.*(\([^,]\+\),.*/GDB_OSABI_\1/') + cat <xmltarget = xmltarget_${name}; #endif - init_target_desc (result, expedite_regs_${name}); + init_target_desc (result, expedite_regs_${name}, ${osabi_enum}); tdesc_${name} = result; } @@ -200,4 +206,4 @@ EOF # close things off exec 1>&2 -mv -- "new-$2" "$2" +mv -- "new-$3" "$3" diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in index 6148ccf9121..f555ff439c4 100644 --- a/gdbserver/Makefile.in +++ b/gdbserver/Makefile.in @@ -488,6 +488,7 @@ stamp-xml: $(XML_DIR)/feature_to_c.sh Makefile $(XML_FILES) MAKEOVERRIDES = regdat_sh = $(srcdir)/../gdb/regformats/regdat.sh +osabi_def = $(srcdir)/../gdbsupport/osabi.def UST_CFLAGS = \ $(ustinc) \ @@ -588,11 +589,11 @@ target/%.o: ../gdb/target/%.c # Rules for register format descriptions. Suffix destination files with # -generated to identify and clean them easily. -%-generated.cc: ../gdb/regformats/%.dat $(regdat_sh) - $(ECHO_REGDAT) $(SHELL) $(regdat_sh) $< $@ +%-generated.cc: ../gdb/regformats/%.dat $(osabi_def) $(regdat_sh) + $(ECHO_REGDAT) $(SHELL) $(regdat_sh) $< $(osabi_def) $@ -%-generated.cc: ../gdb/regformats/rs6000/%.dat $(regdat_sh) - $(ECHO_REGDAT) $(SHELL) $(regdat_sh) $< $@ +%-generated.cc: ../gdb/regformats/rs6000/%.dat $(osabi_def) $(regdat_sh) + $(ECHO_REGDAT) $(SHELL) $(regdat_sh) $< $(osabi_def) $@ # Rule for gdbreplay.o. This is the same as COMPILE, but includes common-defs.h # instead of server.h. diff --git a/gdbserver/linux-aarch32-tdesc.cc b/gdbserver/linux-aarch32-tdesc.cc index b8987752b9f..441fe668e6a 100644 --- a/gdbserver/linux-aarch32-tdesc.cc +++ b/gdbserver/linux-aarch32-tdesc.cc @@ -34,7 +34,7 @@ aarch32_linux_read_description () tdesc_aarch32 = aarch32_create_target_description (false); static const char *expedite_regs[] = { "r11", "sp", "pc", 0 }; - init_target_desc (tdesc_aarch32, expedite_regs); + init_target_desc (tdesc_aarch32, expedite_regs, GDB_OSABI_LINUX); } return tdesc_aarch32; } diff --git a/gdbserver/linux-aarch64-tdesc.cc b/gdbserver/linux-aarch64-tdesc.cc index 31ec7854cc0..39d5bccdce1 100644 --- a/gdbserver/linux-aarch64-tdesc.cc +++ b/gdbserver/linux-aarch64-tdesc.cc @@ -67,7 +67,8 @@ aarch64_linux_read_description (const aarch64_features &features) expedited_registers.push_back (nullptr); - init_target_desc (tdesc, (const char **) expedited_registers.data ()); + init_target_desc (tdesc, (const char **) expedited_registers.data (), + GDB_OSABI_LINUX); tdesc_aarch64_map[features] = tdesc; } diff --git a/gdbserver/linux-arc-low.cc b/gdbserver/linux-arc-low.cc index 1bcaf6c3f91..16d8d5824aa 100644 --- a/gdbserver/linux-arc-low.cc +++ b/gdbserver/linux-arc-low.cc @@ -114,7 +114,7 @@ arc_linux_read_description (void) target_desc_up tdesc = arc_create_target_description (features); static const char *expedite_regs[] = { "sp", "status32", nullptr }; - init_target_desc (tdesc.get (), expedite_regs); + init_target_desc (tdesc.get (), expedite_regs, GDB_OSABI_LINUX); return tdesc.release (); } diff --git a/gdbserver/linux-arm-tdesc.cc b/gdbserver/linux-arm-tdesc.cc index 559f9b0f3dc..fff2e948f81 100644 --- a/gdbserver/linux-arm-tdesc.cc +++ b/gdbserver/linux-arm-tdesc.cc @@ -37,7 +37,7 @@ arm_linux_read_description (arm_fp_type fp_type) tdesc = arm_create_target_description (fp_type, false); static const char *expedite_regs[] = { "r11", "sp", "pc", 0 }; - init_target_desc (tdesc, expedite_regs); + init_target_desc (tdesc, expedite_regs, GDB_OSABI_LINUX); tdesc_arm_list[fp_type] = tdesc; } diff --git a/gdbserver/linux-csky-low.cc b/gdbserver/linux-csky-low.cc index 2eb5a2df17b..18a0d152b5a 100644 --- a/gdbserver/linux-csky-low.cc +++ b/gdbserver/linux-csky-low.cc @@ -133,7 +133,7 @@ csky_target::low_arch_setup () if (tdesc->expedite_regs.empty ()) { - init_target_desc (tdesc.get (), expedite_regs); + init_target_desc (tdesc.get (), expedite_regs, GDB_OSABI_LINUX); gdb_assert (!tdesc->expedite_regs.empty ()); } diff --git a/gdbserver/linux-loongarch-low.cc b/gdbserver/linux-loongarch-low.cc index 584ea64a7d9..cf7d6c0743c 100644 --- a/gdbserver/linux-loongarch-low.cc +++ b/gdbserver/linux-loongarch-low.cc @@ -85,7 +85,7 @@ loongarch_target::low_arch_setup () if (tdesc->expedite_regs.empty ()) { - init_target_desc (tdesc.get (), expedite_regs); + init_target_desc (tdesc.get (), expedite_regs, GDB_OSABI_LINUX); gdb_assert (!tdesc->expedite_regs.empty ()); } current_process ()->tdesc = tdesc.release (); diff --git a/gdbserver/linux-riscv-low.cc b/gdbserver/linux-riscv-low.cc index c4554c507a8..7170ad9922e 100644 --- a/gdbserver/linux-riscv-low.cc +++ b/gdbserver/linux-riscv-low.cc @@ -91,7 +91,7 @@ riscv_target::low_arch_setup () if (tdesc->expedite_regs.empty ()) { - init_target_desc (tdesc.get (), expedite_regs); + init_target_desc (tdesc.get (), expedite_regs, GDB_OSABI_LINUX); gdb_assert (!tdesc->expedite_regs.empty ()); } diff --git a/gdbserver/linux-x86-tdesc.cc b/gdbserver/linux-x86-tdesc.cc index 13c80762605..6aa5c4ab970 100644 --- a/gdbserver/linux-x86-tdesc.cc +++ b/gdbserver/linux-x86-tdesc.cc @@ -26,10 +26,21 @@ void x86_linux_post_init_tdesc (target_desc *tdesc, bool is_64bit) { + enum gdb_osabi osabi = GDB_OSABI_LINUX; + +#ifndef IN_PROCESS_AGENT + /* x86 target descriptions are created with the osabi already set. + However, init_target_desc requires us to override the already set + value. That's fine, out new string should match the old one. */ + gdb_assert (tdesc_osabi_name (tdesc) != nullptr); + gdb_assert (strcmp (tdesc_osabi_name (tdesc), + gdbarch_osabi_name (osabi)) == 0); +#endif /* ! IN_PROCESS_AGENT */ + #ifdef __x86_64__ if (is_64bit) - init_target_desc (tdesc, amd64_expedite_regs); + init_target_desc (tdesc, amd64_expedite_regs, osabi); else #endif - init_target_desc (tdesc, i386_expedite_regs); + init_target_desc (tdesc, i386_expedite_regs, osabi); } diff --git a/gdbserver/netbsd-aarch64-low.cc b/gdbserver/netbsd-aarch64-low.cc index f20a1a71773..8834e0ad894 100644 --- a/gdbserver/netbsd-aarch64-low.cc +++ b/gdbserver/netbsd-aarch64-low.cc @@ -98,7 +98,7 @@ netbsd_aarch64_target::low_arch_setup () = aarch64_create_target_description ({}); static const char *expedite_regs_aarch64[] = { "x29", "sp", "pc", NULL }; - init_target_desc (tdesc, expedite_regs_aarch64); + init_target_desc (tdesc, expedite_regs_aarch64, GDB_OSABI_NETBSD); current_process ()->tdesc = tdesc; } diff --git a/gdbserver/netbsd-amd64-low.cc b/gdbserver/netbsd-amd64-low.cc index b3f3aab5ec3..ad7cb430b92 100644 --- a/gdbserver/netbsd-amd64-low.cc +++ b/gdbserver/netbsd-amd64-low.cc @@ -193,7 +193,7 @@ netbsd_amd64_target::low_arch_setup () target_desc *tdesc = amd64_create_target_description (X86_XSTATE_SSE_MASK, false, false, false); - init_target_desc (tdesc, amd64_expedite_regs); + init_target_desc (tdesc, amd64_expedite_regs, GDB_OSABI_NETBSD); current_process ()->tdesc = tdesc; } diff --git a/gdbserver/netbsd-i386-low.cc b/gdbserver/netbsd-i386-low.cc index 247a39797c4..ea6fce4c6f9 100644 --- a/gdbserver/netbsd-i386-low.cc +++ b/gdbserver/netbsd-i386-low.cc @@ -142,7 +142,7 @@ netbsd_i386_target::low_arch_setup () target_desc *tdesc = i386_create_target_description (X86_XSTATE_SSE_MASK, false, false); - init_target_desc (tdesc, i386_expedite_regs); + init_target_desc (tdesc, i386_expedite_regs, GDB_OSABI_NETBSD); current_process ()->tdesc = tdesc; } diff --git a/gdbserver/tdesc.cc b/gdbserver/tdesc.cc index d052f43c76e..da1287abbbe 100644 --- a/gdbserver/tdesc.cc +++ b/gdbserver/tdesc.cc @@ -53,7 +53,8 @@ void target_desc::accept (tdesc_element_visitor &v) const void init_target_desc (struct target_desc *tdesc, - const char **expedite_regs) + const char **expedite_regs, + enum gdb_osabi osabi) { int offset = 0; @@ -88,6 +89,8 @@ init_target_desc (struct target_desc *tdesc, int expedite_count = 0; while (expedite_regs[expedite_count] != nullptr) tdesc->expedite_regs.push_back (expedite_regs[expedite_count++]); + + set_tdesc_osabi (tdesc, osabi); #endif } diff --git a/gdbserver/tdesc.h b/gdbserver/tdesc.h index 4796b50b4d1..9264786de51 100644 --- a/gdbserver/tdesc.h +++ b/gdbserver/tdesc.h @@ -20,6 +20,7 @@ #define GDBSERVER_TDESC_H #include "gdbsupport/tdesc.h" +#include "gdbsupport/osabi.h" #include "regdef.h" #include @@ -81,10 +82,11 @@ void copy_target_description (struct target_desc *dest, const struct target_desc *src); /* Initialize TDESC, and then set its expedite_regs field to - EXPEDITE_REGS. */ + EXPEDITE_REGS and its osabi to OSABI. */ void init_target_desc (struct target_desc *tdesc, - const char **expedite_regs); + const char **expedite_regs, + enum gdb_osabi osabi); /* Return the current inferior's target description. Never returns NULL. */ diff --git a/gdbserver/win32-i386-low.cc b/gdbserver/win32-i386-low.cc index 0a761ca58ef..13f9aca99b1 100644 --- a/gdbserver/win32-i386-low.cc +++ b/gdbserver/win32-i386-low.cc @@ -596,12 +596,12 @@ i386_arch_setup (void) #ifdef __x86_64__ tdesc = amd64_create_target_description (X86_XSTATE_SSE_MASK, false, false, false); - init_target_desc (tdesc, amd64_expedite_regs); + init_target_desc (tdesc, amd64_expedite_regs, WINDOWS_OSABI); win32_tdesc = tdesc; #endif tdesc = i386_create_target_description (X86_XSTATE_SSE_MASK, false, false); - init_target_desc (tdesc, i386_expedite_regs); + init_target_desc (tdesc, i386_expedite_regs, WINDOWS_OSABI); #ifdef __x86_64__ wow64_win32_tdesc = tdesc; #else diff --git a/gdbserver/win32-low.h b/gdbserver/win32-low.h index ff997df0a66..daed16a6ae6 100644 --- a/gdbserver/win32-low.h +++ b/gdbserver/win32-low.h @@ -21,6 +21,7 @@ #include #include "nat/windows-nat.h" +#include "gdbsupport/osabi.h" struct target_desc; @@ -31,6 +32,12 @@ extern const struct target_desc *win32_tdesc; extern const struct target_desc *wow64_win32_tdesc; #endif +#ifdef __CYGWIN__ +constexpr enum gdb_osabi WINDOWS_OSABI = GDB_OSABI_CYGWIN; +#else +constexpr enum gdb_osabi WINDOWS_OSABI = GDB_OSABI_WINDOWS; +#endif + struct win32_target_ops { /* Architecture-specific setup. */