From patchwork Thu Oct 17 16:19:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Mezentsev X-Patchwork-Id: 99095 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 257083858C39 for ; Thu, 17 Oct 2024 16:20:06 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 84BEE3858C3A for ; Thu, 17 Oct 2024 16:19:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84BEE3858C3A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84BEE3858C3A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1729181977; cv=pass; b=w22JXZ51ZeXRPPPA0rLB7v7Aq82jYqzWTPi6DDtUebSzZmJqSFjUfn7p43+xyb2DVLjfqumjRIfLGycJgxyWPVCRruz97H8X25BjgP7v3V2M8EU4z9CRI2hIGqqeKrHCZN+5n53UaDGbYToo1DM6i02l0nnlT8voG6AbPuXwK7E= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1729181977; c=relaxed/simple; bh=WtTAXzPSV9EOP5CJlgLzzfy4wroW9sPYIQFjZ7BBpMs=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=eju6uLoleYyYDFLe9X8tegQI45RSLPewR93YsAoYzU58gvqlqscbstcuGLMc3e37xnbz0oAnildc8LnHDg3VW5w2VLswAbMd0gXEqQlykZwmI6wb96VNYQCFJCigVJcdKA45yAZhLuyCqcC8zDmy+KCG9N6CjCokp9nx9FF0dLI= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49HFBdRH025065 for ; Thu, 17 Oct 2024 16:19:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=corp-2023-11-20; bh=IZm4KwTrCJMoOtp1 Ku9Cww3ZmU6+Gn2Jr36V9YhBLLQ=; b=ootQZA+gUfebWC0NN939PAUBN6yfGjeu fudFwdb4TmQMxn4vWxbydScOTAX+H10bSLlnI7v/GCbgYpDJfX4QyxTul7LEBKNw cIQbpxpYOZt32Tt7EQ9PLNAsF2AW+40YrHSOEiyaP8yIoR4lhocoQyCRFMy9mVe/ d0EofGgFtWj+xNchARzoehh1OUV6wlhgM41ctqUCBZJeVAbGGxLsbUa4KF8w+nNu WILyEEFcScTOUyddxaL653AS0TP57Xbeptxjrk4nB5nlPI1feD6P9qBpIRdrPeh2 q45jtlnAMHar6YrkeuEJLqPfSq9VH9WoHh9u5gQYvUBpr9AXV5B0HA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427g1apnbj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 17 Oct 2024 16:19:25 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49HFNeZS036115 for ; Thu, 17 Oct 2024 16:19:23 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2044.outbound.protection.outlook.com [104.47.74.44]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 427fjgxs1m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 17 Oct 2024 16:19:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nlVcYSo594+gsl4Fp13S446VX8h7GawOPVS7sb14HfG7eI2xOfhfEXq/Sx0M1pfk0mwU0KbDHsSY2Es6/rDchkY98M28sbYRPfH9P1RmA0Y395cktJkzqgj152U01fKkHYfwFeJcjLKf4HPpjTctGzN7q0VLN+qwujRYAguCAIh9QwTWLdufyBd5nr33h5fJRTzRqVFOCdJ+8sgXyqzALwCh9dNL3TSTRzcz8lwKVuD16uEPsJz4+wMMTCLzHpZ+sB/zPX0/npoFusYwle4fE8zbsQcgBRvezHlA0Mj/32vnk83Rmn7Q2LG/6ANKO/+jzNqyepE7PY9wTaZHp5G9XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZm4KwTrCJMoOtp1Ku9Cww3ZmU6+Gn2Jr36V9YhBLLQ=; b=kcYCNXaE5StFRaQaqjDwgAAYfLg3XeC1VHjnWiYW4YTzzPYyhp23ttLfJO7itIhdBUZxeVilDXR9JYtFKlfDvpqCzjkq4WoyeJ9lstkMSptprEI3MYyAlQP32RNtN3HCULofxzLWxzA71lRuwQWUY2SuQkh7Vd8WCbT9AqqKAX4VWwuPqZWSCt7ypKHLdpi9lQ84/sTQMxCp/UUMj+5RfpG+sTmaDH5/9vcTTMegLwiJCRxKqjwZeLQtikz9DFpe+1+GXQrWQ1FiBfqSL7bRTIpNq/lV4iCsQq2Arw0Z44psrV8ATackkupKBCU601Ve5/2yLXtpWPkzEvrct06gmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZm4KwTrCJMoOtp1Ku9Cww3ZmU6+Gn2Jr36V9YhBLLQ=; b=ojDYQuW0vFKe0u1CM8VwiWWwTLWovdGz24fc+qd0oF5yCL7lFEf+sL2g97rJaz9TbLBLQhsZ+P2NBCa2sL+f1D8HdoSrKLvqgPRfvVShKhT444VjR2CZhS2KMlPko95HFXlWkIly8d/O7zJOx2sH/hUfN7Fyna7/etCthu/OTC0= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by PH0PR10MB4407.namprd10.prod.outlook.com (2603:10b6:510:31::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Thu, 17 Oct 2024 16:19:21 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::1b3d:bd64:9100:c3fb]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::1b3d:bd64:9100:c3fb%7]) with mapi id 15.20.8069.019; Thu, 17 Oct 2024 16:19:21 +0000 From: vladimir.mezentsev@oracle.com To: binutils@sourceware.org Cc: Ruud van der Pas Subject: [PATCH] gprofng: fix a memory leak in the mxv-pthreads example Date: Thu, 17 Oct 2024 09:19:11 -0700 Message-ID: <20241017161911.2323072-1-vladimir.mezentsev@oracle.com> X-Mailer: git-send-email 2.43.5 X-ClientProxiedBy: SJ0PR03CA0143.namprd03.prod.outlook.com (2603:10b6:a03:33c::28) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|PH0PR10MB4407:EE_ X-MS-Office365-Filtering-Correlation-Id: 57548850-2074-4133-df99-08dceec7754e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|10070799003|1800799024|376014; X-Microsoft-Antispam-Message-Info: uRTYSTi+W+Fo20/X3ivleKQSFABlMngH5y8NuuB+n4vLWuPcbR6Q/GngHrkqUNM9/qryKlehg7mdN+07x52PaVshU935gZI58Cxev7mNaLUV/v1OU/rwirFE8mQcrzsIkZhsoDu4r4ZtPzH4POgOK9Pjk9N9lkMCL6loJLDTN8INqRuxqJiiSQleMlSmsaPhB+B+D6bNK1Ne+KbBkOveNvWiyqqh6N3LX68fBYXetm2n9SdV66nN2ZCagGI7J81+XhWEZ3KQZf5Cfsys1QaIdDXT+THZjMiD61VLgg9bbjiG2bWCTOWxcIK/7FJMYsHqCNFXaWtpViimN41VuzFda+nGgQlkqxsc6PJxwOxS7aftcpYVlTvyutIvI5g4j7aNFwItGRxWOimUhT17B32ZajueFVJiXfz6kFrwG7PumCY49/JseSsL0rpeZBw8zLkYC2zlyjTir+IKmBwd0fId8pQjcnb3tCM3yj3DYG5ZPnQ99THuXz6I+LbkE8sLANRHJA765ASAcjRNuClkJ2DBl3enaOQVWoRfHL2u+zBfWPrLCFHkfszzkYJ3BR3ADZUfynWaVsSns4KudT3mTrwl3AEjsaQz8x1WEE/LTHPTwkLR7UJ5Qb8rUPKGMD3Jz2ur25X5+4h8tPkwqiMWnA0afg4+a6Kq96ohYKgfpC/nG0uEo4hac0T/2+/r1iZgoSFAVE90xVXIjFBZdGPUT3UEzONUgo+9wwRViOBq1c7NKr+UVvppe02gJ97e/bj/jxtbpFQW0NWOVhKZiq9tMkZoZmS9f7vi2cxQvqhFgHeEwVvMseSPCvWgbeY8QD9Hp+5nqEeIjbllcTQahdmldNQsUzdOtY3CztSbV8l3HlBQ+zpypsgb2imIhAbSHzbLrkwgZy+1c5bOfqKXPM7XtClAJuQ88YB3j2cGfUB6Cl58yYpprhIYVB3lT1THkObLPpPvX7JXpbM4ft3KYiJbKOhvoUut/HAPQq6seCXndhIABf9qCuTcVvJ6VFhkAGxO0UPtgVZaM6KELhAjNf60KalK1XWvwXNrJMAUJSGQytsOqT3V0065/JAPHbNS5nuiZeGteLZT60yDmWv2TEgdPjkof6ungCGah9N0TGZ+SFR1tkToCCIXg+qe+5U6J2DSz7qd9xa8QQXczxF9Kp6TOI+8hnjlrjhyvAko/6p7tJt9JFAxXfTdK9DCX9smRVP8/oMZj2rbO0bGlPxRLgV7j7MfYzRAKRUxSuXEssHtFwJRcJoaApV3e3xtyOSME8gAifb85WlrbrUbYLLF14nF16wD7QZxH5BRF2T7BStc0eXMuj5DuLsNCzdigRL4XgRq45PY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(10070799003)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XH8COfvIOZFI5Vh7jq05ACYnaFJsfXe7GhwAmOHVA11nYgZL2BQ0KJJmoOXR9r8HrS/IrPv7GA6rSFICmbIGezf/FMDcOetyumSmGYZP2aTeVGOxDeyHMDnth1Mc70vNWagU9fFaawkpEfe6ABRcX4u4cHZFdzbtx/sFAuM5ZSdrz3Sw9so1+aZVH9b5H3PRDseEKa8lxbRTjmACZbCfbgSu3vMsb84aK4j1ywTQ2GTiqCRHqzCYp++KpG0eiusJSrPX5r6yv49YFmmNA9BHgBbZKdifgEORlCEEwLiQ7vbQrXdR8FSWCM4dHL27KVz0g1eByEb7TPggoeF50bvf+BiANrMBO3N0cOlNFptBWKI8jXx6nn4pVVXg0qJLf/Y1G6/VHQHHaB0brXDx9oHDlYccjEcCzNs55RSUpDLFvAJhoytMSC5vtpqYMpZVSjQ+z8dnkkg5UaSXgeNRKdVQNfPpaXrU40HzsxZJSTAFhPBQtmnA6UiCnB4I6/y3+EsK7Td1BTtGr5DTTsl0vtaIQaDzKFjlzcft1QH/lZH3CRWY+v6xfnox5SKypt1idf1OGenGBkHFwXtyQW7x1ETsbnez80bbuMUAgW+wIeSc65030s68lpTcNc5ew/Z67rqB4sIu3huxcqPrLtycxGCH2zTqxCQ9GP/lvOXvJUJEpQkqnpQaQMqth/vY6+E2K13cdEt+QmLtXzkpNpT1NcpxGIy9XECMkqU/xoj8WuCMMLnKjBXCW8npf6J6rYgKoDIU2g9ayq27pK4KTJXfHSZQOtyhwEWav4vJXUBbNzxM5uw1Mkc3ZCOw6J5eJOu4Q7wcS7PR/OqH22UAMonRBWTZl7UO/VfzQ8jZ7KYDU9cYZmPFRl8Ucqkld1jpQ9IK14N/gvDdLN7VhhVLnvmFTt7HddSC4Jvd4xu2d4VgWBllc/5MDbzWkyBw68MDoJUFruBkxvGX9kDfcwmjuWGXNlqydj+XOBE+o2cEdMLyly1xK0XCVonDPfSPOcn1FkhB7APwWjpCFp+0D6ySLTu6V/we8ixHq3DqEtlHo+iUI/TBWR37b11ib16Q/SGcdGu/g4zvFvg2q59PZuSymrHuNpAHDE3gTvr8KWCJjgkTy+Kov6XBUx/hoaAvExUSp+ntpe0BfOYhHMvlbNxkFO6oCR6J9Rq1LUwOTBhYUucqaSj3eMy5kmxsbv7IpzEeb/8cNMWhr9YH4OisrHKe/ERZFkZxs8QZiHSOPUnY6phlxgW4fnOWD0ZpvPqIRqDxtzqsU9Vjr8jQotIXVsJdUdF4g5yhRPLdZr/3iA2Eusnu3S1n82+cjQoHXSgWDryzHO7brdLibqdbEMBTgSPFLMVw114GQ8K1UpoKRgtO2gQpvAIItLK5NpHl+wbox5AEIk3a8Snj3mqEiMDXVrD4rwNW4fO1xfShKf2NRsrVQLHLgTpOHEX1BSKfS5z9O9evqxJmAT+XLN8ZW00FSRzBPmvM6KMaJ3luVoBIFn1xwC7YqL4jIthNqxDa8JYWV39SAI3ulQVYtKTpyCYk3BgvWfg53I+0eEpt4mjD2ebDXhvq7REk4X5GHwOxHk2UsS/6bXMX6rsRf06OKCegfR8S5+6jUIjPyhx4Px4tR2eXRnO2Tx1VpNDL3Qo4F2QdCK/E9++MI6eo X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fZEoXwelDjh7mHozl/2HF9VhsBTDgPdAqTXq/gnHC6KY1rUG1Ijio5jhho1gIuKIrY3OcsgqUk+jYLAxYOPLdu2cmCpPzF/WdAVLvXSS3gbcsqVGSqVSSl1iCEZl2ypqe5IwbaOjF4Qf+UsNE5fj6tob1cBk30vKKBGuXJf7Z+fWnzmNdgp/pXMwTwkmsVdUN37VgmRn9zsY8nVKWhH98Foj6O5ko8QB2FcjtDEHZVLwxD3dlDPoW5tcnYQSKvZfaNtWjoKAjD3amLdssI7nghA+FuczcM8TP3g+Flz5idNI+4sLcJpM5shyo4dhw7vEHAp1Qw6ODgA2EkfRxBVEMrcnZYUJcE/qEdnpvC+M74C6Q4vzRAFYnDJZaoG4e0QOmMJDWAqzGFjNXvEJhPKEq5bhMakNpPBV5gFznKXCzPVSjLLhK5v1q67++RKo/DdZikWRk0J53GWq+AEXCUjqUCMwid5Zi+zg4NHBaaxT7nE/y+TtqSI1bei7i8c/ysIH1OjG60K+w+DpGQF0G6ENscPuQpRp/7g4YbjaxN0MqMLob/T4XK6ua/2lGeYuypbio1RfeWbzL1gUV39mX5QnKiuGZmtClV1YofLPXSoC+Ds= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57548850-2074-4133-df99-08dceec7754e X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2024 16:19:21.6471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hh0XN5IubBYrbN5X8V11zCghk1fLg2oolh6c3wNqpl/eEkurtgb6UWN+E2JGlBaO693QqbVdDSk8prfzERcKRfnsSu5MWD9HjnbgIjHkb1E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4407 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-17_18,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410170111 X-Proofpoint-GUID: LBRsxNCaMT_flfhN1_VoIRG15d1IPg5n X-Proofpoint-ORIG-GUID: LBRsxNCaMT_flfhN1_VoIRG15d1IPg5n X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org From: Ruud van der Pas Fix a bug where the main program does not free the rows of the matrix. The memory for thread_data_arguments is also not released. In function check_results, the memory for the marker vector is not released. The usage of the verbose veriable has been extended to print more messages. gprofng/ChangeLog 2024-10-16 Ruud van der Pas PR 32273 PR 32274 * mxv-pthreads/src/main.c: add calls to free() to release the memory allocated for array A and vector marker. Improve the usage of the verbose variable. * mxv-pthreads/src/manage_data.c: add a diagnostic printf statement. * mxv-pthreads/src/mydefs.h: adapt prototype to match the changes in main.c. --- gprofng/examples/mxv-pthreads/src/main.c | 20 ++++++++++++------- .../examples/mxv-pthreads/src/manage_data.c | 6 ++++-- gprofng/examples/mxv-pthreads/src/mydefs.h | 3 +-- 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/gprofng/examples/mxv-pthreads/src/main.c b/gprofng/examples/mxv-pthreads/src/main.c index 625c60484d1..8596763b918 100644 --- a/gprofng/examples/mxv-pthreads/src/main.c +++ b/gprofng/examples/mxv-pthreads/src/main.c @@ -28,9 +28,10 @@ #include "mydefs.h" +bool verbose; + int main (int argc, char **argv) { - bool verbose = false; thread_data *thread_data_arguments; pthread_t *pthread_ids; @@ -62,8 +63,7 @@ int main (int argc, char **argv) &number_of_rows, &number_of_columns, &repeat_count, - &number_of_threads, - &verbose); + &number_of_threads); if (verbose) printf ("Verbose mode enabled\n"); @@ -191,11 +191,16 @@ int main (int argc, char **argv) * Release the allocated memory and end execution. * ----------------------------------------------------------------------------- */ + for (int64_t i=0; i