From patchwork Mon Oct 18 08:15:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 46322 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB9AE385802D for ; Mon, 18 Oct 2021 08:15:36 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 6CA523858C39 for ; Mon, 18 Oct 2021 08:15:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6CA523858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 708081FD6C for ; Mon, 18 Oct 2021 08:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634544917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FcgAHstyhBRWyehL9D7yueMZkENUB+wfQ13ub0oa1Jk=; b=tIgYevhjfby9D7TCnPtQ1bMpJqb7DWcdJa6qOjZG6F9aBNwFhDljkG12gbntnY6O+Ucq0f zka+fkQzW7p8eNhCWcC6BGI70TUYPz76FPt2jZs43w8ijt3ZsdhF1mwDwY2W/OFsdRVtYk wJojd+ZiKbCoslyR3sWz75t8pvyreuE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634544917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FcgAHstyhBRWyehL9D7yueMZkENUB+wfQ13ub0oa1Jk=; b=1UERdYL6CJQ3qpnwMbVK6yVOipC9uOsO2DIjqONFRE17/djOaH57ViRf3Vag15Dw+YNFM8 PXOaOXkk6BWXz8BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 621CA13CC9 for ; Mon, 18 Oct 2021 08:15:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id adG/FRUtbWFzJAAAMHmgww (envelope-from ) for ; Mon, 18 Oct 2021 08:15:17 +0000 Message-ID: <219882f8-6a54-df48-4897-3f4cd24fcba4@suse.cz> Date: Mon, 18 Oct 2021 10:15:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 From: =?utf-8?q?Martin_Li=C5=A1ka?= Subject: [PATCH][PUSHED] Remove unused but set variables. To: gcc-patches@gcc.gnu.org Content-Language: en-US X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Pushed to master as obvious. Reported by clang13 -Wunused-but-set-variable: gcc/ChangeLog: * dbgcnt.c (dbg_cnt_process_opt): Remove unused but set variable. * gcov.c (get_cycles_count): Likewise. * lto-compress.c (lto_compression_zlib): Likewise. (lto_uncompression_zlib): Likewise. * targhooks.c (default_pch_valid_p): Likewise. libcpp/ChangeLog: * charset.c (convert_oct): Remove unused but set variable. --- gcc/dbgcnt.c | 2 -- gcc/gcov.c | 4 +--- gcc/lto-compress.c | 4 ---- gcc/targhooks.c | 4 +--- libcpp/charset.c | 2 -- 5 files changed, 2 insertions(+), 14 deletions(-) diff --git a/gcc/dbgcnt.c b/gcc/dbgcnt.c index 6a7eb34cd3e..458341a53a0 100644 --- a/gcc/dbgcnt.c +++ b/gcc/dbgcnt.c @@ -208,7 +208,6 @@ void dbg_cnt_process_opt (const char *arg) { char *str = xstrdup (arg); - unsigned int start = 0; auto_vec tokens; for (char *next = strtok (str, ","); next != NULL; next = strtok (NULL, ",")) @@ -227,7 +226,6 @@ dbg_cnt_process_opt (const char *arg) if (!dbg_cnt_process_single_pair (name, ranges[j])) break; } - start += strlen (tokens[i]) + 1; } } diff --git a/gcc/gcov.c b/gcc/gcov.c index 829e955a63b..3672ae7a6f8 100644 --- a/gcc/gcov.c +++ b/gcc/gcov.c @@ -843,7 +843,6 @@ get_cycles_count (line_info &linfo) Therefore, operating on a permuted order (i.e., non-sorted) only has the effect of permuting the output cycles. */ - bool loop_found = false; gcov_type count = 0; for (vector::iterator it = linfo.blocks.begin (); it != linfo.blocks.end (); it++) @@ -851,8 +850,7 @@ get_cycles_count (line_info &linfo) arc_vector_t path; block_vector_t blocked; vector block_lists; - loop_found |= circuit (*it, path, *it, blocked, block_lists, linfo, - count); + circuit (*it, path, *it, blocked, block_lists, linfo, count); } return count; diff --git a/gcc/lto-compress.c b/gcc/lto-compress.c index b5f4916b139..c40a13c8446 100644 --- a/gcc/lto-compress.c +++ b/gcc/lto-compress.c @@ -250,7 +250,6 @@ lto_compression_zlib (struct lto_compression_stream *stream) const size_t outbuf_length = Z_BUFFER_LENGTH; unsigned char *outbuf = (unsigned char *) xmalloc (outbuf_length); z_stream out_stream; - size_t compressed_bytes = 0; int status; gcc_assert (stream->is_compression); @@ -282,7 +281,6 @@ lto_compression_zlib (struct lto_compression_stream *stream) stream->callback ((const char *) outbuf, out_bytes, stream->opaque); lto_stats.num_compressed_il_bytes += out_bytes; - compressed_bytes += out_bytes; cursor += in_bytes; remaining -= in_bytes; @@ -342,7 +340,6 @@ lto_uncompression_zlib (struct lto_compression_stream *stream) size_t remaining = stream->bytes; const size_t outbuf_length = Z_BUFFER_LENGTH; unsigned char *outbuf = (unsigned char *) xmalloc (outbuf_length); - size_t uncompressed_bytes = 0; gcc_assert (!stream->is_compression); timevar_push (TV_IPA_LTO_DECOMPRESS); @@ -378,7 +375,6 @@ lto_uncompression_zlib (struct lto_compression_stream *stream) stream->callback ((const char *) outbuf, out_bytes, stream->opaque); lto_stats.num_uncompressed_il_bytes += out_bytes; - uncompressed_bytes += out_bytes; cursor += in_bytes; remaining -= in_bytes; diff --git a/gcc/targhooks.c b/gcc/targhooks.c index cbbcedf790f..812bbe3f16e 100644 --- a/gcc/targhooks.c +++ b/gcc/targhooks.c @@ -2200,7 +2200,7 @@ pch_option_mismatch (const char *option) /* Default version of pch_valid_p. */ const char * -default_pch_valid_p (const void *data_p, size_t len) +default_pch_valid_p (const void *data_p, size_t len ATTRIBUTE_UNUSED) { struct cl_option_state state; const char *data = (const char *)data_p; @@ -2221,7 +2221,6 @@ default_pch_valid_p (const void *data_p, size_t len) memcpy (&tf, data, sizeof (target_flags)); data += sizeof (target_flags); - len -= sizeof (target_flags); r = targetm.check_pch_target_flags (tf); if (r != NULL) return r; @@ -2233,7 +2232,6 @@ default_pch_valid_p (const void *data_p, size_t len) if (memcmp (data, state.data, state.size) != 0) return pch_option_mismatch (cl_options[i].opt_text); data += state.size; - len -= state.size; } return NULL; diff --git a/libcpp/charset.c b/libcpp/charset.c index b84a9740165..e4e45f6d39d 100644 --- a/libcpp/charset.c +++ b/libcpp/charset.c @@ -1464,7 +1464,6 @@ convert_oct (cpp_reader *pfile, const uchar *from, const uchar *limit, cppchar_t c, n = 0; size_t width = cvt.width; size_t mask = width_to_mask (width); - bool overflow = false; /* loc_reader and ranges must either be both NULL, or both be non-NULL. */ gcc_assert ((loc_reader != NULL) == (ranges != NULL)); @@ -1477,7 +1476,6 @@ convert_oct (cpp_reader *pfile, const uchar *from, const uchar *limit, from++; if (loc_reader) char_range.m_finish = loc_reader->get_next ().m_finish; - overflow |= n ^ (n << 3 >> 3); n = (n << 3) + c - '0'; }