From patchwork Wed Oct 13 14:00:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 46173 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B38A43858413 for ; Wed, 13 Oct 2021 14:01:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B38A43858413 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1634133688; bh=jEAPCqym4sKEwkJQtu6kqdqtYjUY9ki6mmw1xG516JM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=XmtA1GdbwH04d5DXSBtARpX/BybtdJMYpEdr5mMIoQXdwcODZx7bhe/rXES+y5dTK NwIuzBYBVUx9SlsOvvwLHdr5NwtAM2HyqwuX0a7lHUg1Od1cC0f0khLYCy88VCedy0 KgoNhoeXQOi3Y4UpaakTK+2hQ2P7rRsJ21Z72lLY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 562483858C27 for ; Wed, 13 Oct 2021 14:01:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 562483858C27 Received: by mail-wr1-x432.google.com with SMTP id u18so8836197wrg.5 for ; Wed, 13 Oct 2021 07:01:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :mime-version:content-transfer-encoding; bh=jEAPCqym4sKEwkJQtu6kqdqtYjUY9ki6mmw1xG516JM=; b=pGeTKYQly8GdDNVc+bxCMXz2/d2Du9QO5HDrUYx0oURZgH3q58FQaQWf+You2cTLZp h7yXH2IYJHNim6GzVRzSQJ5wTYcufqJkVJNzxFUKBZdhcxRtFjPCBDX0d19nG3p5+3Qi ZjuEJ3REpJPLi7AcgIwDiEuJ0AtzOAHTnb2BKRM8JhdSaxsbfqKekkhVwjt5AX6Becmy Y0nFctTqp07iISjebfTaX2yvsaMo1oZ98hbvrlD8Na4YQpC/QksCHbVFm0wszEGqAEHK YURG6u5jnIyCfIz4+0xGrNvrk0w5v8WYP4R46mzpN9XxZ579AN6fW1NAjbK1tNyAFlzH OJfg== X-Gm-Message-State: AOAM532eLvJHUHNWviczCp7vXPPboINdXxgsNMUu/MqLdwkSFpaZKBhO gDVIEl5bgWYrBGbnlPXCls8FdDmDKIRC7w== X-Google-Smtp-Source: ABdhPJwY1QR/lMmCIFOM7AEkvQ0Ezgsrv9NDKp6G7zO7z0RsV1/f+QXNhE8IP3R84NV2gjLsPi5/Gw== X-Received: by 2002:adf:bc4a:: with SMTP id a10mr40162790wrh.131.1634133659500; Wed, 13 Oct 2021 07:00:59 -0700 (PDT) Received: from localhost.localdomain (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id e9sm5425677wme.37.2021.10.13.07.00.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Oct 2021 07:00:59 -0700 (PDT) X-Google-Original-From: Iain Sandoe To: gcc-patches@gcc.gnu.org Subject: [PATCH] collect2: Fix missing cleanups. Date: Wed, 13 Oct 2021 15:00:52 +0100 Message-Id: <20211013140052.18988-1-iain@sandoe.co.uk> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Iain Sandoe via Gcc-patches From: Iain Sandoe Reply-To: iain@sandoe.co.uk Cc: Iain Sandoe Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" The code that checks to see if objects have LTO content via simple-object was not releasing resources, fixed thus. tested on x86_64, powerpc64le linux, powerpc-aix, i686,x86_64-darwin, OK for master and backports? thanks Iain Signed-off-by: Iain Sandoe gcc/ChangeLog: * collect2.c (is_lto_object_file): Release simple-object resources, close files. --- gcc/collect2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gcc/collect2.c b/gcc/collect2.c index cf04a58ba4d..d47fe3f9195 100644 --- a/gcc/collect2.c +++ b/gcc/collect2.c @@ -2299,10 +2299,15 @@ is_lto_object_file (const char *prog_name) LTO_SEGMENT_NAME, &errmsg, &err); if (!inobj) - return false; + { + close (infd); + return false; + } errmsg = simple_object_find_sections (inobj, has_lto_section, (void *) &found, &err); + simple_object_release_read (inobj); + close (infd); if (! errmsg && found) return true;