From patchwork Mon Oct 11 19:18:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 46108 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6C21A3857C7C for ; Mon, 11 Oct 2021 19:24:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C21A3857C7C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633980263; bh=Ty0j0E1oUIC+qRA9lnoHjiRdIxJkNBBzvQ/jitBgGQ8=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=ZUVlF3oavLkZVXOsOJzjvl1TulAs/dFXb/eOqOah9P9a6TwdOFJaJs/7A7bcJdVaW gBgrIo7vVNExTwuWEcxbEezNq6QAjnoFjmM+SleOV0iq2ro19s8YlUzJ7Ox/ADBWje 5onEIXgYsA3YTuqCUkBxWVMlNi4lPp7FAaDj7M9g= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by sourceware.org (Postfix) with ESMTPS id E8345385801D for ; Mon, 11 Oct 2021 19:19:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8345385801D Received: by mail-qv1-xf2e.google.com with SMTP id k29so1500232qve.6 for ; Mon, 11 Oct 2021 12:19:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ty0j0E1oUIC+qRA9lnoHjiRdIxJkNBBzvQ/jitBgGQ8=; b=wmpcVAcIcoHuKH7vYgi6DjkgXzNJPdKpD665EAqxVBrNweY+S/FYdmXgYLjweMIjcc ASUCb/ZWE5kp/yPmudJVe829PxjVevmNLCykYEmc2rqHUupIMj1EERGO87AuG567nIQ2 rHGBt/VlgKjLcAnh9ExPaK5VtNgw6HqTJ+Wth+xhskYOC7m3TuMtW72VVZCiSWd9ZkjM T62voViItYJEtqt0hYCeTTG7EBjpIAPUIOwA/85l2avXw4fAn4fS45j/PJ9MMORloIeb ft4Td0c7mNfrDJ+Mp6bFP5smTb3TGw/RBEX9QOVkRTBBlugccA1JypbnayHeQQX/rJhs 5f6w== X-Gm-Message-State: AOAM5337WUO3JxCFou+txetne8ZR1KF4GqrNN1nUW8rfT6Bgd0GVson8 ZsTf6ByIL/uIwZpLt57pnGEQEc7QfSHKQg== X-Google-Smtp-Source: ABdhPJxgO+woGawL+sOwWlVydsI2RSL71LLAIWqsq1kDagPiNVDOQtESj1rkHJw2OlOiBWpke8iCTA== X-Received: by 2002:a05:6214:c2f:: with SMTP id a15mr25869577qvd.14.1633979944279; Mon, 11 Oct 2021 12:19:04 -0700 (PDT) Received: from birita.. ([2804:431:c7cb:807a:d3d9:54fd:9a6e:6970]) by smtp.gmail.com with ESMTPSA id v4sm4426704qtk.90.2021.10.11.12.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 12:19:04 -0700 (PDT) To: libc-alpha@sourceware.org, Fangrui Song Subject: [PATCH] elf: Fix elf_get_dynamic_info definition Date: Mon, 11 Oct 2021 16:18:59 -0300 Message-Id: <20211011191859.509946-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Cc: Florian Weimer , Andreas Schwab Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Before 490e6c62aa31a8a ('elf: Avoid nested functions in the loader [BZ #27220]') elf_get_dynamic_info were defined as 'auto' for !RESOLVE_MAP (the default case). Also, the function adds extra asserts depending on whether is defined or not RTLD_BOOTSTRAP. With the commit change, the function is now included and defined once instead of defined as a nested function. So rtld.c defines it when including 'dynamic-link.h' without defining RTLD_BOOTSTRAP and it brokes at least powerpc. This patch fixes by defining iff get-dynamic-info.h, which then the caller can corectly set the expected semantic by STATIC_PIE_BOOTSTRAP, RTLD_BOOTSTRAP, and/or RESOLVE_MAP. It also requires to enable some asserts only for the loader bootstrap since the function is now define once. As a side note, this is another issues with nested functions: it is not clear from pre-processed output (-E -dD) how the function will be build and its semantic (since nested function will be local and extra C defines may change it). I checked on x86_64-linux-gnu (w/o --enable-static-pie), i686-linux-gnu, powerpc64-linux-gnu, powerpc-linux-gnu-power4, aarch64-linux-gnu, arm-linux-gnu, sparc64-linux-gnu, and s390x-linux-gnu. Reviewed-by: Fangrui Song --- elf/dl-conflict.c | 1 + elf/dl-load.c | 3 ++- elf/dl-reloc-static-pie.c | 3 ++- elf/dl-runtime.c | 1 + elf/dynamic-link.h | 1 - elf/get-dynamic-info.h | 25 ++++++++++++++----------- elf/rtld.c | 5 +++-- elf/setup-vdso.h | 2 +- sysdeps/arm/dl-machine.h | 1 + sysdeps/i386/dl-machine.h | 1 + sysdeps/x86_64/dl-machine.h | 1 + 11 files changed, 27 insertions(+), 17 deletions(-) diff --git a/elf/dl-conflict.c b/elf/dl-conflict.c index b58929cc5d..fb501e0373 100644 --- a/elf/dl-conflict.c +++ b/elf/dl-conflict.c @@ -16,6 +16,7 @@ License along with the GNU C Library; see the file COPYING.LIB. If not, see . */ +#include #include #include #include diff --git a/elf/dl-load.c b/elf/dl-load.c index 99c5ab83b3..335c79fad5 100644 --- a/elf/dl-load.c +++ b/elf/dl-load.c @@ -58,6 +58,7 @@ struct filebuf }; #include "dynamic-link.h" +#include "get-dynamic-info.h" #include #include #include @@ -1297,7 +1298,7 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd, else l->l_ld = (ElfW(Dyn) *) ((ElfW(Addr)) l->l_ld + l->l_addr); - elf_get_dynamic_info (l); + elf_get_dynamic_info (l, false); /* Make sure we are not dlopen'ing an object that has the DF_1_NOOPEN flag set, or a PIE object. */ diff --git a/elf/dl-reloc-static-pie.c b/elf/dl-reloc-static-pie.c index 4007580453..8a99c4995b 100644 --- a/elf/dl-reloc-static-pie.c +++ b/elf/dl-reloc-static-pie.c @@ -28,6 +28,7 @@ #define STATIC_PIE_BOOTSTRAP #define RESOLVE_MAP(map, scope, sym, version, flags) map #include "dynamic-link.h" +#include "get-dynamic-info.h" /* Relocate static executable with PIE. */ @@ -51,7 +52,7 @@ _dl_relocate_static_pie (void) break; } - elf_get_dynamic_info (main_map); + elf_get_dynamic_info (main_map, false); # ifdef ELF_MACHINE_BEFORE_RTLD_RELOC ELF_MACHINE_BEFORE_RTLD_RELOC (main_map, main_map->l_info); diff --git a/elf/dl-runtime.c b/elf/dl-runtime.c index 9d0d941000..61c260ddb8 100644 --- a/elf/dl-runtime.c +++ b/elf/dl-runtime.c @@ -19,6 +19,7 @@ #define IN_DL_RUNTIME 1 /* This can be tested in dl-machine.h. */ #include +#include #include #include #include diff --git a/elf/dynamic-link.h b/elf/dynamic-link.h index 7cc3021164..21cdfc88bb 100644 --- a/elf/dynamic-link.h +++ b/elf/dynamic-link.h @@ -93,7 +93,6 @@ elf_machine_lazy_rel (struct link_map *map, struct r_scope_elem *scope[], #include -#include "get-dynamic-info.h" #ifdef RESOLVE_MAP diff --git a/elf/get-dynamic-info.h b/elf/get-dynamic-info.h index 15c316b38c..d169099fbc 100644 --- a/elf/get-dynamic-info.h +++ b/elf/get-dynamic-info.h @@ -25,7 +25,7 @@ #include static inline void __attribute__ ((unused, always_inline)) -elf_get_dynamic_info (struct link_map *l) +elf_get_dynamic_info (struct link_map *l, bool check) { #if __ELF_NATIVE_CLASS == 32 typedef Elf32_Word d_tag_utype; @@ -112,16 +112,19 @@ elf_get_dynamic_info (struct link_map *l) assert (info[DT_RELENT]->d_un.d_val == sizeof (ElfW(Rel))); #endif #ifdef RTLD_BOOTSTRAP - /* Only the bind now flags are allowed. */ - assert (info[VERSYMIDX (DT_FLAGS_1)] == NULL - || (info[VERSYMIDX (DT_FLAGS_1)]->d_un.d_val & ~DF_1_NOW) == 0); - /* Flags must not be set for ld.so. */ - assert (info[DT_FLAGS] == NULL - || (info[DT_FLAGS]->d_un.d_val & ~DF_BIND_NOW) == 0); -#endif -#if defined RTLD_BOOTSTRAP || defined STATIC_PIE_BOOTSTRAP - assert (info[DT_RUNPATH] == NULL); - assert (info[DT_RPATH] == NULL); + if (check) + { + /* Only the bind now flags are allowed. */ + assert (info[VERSYMIDX (DT_FLAGS_1)] == NULL + || (info[VERSYMIDX (DT_FLAGS_1)]->d_un.d_val & ~DF_1_NOW) == 0); + /* Flags must not be set for ld.so. */ + assert (info[DT_FLAGS] == NULL + || (info[DT_FLAGS]->d_un.d_val & ~DF_BIND_NOW) == 0); +# ifdef STATIC_PIE_BOOTSTRAP + assert (info[DT_RUNPATH] == NULL); + assert (info[DT_RPATH] == NULL); +# endif + } #else if (info[DT_FLAGS] != NULL) { diff --git a/elf/rtld.c b/elf/rtld.c index 5eee9e1091..fe5ee9ec4d 100644 --- a/elf/rtld.c +++ b/elf/rtld.c @@ -513,6 +513,7 @@ _dl_start_final (void *arg, struct dl_start_final_info *info) is trivial: always the map of ld.so itself. */ #define RTLD_BOOTSTRAP #define RESOLVE_MAP(map, scope, sym, version, flags) map +#include "get-dynamic-info.h" #include "dynamic-link.h" static ElfW(Addr) __attribute_used__ @@ -547,7 +548,7 @@ _dl_start (void *arg) /* Read our own dynamic section and fill in the info array. */ bootstrap_map.l_ld = (void *) bootstrap_map.l_addr + elf_machine_dynamic (); - elf_get_dynamic_info (&bootstrap_map); + elf_get_dynamic_info (&bootstrap_map, true); #if NO_TLS_OFFSET != 0 bootstrap_map.l_tls_offset = NO_TLS_OFFSET; @@ -1615,7 +1616,7 @@ dl_main (const ElfW(Phdr) *phdr, if (! rtld_is_main) { /* Extract the contents of the dynamic section for easy access. */ - elf_get_dynamic_info (main_map); + elf_get_dynamic_info (main_map, false); /* If the main map is libc.so, update the base namespace to refer to this map. If libc.so is loaded later, this happens diff --git a/elf/setup-vdso.h b/elf/setup-vdso.h index f44748bc98..6fdffafcca 100644 --- a/elf/setup-vdso.h +++ b/elf/setup-vdso.h @@ -64,7 +64,7 @@ setup_vdso (struct link_map *main_map __attribute__ ((unused)), l->l_map_end += l->l_addr; l->l_text_end += l->l_addr; l->l_ld = (void *) ((ElfW(Addr)) l->l_ld + l->l_addr); - elf_get_dynamic_info (l); + elf_get_dynamic_info (l, false); _dl_setup_hash (l); l->l_relocated = 1; diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h index 68a0b4b476..dfa05eee44 100644 --- a/sysdeps/arm/dl-machine.h +++ b/sysdeps/arm/dl-machine.h @@ -21,6 +21,7 @@ #define ELF_MACHINE_NAME "ARM" +#include #include #include #include diff --git a/sysdeps/i386/dl-machine.h b/sysdeps/i386/dl-machine.h index 9f578e536a..78bed03eee 100644 --- a/sysdeps/i386/dl-machine.h +++ b/sysdeps/i386/dl-machine.h @@ -21,6 +21,7 @@ #define ELF_MACHINE_NAME "i386" +#include #include #include #include diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h index 9c0182d597..20afb0b4bc 100644 --- a/sysdeps/x86_64/dl-machine.h +++ b/sysdeps/x86_64/dl-machine.h @@ -21,6 +21,7 @@ #define ELF_MACHINE_NAME "x86_64" +#include #include #include #include