From patchwork Sat Aug 10 01:01:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 95615 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9AB03858D34 for ; Sat, 10 Aug 2024 01:01:47 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 00B0B3858D20 for ; Sat, 10 Aug 2024 01:01:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00B0B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00B0B3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723251676; cv=none; b=rNhi1qQuTIpMID+vlZ6Ue4Og7cXmjO4IXTFBYZE6ksekoID5tY7bv3kRk3ATm9UX8KLLaX/LmZ7vdtLe9MxTpo4DiHa2m1SEt7Wmd0nHcaHrIH2pNvqXnBMbaz0wH+mI7LplPG04CdBDhxdY6/DDrKDnD9/Gzl9PX+7tK3JNxxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723251676; c=relaxed/simple; bh=Xkz2KYnPFjUa97MeJkO9NYZ6O/+bZROZAbQFiJkacII=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=QSlJ4bcoMA2XQEzIMvZi4XzJYQ+KTHM0LJqd00ZgXeqggdeMMbzJAbGoERWbmiSRWIFdO14o8AUm805K5pzPULOu/VAcZv0BfYpd8hB2XjJw8H+5RmcBHof9dsHxJM8Pq4+oS/ILa/iiYHy/yZpYW3eLlS7z7VHY6/JRTyOXb80= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-710ced3642dso1694704b3a.2 for ; Fri, 09 Aug 2024 18:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723251672; x=1723856472; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=tFy6b4snsI0adwUAqHq45/SSKFUaDtcWRpLDUYJEwiE=; b=hO7gm8CO37ce8mOKs3HI8WeY18lYZE316ZoFEpRiGPqunFZ863diGh2AAvv0/HI7na ReWm28fALFRkrKf96Axk8ZMAFNPWuvabNyLOq5BmjSojYzxRfumrGfQD5MzjIABpLDsr okuX/SSVMqU5nhtejiNcFrvHPlKLr9su1B9fjr+ucwYr0+IT1inG27tVBmy0MaBV8BmU C/X+ob5tXfJKr6NJL/Xn5oABtJX/ze0a3beo8XpLCE8aARvgK9vlZuiz25KUapptXU74 B6L3A+tOv1RFCvDSTZMiwPoshkwlDTmitF1Icw8H3FFasUBUbwuS37aHK/tRo17DEiA0 nWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723251672; x=1723856472; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tFy6b4snsI0adwUAqHq45/SSKFUaDtcWRpLDUYJEwiE=; b=KyPvPvvXI4ctTvmL/bWzHLP7FwEIz5/FiULv58AP2MWkiHSdi1H4MYPTRU1v8QbWbU wRbbAZnhigMnE88zuFw6DMb9hjLdFxjSylLOphDW4ym6D7IQNhEWvqxOp8HHcpzOfzw+ lzpYoG3RMsMl2CT9/JbHm0lULeiATAcRhZth19TIwutXwzO6F4CBN0Qf90ew4zlbDvum P3G16ivlFY35vkxBw7PpLkC6sMoHHkTOFqnU3LQyU5sIMbLPg1qLIcC/RY1BoNCy6rhv o2nlsHLPA49lT9SPi52pFT7V2pC7jq/1QY6CrXPyQ97uEDYECSiJ3xmBmrUfezFzsVh2 N24A== X-Gm-Message-State: AOJu0Yz5l/tD5a/kGB3Ry2wzIqyR+uN8jvhAD3hr73e0OyniLJzOn33j DGnltbMW8hNq02RITjMBGGeLRuznv0dfa5sI6qFpoSCYkIDM3SCkPBnvzg== X-Google-Smtp-Source: AGHT+IGbk9odvYPGwITslM9Y1PCs6CqQ+Tsq6CPuOKkIyiZHtu8Fe9BKyltJA5OjAtabzGJri4NU1w== X-Received: by 2002:a05:6a20:c916:b0:1c3:b26d:82ad with SMTP id adf61e73a8af0-1c89fd2693amr4398496637.3.1723251672461; Fri, 09 Aug 2024 18:01:12 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-200bb9fed69sm3236295ad.188.2024.08.09.18.01.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 18:01:12 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 89CE911402C7; Sat, 10 Aug 2024 10:31:09 +0930 (ACST) Date: Sat, 10 Aug 2024 10:31:09 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR32067, ld -Wl,--oformat,binary crash in _bfd_elf_link_keep_memory Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces~patchwork=sourceware.org@sourceware.org The direct fix for this segfault is to test for a non-NULL bed in _bfd_elf_link_keep_memory, but also there isn't much point in running code for LTO if the output is binary. PR 32067 * elflink.c (_bfd_elf_link_keep_memory): Test for non-NULL bed. (elf_link_add_object_symbols): Don't run the loop setting non_ir_ref_regular if the output hash table is not ELF. diff --git a/bfd/elflink.c b/bfd/elflink.c index a180e59e8ca..2430d606c30 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -64,7 +64,7 @@ _bfd_elf_link_keep_memory (struct bfd_link_info *info) this is opt-in by each backend. */ const struct elf_backend_data *bed = get_elf_backend_data (info->output_bfd); - if (bed->use_mmap) + if (bed != NULL && bed->use_mmap) return false; #endif bfd *abfd; @@ -5694,7 +5694,8 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info) && !bfd_link_relocatable (info) && (abfd->flags & BFD_PLUGIN) == 0 && !just_syms - && extsymcount) + && extsymcount != 0 + && is_elf_hash_table (&htab->root)) { int r_sym_shift;